usb: dwc3: gadget: Ignore EP queue requests during bus reset
authorWesley Cheng <wcheng@codeaurora.org>
Fri, 19 Mar 2021 09:31:25 +0000 (02:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 23 Mar 2021 12:01:11 +0000 (13:01 +0100)
The current dwc3_gadget_reset_interrupt() will stop any active
transfers, but only addresses blocking of EP queuing for while we are
coming from a disconnected scenario, i.e. after receiving the disconnect
event.  If the host decides to issue a bus reset on the device, the
connected parameter will still be set to true, allowing for EP queuing
to continue while we are disabling the functions.  To avoid this, set the
connected flag to false until the stop active transfers is complete.

Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
Link: https://lore.kernel.org/r/1616146285-19149-3-git-send-email-wcheng@codeaurora.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c

index d366f414d7a75e9a6e230a593c6a9b03d1565cb3..e1442fc763e107dd638d35b1b951ee8e79a7f543 100644 (file)
@@ -3331,6 +3331,15 @@ static void dwc3_gadget_reset_interrupt(struct dwc3 *dwc)
 {
        u32                     reg;
 
+       /*
+        * Ideally, dwc3_reset_gadget() would trigger the function
+        * drivers to stop any active transfers through ep disable.
+        * However, for functions which defer ep disable, such as mass
+        * storage, we will need to rely on the call to stop active
+        * transfers here, and avoid allowing of request queuing.
+        */
+       dwc->connected = false;
+
        /*
         * WORKAROUND: DWC3 revisions <1.88a have an issue which
         * would cause a missing Disconnect Event if there's a