wifi: wl1251: simplify module initialization
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 29 Mar 2024 17:10:17 +0000 (18:10 +0100)
committerKalle Valo <kvalo@kernel.org>
Fri, 5 Apr 2024 08:59:38 +0000 (11:59 +0300)
This driver's initialization functions do not perform any custom code,
except printing messages.  Printing messages on modules
loading/unloading is discouraged because it pollutes the dmesg
regardless whether user actually has this device.  Core kernel code
already gives tools to investigate whether module was loaded or not.

Drop the printing messages which allows to replace open-coded
module_sdio_driver().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240329171019.63836-4-krzysztof.kozlowski@linaro.org
drivers/net/wireless/ti/wl1251/sdio.c

index 4e5b351f80f0922cabc3f1ce57fa44960c090e3c..c705081249d697625d894cf2ba3dbb7acb29ed7c 100644 (file)
@@ -323,25 +323,7 @@ static struct sdio_driver wl1251_sdio_driver = {
        .remove         = wl1251_sdio_remove,
        .drv.pm         = &wl1251_sdio_pm_ops,
 };
-
-static int __init wl1251_sdio_init(void)
-{
-       int err;
-
-       err = sdio_register_driver(&wl1251_sdio_driver);
-       if (err)
-               wl1251_error("failed to register sdio driver: %d", err);
-       return err;
-}
-
-static void __exit wl1251_sdio_exit(void)
-{
-       sdio_unregister_driver(&wl1251_sdio_driver);
-       wl1251_notice("unloaded");
-}
-
-module_init(wl1251_sdio_init);
-module_exit(wl1251_sdio_exit);
+module_sdio_driver(wl1251_sdio_driver);
 
 MODULE_DESCRIPTION("TI WL1251 SDIO helpers");
 MODULE_LICENSE("GPL");