scripts/checkstack.pl: change min_stack to 512 by default
authorTiezhu Yang <yangtiezhu@loongson.cn>
Tue, 19 Dec 2023 12:50:00 +0000 (20:50 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 29 Dec 2023 20:22:27 +0000 (12:22 -0800)
According to Documentation/process/submit-checklist.rst, checkstack does
not point out problems explicitly, but any one function that uses more
than 512 bytes on the stack is a candidate for change, hence it is better
to omit any stack frame sizes smaller than 512 bytes, just change
min_stack to 512 by default.

Link: https://lkml.kernel.org/r/20231219125008.23007-5-yangtiezhu@loongson.cn
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
scripts/checkstack.pl

index a564c46d61297fd679cfa310d1916509b2479cc8..8e04659ef4637dad442b84672a9d6d1908a1b863 100755 (executable)
@@ -47,7 +47,7 @@ my (@stack, $re, $dre, $sub, $x, $xs, $funcre, $min_stack);
 
        $min_stack = shift;
        if ($min_stack eq "" || $min_stack !~ /^\d+$/) {
-               $min_stack = 100;
+               $min_stack = 512;
        }
 
        $x      = "[0-9a-f]";   # hex character