rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()
authorTiezhu Yang <yangtiezhu@loongson.cn>
Mon, 25 May 2020 01:39:48 +0000 (09:39 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 30 May 2020 02:12:38 +0000 (04:12 +0200)
When call function devm_platform_ioremap_resource(), we should use IS_ERR()
to check the return value and return PTR_ERR() if failed.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1590370788-15136-2-git-send-email-yangtiezhu@loongson.cn
drivers/rtc/rtc-mpc5121.c

index 3040844129cee7ce17202d58c4fa9e4352bc50ca..5c2ce71aa044db36b29d4170a9f94729195cf477 100644 (file)
@@ -316,7 +316,7 @@ static int mpc5121_rtc_probe(struct platform_device *op)
        rtc->regs = devm_platform_ioremap_resource(op, 0);
        if (IS_ERR(rtc->regs)) {
                dev_err(&op->dev, "%s: couldn't map io space\n", __func__);
-               return -ENOSYS;
+               return PTR_ERR(rtc->regs);
        }
 
        device_init_wakeup(&op->dev, 1);