drm/msm: Remove sgt from the mmu unmap function
authorJordan Crouse <jcrouse@codeaurora.org>
Wed, 7 Nov 2018 22:35:47 +0000 (15:35 -0700)
committerRob Clark <robdclark@gmail.com>
Tue, 11 Dec 2018 18:05:31 +0000 (13:05 -0500)
The scatter gather table doesn't need to be passed in for the
MMU unmap function.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/msm_drv.h
drivers/gpu/drm/msm/msm_gem.c
drivers/gpu/drm/msm/msm_gem_vma.c
drivers/gpu/drm/msm/msm_iommu.c
drivers/gpu/drm/msm/msm_mmu.h

index 3225f8fbd8c99ba7af39b5aa066f65488707a141..3a0f2119127bb1479465672cf22a4b466775f92d 100644 (file)
@@ -242,7 +242,7 @@ void msm_atomic_state_clear(struct drm_atomic_state *state);
 void msm_atomic_state_free(struct drm_atomic_state *state);
 
 void msm_gem_unmap_vma(struct msm_gem_address_space *aspace,
-               struct msm_gem_vma *vma, struct sg_table *sgt);
+               struct msm_gem_vma *vma);
 int msm_gem_map_vma(struct msm_gem_address_space *aspace,
                struct msm_gem_vma *vma, struct sg_table *sgt, int npages);
 
index f32cf75e1b3fd177af731ed95e55ad56bceae99a..0b9b8a21dfbbc828cade10a59eaff881a3804bc9 100644 (file)
@@ -352,7 +352,7 @@ put_iova(struct drm_gem_object *obj)
        WARN_ON(!mutex_is_locked(&msm_obj->lock));
 
        list_for_each_entry_safe(vma, tmp, &msm_obj->vmas, list) {
-               msm_gem_unmap_vma(vma->aspace, vma, msm_obj->sgt);
+               msm_gem_unmap_vma(vma->aspace, vma);
                del_vma(vma);
        }
 }
index ffbec224551b52f927eebb92b4319134b3399e2c..704ae7e695000e438194da631d8f202667f70e74 100644 (file)
@@ -40,14 +40,14 @@ void msm_gem_address_space_put(struct msm_gem_address_space *aspace)
 
 void
 msm_gem_unmap_vma(struct msm_gem_address_space *aspace,
-               struct msm_gem_vma *vma, struct sg_table *sgt)
+               struct msm_gem_vma *vma)
 {
        if (!aspace || !vma->iova)
                return;
 
        if (aspace->mmu) {
                unsigned size = vma->node.size << PAGE_SHIFT;
-               aspace->mmu->funcs->unmap(aspace->mmu, vma->iova, sgt, size);
+               aspace->mmu->funcs->unmap(aspace->mmu, vma->iova, size);
        }
 
        spin_lock(&aspace->lock);
index b23d33622f374b0ce88791914b53cb126899676b..9c313cb129ee75cf2f63515d7160b25a22e9772f 100644 (file)
@@ -71,8 +71,7 @@ static int msm_iommu_map(struct msm_mmu *mmu, uint64_t iova,
        return (ret == len) ? 0 : -EINVAL;
 }
 
-static int msm_iommu_unmap(struct msm_mmu *mmu, uint64_t iova,
-               struct sg_table *sgt, unsigned len)
+static int msm_iommu_unmap(struct msm_mmu *mmu, uint64_t iova, unsigned len)
 {
        struct msm_iommu *iommu = to_msm_iommu(mmu);
 
index aa2c5d4580c820b2e54c16317c121994bd7f37a9..94c0b83d80263af131dd8ce72da651de17009560 100644 (file)
@@ -25,8 +25,7 @@ struct msm_mmu_funcs {
        void (*detach)(struct msm_mmu *mmu, const char * const *names, int cnt);
        int (*map)(struct msm_mmu *mmu, uint64_t iova, struct sg_table *sgt,
                        unsigned len, int prot);
-       int (*unmap)(struct msm_mmu *mmu, uint64_t iova, struct sg_table *sgt,
-                       unsigned len);
+       int (*unmap)(struct msm_mmu *mmu, uint64_t iova, unsigned len);
        void (*destroy)(struct msm_mmu *mmu);
 };