USB: ohci-jz4740: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Mon, 6 May 2013 10:10:40 +0000 (19:10 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2013 00:47:17 +0000 (17:47 -0700)
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ohci-jz4740.c

index 8062bb9dea16eaeeeeda7c274bf8abd95f593fd1..d4ef53990d7325c33746e7d57fd395c4ffc1c63b 100644 (file)
@@ -221,7 +221,6 @@ static int jz4740_ohci_probe(struct platform_device *pdev)
        return 0;
 
 err_disable:
-       platform_set_drvdata(pdev, NULL);
        if (jz4740_ohci->vbus) {
                regulator_disable(jz4740_ohci->vbus);
                regulator_put(jz4740_ohci->vbus);
@@ -246,8 +245,6 @@ static int jz4740_ohci_remove(struct platform_device *pdev)
 
        usb_remove_hcd(hcd);
 
-       platform_set_drvdata(pdev, NULL);
-
        if (jz4740_ohci->vbus) {
                regulator_disable(jz4740_ohci->vbus);
                regulator_put(jz4740_ohci->vbus);