ipv6: remove useless assignment to newinet in tcp_v6_syn_recv_sock()
authorNghia Le <nghialm78@gmail.com>
Thu, 4 Nov 2021 14:37:40 +0000 (21:37 +0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 6 Nov 2021 02:49:40 +0000 (19:49 -0700)
The newinet value is initialized with inet_sk() in a block code to
handle sockets for the ETH_P_IP protocol. Along this code path,
newinet is never read. Thus, assignment to newinet is needless and
can be removed.

Signed-off-by: Nghia Le <nghialm78@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20211104143740.32446-1-nghialm78@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/tcp_ipv6.c

index 2cc9b0e53ad1c8e2d35fc9c6dbd1e90fee40b632..551fce49841d7f53a111b0435855634cece2b40a 100644 (file)
@@ -1263,7 +1263,6 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff *
 
                inet_sk(newsk)->pinet6 = tcp_inet6_sk(newsk);
 
-               newinet = inet_sk(newsk);
                newnp = tcp_inet6_sk(newsk);
                newtp = tcp_sk(newsk);