ubifs: rename_whiteout: correct old_dir size computing
authorBaokun Li <libaokun1@huawei.com>
Tue, 15 Feb 2022 04:07:36 +0000 (12:07 +0800)
committerRichard Weinberger <richard@nod.at>
Thu, 17 Mar 2022 22:34:07 +0000 (23:34 +0100)
When renaming the whiteout file, the old whiteout file is not deleted.
Therefore, we add the old dentry size to the old dir like XFS.
Otherwise, an error may be reported due to `fscki->calc_sz != fscki->size`
in check_indes.

Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT")
Reported-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/dir.c

index ae082a0be2a3f2ca5e9316220f423ce22a0114a3..86151889548e3af45a4efc695ab5a6c68d985190 100644 (file)
@@ -1402,6 +1402,9 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
                        iput(whiteout);
                        goto out_release;
                }
+
+               /* Add the old_dentry size to the old_dir size. */
+               old_sz -= CALC_DENT_SIZE(fname_len(&old_nm));
        }
 
        lock_4_inodes(old_dir, new_dir, new_inode, whiteout);