selftests/mount_setattr: adapt detached mount propagation test
authorChristian Brauner <brauner@kernel.org>
Thu, 5 Jun 2025 12:50:54 +0000 (14:50 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 7 Jun 2025 04:41:29 +0000 (00:41 -0400)
Make sure that detached trees don't receive mount propagation.

Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
tools/testing/selftests/mount_setattr/mount_setattr_test.c

index 8b378c91debf5ceda8b84f03ebb9b832327e42db..b1e4618399be6720e92a2dba6e27947d5698dce3 100644 (file)
@@ -2079,24 +2079,9 @@ TEST_F(mount_setattr, detached_tree_propagation)
         * means that the device information will be different for any
         * statx() that was taken from /mnt/A before the mount compared
         * to one after the mount.
-        *
-        * Since we already now that the device information between the
-        * stx1 and stx2 samples are identical we also now that stx2 and
-        * stx3 device information will necessarily differ.
         */
        ASSERT_NE(stx1.stx_dev_minor, stx3.stx_dev_minor);
-
-       /*
-        * If mount propagation worked correctly then the tmpfs mount
-        * that was created after the mount namespace was unshared will
-        * have propagated onto /mnt/A in the detached mount tree.
-        *
-        * Verify that the device information for stx3 and stx4 are
-        * identical. It is already established that stx3 is different
-        * from both stx1 and stx2 sampled before the tmpfs mount was
-        * done so if stx3 and stx4 are identical the proof is done.
-        */
-       ASSERT_EQ(stx3.stx_dev_minor, stx4.stx_dev_minor);
+       ASSERT_EQ(stx1.stx_dev_minor, stx4.stx_dev_minor);
 
        EXPECT_EQ(close(fd_tree), 0);
 }