HID: appletb-kbd: Fix inconsistent indentation and pass -ENODEV to dev_err_probe

The following warnings were flagged by the kernel test robot:

drivers/hid/hid-appletb-kbd.c:405 appletb_kbd_probe() warn: inconsistent indenting
drivers/hid/hid-appletb-kbd.c:406 appletb_kbd_probe() warn: passing zero to 'dev_err_probe'

This patch aims at fixing those warnings.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502152006.fBBCdEr3-lkp@intel.com/
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-input/6263a1a2-4d50-41db-aa54-cfcb3e0523a4@stanley.mountain/
Fixes: 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar")
Signed-off-by: Aditya Garg <gargaditya08@live.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/hid-appletb-kbd.c b/drivers/hid/hid-appletb-kbd.c
index e45cc3ac46ee39f6138c66cf17995094b49206b7..d4b95aa3eecbe81e1588fa0144710b59e3169837 100644 (file)
--- a/drivers/hid/hid-appletb-kbd.c
+++ b/drivers/hid/hid-appletb-kbd.c
@@ -402,13 +402,13 @@ static int appletb_kbd_probe(struct hid_device *hdev, const struct hid_device_id
        }
 
        kbd->backlight_dev = backlight_device_get_by_name("appletb_backlight");
-               if (!kbd->backlight_dev)
-                       dev_err_probe(dev, ret, "Failed to get backlight device\n");
-               else {
-                       backlight_device_set_brightness(kbd->backlight_dev, 2);
-                       timer_setup(&kbd->inactivity_timer, appletb_inactivity_timer, 0);
-                       mod_timer(&kbd->inactivity_timer, jiffies + msecs_to_jiffies(appletb_tb_dim_timeout * 1000));
-               }
+       if (!kbd->backlight_dev) {
+               dev_err_probe(dev, -ENODEV, "Failed to get backlight device\n");
+       } else {
+               backlight_device_set_brightness(kbd->backlight_dev, 2);
+               timer_setup(&kbd->inactivity_timer, appletb_inactivity_timer, 0);
+               mod_timer(&kbd->inactivity_timer, jiffies + msecs_to_jiffies(appletb_tb_dim_timeout * 1000));
+       }
 
        kbd->inp_handler.event = appletb_kbd_inp_event;
        kbd->inp_handler.connect = appletb_kbd_inp_connect;