NFS: use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Mon, 5 Dec 2022 09:13:45 +0000 (17:13 +0800)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Tue, 6 Dec 2022 17:32:37 +0000 (12:32 -0500)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/namespace.c

index 88a23af2bd5c9caba956b392f8bcd3ca677a62e0..b0ef7e7ddb30671f9171b3ca22fa2ecad0964056 100644 (file)
@@ -354,7 +354,7 @@ static int param_get_nfs_timeout(char *buffer, const struct kernel_param *kp)
                        num = (num + (HZ - 1)) / HZ;
        } else
                num = -1;
-       return scnprintf(buffer, PAGE_SIZE, "%li\n", num);
+       return sysfs_emit(buffer, "%li\n", num);
 }
 
 static const struct kernel_param_ops param_ops_nfs_timeout = {