ag71xx: fix error return code in ag71xx_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 19 Jul 2019 01:21:57 +0000 (01:21 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jul 2019 03:33:48 +0000 (20:33 -0700)
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.

Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/ag71xx.c

index 8f450a03a885331dd2a8c8bfcb49d49337a39b7b..31d27808ddee06fb2c5474f040f755d140e93de0 100644 (file)
@@ -1725,8 +1725,10 @@ static int ag71xx_probe(struct platform_device *pdev)
        ag->stop_desc = dmam_alloc_coherent(&pdev->dev,
                                            sizeof(struct ag71xx_desc),
                                            &ag->stop_desc_dma, GFP_KERNEL);
-       if (!ag->stop_desc)
+       if (!ag->stop_desc) {
+               err = -ENOMEM;
                goto err_free;
+       }
 
        ag->stop_desc->data = 0;
        ag->stop_desc->ctrl = 0;