projects
/
linux-2.6-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4477138
)
net: openvswitch: fix a NULL pointer dereference
author
Kangjie Lu
<kjlu@umn.edu>
Fri, 15 Mar 2019 04:20:16 +0000
(23:20 -0500)
committer
David S. Miller
<davem@davemloft.net>
Sat, 16 Mar 2019 18:35:58 +0000
(11:35 -0700)
upcall is dereferenced even when genlmsg_put fails. The fix
goto out to avoid the NULL pointer dereference in this case.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/openvswitch/datapath.c
patch
|
blob
|
blame
|
history
diff --git
a/net/openvswitch/datapath.c
b/net/openvswitch/datapath.c
index 6679e96ab1dcdf8761845b863c39e1b6aac20d2e..45d1469308b048389aa503e737bccdef23f895a7 100644
(file)
--- a/
net/openvswitch/datapath.c
+++ b/
net/openvswitch/datapath.c
@@
-448,6
+448,10
@@
static int queue_userspace_packet(struct datapath *dp, struct sk_buff *skb,
upcall = genlmsg_put(user_skb, 0, 0, &dp_packet_genl_family,
0, upcall_info->cmd);
+ if (!upcall) {
+ err = -EINVAL;
+ goto out;
+ }
upcall->dp_ifindex = dp_ifindex;
err = ovs_nla_put_key(key, key, OVS_PACKET_ATTR_KEY, false, user_skb);