extcon: Use sysfs_emit() to instead of sprintf()

Follow the advice of the Documentation/filesystems/sysfs.rst that
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 70e9755ba2bc2ec77f3c23bbe6350aea14cfb624..ac84f4aafc697772947417ac3ed686f0817ff268 100644 (file)
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -370,12 +370,12 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr,
        struct extcon_dev *edev = dev_get_drvdata(dev);
 
        if (edev->max_supported == 0)
-               return sprintf(buf, "%u\n", edev->state);
+               return sysfs_emit(buf, "%u\n", edev->state);
 
        for (i = 0; i < edev->max_supported; i++) {
-               count += sprintf(buf + count, "%s=%d\n",
-                               extcon_info[edev->supported_cable[i]].name,
-                                !!(edev->state & BIT(i)));
+               count += sysfs_emit_at(buf, count, "%s=%d\n",
+                                      extcon_info[edev->supported_cable[i]].name,
+                                      !!(edev->state & BIT(i)));
        }
 
        return count;
@@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr,
 {
        struct extcon_dev *edev = dev_get_drvdata(dev);
 
-       return sprintf(buf, "%s\n", edev->name);
+       return sysfs_emit(buf, "%s\n", edev->name);
 }
 static DEVICE_ATTR_RO(name);
 
@@ -398,8 +398,8 @@ static ssize_t cable_name_show(struct device *dev,
                                                  attr_name);
        int i = cable->cable_index;
 
-       return sprintf(buf, "%s\n",
-                       extcon_info[cable->edev->supported_cable[i]].name);
+       return sysfs_emit(buf, "%s\n",
+                         extcon_info[cable->edev->supported_cable[i]].name);
 }
 
 static ssize_t cable_state_show(struct device *dev,
@@ -410,8 +410,8 @@ static ssize_t cable_state_show(struct device *dev,
 
        int i = cable->cable_index;
 
-       return sprintf(buf, "%d\n",
-               extcon_get_state(cable->edev, cable->edev->supported_cable[i]));
+       return sysfs_emit(buf, "%d\n",
+                         extcon_get_state(cable->edev, cable->edev->supported_cable[i]));
 }
 
 /**