dmaengine: sun4i: use 'linear_mode' in sun4i_dma_prep_dma_cyclic
authorYueHaibing <yuehaibing@huawei.com>
Fri, 7 Feb 2020 02:44:45 +0000 (10:44 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 13 Feb 2020 15:08:53 +0000 (20:38 +0530)
drivers/dma/sun4i-dma.c: In function sun4i_dma_prep_dma_cyclic:
drivers/dma/sun4i-dma.c:672:24: warning:
 variable linear_mode set but not used [-Wunused-but-set-variable]

commit ffc079a4accc ("dmaengine: sun4i: Add support for cyclic requests with dedicated DMA")
involved this, explicitly using the value makes the code more readable.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20200207024445.44600-1-yuehaibing@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sun4i-dma.c

index bbc2bda3b902f0a798906ee8922723aa4be030f7..e87fc7c460dd4b160968f126113a75ba880f4d60 100644 (file)
@@ -698,10 +698,12 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len,
                endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(vchan->endpoint) |
                            SUN4I_DMA_CFG_DST_ADDR_MODE(io_mode) |
                            SUN4I_DMA_CFG_SRC_DRQ_TYPE(ram_type);
+                           SUN4I_DMA_CFG_SRC_ADDR_MODE(linear_mode);
        } else {
                src = sconfig->src_addr;
                dest = buf;
                endpoints = SUN4I_DMA_CFG_DST_DRQ_TYPE(ram_type) |
+                           SUN4I_DMA_CFG_DST_ADDR_MODE(linear_mode) |
                            SUN4I_DMA_CFG_SRC_DRQ_TYPE(vchan->endpoint) |
                            SUN4I_DMA_CFG_SRC_ADDR_MODE(io_mode);
        }