PCI: Remove stray put_device() in pci_register_host_bridge()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 7 Mar 2025 08:46:34 +0000 (11:46 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 10 Mar 2025 18:41:48 +0000 (13:41 -0500)
This put_device() was accidentally left over from when we changed the code
from using device_register() to calling device_add().  Delete it.

Link: https://lore.kernel.org/r/55b24870-89fb-4c91-b85d-744e35db53c2@stanley.mountain
Fixes: 9885440b16b8 ("PCI: Fix pci_host_bridge struct device release/free handling")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/probe.c

index 088131a74d7d461eba6c880328eda384c42eed11..1448f65cc1918ca8e005b1cb634374a8f9fc9c68 100644 (file)
@@ -996,10 +996,9 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)
        /* Temporarily move resources off the list */
        list_splice_init(&bridge->windows, &resources);
        err = device_add(&bridge->dev);
-       if (err) {
-               put_device(&bridge->dev);
+       if (err)
                goto free;
-       }
+
        bus->bridge = get_device(&bridge->dev);
        device_enable_async_suspend(bus->bridge);
        pci_set_bus_of_node(bus);