ipv6: sr: fix incorrect unregister order
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 9 May 2024 13:18:11 +0000 (21:18 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 May 2024 02:27:46 +0000 (19:27 -0700)
Commit 5559cea2d5aa ("ipv6: sr: fix possible use-after-free and
null-ptr-deref") changed the register order in seg6_init(). But the
unregister order in seg6_exit() is not updated.

Fixes: 5559cea2d5aa ("ipv6: sr: fix possible use-after-free and null-ptr-deref")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20240509131812.1662197-3-liuhangbin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/seg6.c

index 5423f1f2aa626646f9ef5518624e388315e61764..c4ef96c8fdaca2900bc14f7dbfdfa4bd1bbfddea 100644 (file)
@@ -567,6 +567,6 @@ void seg6_exit(void)
        seg6_local_exit();
        seg6_iptunnel_exit();
 #endif
-       unregister_pernet_subsys(&ip6_segments_ops);
        genl_unregister_family(&seg6_genl_family);
+       unregister_pernet_subsys(&ip6_segments_ops);
 }