tracing: Remove duplicate warnings when calling trace_create_file()
authorYuntao Wang <ytcoode@gmail.com>
Sun, 9 Jan 2022 16:22:32 +0000 (00:22 +0800)
committerSteven Rostedt <rostedt@goodmis.org>
Thu, 13 Jan 2022 22:02:42 +0000 (17:02 -0500)
Since the same warning message is already printed in the
trace_create_file() function, there is no need to print it again.

Link: https://lkml.kernel.org/r/20220109162232.361747-1-ytcoode@gmail.com
Signed-off-by: Yuntao Wang <ytcoode@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 92be9cb1d7d4bc313507e3a1f516b4517701bc8e..3147614c1812a16293b0abd47dca1f8f00113b49 100644 (file)
@@ -3461,10 +3461,8 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
 
        entry = trace_create_file("enable", TRACE_MODE_WRITE, d_events,
                                  tr, &ftrace_tr_enable_fops);
-       if (!entry) {
-               pr_warn("Could not create tracefs 'enable' entry\n");
+       if (!entry)
                return -ENOMEM;
-       }
 
        /* There are not as crucial, just warn if they are not created */
 
@@ -3480,17 +3478,13 @@ create_event_toplevel_files(struct dentry *parent, struct trace_array *tr)
                pr_warn("Could not create tracefs 'set_event_notrace_pid' entry\n");
 
        /* ring buffer internal formats */
-       entry = trace_create_file("header_page", TRACE_MODE_READ, d_events,
+       trace_create_file("header_page", TRACE_MODE_READ, d_events,
                                  ring_buffer_print_page_header,
                                  &ftrace_show_header_fops);
-       if (!entry)
-               pr_warn("Could not create tracefs 'header_page' entry\n");
 
-       entry = trace_create_file("header_event", TRACE_MODE_READ, d_events,
+       trace_create_file("header_event", TRACE_MODE_READ, d_events,
                                  ring_buffer_print_entry_header,
                                  &ftrace_show_header_fops);
-       if (!entry)
-               pr_warn("Could not create tracefs 'header_event' entry\n");
 
        tr->event_dir = d_events;