greybus: interface: fix broken UniPro flow control
authorJohan Hovold <johan@hovoldconsulting.com>
Thu, 28 Apr 2016 14:19:39 +0000 (16:19 +0200)
committerGreg Kroah-Hartman <gregkh@google.com>
Thu, 28 Apr 2016 15:13:46 +0000 (08:13 -0700)
A recent commit inadvertently disabled E2EFC on all interface
connections, due to a failure to clear the ES3 bootrom quirk flags
during mode switch.

Testing Done: Verified that the CPort flags are again set to 0x7 for
non-bootrom interface connections.

Fixes: 5b638080e94e ("svc: keep interfaces registered during
mode switch")
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/interface.c

index f6c058a63fa24c9990add730ee37fe375358f23a..b5ad1ac9d3dfd2d1fd7c37cad5481baaea37bbe5 100644 (file)
@@ -226,6 +226,9 @@ static int gb_interface_read_and_clear_init_status(struct gb_interface *intf)
                intf->quirks |= GB_INTERFACE_QUIRK_NO_CPORT_FEATURES;
                intf->quirks |= GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION;
                break;
+       default:
+               intf->quirks &= ~GB_INTERFACE_QUIRK_NO_CPORT_FEATURES;
+               intf->quirks &= ~GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION;
        }
 
        /* Clear the init status. */