mm/mempolicy: remove unneeded out label
authorMiaohe Lin <linmiaohe@huawei.com>
Tue, 19 Jul 2022 11:52:33 +0000 (19:52 +0800)
committerakpm <akpm@linux-foundation.org>
Sat, 30 Jul 2022 01:07:16 +0000 (18:07 -0700)
We can use unlock label to unlock ptl and return ret directly to remove
the unneeded out label and reduce the size of mempolicy.o.  No functional
change intended.

[Before]
   text    data     bss     dec     hex filename
  26702    3972    6168   36842    8fea mm/mempolicy.o

[After]
   text    data     bss     dec     hex filename
  26662    3972    6168   36802    8fc2 mm/mempolicy.o

Link: https://lkml.kernel.org/r/20220719115233.6706-1-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/mempolicy.c

index 88a5173c6ff077b74bad2e95a34a60a5575fbf42..b73d3248d976a075d2919cfc0fef6ec1043e313a 100644 (file)
@@ -465,9 +465,8 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr,
        }
        page = pmd_page(*pmd);
        if (is_huge_zero_page(page)) {
-               spin_unlock(ptl);
                walk->action = ACTION_CONTINUE;
-               goto out;
+               goto unlock;
        }
        if (!queue_pages_required(page, qp))
                goto unlock;
@@ -484,7 +483,6 @@ static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr,
                ret = -EIO;
 unlock:
        spin_unlock(ptl);
-out:
        return ret;
 }