usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs
authorVivek Gautam <gautam.vivek@samsung.com>
Mon, 6 Oct 2014 06:21:10 +0000 (11:51 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 Nov 2014 23:34:00 +0000 (15:34 -0800)
On enabling CONFIG_OF_SELFTEST which enables CONFIG_OF_DYNAMIC,
we found out that while getting PHYs for the controller we were
doing an extra of_node_put on the child node in our routines -
exynos_e/ohci_get_phy().
This child is however already put by of_get_next_available_child()
which does a of_node_put() on the "prev" node. So there's no point
in putting the same node again in our routine.

Reported-by: Daniel Drake <drake@endlessm.com>
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-exynos.c
drivers/usb/host/ohci-exynos.c

index 7189f2e32ac2f1b27a793699d2906c2851bd577a..1b726bfdcbea50982f08b98e492c53e5f7b2e44b 100644 (file)
@@ -74,7 +74,6 @@ static int exynos_ehci_get_phy(struct device *dev,
 
                phy = devm_of_phy_get(dev, child, NULL);
                exynos_ehci->phy[phy_number] = phy;
-               of_node_put(child);
                if (IS_ERR(phy)) {
                        ret = PTR_ERR(phy);
                        if (ret == -EPROBE_DEFER) {
index d28b6583ba025777ab33fb9b46732181e740092d..39f366b6b1a7049ec2a4bb21f1f61a0afb867478 100644 (file)
@@ -63,7 +63,6 @@ static int exynos_ohci_get_phy(struct device *dev,
 
                phy = devm_of_phy_get(dev, child, NULL);
                exynos_ohci->phy[phy_number] = phy;
-               of_node_put(child);
                if (IS_ERR(phy)) {
                        ret = PTR_ERR(phy);
                        if (ret == -EPROBE_DEFER) {