drm/mediatek: Remove redundant calls to drm_connector_register_all()
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 17 Jun 2016 08:25:21 +0000 (09:25 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 21 Jun 2016 08:53:13 +0000 (10:53 +0200)
Up to now, the recommendation was for drivers to call drm_dev_register()
followed by drm_connector_register_all(). Now that
drm_connector_register() is safe against multiple invocations, we can
move drm_connector_register_all() to drm_dev_register() and not suffer
from any backwards compatibility issues with drivers not following the
more rigorous init ordering.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466151923-1572-6-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/mediatek/mtk_drm_drv.c

index c33bf98c5d5e212cdada03cd0d3c95ef3fefc70d..7ab91f4a200fb50a3f78d02133bf66a748a28367 100644 (file)
@@ -293,14 +293,8 @@ static int mtk_drm_bind(struct device *dev)
        if (ret < 0)
                goto err_deinit;
 
-       ret = drm_connector_register_all(drm);
-       if (ret < 0)
-               goto err_unregister;
-
        return 0;
 
-err_unregister:
-       drm_dev_unregister(drm);
 err_deinit:
        mtk_drm_kms_deinit(drm);
 err_free:
@@ -455,7 +449,6 @@ static int mtk_drm_remove(struct platform_device *pdev)
        struct drm_device *drm = private->drm;
        int i;
 
-       drm_connector_unregister_all(drm);
        drm_dev_unregister(drm);
        mtk_drm_kms_deinit(drm);
        drm_dev_unref(drm);