Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
authorPeter Jones <pjones@redhat.com>
Fri, 6 Jul 2018 19:04:24 +0000 (15:04 -0400)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 20 Apr 2020 16:14:59 +0000 (19:14 +0300)
This was sort of annoying me:

random:~$ dmesg | tail -1
[523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
random:~$ dmesg | grep -c "Reducing the compressed"
47

This patch makes it DRM_INFO_ONCE() just like the similar message
farther down in that function is pr_info_once().

Cc: stable@vger.kernel.org
Signed-off-by: Peter Jones <pjones@redhat.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1745
Link: https://patchwork.freedesktop.org/patch/msgid/20180706190424.29194-1-pjones@redhat.com
[vsyrjala: Rebase due to per-device logging]
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
drivers/gpu/drm/i915/display/intel_fbc.c

index 56bcd6c52a02c42c354ec77cf48286d3f6f389e7..c6afa10e814c7c8f93635bf75e80491e5c61c1e2 100644 (file)
@@ -485,9 +485,8 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,
        if (!ret)
                goto err_llb;
        else if (ret > 1) {
-               drm_info(&dev_priv->drm,
-                        "Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
-
+               drm_info_once(&dev_priv->drm,
+                             "Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
        }
 
        fbc->threshold = ret;