pmdomain: rockchip: fix rockchip_pd_power error handling

The calls rockchip_pd_power makes to rockchip_pmu_set_idle_request lack
any return error handling, causing device drivers to incorrectly believe
the hardware idle requests succeed when they may have failed. This leads
to software possibly accessing hardware that is powered off and the
subsequent SError panic that follows.

Add error checking and return errors to the calling function to prevent
such crashes.

gst-launch-1.0 videotestsrc num-buffers=2000 ! v4l2jpegenc ! fakesink
Setting pipeline to PAUSED ...er-x64
Pipeline is PREROLLING ...
Redistribute latency...
rockchip-pm-domain ff100000.syscon:power-controller: failed to get ack on domain 'hevc', val=0x98260
SError Interrupt on CPU2, code 0x00000000bf000002 -- SError

Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Link: https://lore.kernel.org/r/20241214215802.23989-1-pgwipeout@gmail.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20250220-rk3588-gpu-pwr-domain-regulator-v6-5-a4f9c24e5b81@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
index 2b620f036838207767fa927081b4500439fc9d95..08207b3dd5e3aad869ed64fa9803a2d7de59091a 100644 (file)
--- a/drivers/pmdomain/rockchip/pm-domains.c
+++ b/drivers/pmdomain/rockchip/pm-domains.c
@@ -607,26 +607,29 @@ static int rockchip_pd_power(struct rockchip_pm_domain *pd, bool power_on)
                rockchip_pmu_save_qos(pd);
 
                /* if powering down, idle request to NIU first */
-               rockchip_pmu_set_idle_request(pd, true);
+               ret = rockchip_pmu_set_idle_request(pd, true);
+               if (ret < 0)
+                       goto out;
        }
 
        ret = rockchip_do_pmu_set_power_domain(pd, power_on);
-       if (ret < 0) {
-               clk_bulk_disable(pd->num_clks, pd->clks);
-               return ret;
-       }
+       if (ret < 0)
+               goto out;
 
        if (power_on) {
                /* if powering up, leave idle mode */
-               rockchip_pmu_set_idle_request(pd, false);
+               ret = rockchip_pmu_set_idle_request(pd, false);
+               if (ret < 0)
+                       goto out;
 
                rockchip_pmu_restore_qos(pd);
        }
 
+out:
        rockchip_pmu_ungate_clk(pd, false);
        clk_bulk_disable(pd->num_clks, pd->clks);
 
-       return 0;
+       return ret;
 }
 
 static int rockchip_pd_power_on(struct generic_pm_domain *domain)