kill signal_pt_regs()
authorAl Viro <viro@zeniv.linux.org.uk>
Mon, 8 Jun 2020 16:21:07 +0000 (12:21 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 23 Oct 2022 22:06:54 +0000 (18:06 -0400)
Once upon at it was used on hot paths, but that had not been
true since 2013.  IOW, there's no point for arch-optimized
equivalent of task_pt_regs(current) - remaining two users are
not worth bothering with.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
arch/alpha/include/asm/ptrace.h
fs/coredump.c
include/linux/ptrace.h
kernel/signal.c

index df5f317ab3fcba67152fae5971c3471f105b125d..3557ce64ed2140676ca07d77993140aca5ca4d51 100644 (file)
@@ -16,7 +16,6 @@
 
 #define current_pt_regs() \
   ((struct pt_regs *) ((char *)current_thread_info() + 2*PAGE_SIZE) - 1)
-#define signal_pt_regs current_pt_regs
 
 #define force_successful_syscall_return() (current_pt_regs()->r0 = 0)
 
index 7bad7785e8e675ac92d5ba6f55bec90658e4ca51..b4ec1bf889f93624239dc10b44e59f253006e178 100644 (file)
@@ -525,7 +525,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
        static atomic_t core_dump_count = ATOMIC_INIT(0);
        struct coredump_params cprm = {
                .siginfo = siginfo,
-               .regs = signal_pt_regs(),
+               .regs = task_pt_regs(current),
                .limit = rlimit(RLIMIT_CORE),
                /*
                 * We must use the same mm->flags while dumping core to avoid
index c952c5ba8fab6bb4174315ed31f4fb5aecec5f08..eaaef3ffec221b93cfbb9a2f4c20646b473754fa 100644 (file)
@@ -389,15 +389,6 @@ static inline void user_single_step_report(struct pt_regs *regs)
 #define current_pt_regs() task_pt_regs(current)
 #endif
 
-/*
- * unlike current_pt_regs(), this one is equal to task_pt_regs(current)
- * on *all* architectures; the only reason to have a per-arch definition
- * is optimisation.
- */
-#ifndef signal_pt_regs
-#define signal_pt_regs() task_pt_regs(current)
-#endif
-
 #ifndef current_user_stack_pointer
 #define current_user_stack_pointer() user_stack_pointer(current_pt_regs())
 #endif
index d140672185a489bff3a44f759497b5f8e61e433b..848d5c282d35bbe2ca187e69b23df25ac813fa09 100644 (file)
@@ -1255,7 +1255,7 @@ int send_signal_locked(int sig, struct kernel_siginfo *info,
 
 static void print_fatal_signal(int signr)
 {
-       struct pt_regs *regs = signal_pt_regs();
+       struct pt_regs *regs = task_pt_regs(current);
        pr_info("potentially unexpected fatal signal %d.\n", signr);
 
 #if defined(__i386__) && !defined(__arch_um__)