wifi: iwlwifi: mvm: don't always set antenna in beacon template cmd
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Sun, 12 May 2024 04:30:55 +0000 (07:30 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 23 May 2024 08:51:15 +0000 (10:51 +0200)
This needs to be set only if the FW is not capable of selecting an
antenna on its own.

Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240512072733.73d790911268.I158dc1dbc9c2e199c69d8213e5496d2de72da28b@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mac-ctxt.c

index 5a06f887769a6ad2de8f73c59afb1b75aa37aa1f..f6baf7135efd9f803c9674f1f8e512cd44ee4cf8 100644 (file)
@@ -1010,12 +1010,13 @@ static void iwl_mvm_mac_ctxt_set_tx(struct iwl_mvm *mvm,
        tx->tx_flags = cpu_to_le32(tx_flags);
 
        if (!fw_has_capa(&mvm->fw->ucode_capa,
-                        IWL_UCODE_TLV_CAPA_BEACON_ANT_SELECTION))
+                        IWL_UCODE_TLV_CAPA_BEACON_ANT_SELECTION)) {
                iwl_mvm_toggle_tx_ant(mvm, &mvm->mgmt_last_antenna_idx);
 
-       tx->rate_n_flags =
-               cpu_to_le32(BIT(mvm->mgmt_last_antenna_idx) <<
-                           RATE_MCS_ANT_POS);
+               tx->rate_n_flags =
+                       cpu_to_le32(BIT(mvm->mgmt_last_antenna_idx) <<
+                                   RATE_MCS_ANT_POS);
+       }
 
        rate = iwl_mvm_mac_ctxt_get_beacon_rate(mvm, info, vif);