spi: spi-fsl-dspi: Drop extra spi_master_put in device remove function
authorWei Yongjun <weiyj.lk@gmail.com>
Sat, 20 Aug 2016 15:25:32 +0000 (15:25 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 22 Aug 2016 16:45:22 +0000 (17:45 +0100)
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which and results
in device memory being freed. The subsequent call to spi_master_put is
unnecessary and results in an access to free memory. Drop it.

Fixes: 9298bc727385 ("spi: spi-fsl-dspi: Remove spi-bitbang")
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-dspi.c

index 95d8b929cd52f635a8cd5f5bf531aad02563adb9..35c0dd94566814c484758bae43d354bf4e282e13 100644 (file)
@@ -763,7 +763,6 @@ static int dspi_remove(struct platform_device *pdev)
        /* Disconnect from the SPI framework */
        clk_disable_unprepare(dspi->clk);
        spi_unregister_master(dspi->master);
-       spi_master_put(dspi->master);
 
        return 0;
 }