devlink: Create a helper function for one parameter registration
authorParav Pandit <parav@nvidia.com>
Tue, 10 Aug 2021 13:24:18 +0000 (16:24 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Aug 2021 13:34:21 +0000 (14:34 +0100)
Create and use a helper function for one parameter registration.
Subsequent patch also will reuse this for driver facing routine to
register a single parameter.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c

index 867ae7e397882941e5219e21b9bf2cb2cc149eb4..050dd7271a45e072b8a43ea936dd509517ef1128 100644 (file)
@@ -9800,6 +9800,22 @@ static int devlink_param_verify(const struct devlink_param *param)
                return devlink_param_driver_verify(param);
 }
 
+static int __devlink_param_register_one(struct devlink *devlink,
+                                       unsigned int port_index,
+                                       struct list_head *param_list,
+                                       const struct devlink_param *param,
+                                       enum devlink_command reg_cmd)
+{
+       int err;
+
+       err = devlink_param_verify(param);
+       if (err)
+               return err;
+
+       return devlink_param_register_one(devlink, port_index,
+                                         param_list, param, reg_cmd);
+}
+
 static int __devlink_params_register(struct devlink *devlink,
                                     unsigned int port_index,
                                     struct list_head *param_list,
@@ -9814,12 +9830,8 @@ static int __devlink_params_register(struct devlink *devlink,
 
        mutex_lock(&devlink->lock);
        for (i = 0; i < params_count; i++, param++) {
-               err = devlink_param_verify(param);
-               if (err)
-                       goto rollback;
-
-               err = devlink_param_register_one(devlink, port_index,
-                                                param_list, param, reg_cmd);
+               err = __devlink_param_register_one(devlink, port_index,
+                                                  param_list, param, reg_cmd);
                if (err)
                        goto rollback;
        }