thunderbolt: Do not make DROM read success compulsory
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 3 Mar 2022 13:13:26 +0000 (07:13 -0600)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Fri, 4 Mar 2022 14:10:36 +0000 (17:10 +0300)
The USB4 specification doesn't make any requirements that reading
a device router's DROM is needed for the operation of the device.

Other connection manager solutions don't necessarily read it or gate
the usability of the device on whether it was read.

So make failures when reading the DROM show warnings but not
fail the initialization of the router.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/switch.c

index 294518af4ee4ece869c93d28355c849c24f1fe9e..ac87e8b50e52542b03c65698097cc46cb7f8516d 100644 (file)
@@ -2784,10 +2784,8 @@ int tb_switch_add(struct tb_switch *sw)
 
                /* read drom */
                ret = tb_drom_read(sw);
-               if (ret) {
-                       dev_err(&sw->dev, "reading DROM failed\n");
-                       return ret;
-               }
+               if (ret)
+                       dev_warn(&sw->dev, "reading DROM failed: %d\n", ret);
                tb_sw_dbg(sw, "uid: %#llx\n", sw->uid);
 
                tb_check_quirks(sw);