gpio: imx-scu: destroy the mutex in detach path
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 23 Apr 2025 07:15:05 +0000 (09:15 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 30 Apr 2025 08:27:58 +0000 (10:27 +0200)
Use devm_mutex_init() in order to clean up after the mutex debug data in
detach and error path.

Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-gpio-part2-v1-3-b22245cde81a@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-imx-scu.c

index 99df95e65820c2e8f7bea3488b29bace43dbc879..cf98b948f8049e4e88dc2508d3584a04ec076e55 100644 (file)
@@ -88,7 +88,10 @@ static int imx_scu_gpio_probe(struct platform_device *pdev)
                return ret;
 
        priv->dev = dev;
-       mutex_init(&priv->lock);
+
+       ret = devm_mutex_init(&pdev->dev, &priv->lock);
+       if (ret)
+               return ret;
 
        gc = &priv->chip;
        gc->base = -1;