drm/bridge: cdns-csi: Switch to atomic helpers

The Cadence DSI driver follows the drm_encoder->crtc pointer that is
deprecated and shouldn't be used by atomic drivers.

Fortunately, the atomic hooks provide the drm_atomic_state and we can
access our current CRTC from that, going from the bridge to its encoder,
to its connector, and to its CRTC.

Let's convert this bridge driver to atomic so we can get rid of the
drm_encoder->crtc dereference.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250313-bridge-connector-v6-12-511c54a604fb@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
index 8f54c034ac4f3e82c38607a0e52d4745654b571f..99d43944fb8fc685520b78732cd1181175ff7cc9 100644 (file)
--- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
@@ -656,7 +656,8 @@ cdns_dsi_bridge_mode_valid(struct drm_bridge *bridge,
        return MODE_OK;
 }
 
-static void cdns_dsi_bridge_disable(struct drm_bridge *bridge)
+static void cdns_dsi_bridge_atomic_disable(struct drm_bridge *bridge,
+                                          struct drm_atomic_state *state)
 {
        struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
        struct cdns_dsi *dsi = input_to_dsi(input);
@@ -676,7 +677,8 @@ static void cdns_dsi_bridge_disable(struct drm_bridge *bridge)
        pm_runtime_put(dsi->base.dev);
 }
 
-static void cdns_dsi_bridge_post_disable(struct drm_bridge *bridge)
+static void cdns_dsi_bridge_atomic_post_disable(struct drm_bridge *bridge,
+                                               struct drm_atomic_state *state)
 {
        struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
        struct cdns_dsi *dsi = input_to_dsi(input);
@@ -753,13 +755,17 @@ static void cdns_dsi_init_link(struct cdns_dsi *dsi)
        dsi->link_initialized = true;
 }
 
-static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
+static void cdns_dsi_bridge_atomic_enable(struct drm_bridge *bridge,
+                                         struct drm_atomic_state *state)
 {
        struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
        struct cdns_dsi *dsi = input_to_dsi(input);
        struct cdns_dsi_output *output = &dsi->output;
+       struct drm_connector_state *conn_state;
+       struct drm_crtc_state *crtc_state;
        struct drm_display_mode *mode;
        struct phy_configure_opts_mipi_dphy *phy_cfg = &output->phy_opts.mipi_dphy;
+       struct drm_connector *connector;
        unsigned long tx_byte_period;
        struct cdns_dsi_cfg dsi_cfg;
        u32 tmp, reg_wakeup, div;
@@ -771,7 +777,10 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
        if (dsi->platform_ops && dsi->platform_ops->enable)
                dsi->platform_ops->enable(dsi);
 
-       mode = &bridge->encoder->crtc->state->adjusted_mode;
+       connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder);
+       conn_state = drm_atomic_get_new_connector_state(state, connector);
+       crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc);
+       mode = &crtc_state->adjusted_mode;
        nlanes = output->dev->lanes;
 
        WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false));
@@ -893,7 +902,8 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge)
        writel(tmp, dsi->regs + MCTL_MAIN_EN);
 }
 
-static void cdns_dsi_bridge_pre_enable(struct drm_bridge *bridge)
+static void cdns_dsi_bridge_atomic_pre_enable(struct drm_bridge *bridge,
+                                             struct drm_atomic_state *state)
 {
        struct cdns_dsi_input *input = bridge_to_cdns_dsi_input(bridge);
        struct cdns_dsi *dsi = input_to_dsi(input);
@@ -908,10 +918,13 @@ static void cdns_dsi_bridge_pre_enable(struct drm_bridge *bridge)
 static const struct drm_bridge_funcs cdns_dsi_bridge_funcs = {
        .attach = cdns_dsi_bridge_attach,
        .mode_valid = cdns_dsi_bridge_mode_valid,
-       .disable = cdns_dsi_bridge_disable,
-       .pre_enable = cdns_dsi_bridge_pre_enable,
-       .enable = cdns_dsi_bridge_enable,
-       .post_disable = cdns_dsi_bridge_post_disable,
+       .atomic_disable = cdns_dsi_bridge_atomic_disable,
+       .atomic_pre_enable = cdns_dsi_bridge_atomic_pre_enable,
+       .atomic_enable = cdns_dsi_bridge_atomic_enable,
+       .atomic_post_disable = cdns_dsi_bridge_atomic_post_disable,
+       .atomic_reset = drm_atomic_helper_bridge_reset,
+       .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
+       .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
 };
 
 static int cdns_dsi_attach(struct mipi_dsi_host *host,