Merge tag 'intel-gpio-v6.10-1' of git://git.kernel.org/pub/scm/linux/kernel/git/andy...
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 7 May 2024 07:42:06 +0000 (09:42 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 7 May 2024 07:42:06 +0000 (09:42 +0200)
intel-gpio for v6.10-1

* New driver for vGPIO controller on Intel Granite Rapids-D
* Update ACPI GPIO library to unify the IRQ code path
* Better GPIO IRQ line labeling for ACPI
* Switched Intel SCH driver to use "mapped" I/O accessors

The following is an automated git shortlog grouped by driver:

Add Intel Granite Rapids-D vGPIO driver:
 - Add Intel Granite Rapids-D vGPIO driver

crystalcove:
 -  Use -ENOTSUPP consistently

gpiolib:
 -  acpi: Set label for IRQ only lines
 -  acpi: Add fwnode name to the GPIO interrupt label
 -  acpi: Pass con_id instead of property into acpi_dev_gpio_irq_get_by()
 -  acpi: Move acpi_can_fallback_to_crs() out of __acpi_find_gpio()
 -  acpi: Simplify error handling in __acpi_find_gpio()
 -  acpi: Extract __acpi_find_gpio() helper
 -  acpi: Check for errors first in acpi_find_gpio()
 -  acpi: Remove never true check in acpi_get_gpiod_by_index()

sch:
 -  Utilise temporary variable for struct device
 -  Switch to memory mapped IO accessors

wcove:
 -  Use -ENOTSUPP consistently

421 files changed:
.mailmap
Documentation/arch/x86/resctrl.rst
Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
Documentation/driver-api/gpio/driver.rst
Documentation/driver-api/gpio/legacy.rst
Documentation/kbuild/llvm.rst
Documentation/translations/zh_CN/driver-api/gpio/legacy.rst
Documentation/translations/zh_TW/gpio.txt
Documentation/userspace-api/gpio/gpio-v2-get-line-ioctl.rst
MAINTAINERS
Makefile
arch/arm/include/asm/mman.h [new file with mode: 0644]
arch/arm/mach-pxa/spitz_pm.c
arch/arm/mach-sa1100/h3600.c
arch/arm64/net/bpf_jit_comp.c
arch/hexagon/kernel/vmlinux.lds.S
arch/mips/Kconfig
arch/parisc/include/asm/mman.h [new file with mode: 0644]
arch/riscv/net/bpf_jit_comp64.c
arch/s390/net/bpf_jit_comp.c
arch/x86/Kbuild
arch/x86/Kconfig
arch/x86/Makefile
arch/x86/boot/compressed/efi_mixed.S
arch/x86/entry/vdso/Makefile
arch/x86/events/amd/core.c
arch/x86/events/amd/lbr.c
arch/x86/include/asm/asm-prototypes.h
arch/x86/include/asm/cpufeature.h
arch/x86/include/asm/cpufeatures.h
arch/x86/include/asm/crash_reserve.h
arch/x86/include/asm/disabled-features.h
arch/x86/include/asm/nospec-branch.h
arch/x86/include/asm/required-features.h
arch/x86/include/asm/sev.h
arch/x86/include/asm/x86_init.h
arch/x86/kernel/cpu/scattered.c
arch/x86/kernel/eisa.c
arch/x86/kernel/nmi.c
arch/x86/kernel/probe_roms.c
arch/x86/kernel/setup.c
arch/x86/kernel/sev.c
arch/x86/kernel/x86_init.c
arch/x86/lib/retpoline.S
arch/x86/mm/ident_map.c
arch/x86/mm/mem_encrypt_amd.c
arch/x86/virt/Makefile
block/blk-merge.c
block/blk-mq.c
block/blk-settings.c
block/blk.h
crypto/asymmetric_keys/mscode_parser.c
crypto/asymmetric_keys/pkcs7_parser.c
crypto/asymmetric_keys/public_key.c
crypto/asymmetric_keys/signature.c
crypto/asymmetric_keys/x509_cert_parser.c
crypto/testmgr.h
drivers/acpi/acpica/dbnames.c
drivers/acpi/apei/einj-core.c
drivers/ata/libata-eh.c
drivers/ata/libata-scsi.c
drivers/crypto/intel/iaa/iaa_crypto_main.c
drivers/cxl/Kconfig
drivers/dma-buf/st-dma-fence-chain.c
drivers/dpll/Kconfig
drivers/firmware/efi/libstub/randomalloc.c
drivers/firmware/efi/libstub/x86-stub.c
drivers/gpio/gpio-brcmstb.c
drivers/gpio/gpio-cros-ec.c
drivers/gpio/gpio-pcie-idio-24.c
drivers/gpio/gpio-regmap.c
drivers/gpio/gpiolib-cdev.c
drivers/gpio/gpiolib-legacy.c
drivers/gpio/gpiolib-of.c
drivers/gpio/gpiolib-sysfs.c
drivers/gpio/gpiolib.c
drivers/gpio/gpiolib.h
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.h
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
drivers/gpu/drm/amd/amdgpu/umsch_mm_v4_0.c
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
drivers/gpu/drm/amd/amdkfd/kfd_int_process_v9.c
drivers/gpu/drm/amd/amdkfd/kfd_priv.h
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.h
drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
drivers/gpu/drm/amd/display/dc/core/dc.c
drivers/gpu/drm/amd/display/dc/dce110/Makefile
drivers/gpu/drm/amd/display/dc/dce112/Makefile
drivers/gpu/drm/amd/display/dc/dce120/Makefile
drivers/gpu/drm/amd/display/dc/dce60/Makefile
drivers/gpu/drm/amd/display/dc/dce80/Makefile
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.c
drivers/gpu/drm/amd/display/dc/dcn30/dcn30_mpc.h
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
drivers/gpu/drm/amd/display/dc/dml/dcn35/dcn35_fpu.c
drivers/gpu/drm/amd/display/dc/dml/dcn351/dcn351_fpu.c
drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
drivers/gpu/drm/amd/display/dc/hwss/dce110/dce110_hwseq.c
drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_hwseq.c
drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c
drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c
drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
drivers/gpu/drm/amd/include/umsch_mm_4_0_api_def.h
drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v14_0_0_ppsmc.h
drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0.c
drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
drivers/gpu/drm/display/drm_dp_helper.c
drivers/gpu/drm/i915/Makefile
drivers/gpu/drm/i915/display/g4x_dp.c
drivers/gpu/drm/i915/display/icl_dsi.c
drivers/gpu/drm/i915/display/intel_bios.c
drivers/gpu/drm/i915/display/intel_cursor.c
drivers/gpu/drm/i915/display/intel_display_types.h
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dpll_mgr.c
drivers/gpu/drm/i915/display/intel_drrs.c
drivers/gpu/drm/i915/display/intel_drrs.h
drivers/gpu/drm/i915/display/intel_dsb.c
drivers/gpu/drm/i915/display/intel_fb_pin.c
drivers/gpu/drm/i915/display/intel_sdvo.c
drivers/gpu/drm/i915/display/intel_vrr.c
drivers/gpu/drm/i915/display/skl_universal_plane.c
drivers/gpu/drm/i915/gt/intel_engine_pm.c
drivers/gpu/drm/i915/gt/intel_execlists_submission.c
drivers/gpu/drm/i915/gt/intel_workarounds.c
drivers/gpu/drm/i915/i915_driver.c
drivers/gpu/drm/i915/i915_hwmon.c
drivers/gpu/drm/i915/i915_memcpy.c
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/i915_vma.c
drivers/gpu/drm/nouveau/nouveau_dmem.c
drivers/gpu/drm/qxl/qxl_cmd.c
drivers/gpu/drm/qxl/qxl_ioctl.c
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
drivers/gpu/drm/scheduler/sched_entity.c
drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
drivers/gpu/drm/xe/Makefile
drivers/gpu/drm/xe/xe_bo.c
drivers/gpu/drm/xe/xe_bo_types.h
drivers/gpu/drm/xe/xe_device.h
drivers/gpu/drm/xe/xe_exec_queue.c
drivers/gpu/drm/xe/xe_guc_submit.c
drivers/gpu/drm/xe/xe_lrc.c
drivers/gpu/drm/xe/xe_query.c
drivers/i2c/busses/i2c-i801.c
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
drivers/iommu/iommu.c
drivers/irqchip/irq-armada-370-xp.c
drivers/md/dm-integrity.c
drivers/md/dm-vdo/murmurhash3.c
drivers/mmc/core/block.c
drivers/mmc/host/sdhci-of-dwcmshc.c
drivers/mmc/host/sdhci-omap.c
drivers/net/dsa/mt7530.c
drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
drivers/net/ethernet/intel/ice/ice_lag.c
drivers/net/ethernet/intel/ice/ice_lib.c
drivers/net/ethernet/intel/ice/ice_switch.c
drivers/net/ethernet/intel/ice/ice_switch.h
drivers/net/ethernet/intel/igc/igc_main.c
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
drivers/net/ethernet/marvell/octeontx2/af/cgx.c
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
drivers/net/ethernet/microchip/lan743x_main.c
drivers/net/ethernet/microchip/lan743x_main.h
drivers/net/ethernet/renesas/sh_eth.c
drivers/net/ethernet/xilinx/ll_temac_main.c
drivers/net/phy/qcom/at803x.c
drivers/net/wireless/intel/iwlwifi/fw/dbg.c
drivers/net/wireless/intel/iwlwifi/mvm/d3.c
drivers/net/wireless/intel/iwlwifi/mvm/debugfs-vif.c
drivers/net/wireless/intel/iwlwifi/mvm/link.c
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
drivers/net/wireless/intel/iwlwifi/queue/tx.c
drivers/net/wireless/realtek/rtw89/rtw8922a.c
drivers/net/wwan/t7xx/t7xx_cldma.c
drivers/net/wwan/t7xx/t7xx_hif_cldma.c
drivers/net/wwan/t7xx/t7xx_pcie_mac.c
drivers/pinctrl/aspeed/Makefile
drivers/pinctrl/pinctrl-amd.c
drivers/pwm/pwm-img.c
drivers/ras/amd/fmpm.c
drivers/ras/debugfs.h
drivers/s390/net/qeth_core_main.c
drivers/scsi/bnx2fc/bnx2fc_tgt.c
drivers/scsi/ch.c
drivers/scsi/cxlflash/main.c
drivers/scsi/hosts.c
drivers/scsi/libsas/sas_expander.c
drivers/scsi/lpfc/lpfc.h
drivers/scsi/lpfc/lpfc_attr.c
drivers/scsi/lpfc/lpfc_bsg.c
drivers/scsi/lpfc/lpfc_debugfs.c
drivers/scsi/lpfc/lpfc_els.c
drivers/scsi/lpfc/lpfc_hbadisc.c
drivers/scsi/lpfc/lpfc_init.c
drivers/scsi/lpfc/lpfc_mbox.c
drivers/scsi/lpfc/lpfc_nportdisc.c
drivers/scsi/lpfc/lpfc_nvme.c
drivers/scsi/lpfc/lpfc_nvmet.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/lpfc/lpfc_sli.c
drivers/scsi/lpfc/lpfc_sli.h
drivers/scsi/lpfc/lpfc_sli4.h
drivers/scsi/lpfc/lpfc_version.h
drivers/scsi/lpfc/lpfc_vport.c
drivers/scsi/mpi3mr/mpi3mr_app.c
drivers/scsi/pmcraid.c
drivers/scsi/qla2xxx/qla_attr.c
drivers/scsi/qla2xxx/qla_def.h
drivers/scsi/qla2xxx/qla_gbl.h
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_iocb.c
drivers/scsi/qla2xxx/qla_mbx.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qla2xxx/qla_target.c
drivers/scsi/qla2xxx/qla_version.h
drivers/scsi/scsi_scan.c
drivers/scsi/sd.c
drivers/scsi/sg.c
drivers/scsi/st.c
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
drivers/target/iscsi/iscsi_target_erl1.c
drivers/thermal/devfreq_cooling.c
drivers/thermal/thermal_trip.c
drivers/ufs/core/ufs-mcq.c
drivers/ufs/host/ufs-qcom.c
drivers/uio/uio.c
drivers/uio/uio_dmem_genirq.c
drivers/uio/uio_pruss.c
drivers/usb/class/cdc-wdm.c
drivers/usb/core/hub.c
drivers/usb/core/hub.h
drivers/usb/core/port.c
drivers/usb/core/sysfs.c
drivers/usb/dwc2/core.h
drivers/usb/dwc2/core_intr.c
drivers/usb/dwc2/gadget.c
drivers/usb/dwc2/hcd.c
drivers/usb/dwc2/hcd_ddma.c
drivers/usb/dwc2/hw.h
drivers/usb/dwc2/platform.c
drivers/usb/dwc3/core.c
drivers/usb/dwc3/core.h
drivers/usb/dwc3/dwc3-pci.c
drivers/usb/dwc3/gadget.c
drivers/usb/dwc3/host.c
drivers/usb/gadget/udc/core.c
drivers/usb/misc/usb-ljca.c
drivers/usb/phy/phy-generic.c
drivers/usb/storage/uas.c
drivers/usb/typec/class.c
drivers/usb/typec/tcpm/tcpm.c
drivers/usb/typec/ucsi/ucsi.c
drivers/usb/typec/ucsi/ucsi.h
drivers/usb/typec/ucsi/ucsi_acpi.c
drivers/usb/typec/ucsi/ucsi_glink.c
drivers/video/fbdev/Kconfig
fs/9p/vfs_inode.c
fs/9p/vfs_inode_dotl.c
fs/binfmt_elf_fdpic.c
fs/btrfs/block-group.c
fs/btrfs/extent_io.c
fs/btrfs/extent_map.c
fs/btrfs/scrub.c
fs/btrfs/volumes.c
fs/btrfs/zoned.c
fs/erofs/super.c
fs/exec.c
fs/gfs2/bmap.c
fs/nfsd/nfs4state.c
fs/nfsd/vfs.c
fs/proc/Makefile
fs/smb/client/dir.c
fs/smb/client/fscache.c
fs/smb/client/inode.c
fs/smb/client/trace.h
fs/xfs/libxfs/xfs_sb.c
fs/xfs/libxfs/xfs_sb.h
fs/xfs/scrub/common.c
fs/xfs/xfs_aops.c
fs/xfs/xfs_icache.c
fs/xfs/xfs_trans.h
include/asm-generic/export.h [deleted file]
include/linux/framer/framer.h
include/linux/gpio.h
include/linux/gpio/driver.h
include/linux/interrupt.h
include/linux/libata.h
include/linux/mman.h
include/linux/oid_registry.h
include/linux/pagevec.h
include/linux/skbuff.h
include/net/cfg80211.h
include/net/inet_connection_sock.h
include/net/sock.h
include/net/xdp_sock.h
include/scsi/scsi_driver.h
include/scsi/scsi_host.h
include/sound/intel-nhlt.h
include/uapi/linux/kfd_ioctl.h
include/uapi/scsi/scsi_bsg_mpi3mr.h
include/ufs/ufshcd.h
init/initramfs.c
kernel/bpf/Makefile
kernel/bpf/arena.c
kernel/bpf/bloom_filter.c
kernel/bpf/helpers.c
kernel/bpf/verifier.c
kernel/crash_reserve.c
kernel/irq/manage.c
kernel/module/Kconfig
kernel/printk/printk.c
kernel/sys.c
kernel/time/posix-clock.c
kernel/trace/trace_probe.c
mm/Makefile
mm/filemap.c
mm/gup.c
mm/memory.c
mm/page_owner.c
mm/shmem_quota.c
mm/userfaultfd.c
mm/zswap.c
net/core/sock.c
net/hsr/hsr_slave.c
net/ipv4/inet_connection_sock.c
net/ipv4/inet_fragment.c
net/ipv4/ip_fragment.c
net/ipv4/netfilter/Kconfig
net/ipv4/nexthop.c
net/ipv4/tcp.c
net/ipv6/addrconf.c
net/ipv6/netfilter/nf_conntrack_reasm.c
net/mac80211/cfg.c
net/mac80211/debug.h
net/mac80211/ieee80211_i.h
net/mac80211/mlme.c
net/netfilter/nf_tables_api.c
net/nfc/nci/core.c
net/sunrpc/auth_gss/gss_krb5_crypto.c
net/tls/tls_sw.c
net/wireless/trace.h
net/wireless/wext-core.c
scripts/Makefile.extrawarn
scripts/Makefile.modfinal
scripts/bpf_doc.py
scripts/kconfig/conf.c
scripts/kconfig/lkc.h
scripts/kconfig/lxdialog/checklist.c
scripts/kconfig/lxdialog/dialog.h
scripts/kconfig/lxdialog/inputbox.c
scripts/kconfig/lxdialog/menubox.c
scripts/kconfig/lxdialog/textbox.c
scripts/kconfig/lxdialog/util.c
scripts/kconfig/lxdialog/yesno.c
scripts/kconfig/mconf.c
scripts/kconfig/menu.c
scripts/kconfig/parser.y
scripts/mod/modpost.c
sound/aoa/soundbus/i2sbus/core.c
sound/hda/intel-nhlt.c
sound/pci/hda/cs35l56_hda.c
sound/pci/hda/tas2781_hda_i2c.c
sound/sh/aica.c
sound/soc/sof/ipc4-topology.c
tools/Makefile
tools/bpf/bpftool/gen.c
tools/lib/bpf/libbpf.c
tools/net/ynl/ynl-gen-c.py
tools/objtool/check.c
tools/testing/kunit/configs/all_tests.config
tools/testing/selftests/bpf/bpf_arena_common.h
tools/testing/selftests/bpf/prog_tests/arena_htab.c
tools/testing/selftests/bpf/prog_tests/arena_list.c
tools/testing/selftests/bpf/prog_tests/bloom_filter_map.c
tools/testing/selftests/bpf/prog_tests/verifier.c
tools/testing/selftests/bpf/progs/arena_htab.c
tools/testing/selftests/bpf/progs/arena_list.c
tools/testing/selftests/bpf/progs/verifier_arena.c
tools/testing/selftests/bpf/progs/verifier_arena_large.c [new file with mode: 0644]
tools/testing/selftests/dmabuf-heaps/config [new file with mode: 0644]
tools/testing/selftests/drivers/net/netdevsim/settings [new file with mode: 0644]
tools/testing/selftests/exec/Makefile
tools/testing/selftests/exec/binfmt_script.py
tools/testing/selftests/exec/execveat.c
tools/testing/selftests/exec/load_address.c
tools/testing/selftests/exec/recursion-depth.c
tools/testing/selftests/ftrace/test.d/filter/event-filter-function.tc
tools/testing/selftests/mm/gup_test.c
tools/testing/selftests/mm/protection_keys.c
tools/testing/selftests/mm/soft-dirty.c
tools/testing/selftests/mm/split_huge_page_test.c
tools/testing/selftests/mm/uffd-common.c
tools/testing/selftests/mm/uffd-common.h
tools/testing/selftests/mm/uffd-unit-tests.c
tools/testing/selftests/net/test_vxlan_mdb.sh
tools/testing/selftests/net/tls.c
tools/testing/selftests/seccomp/settings

index 2216b5d5c84e44ccb1ea8d99ec7e4ba4fa059f08..59c9a841bf71494f3371c9658af76aa5644783a5 100644 (file)
--- a/.mailmap
+++ b/.mailmap
@@ -340,7 +340,8 @@ Lee Jones <lee@kernel.org> <joneslee@google.com>
 Lee Jones <lee@kernel.org> <lee.jones@canonical.com>
 Lee Jones <lee@kernel.org> <lee.jones@linaro.org>
 Lee Jones <lee@kernel.org> <lee@ubuntu.com>
-Leonard Crestez <leonard.crestez@nxp.com> Leonard Crestez <cdleonard@gmail.com>
+Leonard Crestez <cdleonard@gmail.com> <leonard.crestez@nxp.com>
+Leonard Crestez <cdleonard@gmail.com> <leonard.crestez@intel.com>
 Leonardo Bras <leobras.c@gmail.com> <leonardo@linux.ibm.com>
 Leonard Göhrs <l.goehrs@pengutronix.de>
 Leonid I Ananiev <leonid.i.ananiev@intel.com>
@@ -497,7 +498,8 @@ Prasad Sodagudi <quic_psodagud@quicinc.com> <psodagud@codeaurora.org>
 Punit Agrawal <punitagrawal@gmail.com> <punit.agrawal@arm.com>
 Qais Yousef <qyousef@layalina.io> <qais.yousef@imgtec.com>
 Qais Yousef <qyousef@layalina.io> <qais.yousef@arm.com>
-Quentin Monnet <quentin@isovalent.com> <quentin.monnet@netronome.com>
+Quentin Monnet <qmo@kernel.org> <quentin.monnet@netronome.com>
+Quentin Monnet <qmo@kernel.org> <quentin@isovalent.com>
 Quentin Perret <qperret@qperret.net> <quentin.perret@arm.com>
 Rafael J. Wysocki <rjw@rjwysocki.net> <rjw@sisk.pl>
 Rajeev Nandan <quic_rajeevny@quicinc.com> <rajeevny@codeaurora.org>
index 3712d81cb50c67ac567c16ed7e768f2a79876ca4..6c245582d8fb16c6691924c7fea866b6c1bb15e8 100644 (file)
@@ -574,7 +574,7 @@ Memory b/w domain is L3 cache.
        MB:<cache_id0>=bandwidth0;<cache_id1>=bandwidth1;...
 
 Memory bandwidth Allocation specified in MiBps
----------------------------------------------
+----------------------------------------------
 
 Memory bandwidth domain is L3 cache.
 ::
index a1e71c974e79cef0289587453e835e47b2415a7b..f096f286da19cd1db7a92294a531e976e57b0bdb 100644 (file)
@@ -62,6 +62,8 @@ properties:
 
   interrupt-controller: true
 
+  gpio-ranges: true
+
   wakeup-source:
     type: boolean
     description: >
@@ -88,6 +90,7 @@ examples:
         interrupt-parent = <&irq0_intc>;
         interrupts = <0x6>;
         brcm,gpio-bank-widths = <32 32 32 24>;
+        gpio-ranges = <&pinctrl 0 0 120>;
     };
 
     upg_gio_aon: gpio@f04172c0 {
index d481e78958a74ae9f62f61c83d12eaf9caf51a3f..d61569b3f15b2aae13fe3790fa780f885a863559 100644 (file)
@@ -14,6 +14,7 @@ properties:
     items:
       - enum:
           - microchip,mpfs-gpio
+          - microchip,coregpio-rtl-v3
 
   reg:
     maxItems: 1
@@ -43,6 +44,7 @@ properties:
     default: 32
 
   gpio-controller: true
+  gpio-line-names: true
 
 patternProperties:
   "^.+-hog(-[0-9]+)?$":
@@ -62,12 +64,21 @@ patternProperties:
       - gpio-hog
       - gpios
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: microchip,mpfs-gpio
+    then:
+      required:
+        - interrupts
+        - "#interrupt-cells"
+        - interrupt-controller
+
 required:
   - compatible
   - reg
-  - interrupts
-  - "#interrupt-cells"
-  - interrupt-controller
   - "#gpio-cells"
   - gpio-controller
   - clocks
index bf6319cc531b7a14c9a489c7d7b4eaca069319bf..e541bd2e898b518432750930b3176dbca671d14d 100644 (file)
@@ -7,7 +7,7 @@ This document serves as a guide for writers of GPIO chip drivers.
 Each GPIO controller driver needs to include the following header, which defines
 the structures used to define a GPIO driver::
 
-       #include <linux/gpio/driver.h>
+  #include <linux/gpio/driver.h>
 
 
 Internal Representation of GPIOs
@@ -144,7 +144,7 @@ is not open, it will present a high-impedance (tristate) to the external rail::
      in ----||                   |/
             ||--+         in ----|
                 |                |\
-               GND                GND
+               GND                 GND
 
 This configuration is normally used as a way to achieve one of two things:
 
@@ -550,10 +550,10 @@ the interrupt separately and go with it:
   struct my_gpio *g;
   struct gpio_irq_chip *girq;
 
-  ret = devm_request_threaded_irq(dev, irq, NULL,
-               irq_thread_fn, IRQF_ONESHOT, "my-chip", g);
+  ret = devm_request_threaded_irq(dev, irq, NULL, irq_thread_fn,
+                                  IRQF_ONESHOT, "my-chip", g);
   if (ret < 0)
-       return ret;
+      return ret;
 
   /* Get a pointer to the gpio_irq_chip */
   girq = &g->gc.irq;
@@ -681,12 +681,12 @@ certain operations and keep track of usage inside of the gpiolib subsystem.
 Input GPIOs can be used as IRQ signals. When this happens, a driver is requested
 to mark the GPIO as being used as an IRQ::
 
-       int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset)
+  int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset)
 
 This will prevent the use of non-irq related GPIO APIs until the GPIO IRQ lock
 is released::
 
-       void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset)
+  void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset)
 
 When implementing an irqchip inside a GPIO driver, these two functions should
 typically be called in the .startup() and .shutdown() callbacks from the
@@ -708,12 +708,12 @@ When a GPIO is used as an IRQ signal, then gpiolib also needs to know if
 the IRQ is enabled or disabled. In order to inform gpiolib about this,
 the irqchip driver should call::
 
-       void gpiochip_disable_irq(struct gpio_chip *chip, unsigned int offset)
+  void gpiochip_disable_irq(struct gpio_chip *chip, unsigned int offset)
 
 This allows drivers to drive the GPIO as an output while the IRQ is
 disabled. When the IRQ is enabled again, a driver should call::
 
-       void gpiochip_enable_irq(struct gpio_chip *chip, unsigned int offset)
+  void gpiochip_enable_irq(struct gpio_chip *chip, unsigned int offset)
 
 When implementing an irqchip inside a GPIO driver, these two functions should
 typically be called in the .irq_disable() and .irq_enable() callbacks from the
@@ -763,12 +763,12 @@ Sometimes it is useful to allow a GPIO chip driver to request its own GPIO
 descriptors through the gpiolib API. A GPIO driver can use the following
 functions to request and free descriptors::
 
-       struct gpio_desc *gpiochip_request_own_desc(struct gpio_desc *desc,
-                                                   u16 hwnum,
-                                                   const char *label,
-                                                   enum gpiod_flags flags)
+  struct gpio_desc *gpiochip_request_own_desc(struct gpio_desc *desc,
+                                              u16 hwnum,
+                                              const char *label,
+                                              enum gpiod_flags flags)
 
-       void gpiochip_free_own_desc(struct gpio_desc *desc)
+  void gpiochip_free_own_desc(struct gpio_desc *desc)
 
 Descriptors requested with gpiochip_request_own_desc() must be released with
 gpiochip_free_own_desc().
index b6505914791c7d2dead8210d0a5c222ec98152ae..534dfe95d128b89f277dba671bf6223c328367dd 100644 (file)
@@ -225,8 +225,6 @@ setup or driver probe/teardown code, so this is an easy constraint.)::
                 gpio_request()
 
         ##     gpio_request_one()
-        ##     gpio_request_array()
-        ##     gpio_free_array()
 
                 gpio_free()
 
@@ -295,14 +293,6 @@ are claimed, three additional calls are defined::
         */
        int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
 
-       /* request multiple GPIOs in a single call
-        */
-       int gpio_request_array(struct gpio *array, size_t num);
-
-       /* release multiple GPIOs in a single call
-        */
-       void gpio_free_array(struct gpio *array, size_t num);
-
 where 'flags' is currently defined to specify the following properties:
 
        * GPIOF_DIR_IN          - to configure direction as input
@@ -341,12 +331,6 @@ A typical example of usage::
        if (err)
                ...
 
-       err = gpio_request_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-       if (err)
-               ...
-
-       gpio_free_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-
 
 GPIOs mapped to IRQs
 --------------------
index b1d97fafddcfc990d91d101a0166dd616acfe717..bb5c44f8bd1c49cd88263c94200405479eea8325 100644 (file)
@@ -178,7 +178,7 @@ yet. Bug reports are always welcome at the issue tracker below!
      - ``LLVM=1``
    * - s390
      - Maintained
-     - ``CC=clang``
+     - ``LLVM=1`` (LLVM >= 18.1.0), ``CC=clang`` (LLVM < 18.1.0)
    * - um (User Mode)
      - Maintained
      - ``LLVM=1``
index aeccff777170903f56a3eab7bbb231aa25f8676c..0faf042001d24129974f75a56a4b33d52e15431f 100644 (file)
@@ -208,8 +208,6 @@ GPIO 值的命令需要等待其信息排到队首才发送命令,再获得其
                 gpio_request()
 
         ##     gpio_request_one()
-        ##     gpio_request_array()
-        ##     gpio_free_array()
 
                 gpio_free()
 
@@ -272,14 +270,6 @@ gpio_request()前将这类细节配置好,例如使用引脚控制子系统的
         */
        int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
 
-       /* 在单个函数中申请多个 GPIO
-        */
-       int gpio_request_array(struct gpio *array, size_t num);
-
-       /* 在单个函数中释放多个 GPIO
-        */
-       void gpio_free_array(struct gpio *array, size_t num);
-
 这里 'flags' 当前定义可指定以下属性:
 
        * GPIOF_DIR_IN          - 配置方向为输入
@@ -317,12 +307,6 @@ gpio_request()前将这类细节配置好,例如使用引脚控制子系统的
        if (err)
                ...
 
-       err = gpio_request_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-       if (err)
-               ...
-
-       gpio_free_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-
 
 GPIO 映射到 IRQ
 ----------------
index b9b48012c62e59050cf78bd07fa0fb087d5ce20a..77d69d38131637c90a3ce83747ed79aa83c2b3aa 100644 (file)
@@ -215,13 +215,10 @@ GPIO 值的命令需要等待其信息排到隊首才發送命令,再獲得其
        gpio_request()
 
 ##     gpio_request_one()
-##     gpio_request_array()
-##     gpio_free_array()
 
        gpio_free()
 
 
-
 聲明和釋放 GPIO
 ----------------------------
 爲了有助於捕獲系統配置錯誤,定義了兩個函數。
@@ -278,14 +275,6 @@ gpio_request()前將這類細節配置好,例如使用 pinctrl 子系統的映
         */
        int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
 
-       /* 在單個函數中申請多個 GPIO
-        */
-       int gpio_request_array(struct gpio *array, size_t num);
-
-       /* 在單個函數中釋放多個 GPIO
-        */
-       void gpio_free_array(struct gpio *array, size_t num);
-
 這裡 'flags' 當前定義可指定以下屬性:
 
        * GPIOF_DIR_IN          - 配置方向爲輸入
@@ -323,12 +312,6 @@ gpio_request()前將這類細節配置好,例如使用 pinctrl 子系統的映
        if (err)
                ...
 
-       err = gpio_request_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-       if (err)
-               ...
-
-       gpio_free_array(leds_gpios, ARRAY_SIZE(leds_gpios));
-
 
 GPIO 映射到 IRQ
 --------------------
index 56b975801b6af02e9cc213cb7c97f479fdc19c24..6615d6ced755bac396a65218b958f29c75517c4d 100644 (file)
@@ -81,7 +81,7 @@ Only one event clock flag, ``GPIO_V2_LINE_FLAG_EVENT_CLOCK_xxx``, may be set.
 If none are set then the event clock defaults to ``CLOCK_MONOTONIC``.
 The ``GPIO_V2_LINE_FLAG_EVENT_CLOCK_HTE`` flag requires supporting hardware
 and a kernel with ``CONFIG_HTE`` set.  Requesting HTE from a device that
-doesn't support it is an error (**EOPNOTSUP**).
+doesn't support it is an error (**EOPNOTSUPP**).
 
 The :c:type:`debounce_period_us<gpio_v2_line_attribute>` attribute may only
 be applied to lines with ``GPIO_V2_LINE_FLAG_INPUT`` set. When set, debounce
index ad1afaf5d1f63be28dae8fe1755bd342c8cbd7ab..453b39a43f2c0c19bedc5b4e94593e571039d991 100644 (file)
@@ -3942,8 +3942,7 @@ F:        kernel/bpf/ringbuf.c
 
 BPF [SECURITY & LSM] (Security Audit and Enforcement using BPF)
 M:     KP Singh <kpsingh@kernel.org>
-R:     Florent Revest <revest@chromium.org>
-R:     Brendan Jackman <jackmanb@chromium.org>
+R:     Matt Bobrowski <mattbobrowski@google.com>
 L:     bpf@vger.kernel.org
 S:     Maintained
 F:     Documentation/bpf/prog_lsm.rst
@@ -3968,7 +3967,7 @@ F:        kernel/bpf/bpf_lru*
 F:     kernel/bpf/cgroup.c
 
 BPF [TOOLING] (bpftool)
-M:     Quentin Monnet <quentin@isovalent.com>
+M:     Quentin Monnet <qmo@kernel.org>
 L:     bpf@vger.kernel.org
 S:     Maintained
 F:     kernel/bpf/disasm.*
@@ -6157,7 +6156,6 @@ DEVICE-MAPPER  (LVM)
 M:     Alasdair Kergon <agk@redhat.com>
 M:     Mike Snitzer <snitzer@kernel.org>
 M:     Mikulas Patocka <mpatocka@redhat.com>
-M:     dm-devel@lists.linux.dev
 L:     dm-devel@lists.linux.dev
 S:     Maintained
 Q:     http://patchwork.kernel.org/project/dm-devel/list/
@@ -6173,7 +6171,6 @@ F:        include/uapi/linux/dm-*.h
 
 DEVICE-MAPPER VDO TARGET
 M:     Matthew Sakai <msakai@redhat.com>
-M:     dm-devel@lists.linux.dev
 L:     dm-devel@lists.linux.dev
 S:     Maintained
 F:     Documentation/admin-guide/device-mapper/vdo*.rst
@@ -7941,6 +7938,7 @@ M:        Gao Xiang <xiang@kernel.org>
 M:     Chao Yu <chao@kernel.org>
 R:     Yue Hu <huyue2@coolpad.com>
 R:     Jeffle Xu <jefflexu@linux.alibaba.com>
+R:     Sandeep Dhavale <dhavale@google.com>
 L:     linux-erofs@lists.ozlabs.org
 S:     Maintained
 W:     https://erofs.docs.kernel.org
@@ -9653,7 +9651,9 @@ L:        linux-input@vger.kernel.org
 S:     Maintained
 F:     drivers/hid/hid-logitech-hidpp.c
 
-HIGH-RESOLUTION TIMERS, CLOCKEVENTS
+HIGH-RESOLUTION TIMERS, TIMER WHEEL, CLOCKEVENTS
+M:     Anna-Maria Behnsen <anna-maria@linutronix.de>
+M:     Frederic Weisbecker <frederic@kernel.org>
 M:     Thomas Gleixner <tglx@linutronix.de>
 L:     linux-kernel@vger.kernel.org
 S:     Maintained
@@ -9661,9 +9661,13 @@ T:       git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
 F:     Documentation/timers/
 F:     include/linux/clockchips.h
 F:     include/linux/hrtimer.h
+F:     include/linux/timer.h
 F:     kernel/time/clockevents.c
 F:     kernel/time/hrtimer.c
-F:     kernel/time/timer_*.c
+F:     kernel/time/timer.c
+F:     kernel/time/timer_list.c
+F:     kernel/time/timer_migration.*
+F:     tools/testing/selftests/timers/
 
 HIGH-SPEED SCC DRIVER FOR AX.25
 L:     linux-hams@vger.kernel.org
@@ -13135,6 +13139,7 @@ F:      drivers/net/ethernet/marvell/mvpp2/
 
 MARVELL MWIFIEX WIRELESS DRIVER
 M:     Brian Norris <briannorris@chromium.org>
+R:     Francesco Dolcini <francesco@dolcini.it>
 L:     linux-wireless@vger.kernel.org
 S:     Odd Fixes
 F:     drivers/net/wireless/marvell/mwifiex/
@@ -15628,9 +15633,10 @@ F:     drivers/misc/nsm.c
 F:     include/uapi/linux/nsm.h
 
 NOHZ, DYNTICKS SUPPORT
+M:     Anna-Maria Behnsen <anna-maria@linutronix.de>
 M:     Frederic Weisbecker <frederic@kernel.org>
-M:     Thomas Gleixner <tglx@linutronix.de>
 M:     Ingo Molnar <mingo@kernel.org>
+M:     Thomas Gleixner <tglx@linutronix.de>
 L:     linux-kernel@vger.kernel.org
 S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/nohz
@@ -17591,15 +17597,20 @@ F:    drivers/pnp/
 F:     include/linux/pnp.h
 
 POSIX CLOCKS and TIMERS
+M:     Anna-Maria Behnsen <anna-maria@linutronix.de>
+M:     Frederic Weisbecker <frederic@kernel.org>
 M:     Thomas Gleixner <tglx@linutronix.de>
 L:     linux-kernel@vger.kernel.org
 S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
 F:     fs/timerfd.c
 F:     include/linux/time_namespace.h
-F:     include/linux/timer*
+F:     include/linux/timerfd.h
+F:     include/uapi/linux/time.h
+F:     include/uapi/linux/timerfd.h
 F:     include/trace/events/timer*
-F:     kernel/time/*timer*
+F:     kernel/time/itimer.c
+F:     kernel/time/posix-*
 F:     kernel/time/namespace.c
 
 POWER MANAGEMENT CORE
@@ -18646,18 +18657,21 @@ REALTEK WIRELESS DRIVER (rtlwifi family)
 M:     Ping-Ke Shih <pkshih@realtek.com>
 L:     linux-wireless@vger.kernel.org
 S:     Maintained
+T:     git https://github.com/pkshih/rtw.git
 F:     drivers/net/wireless/realtek/rtlwifi/
 
 REALTEK WIRELESS DRIVER (rtw88)
 M:     Ping-Ke Shih <pkshih@realtek.com>
 L:     linux-wireless@vger.kernel.org
 S:     Maintained
+T:     git https://github.com/pkshih/rtw.git
 F:     drivers/net/wireless/realtek/rtw88/
 
 REALTEK WIRELESS DRIVER (rtw89)
 M:     Ping-Ke Shih <pkshih@realtek.com>
 L:     linux-wireless@vger.kernel.org
 S:     Maintained
+T:     git https://github.com/pkshih/rtw.git
 F:     drivers/net/wireless/realtek/rtw89/
 
 REDPINE WIRELESS DRIVER
@@ -18728,13 +18742,24 @@ S:    Supported
 F:     Documentation/devicetree/bindings/i2c/renesas,iic-emev2.yaml
 F:     drivers/i2c/busses/i2c-emev2.c
 
-RENESAS ETHERNET DRIVERS
+RENESAS ETHERNET AVB DRIVER
 R:     Sergey Shtylyov <s.shtylyov@omp.ru>
 L:     netdev@vger.kernel.org
 L:     linux-renesas-soc@vger.kernel.org
-F:     Documentation/devicetree/bindings/net/renesas,*.yaml
-F:     drivers/net/ethernet/renesas/
-F:     include/linux/sh_eth.h
+F:     Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+F:     drivers/net/ethernet/renesas/Kconfig
+F:     drivers/net/ethernet/renesas/Makefile
+F:     drivers/net/ethernet/renesas/ravb*
+
+RENESAS ETHERNET SWITCH DRIVER
+R:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
+L:     netdev@vger.kernel.org
+L:     linux-renesas-soc@vger.kernel.org
+F:     Documentation/devicetree/bindings/net/renesas,*ether-switch.yaml
+F:     drivers/net/ethernet/renesas/Kconfig
+F:     drivers/net/ethernet/renesas/Makefile
+F:     drivers/net/ethernet/renesas/rcar_gen4*
+F:     drivers/net/ethernet/renesas/rswitch*
 
 RENESAS IDT821034 ASoC CODEC
 M:     Herve Codina <herve.codina@bootlin.com>
@@ -18844,6 +18869,16 @@ S:     Supported
 F:     Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml
 F:     drivers/i2c/busses/i2c-rzv2m.c
 
+RENESAS SUPERH ETHERNET DRIVER
+R:     Sergey Shtylyov <s.shtylyov@omp.ru>
+L:     netdev@vger.kernel.org
+L:     linux-renesas-soc@vger.kernel.org
+F:     Documentation/devicetree/bindings/net/renesas,ether.yaml
+F:     drivers/net/ethernet/renesas/Kconfig
+F:     drivers/net/ethernet/renesas/Makefile
+F:     drivers/net/ethernet/renesas/sh_eth*
+F:     include/linux/sh_eth.h
+
 RENESAS USB PHY DRIVER
 M:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
 L:     linux-renesas-soc@vger.kernel.org
@@ -19180,12 +19215,14 @@ M:    Hin-Tak Leung <hintak.leung@gmail.com>
 M:     Larry Finger <Larry.Finger@lwfinger.net>
 L:     linux-wireless@vger.kernel.org
 S:     Maintained
+T:     git https://github.com/pkshih/rtw.git
 F:     drivers/net/wireless/realtek/rtl818x/rtl8187/
 
 RTL8XXXU WIRELESS DRIVER (rtl8xxxu)
 M:     Jes Sorensen <Jes.Sorensen@gmail.com>
 L:     linux-wireless@vger.kernel.org
 S:     Maintained
+T:     git https://github.com/pkshih/rtw.git
 F:     drivers/net/wireless/realtek/rtl8xxxu/
 
 RTRS TRANSPORT DRIVERS
@@ -22255,13 +22292,20 @@ S:    Supported
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
 F:     include/linux/clocksource.h
 F:     include/linux/time.h
+F:     include/linux/timekeeper_internal.h
+F:     include/linux/timekeeping.h
 F:     include/linux/timex.h
 F:     include/uapi/linux/time.h
 F:     include/uapi/linux/timex.h
 F:     kernel/time/alarmtimer.c
-F:     kernel/time/clocksource.c
-F:     kernel/time/ntp.c
-F:     kernel/time/time*.c
+F:     kernel/time/clocksource*
+F:     kernel/time/ntp*
+F:     kernel/time/time.c
+F:     kernel/time/timeconst.bc
+F:     kernel/time/timeconv.c
+F:     kernel/time/timecounter.c
+F:     kernel/time/timekeeping*
+F:     kernel/time/time_test.c
 F:     tools/testing/selftests/timers/
 
 TIPC NETWORK LAYER
index 763b6792d3d5133d5acb84916f677af68773225a..4bef6323c47decb8805896b3a017213ef461c44e 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
 VERSION = 6
 PATCHLEVEL = 9
 SUBLEVEL = 0
-EXTRAVERSION = -rc1
+EXTRAVERSION = -rc2
 NAME = Hurr durr I'ma ninja sloth
 
 # *DOCUMENTATION*
diff --git a/arch/arm/include/asm/mman.h b/arch/arm/include/asm/mman.h
new file mode 100644 (file)
index 0000000..2189e50
--- /dev/null
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __ASM_MMAN_H__
+#define __ASM_MMAN_H__
+
+#include <asm/system_info.h>
+#include <uapi/asm/mman.h>
+
+static inline bool arch_memory_deny_write_exec_supported(void)
+{
+       return cpu_architecture() >= CPU_ARCH_ARMv6;
+}
+#define arch_memory_deny_write_exec_supported arch_memory_deny_write_exec_supported
+
+#endif /* __ASM_MMAN_H__ */
index 8bc4ea51a0c164f9fa8bbabb98623a96e8820fd4..03b4b347f11a07c3f4c1a2016e32e98d91f7da15 100644 (file)
 
 static int spitz_last_ac_status;
 
-static struct gpio spitz_charger_gpios[] = {
-       { SPITZ_GPIO_KEY_INT,   GPIOF_IN, "Keyboard Interrupt" },
-       { SPITZ_GPIO_SYNC,      GPIOF_IN, "Sync" },
-       { SPITZ_GPIO_AC_IN,     GPIOF_IN, "Charger Detection" },
-       { SPITZ_GPIO_ADC_TEMP_ON, GPIOF_OUT_INIT_LOW, "ADC Temp On" },
-       { SPITZ_GPIO_JK_B,        GPIOF_OUT_INIT_LOW, "JK B" },
-       { SPITZ_GPIO_CHRG_ON,     GPIOF_OUT_INIT_LOW, "Charger On" },
-};
-
 static void spitz_charger_init(void)
 {
-       gpio_request_array(ARRAY_AND_SIZE(spitz_charger_gpios));
+       gpio_request(SPITZ_GPIO_KEY_INT, "Keyboard Interrupt");
+       gpio_direction_input(SPITZ_GPIO_KEY_INT);
+       gpio_request(SPITZ_GPIO_SYNC, "Sync");
+       gpio_direction_input(SPITZ_GPIO_SYNC);
+       gpio_request(SPITZ_GPIO_AC_IN, "Charger Detection");
+       gpio_direction_input(SPITZ_GPIO_AC_IN);
+       gpio_request(SPITZ_GPIO_ADC_TEMP_ON, "ADC Temp On");
+       gpio_direction_output(SPITZ_GPIO_ADC_TEMP_ON, 0);
+       gpio_request(SPITZ_GPIO_JK_B, "JK B");
+       gpio_direction_output(SPITZ_GPIO_JK_B, 0);
+       gpio_request(SPITZ_GPIO_CHRG_ON, "Charger On");
+       gpio_direction_output(SPITZ_GPIO_CHRG_ON, 0);
 }
 
 static void spitz_measure_temp(int on)
index 5e25dfa752e9087485717f4db32bc77e97ca6d46..1cfc0b1fa41ca4648dbf41846654bc56d5f77e59 100644 (file)
 
 #include "generic.h"
 
-/*
- * helper for sa1100fb
- */
-static struct gpio h3600_lcd_gpio[] = {
-       { H3XXX_EGPIO_LCD_ON,   GPIOF_OUT_INIT_LOW,     "LCD power" },
-       { H3600_EGPIO_LCD_PCI,  GPIOF_OUT_INIT_LOW,     "LCD control" },
-       { H3600_EGPIO_LCD_5V_ON, GPIOF_OUT_INIT_LOW,    "LCD 5v" },
-       { H3600_EGPIO_LVDD_ON,  GPIOF_OUT_INIT_LOW,     "LCD 9v/-6.5v" },
-};
-
 static bool h3600_lcd_request(void)
 {
        static bool h3600_lcd_ok;
@@ -38,7 +28,42 @@ static bool h3600_lcd_request(void)
        if (h3600_lcd_ok)
                return true;
 
-       rc = gpio_request_array(h3600_lcd_gpio, ARRAY_SIZE(h3600_lcd_gpio));
+       rc = gpio_request(H3XXX_EGPIO_LCD_ON, "LCD power");
+       if (rc)
+               goto out;
+       rc = gpio_direction_output(H3XXX_EGPIO_LCD_ON, 0);
+       if (rc)
+               goto out_free_on;
+       rc = gpio_request(H3600_EGPIO_LCD_PCI, "LCD control");
+       if (rc)
+               goto out_free_on;
+       rc = gpio_direction_output(H3600_EGPIO_LCD_PCI, 0);
+       if (rc)
+               goto out_free_pci;
+       rc = gpio_request(H3600_EGPIO_LCD_5V_ON, "LCD 5v");
+       if (rc)
+               goto out_free_pci;
+       rc = gpio_direction_output(H3600_EGPIO_LCD_5V_ON, 0);
+       if (rc)
+               goto out_free_5v_on;
+       rc = gpio_request(H3600_EGPIO_LVDD_ON, "LCD 9v/-6.5v");
+       if (rc)
+               goto out_free_5v_on;
+       rc = gpio_direction_output(H3600_EGPIO_LVDD_ON, 0);
+       if (rc)
+               goto out_free_lvdd_on;
+
+       goto out;
+
+out_free_lvdd_on:
+       gpio_free(H3600_EGPIO_LVDD_ON);
+out_free_5v_on:
+       gpio_free(H3600_EGPIO_LCD_5V_ON);
+out_free_pci:
+       gpio_free(H3600_EGPIO_LCD_PCI);
+out_free_on:
+       gpio_free(H3XXX_EGPIO_LCD_ON);
+out:
        if (rc)
                pr_err("%s: can't request GPIOs\n", __func__);
        else
index c5b461dda4385960437d5472cc3e3945d7f9a3fe..122021f9bdfc87c3c9634d6801edad7845b9f96e 100644 (file)
@@ -943,7 +943,7 @@ static int build_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,
                        emit(A64_UXTH(is64, dst, dst), ctx);
                        break;
                case 32:
-                       emit(A64_REV32(is64, dst, dst), ctx);
+                       emit(A64_REV32(0, dst, dst), ctx);
                        /* upper 32 bits already cleared */
                        break;
                case 64:
@@ -1256,7 +1256,7 @@ emit_cond_jmp:
                        } else {
                                emit_a64_mov_i(1, tmp, off, ctx);
                                if (sign_extend)
-                                       emit(A64_LDRSW(dst, src_adj, off_adj), ctx);
+                                       emit(A64_LDRSW(dst, src, tmp), ctx);
                                else
                                        emit(A64_LDR32(dst, src, tmp), ctx);
                        }
index 1140051a0c455d07cc2db9fccfe7b4cf10256671..1150b77fa281ce002f7b4c0f502851ce18728cc5 100644 (file)
@@ -63,6 +63,7 @@ SECTIONS
        STABS_DEBUG
        DWARF_DEBUG
        ELF_DETAILS
+       .hexagon.attributes 0 : { *(.hexagon.attributes) }
 
        DISCARDS
 }
index 06ef440d16ce71bef0092d64e47526690735197c..516dc7022bd74a46a9187019ba37618f9aeb2b00 100644 (file)
@@ -619,15 +619,6 @@ config MACH_EYEQ5
 
        bool
 
-config FIT_IMAGE_FDT_EPM5
-       bool "Include FDT for Mobileye EyeQ5 development platforms"
-       depends on MACH_EYEQ5
-       default n
-       help
-         Enable this to include the FDT for the EyeQ5 development platforms
-         from Mobileye in the FIT kernel image.
-         This requires u-boot on the platform.
-
 config MACH_NINTENDO64
        bool "Nintendo 64 console"
        select CEVT_R4K
@@ -1011,6 +1002,15 @@ config CAVIUM_OCTEON_SOC
 
 endchoice
 
+config FIT_IMAGE_FDT_EPM5
+       bool "Include FDT for Mobileye EyeQ5 development platforms"
+       depends on MACH_EYEQ5
+       default n
+       help
+         Enable this to include the FDT for the EyeQ5 development platforms
+         from Mobileye in the FIT kernel image.
+         This requires u-boot on the platform.
+
 source "arch/mips/alchemy/Kconfig"
 source "arch/mips/ath25/Kconfig"
 source "arch/mips/ath79/Kconfig"
diff --git a/arch/parisc/include/asm/mman.h b/arch/parisc/include/asm/mman.h
new file mode 100644 (file)
index 0000000..47c5a19
--- /dev/null
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __ASM_MMAN_H__
+#define __ASM_MMAN_H__
+
+#include <uapi/asm/mman.h>
+
+/* PARISC cannot allow mdwe as it needs writable stacks */
+static inline bool arch_memory_deny_write_exec_supported(void)
+{
+       return false;
+}
+#define arch_memory_deny_write_exec_supported arch_memory_deny_write_exec_supported
+
+#endif /* __ASM_MMAN_H__ */
index aac190085472411f4552c54b36a802f896e72cd3..1adf2f39ce59cbb691b7f89ae9fc7a5127642ca4 100644 (file)
@@ -1463,6 +1463,22 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct rv_jit_context *ctx,
                if (ret < 0)
                        return ret;
 
+               if (insn->src_reg == BPF_PSEUDO_KFUNC_CALL) {
+                       const struct btf_func_model *fm;
+                       int idx;
+
+                       fm = bpf_jit_find_kfunc_model(ctx->prog, insn);
+                       if (!fm)
+                               return -EINVAL;
+
+                       for (idx = 0; idx < fm->nr_args; idx++) {
+                               u8 reg = bpf_to_rv_reg(BPF_REG_1 + idx, ctx);
+
+                               if (fm->arg_size[idx] == sizeof(int))
+                                       emit_sextw(reg, reg, ctx);
+                       }
+               }
+
                ret = emit_call(addr, fixed_addr, ctx);
                if (ret)
                        return ret;
index b418333bb08635304780933646e26f5ab9354e8e..5af0402e94b88c07ec3772699926d19f8f18b043 100644 (file)
@@ -516,11 +516,12 @@ static void bpf_skip(struct bpf_jit *jit, int size)
  * PLT for hotpatchable calls. The calling convention is the same as for the
  * ftrace hotpatch trampolines: %r0 is return address, %r1 is clobbered.
  */
-extern const char bpf_plt[];
-extern const char bpf_plt_ret[];
-extern const char bpf_plt_target[];
-extern const char bpf_plt_end[];
-#define BPF_PLT_SIZE 32
+struct bpf_plt {
+       char code[16];
+       void *ret;
+       void *target;
+} __packed;
+extern const struct bpf_plt bpf_plt;
 asm(
        ".pushsection .rodata\n"
        "       .balign 8\n"
@@ -531,15 +532,14 @@ asm(
        "       .balign 8\n"
        "bpf_plt_ret: .quad 0\n"
        "bpf_plt_target: .quad 0\n"
-       "bpf_plt_end:\n"
        "       .popsection\n"
 );
 
-static void bpf_jit_plt(void *plt, void *ret, void *target)
+static void bpf_jit_plt(struct bpf_plt *plt, void *ret, void *target)
 {
-       memcpy(plt, bpf_plt, BPF_PLT_SIZE);
-       *(void **)((char *)plt + (bpf_plt_ret - bpf_plt)) = ret;
-       *(void **)((char *)plt + (bpf_plt_target - bpf_plt)) = target ?: ret;
+       memcpy(plt, &bpf_plt, sizeof(*plt));
+       plt->ret = ret;
+       plt->target = target;
 }
 
 /*
@@ -662,9 +662,9 @@ static void bpf_jit_epilogue(struct bpf_jit *jit, u32 stack_depth)
        jit->prg = ALIGN(jit->prg, 8);
        jit->prologue_plt = jit->prg;
        if (jit->prg_buf)
-               bpf_jit_plt(jit->prg_buf + jit->prg,
+               bpf_jit_plt((struct bpf_plt *)(jit->prg_buf + jit->prg),
                            jit->prg_buf + jit->prologue_plt_ret, NULL);
-       jit->prg += BPF_PLT_SIZE;
+       jit->prg += sizeof(struct bpf_plt);
 }
 
 static int get_probe_mem_regno(const u8 *insn)
@@ -2040,9 +2040,6 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *fp)
        struct bpf_jit jit;
        int pass;
 
-       if (WARN_ON_ONCE(bpf_plt_end - bpf_plt != BPF_PLT_SIZE))
-               return orig_fp;
-
        if (!fp->jit_requested)
                return orig_fp;
 
@@ -2148,14 +2145,11 @@ bool bpf_jit_supports_far_kfunc_call(void)
 int bpf_arch_text_poke(void *ip, enum bpf_text_poke_type t,
                       void *old_addr, void *new_addr)
 {
+       struct bpf_plt expected_plt, current_plt, new_plt, *plt;
        struct {
                u16 opc;
                s32 disp;
        } __packed insn;
-       char expected_plt[BPF_PLT_SIZE];
-       char current_plt[BPF_PLT_SIZE];
-       char new_plt[BPF_PLT_SIZE];
-       char *plt;
        char *ret;
        int err;
 
@@ -2174,18 +2168,18 @@ int bpf_arch_text_poke(void *ip, enum bpf_text_poke_type t,
                 */
        } else {
                /* Verify the PLT. */
-               plt = (char *)ip + (insn.disp << 1);
-               err = copy_from_kernel_nofault(current_plt, plt, BPF_PLT_SIZE);
+               plt = ip + (insn.disp << 1);
+               err = copy_from_kernel_nofault(&current_plt, plt,
+                                              sizeof(current_plt));
                if (err < 0)
                        return err;
                ret = (char *)ip + 6;
-               bpf_jit_plt(expected_plt, ret, old_addr);
-               if (memcmp(current_plt, expected_plt, BPF_PLT_SIZE))
+               bpf_jit_plt(&expected_plt, ret, old_addr);
+               if (memcmp(&current_plt, &expected_plt, sizeof(current_plt)))
                        return -EINVAL;
                /* Adjust the call address. */
-               bpf_jit_plt(new_plt, ret, new_addr);
-               s390_kernel_write(plt + (bpf_plt_target - bpf_plt),
-                                 new_plt + (bpf_plt_target - bpf_plt),
+               bpf_jit_plt(&new_plt, ret, new_addr);
+               s390_kernel_write(&plt->target, &new_plt.target,
                                  sizeof(void *));
        }
 
index 6a1f36df6a181761d805d99279539874095f096a..cf0ad89f5639da8a9eaa502eb1a8b8f2432fa1ba 100644 (file)
@@ -28,7 +28,7 @@ obj-y += net/
 
 obj-$(CONFIG_KEXEC_FILE) += purgatory/
 
-obj-y += virt/svm/
+obj-y += virt/
 
 # for cleaning
 subdir- += boot tools
index 39886bab943a88b3a8262a733a7e2e82269934f8..4fff6ed46e902cfbe723cf5ed5ce517e2d131891 100644 (file)
@@ -2439,6 +2439,8 @@ config USE_X86_SEG_SUPPORT
        # with named address spaces - see GCC PR sanitizer/111736.
        #
        depends on !KASAN
+       # -fsanitize=thread (KCSAN) is also incompatible.
+       depends on !KCSAN
 
 config CC_HAS_SLS
        def_bool $(cc-option,-mharden-sls=all)
index 662d9d4033e6b855c327615fa20765f3b374f644..5ab93fcdd691dcf2d58e3c5c5e4dff67838ed951 100644 (file)
@@ -251,8 +251,6 @@ archheaders:
 
 libs-y  += arch/x86/lib/
 
-core-y += arch/x86/virt/
-
 # drivers-y are linked after core-y
 drivers-$(CONFIG_MATH_EMULATION) += arch/x86/math-emu/
 drivers-$(CONFIG_PCI)            += arch/x86/pci/
index 719e939050cbfa0b9d574b326d46c4791a0a3eed..876fc6d46a1318cf0e6ea0806f399e625206dfc3 100644 (file)
  */
 
 #include <linux/linkage.h>
+#include <asm/asm-offsets.h>
 #include <asm/msr.h>
 #include <asm/page_types.h>
 #include <asm/processor-flags.h>
 #include <asm/segment.h>
+#include <asm/setup.h>
 
        .code64
        .text
@@ -149,6 +151,7 @@ SYM_FUNC_END(__efi64_thunk)
 SYM_FUNC_START(efi32_stub_entry)
        call    1f
 1:     popl    %ecx
+       leal    (efi32_boot_args - 1b)(%ecx), %ebx
 
        /* Clear BSS */
        xorl    %eax, %eax
@@ -163,6 +166,7 @@ SYM_FUNC_START(efi32_stub_entry)
        popl    %ecx
        popl    %edx
        popl    %esi
+       movl    %esi, 8(%ebx)
        jmp     efi32_entry
 SYM_FUNC_END(efi32_stub_entry)
 #endif
@@ -239,8 +243,6 @@ SYM_FUNC_END(efi_enter32)
  *
  * Arguments:  %ecx    image handle
  *             %edx    EFI system table pointer
- *             %esi    struct bootparams pointer (or NULL when not using
- *                     the EFI handover protocol)
  *
  * Since this is the point of no return for ordinary execution, no registers
  * are considered live except for the function parameters. [Note that the EFI
@@ -266,9 +268,18 @@ SYM_FUNC_START_LOCAL(efi32_entry)
        leal    (efi32_boot_args - 1b)(%ebx), %ebx
        movl    %ecx, 0(%ebx)
        movl    %edx, 4(%ebx)
-       movl    %esi, 8(%ebx)
        movb    $0x0, 12(%ebx)          // efi_is64
 
+       /*
+        * Allocate some memory for a temporary struct boot_params, which only
+        * needs the minimal pieces that startup_32() relies on.
+        */
+       subl    $PARAM_SIZE, %esp
+       movl    %esp, %esi
+       movl    $PAGE_SIZE, BP_kernel_alignment(%esi)
+       movl    $_end - 1b, BP_init_size(%esi)
+       subl    $startup_32 - 1b, BP_init_size(%esi)
+
        /* Disable paging */
        movl    %cr0, %eax
        btrl    $X86_CR0_PG_BIT, %eax
@@ -294,8 +305,7 @@ SYM_FUNC_START(efi32_pe_entry)
 
        movl    8(%ebp), %ecx                   // image_handle
        movl    12(%ebp), %edx                  // sys_table
-       xorl    %esi, %esi
-       jmp     efi32_entry                     // pass %ecx, %edx, %esi
+       jmp     efi32_entry                     // pass %ecx, %edx
                                                // no other registers remain live
 
 2:     popl    %edi                            // restore callee-save registers
index fd63051bbbbb8255b8c0d24f89e90d074a51e6f2..3d64bcc403cfbe16645172e3e5d215bc8e48d6dd 100644 (file)
@@ -41,6 +41,7 @@ obj-$(CONFIG_X86_X32_ABI)                     += vdso-image-x32.o
 obj-$(CONFIG_COMPAT_32)                                += vdso-image-32.o vdso32-setup.o
 
 OBJECT_FILES_NON_STANDARD_vdso-image-32.o      := n
+OBJECT_FILES_NON_STANDARD_vdso-image-x32.o     := n
 OBJECT_FILES_NON_STANDARD_vdso-image-64.o      := n
 OBJECT_FILES_NON_STANDARD_vdso32-setup.o       := n
 
index aec16e581f5b2aad520bcdfbab7bff61ca99c072..985ef3b479191f7ab87b5039867742841fb0fce4 100644 (file)
@@ -250,7 +250,7 @@ static const u64 amd_perfmon_event_map[PERF_COUNT_HW_MAX] =
 /*
  * AMD Performance Monitor Family 17h and later:
  */
-static const u64 amd_f17h_perfmon_event_map[PERF_COUNT_HW_MAX] =
+static const u64 amd_zen1_perfmon_event_map[PERF_COUNT_HW_MAX] =
 {
        [PERF_COUNT_HW_CPU_CYCLES]              = 0x0076,
        [PERF_COUNT_HW_INSTRUCTIONS]            = 0x00c0,
@@ -262,10 +262,39 @@ static const u64 amd_f17h_perfmon_event_map[PERF_COUNT_HW_MAX] =
        [PERF_COUNT_HW_STALLED_CYCLES_BACKEND]  = 0x0187,
 };
 
+static const u64 amd_zen2_perfmon_event_map[PERF_COUNT_HW_MAX] =
+{
+       [PERF_COUNT_HW_CPU_CYCLES]              = 0x0076,
+       [PERF_COUNT_HW_INSTRUCTIONS]            = 0x00c0,
+       [PERF_COUNT_HW_CACHE_REFERENCES]        = 0xff60,
+       [PERF_COUNT_HW_CACHE_MISSES]            = 0x0964,
+       [PERF_COUNT_HW_BRANCH_INSTRUCTIONS]     = 0x00c2,
+       [PERF_COUNT_HW_BRANCH_MISSES]           = 0x00c3,
+       [PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x00a9,
+};
+
+static const u64 amd_zen4_perfmon_event_map[PERF_COUNT_HW_MAX] =
+{
+       [PERF_COUNT_HW_CPU_CYCLES]              = 0x0076,
+       [PERF_COUNT_HW_INSTRUCTIONS]            = 0x00c0,
+       [PERF_COUNT_HW_CACHE_REFERENCES]        = 0xff60,
+       [PERF_COUNT_HW_CACHE_MISSES]            = 0x0964,
+       [PERF_COUNT_HW_BRANCH_INSTRUCTIONS]     = 0x00c2,
+       [PERF_COUNT_HW_BRANCH_MISSES]           = 0x00c3,
+       [PERF_COUNT_HW_STALLED_CYCLES_FRONTEND] = 0x00a9,
+       [PERF_COUNT_HW_REF_CPU_CYCLES]          = 0x100000120,
+};
+
 static u64 amd_pmu_event_map(int hw_event)
 {
-       if (boot_cpu_data.x86 >= 0x17)
-               return amd_f17h_perfmon_event_map[hw_event];
+       if (cpu_feature_enabled(X86_FEATURE_ZEN4) || boot_cpu_data.x86 >= 0x1a)
+               return amd_zen4_perfmon_event_map[hw_event];
+
+       if (cpu_feature_enabled(X86_FEATURE_ZEN2) || boot_cpu_data.x86 >= 0x19)
+               return amd_zen2_perfmon_event_map[hw_event];
+
+       if (cpu_feature_enabled(X86_FEATURE_ZEN1))
+               return amd_zen1_perfmon_event_map[hw_event];
 
        return amd_perfmon_event_map[hw_event];
 }
@@ -904,8 +933,8 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs)
        if (!status)
                goto done;
 
-       /* Read branch records before unfreezing */
-       if (status & GLOBAL_STATUS_LBRS_FROZEN) {
+       /* Read branch records */
+       if (x86_pmu.lbr_nr) {
                amd_pmu_lbr_read();
                status &= ~GLOBAL_STATUS_LBRS_FROZEN;
        }
index 4a1e600314d5df124403636915a0f5fcf64ec475..5149830c7c4fa61207a3a30122e07a24964374d9 100644 (file)
@@ -402,10 +402,12 @@ void amd_pmu_lbr_enable_all(void)
                wrmsrl(MSR_AMD64_LBR_SELECT, lbr_select);
        }
 
-       rdmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl);
-       rdmsrl(MSR_AMD_DBG_EXTN_CFG, dbg_extn_cfg);
+       if (cpu_feature_enabled(X86_FEATURE_AMD_LBR_PMC_FREEZE)) {
+               rdmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl);
+               wrmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl | DEBUGCTLMSR_FREEZE_LBRS_ON_PMI);
+       }
 
-       wrmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl | DEBUGCTLMSR_FREEZE_LBRS_ON_PMI);
+       rdmsrl(MSR_AMD_DBG_EXTN_CFG, dbg_extn_cfg);
        wrmsrl(MSR_AMD_DBG_EXTN_CFG, dbg_extn_cfg | DBG_EXTN_CFG_LBRV2EN);
 }
 
@@ -418,10 +420,12 @@ void amd_pmu_lbr_disable_all(void)
                return;
 
        rdmsrl(MSR_AMD_DBG_EXTN_CFG, dbg_extn_cfg);
-       rdmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl);
-
        wrmsrl(MSR_AMD_DBG_EXTN_CFG, dbg_extn_cfg & ~DBG_EXTN_CFG_LBRV2EN);
-       wrmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl & ~DEBUGCTLMSR_FREEZE_LBRS_ON_PMI);
+
+       if (cpu_feature_enabled(X86_FEATURE_AMD_LBR_PMC_FREEZE)) {
+               rdmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl);
+               wrmsrl(MSR_IA32_DEBUGCTLMSR, dbg_ctl & ~DEBUGCTLMSR_FREEZE_LBRS_ON_PMI);
+       }
 }
 
 __init int amd_pmu_lbr_init(void)
index 076bf8dee70264f63d2a4842bca4be9c5f587f7e..25466c4d213481bed7970ee135e3a5697b3f1b77 100644 (file)
@@ -14,6 +14,7 @@
 #include <asm/asm.h>
 #include <asm/fred.h>
 #include <asm/gsseg.h>
+#include <asm/nospec-branch.h>
 
 #ifndef CONFIG_X86_CMPXCHG64
 extern void cmpxchg8b_emu(void);
index a1273698fc430b41951c241b6b76dfa9b7887692..42157ddcc09d436fef9684a813b3e9b9e666e9da 100644 (file)
@@ -91,8 +91,9 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
           CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 18, feature_bit) ||    \
           CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 19, feature_bit) ||    \
           CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 20, feature_bit) ||    \
+          CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 21, feature_bit) ||    \
           REQUIRED_MASK_CHECK                                    ||    \
-          BUILD_BUG_ON_ZERO(NCAPINTS != 21))
+          BUILD_BUG_ON_ZERO(NCAPINTS != 22))
 
 #define DISABLED_MASK_BIT_SET(feature_bit)                             \
         ( CHECK_BIT_IN_MASK_WORD(DISABLED_MASK,  0, feature_bit) ||    \
@@ -116,8 +117,9 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
           CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 18, feature_bit) ||    \
           CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 19, feature_bit) ||    \
           CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 20, feature_bit) ||    \
+          CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 21, feature_bit) ||    \
           DISABLED_MASK_CHECK                                    ||    \
-          BUILD_BUG_ON_ZERO(NCAPINTS != 21))
+          BUILD_BUG_ON_ZERO(NCAPINTS != 22))
 
 #define cpu_has(c, bit)                                                        \
        (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 :  \
index f0337f7bcf16255c7531b69a6134aa30e295ae3a..a38f8f9ba65729125234814c08547498e4e3b8bc 100644 (file)
@@ -13,7 +13,7 @@
 /*
  * Defines x86 CPU feature bits
  */
-#define NCAPINTS                       21         /* N 32-bit words worth of info */
+#define NCAPINTS                       22         /* N 32-bit words worth of info */
 #define NBUGINTS                       2          /* N 32-bit bug flags */
 
 /*
 #define X86_FEATURE_IBPB_BRTYPE                (20*32+28) /* "" MSR_PRED_CMD[IBPB] flushes all branch type predictions */
 #define X86_FEATURE_SRSO_NO            (20*32+29) /* "" CPU is not affected by SRSO */
 
+/*
+ * Extended auxiliary flags: Linux defined - for features scattered in various
+ * CPUID levels like 0x80000022, etc.
+ *
+ * Reuse free bits when adding new feature flags!
+ */
+#define X86_FEATURE_AMD_LBR_PMC_FREEZE (21*32+ 0) /* AMD LBR and PMC Freeze */
+
 /*
  * BUG word(s)
  */
index 152239f95541953ee9c7afb65d10f6e16e090e72..7835b2cdff04a7176a0a516e7f8fa06ab098de30 100644 (file)
@@ -39,4 +39,6 @@ static inline unsigned long crash_low_size_default(void)
 #endif
 }
 
+#define HAVE_ARCH_ADD_CRASH_RES_TO_IOMEM_EARLY
+
 #endif /* _X86_CRASH_RESERVE_H */
index da4054fbf533e9d5884066b5fcbbd766822e3a1e..c492bdc97b0595ec77f89dc9b0cefe5e3e64be41 100644 (file)
 #define DISABLED_MASK18        (DISABLE_IBT)
 #define DISABLED_MASK19        (DISABLE_SEV_SNP)
 #define DISABLED_MASK20        0
-#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 21)
+#define DISABLED_MASK21        0
+#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 22)
 
 #endif /* _ASM_X86_DISABLED_FEATURES_H */
index fc3a8a3c7ffeece5b1b418bda0fc4d124c83d62a..170c89ed22fcd3a27106d166a9e7f5a5d1fadf80 100644 (file)
 .Lskip_rsb_\@:
 .endm
 
+/*
+ * The CALL to srso_alias_untrain_ret() must be patched in directly at
+ * the spot where untraining must be done, ie., srso_alias_untrain_ret()
+ * must be the target of a CALL instruction instead of indirectly
+ * jumping to a wrapper which then calls it. Therefore, this macro is
+ * called outside of __UNTRAIN_RET below, for the time being, before the
+ * kernel can support nested alternatives with arbitrary nesting.
+ */
+.macro CALL_UNTRAIN_RET
 #if defined(CONFIG_MITIGATION_UNRET_ENTRY) || defined(CONFIG_MITIGATION_SRSO)
-#define CALL_UNTRAIN_RET       "call entry_untrain_ret"
-#else
-#define CALL_UNTRAIN_RET       ""
+       ALTERNATIVE_2 "", "call entry_untrain_ret", X86_FEATURE_UNRET, \
+                         "call srso_alias_untrain_ret", X86_FEATURE_SRSO_ALIAS
 #endif
+.endm
 
 /*
  * Mitigate RETBleed for AMD/Hygon Zen uarch. Requires KERNEL CR3 because the
 .macro __UNTRAIN_RET ibpb_feature, call_depth_insns
 #if defined(CONFIG_MITIGATION_RETHUNK) || defined(CONFIG_MITIGATION_IBPB_ENTRY)
        VALIDATE_UNRET_END
-       ALTERNATIVE_3 "",                                               \
-                     CALL_UNTRAIN_RET, X86_FEATURE_UNRET,              \
+       CALL_UNTRAIN_RET
+       ALTERNATIVE_2 "",                                               \
                      "call entry_ibpb", \ibpb_feature,                 \
                     __stringify(\call_depth_insns), X86_FEATURE_CALL_DEPTH
 #endif
@@ -342,6 +351,8 @@ extern void retbleed_return_thunk(void);
 static inline void retbleed_return_thunk(void) {}
 #endif
 
+extern void srso_alias_untrain_ret(void);
+
 #ifdef CONFIG_MITIGATION_SRSO
 extern void srso_return_thunk(void);
 extern void srso_alias_return_thunk(void);
index 7ba1726b71c7b8bfc95888dc78508998bba263fe..e9187ddd3d1fdc61fff087b0ea3b8b9b0ff33ac3 100644 (file)
@@ -99,6 +99,7 @@
 #define REQUIRED_MASK18        0
 #define REQUIRED_MASK19        0
 #define REQUIRED_MASK20        0
-#define REQUIRED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 21)
+#define REQUIRED_MASK21        0
+#define REQUIRED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 22)
 
 #endif /* _ASM_X86_REQUIRED_FEATURES_H */
index 9477b4053bce2ccb9d6c1c0113fd6ee44bd34d50..07e125f32528394df24c06de44e3232eaf15e4cd 100644 (file)
@@ -218,12 +218,12 @@ void early_snp_set_memory_private(unsigned long vaddr, unsigned long paddr,
                                  unsigned long npages);
 void early_snp_set_memory_shared(unsigned long vaddr, unsigned long paddr,
                                 unsigned long npages);
-void __init snp_prep_memory(unsigned long paddr, unsigned int sz, enum psc_op op);
 void snp_set_memory_shared(unsigned long vaddr, unsigned long npages);
 void snp_set_memory_private(unsigned long vaddr, unsigned long npages);
 void snp_set_wakeup_secondary_cpu(void);
 bool snp_init(struct boot_params *bp);
 void __noreturn snp_abort(void);
+void snp_dmi_setup(void);
 int snp_issue_guest_request(u64 exit_code, struct snp_req_data *input, struct snp_guest_request_ioctl *rio);
 void snp_accept_memory(phys_addr_t start, phys_addr_t end);
 u64 snp_get_unsupported_features(u64 status);
@@ -244,12 +244,12 @@ static inline void __init
 early_snp_set_memory_private(unsigned long vaddr, unsigned long paddr, unsigned long npages) { }
 static inline void __init
 early_snp_set_memory_shared(unsigned long vaddr, unsigned long paddr, unsigned long npages) { }
-static inline void __init snp_prep_memory(unsigned long paddr, unsigned int sz, enum psc_op op) { }
 static inline void snp_set_memory_shared(unsigned long vaddr, unsigned long npages) { }
 static inline void snp_set_memory_private(unsigned long vaddr, unsigned long npages) { }
 static inline void snp_set_wakeup_secondary_cpu(void) { }
 static inline bool snp_init(struct boot_params *bp) { return false; }
 static inline void snp_abort(void) { }
+static inline void snp_dmi_setup(void) { }
 static inline int snp_issue_guest_request(u64 exit_code, struct snp_req_data *input, struct snp_guest_request_ioctl *rio)
 {
        return -ENOTTY;
index b89b40f250e6f55c52cbd520bdbaeaff4eb77cf2..6149eabe200f5bb47bd18322bff50ff196e8d86e 100644 (file)
@@ -30,12 +30,13 @@ struct x86_init_mpparse {
  * @reserve_resources:         reserve the standard resources for the
  *                             platform
  * @memory_setup:              platform specific memory setup
- *
+ * @dmi_setup:                 platform specific DMI setup
  */
 struct x86_init_resources {
        void (*probe_roms)(void);
        void (*reserve_resources)(void);
        char *(*memory_setup)(void);
+       void (*dmi_setup)(void);
 };
 
 /**
index 0dad49a09b7a9e243c647a294e18e13326d140df..a515328d9d7d88b802f588bf678d098e0ba53b86 100644 (file)
@@ -49,6 +49,7 @@ static const struct cpuid_bit cpuid_bits[] = {
        { X86_FEATURE_BMEC,             CPUID_EBX,  3, 0x80000020, 0 },
        { X86_FEATURE_PERFMON_V2,       CPUID_EAX,  0, 0x80000022, 0 },
        { X86_FEATURE_AMD_LBR_V2,       CPUID_EAX,  1, 0x80000022, 0 },
+       { X86_FEATURE_AMD_LBR_PMC_FREEZE,       CPUID_EAX,  2, 0x80000022, 0 },
        { 0, 0, 0, 0, 0 }
 };
 
index e963344b044902a78340be45c30e5634bfdb2566..53935b4d62e30560d806d2c70d8aee209ec9f9df 100644 (file)
@@ -2,6 +2,7 @@
 /*
  * EISA specific code
  */
+#include <linux/cc_platform.h>
 #include <linux/ioport.h>
 #include <linux/eisa.h>
 #include <linux/io.h>
@@ -12,7 +13,7 @@ static __init int eisa_bus_probe(void)
 {
        void __iomem *p;
 
-       if (xen_pv_domain() && !xen_initial_domain())
+       if ((xen_pv_domain() && !xen_initial_domain()) || cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
                return 0;
 
        p = ioremap(0x0FFFD9, 4);
index 9a5b372c706fccb15aea2375a5424461a201d716..ed163c8c8604e30afed3855c856b461a51c9561a 100644 (file)
@@ -580,7 +580,7 @@ EXPORT_SYMBOL_GPL(asm_exc_nmi_kvm_vmx);
 
 static char *nmi_check_stall_msg[] = {
 /*                                                                     */
-/* +--------- nsp->idt_seq_snap & 0x1: CPU is in NMI handler.          */
+/* +--------- nmi_seq & 0x1: CPU is currently in NMI handler.          */
 /* | +------ cpu_is_offline(cpu)                                       */
 /* | | +--- nsp->idt_calls_snap != atomic_long_read(&nsp->idt_calls):  */
 /* | | |       NMI handler has been invoked.                           */
@@ -628,22 +628,26 @@ void nmi_backtrace_stall_check(const struct cpumask *btp)
                nmi_seq = READ_ONCE(nsp->idt_nmi_seq);
                if (nsp->idt_nmi_seq_snap + 1 == nmi_seq && (nmi_seq & 0x1)) {
                        msgp = "CPU entered NMI handler function, but has not exited";
-               } else if ((nsp->idt_nmi_seq_snap & 0x1) != (nmi_seq & 0x1)) {
-                       msgp = "CPU is handling NMIs";
-               } else {
-                       idx = ((nsp->idt_seq_snap & 0x1) << 2) |
+               } else if (nsp->idt_nmi_seq_snap == nmi_seq ||
+                          nsp->idt_nmi_seq_snap + 1 == nmi_seq) {
+                       idx = ((nmi_seq & 0x1) << 2) |
                              (cpu_is_offline(cpu) << 1) |
                              (nsp->idt_calls_snap != atomic_long_read(&nsp->idt_calls));
                        msgp = nmi_check_stall_msg[idx];
                        if (nsp->idt_ignored_snap != READ_ONCE(nsp->idt_ignored) && (idx & 0x1))
                                modp = ", but OK because ignore_nmis was set";
-                       if (nmi_seq & 0x1)
-                               msghp = " (CPU currently in NMI handler function)";
-                       else if (nsp->idt_nmi_seq_snap + 1 == nmi_seq)
+                       if (nsp->idt_nmi_seq_snap + 1 == nmi_seq)
                                msghp = " (CPU exited one NMI handler function)";
+                       else if (nmi_seq & 0x1)
+                               msghp = " (CPU currently in NMI handler function)";
+                       else
+                               msghp = " (CPU was never in an NMI handler function)";
+               } else {
+                       msgp = "CPU is handling NMIs";
                }
-               pr_alert("%s: CPU %d: %s%s%s, last activity: %lu jiffies ago.\n",
-                        __func__, cpu, msgp, modp, msghp, j - READ_ONCE(nsp->recv_jiffies));
+               pr_alert("%s: CPU %d: %s%s%s\n", __func__, cpu, msgp, modp, msghp);
+               pr_alert("%s: last activity: %lu jiffies ago.\n",
+                        __func__, j - READ_ONCE(nsp->recv_jiffies));
        }
 }
 
index 319fef37d9dce41f8109c768f58f627649dbac99..cc2c34ba7228ac52b5c8d14e1f57625337154881 100644 (file)
@@ -203,16 +203,6 @@ void __init probe_roms(void)
        unsigned char c;
        int i;
 
-       /*
-        * The ROM memory range is not part of the e820 table and is therefore not
-        * pre-validated by BIOS. The kernel page table maps the ROM region as encrypted
-        * memory, and SNP requires encrypted memory to be validated before access.
-        * Do that here.
-        */
-       snp_prep_memory(video_rom_resource.start,
-                       ((system_rom_resource.end + 1) - video_rom_resource.start),
-                       SNP_PAGE_STATE_PRIVATE);
-
        /* video rom */
        upper = adapter_rom_resources[0].start;
        for (start = video_rom_resource.start; start < upper; start += 2048) {
index ef206500ed6f22e11228ebfb6f4537343a064076..0109e6c510e02fcced0e2bbbfedc6af8e48ba90e 100644 (file)
@@ -9,7 +9,6 @@
 #include <linux/console.h>
 #include <linux/crash_dump.h>
 #include <linux/dma-map-ops.h>
-#include <linux/dmi.h>
 #include <linux/efi.h>
 #include <linux/ima.h>
 #include <linux/init_ohci1394_dma.h>
@@ -902,7 +901,7 @@ void __init setup_arch(char **cmdline_p)
                efi_init();
 
        reserve_ibft_region();
-       dmi_setup();
+       x86_init.resources.dmi_setup();
 
        /*
         * VMware detection requires dmi to be available, so this
index b59b09c2f28406fc286066a2517eb178f36ad6ae..7e1e63cc48e67dcc3f3abc84362ba805fef5a93d 100644 (file)
@@ -23,6 +23,7 @@
 #include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/psp-sev.h>
+#include <linux/dmi.h>
 #include <uapi/linux/sev-guest.h>
 
 #include <asm/init.h>
@@ -795,21 +796,6 @@ void __init early_snp_set_memory_shared(unsigned long vaddr, unsigned long paddr
        early_set_pages_state(vaddr, paddr, npages, SNP_PAGE_STATE_SHARED);
 }
 
-void __init snp_prep_memory(unsigned long paddr, unsigned int sz, enum psc_op op)
-{
-       unsigned long vaddr, npages;
-
-       vaddr = (unsigned long)__va(paddr);
-       npages = PAGE_ALIGN(sz) >> PAGE_SHIFT;
-
-       if (op == SNP_PAGE_STATE_PRIVATE)
-               early_snp_set_memory_private(vaddr, paddr, npages);
-       else if (op == SNP_PAGE_STATE_SHARED)
-               early_snp_set_memory_shared(vaddr, paddr, npages);
-       else
-               WARN(1, "invalid memory op %d\n", op);
-}
-
 static unsigned long __set_pages_state(struct snp_psc_desc *data, unsigned long vaddr,
                                       unsigned long vaddr_end, int op)
 {
@@ -2136,6 +2122,17 @@ void __head __noreturn snp_abort(void)
        sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_UNSUPPORTED);
 }
 
+/*
+ * SEV-SNP guests should only execute dmi_setup() if EFI_CONFIG_TABLES are
+ * enabled, as the alternative (fallback) logic for DMI probing in the legacy
+ * ROM region can cause a crash since this region is not pre-validated.
+ */
+void __init snp_dmi_setup(void)
+{
+       if (efi_enabled(EFI_CONFIG_TABLES))
+               dmi_setup();
+}
+
 static void dump_cpuid_table(void)
 {
        const struct snp_cpuid_table *cpuid_table = snp_cpuid_get_table();
index a42830dc151bc48af1362a3fbe8248ae63038b63..d5dc5a92635a8290bf87bdf6227c015125442767 100644 (file)
@@ -3,6 +3,7 @@
  *
  *  For licencing details see kernel-base/COPYING
  */
+#include <linux/dmi.h>
 #include <linux/init.h>
 #include <linux/ioport.h>
 #include <linux/export.h>
@@ -66,6 +67,7 @@ struct x86_init_ops x86_init __initdata = {
                .probe_roms             = probe_roms,
                .reserve_resources      = reserve_standard_io_resources,
                .memory_setup           = e820__memory_setup_default,
+               .dmi_setup              = dmi_setup,
        },
 
        .mpparse = {
index 721b528da9acee3e4eb2168bbd65ab7303a4db3a..02cde194a99e691c54b6252a31b3d9ca7f8e7e42 100644 (file)
@@ -163,6 +163,7 @@ SYM_CODE_START_NOALIGN(srso_alias_untrain_ret)
        lfence
        jmp srso_alias_return_thunk
 SYM_FUNC_END(srso_alias_untrain_ret)
+__EXPORT_THUNK(srso_alias_untrain_ret)
        .popsection
 
        .pushsection .text..__x86.rethunk_safe
@@ -224,10 +225,12 @@ SYM_CODE_START(srso_return_thunk)
 SYM_CODE_END(srso_return_thunk)
 
 #define JMP_SRSO_UNTRAIN_RET "jmp srso_untrain_ret"
-#define JMP_SRSO_ALIAS_UNTRAIN_RET "jmp srso_alias_untrain_ret"
 #else /* !CONFIG_MITIGATION_SRSO */
+/* Dummy for the alternative in CALL_UNTRAIN_RET. */
+SYM_CODE_START(srso_alias_untrain_ret)
+       RET
+SYM_FUNC_END(srso_alias_untrain_ret)
 #define JMP_SRSO_UNTRAIN_RET "ud2"
-#define JMP_SRSO_ALIAS_UNTRAIN_RET "ud2"
 #endif /* CONFIG_MITIGATION_SRSO */
 
 #ifdef CONFIG_MITIGATION_UNRET_ENTRY
@@ -319,9 +322,7 @@ SYM_FUNC_END(retbleed_untrain_ret)
 #if defined(CONFIG_MITIGATION_UNRET_ENTRY) || defined(CONFIG_MITIGATION_SRSO)
 
 SYM_FUNC_START(entry_untrain_ret)
-       ALTERNATIVE_2 JMP_RETBLEED_UNTRAIN_RET,                         \
-                     JMP_SRSO_UNTRAIN_RET, X86_FEATURE_SRSO,           \
-                     JMP_SRSO_ALIAS_UNTRAIN_RET, X86_FEATURE_SRSO_ALIAS
+       ALTERNATIVE JMP_RETBLEED_UNTRAIN_RET, JMP_SRSO_UNTRAIN_RET, X86_FEATURE_SRSO
 SYM_FUNC_END(entry_untrain_ret)
 __EXPORT_THUNK(entry_untrain_ret)
 
index a204a332c71fc50948c884251cc15cc89afeaf1f..968d7005f4a72454ccf8678967f040fe06f36ad6 100644 (file)
@@ -26,31 +26,18 @@ static int ident_pud_init(struct x86_mapping_info *info, pud_t *pud_page,
        for (; addr < end; addr = next) {
                pud_t *pud = pud_page + pud_index(addr);
                pmd_t *pmd;
-               bool use_gbpage;
 
                next = (addr & PUD_MASK) + PUD_SIZE;
                if (next > end)
                        next = end;
 
-               /* if this is already a gbpage, this portion is already mapped */
-               if (pud_leaf(*pud))
-                       continue;
-
-               /* Is using a gbpage allowed? */
-               use_gbpage = info->direct_gbpages;
-
-               /* Don't use gbpage if it maps more than the requested region. */
-               /* at the begining: */
-               use_gbpage &= ((addr & ~PUD_MASK) == 0);
-               /* ... or at the end: */
-               use_gbpage &= ((next & ~PUD_MASK) == 0);
-
-               /* Never overwrite existing mappings */
-               use_gbpage &= !pud_present(*pud);
-
-               if (use_gbpage) {
+               if (info->direct_gbpages) {
                        pud_t pudval;
 
+                       if (pud_present(*pud))
+                               continue;
+
+                       addr &= PUD_MASK;
                        pudval = __pud((addr - info->offset) | info->page_flag);
                        set_pud(pud, pudval);
                        continue;
index 70b91de2e053abb5f181612e3db295b16def3c02..422602f6039b82297c71ce7802d560b5ef550486 100644 (file)
@@ -492,6 +492,24 @@ void __init sme_early_init(void)
         */
        if (sev_status & MSR_AMD64_SEV_ENABLED)
                ia32_disable();
+
+       /*
+        * Override init functions that scan the ROM region in SEV-SNP guests,
+        * as this memory is not pre-validated and would thus cause a crash.
+        */
+       if (sev_status & MSR_AMD64_SEV_SNP_ENABLED) {
+               x86_init.mpparse.find_mptable = x86_init_noop;
+               x86_init.pci.init_irq = x86_init_noop;
+               x86_init.resources.probe_roms = x86_init_noop;
+
+               /*
+                * DMI setup behavior for SEV-SNP guests depends on
+                * efi_enabled(EFI_CONFIG_TABLES), which hasn't been
+                * parsed yet. snp_dmi_setup() will run after that
+                * parsing has happened.
+                */
+               x86_init.resources.dmi_setup = snp_dmi_setup;
+       }
 }
 
 void __init mem_encrypt_free_decrypted_mem(void)
index 1e36502cd7383ad031d3ceaa3ddced2703e4f61d..ea343fc392dcc89f0aa2690cebb25fe6fa68aee8 100644 (file)
@@ -1,2 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0-only
-obj-y  += vmx/
+obj-y  += svm/ vmx/
index 2a06fd33039da6ad1cbb2b6d212c8662184788e0..4e3483a16b7575ec1d6f1cf9b92ebc7dfca1e9e5 100644 (file)
@@ -726,7 +726,7 @@ static int ll_merge_requests_fn(struct request_queue *q, struct request *req,
  *     which can be mixed are set in each bio and mark @rq as mixed
  *     merged.
  */
-void blk_rq_set_mixed_merge(struct request *rq)
+static void blk_rq_set_mixed_merge(struct request *rq)
 {
        blk_opf_t ff = rq->cmd_flags & REQ_FAILFAST_MASK;
        struct bio *bio;
index 555ada922cf06021124eb3170983fc308e8d2a38..32afb87efbd0ef6a4814d05aa79020a07cbfc19f 100644 (file)
@@ -770,16 +770,11 @@ static void req_bio_endio(struct request *rq, struct bio *bio,
                /*
                 * Partial zone append completions cannot be supported as the
                 * BIO fragments may end up not being written sequentially.
-                * For such case, force the completed nbytes to be equal to
-                * the BIO size so that bio_advance() sets the BIO remaining
-                * size to 0 and we end up calling bio_endio() before returning.
                 */
-               if (bio->bi_iter.bi_size != nbytes) {
+               if (bio->bi_iter.bi_size != nbytes)
                        bio->bi_status = BLK_STS_IOERR;
-                       nbytes = bio->bi_iter.bi_size;
-               } else {
+               else
                        bio->bi_iter.bi_sector = rq->__sector;
-               }
        }
 
        bio_advance(bio, nbytes);
index 3c7d8d638ab59dc9704aa01217c9b940b5941e4b..cdbaef159c4bc3e2f713ac8541a36450271678e7 100644 (file)
@@ -146,8 +146,7 @@ static int blk_validate_limits(struct queue_limits *lim)
        max_hw_sectors = min_not_zero(lim->max_hw_sectors,
                                lim->max_dev_sectors);
        if (lim->max_user_sectors) {
-               if (lim->max_user_sectors > max_hw_sectors ||
-                   lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE)
+               if (lim->max_user_sectors < PAGE_SIZE / SECTOR_SIZE)
                        return -EINVAL;
                lim->max_sectors = min(max_hw_sectors, lim->max_user_sectors);
        } else {
index 5cac4e29ae1744fe4dd370e05290df0f31f3f4ba..d9f584984bc44b8280436a6ddfa044d909c626ad 100644 (file)
@@ -339,7 +339,6 @@ int ll_back_merge_fn(struct request *req, struct bio *bio,
 bool blk_attempt_req_merge(struct request_queue *q, struct request *rq,
                                struct request *next);
 unsigned int blk_recalc_rq_segments(struct request *rq);
-void blk_rq_set_mixed_merge(struct request *rq);
 bool blk_rq_merge_ok(struct request *rq, struct bio *bio);
 enum elv_merge blk_try_merge(struct request *rq, struct bio *bio);
 
index 05402ef8964ed41332f121919660376dc7e43e6a..8aecbe4637f36e7b7e5518d01257f03e6d2a3d8b 100644 (file)
@@ -75,6 +75,9 @@ int mscode_note_digest_algo(void *context, size_t hdrlen,
 
        oid = look_up_OID(value, vlen);
        switch (oid) {
+       case OID_sha1:
+               ctx->digest_algo = "sha1";
+               break;
        case OID_sha256:
                ctx->digest_algo = "sha256";
                break;
index 5b08c50722d0f512f9605b5d3375b90cff119778..231ad7b3789d5e4aac7087e8ac76df6775a17af7 100644 (file)
@@ -227,6 +227,9 @@ int pkcs7_sig_note_digest_algo(void *context, size_t hdrlen,
        struct pkcs7_parse_context *ctx = context;
 
        switch (ctx->last_oid) {
+       case OID_sha1:
+               ctx->sinfo->sig->hash_algo = "sha1";
+               break;
        case OID_sha256:
                ctx->sinfo->sig->hash_algo = "sha256";
                break;
@@ -278,6 +281,7 @@ int pkcs7_sig_note_pkey_algo(void *context, size_t hdrlen,
                ctx->sinfo->sig->pkey_algo = "rsa";
                ctx->sinfo->sig->encoding = "pkcs1";
                break;
+       case OID_id_ecdsa_with_sha1:
        case OID_id_ecdsa_with_sha224:
        case OID_id_ecdsa_with_sha256:
        case OID_id_ecdsa_with_sha384:
index e5f22691febd599d9a1eeb3310c19c762e715cd8..e314fd57e6f88acffad4d4b4d8fa0b1e68071b9b 100644 (file)
@@ -115,7 +115,8 @@ software_key_determine_akcipher(const struct public_key *pkey,
                 */
                if (!hash_algo)
                        return -EINVAL;
-               if (strcmp(hash_algo, "sha224") != 0 &&
+               if (strcmp(hash_algo, "sha1") != 0 &&
+                   strcmp(hash_algo, "sha224") != 0 &&
                    strcmp(hash_algo, "sha256") != 0 &&
                    strcmp(hash_algo, "sha384") != 0 &&
                    strcmp(hash_algo, "sha512") != 0 &&
index 398983be77e8bc4ee844f63b457188be9f71a1b5..2deff81f8af50bfed8159b72d119e95d35dbe510 100644 (file)
@@ -115,7 +115,7 @@ EXPORT_SYMBOL_GPL(decrypt_blob);
  * Sign the specified data blob using the private key specified by params->key.
  * The signature is wrapped in an encoding if params->encoding is specified
  * (eg. "pkcs1").  If the encoding needs to know the digest type, this can be
- * passed through params->hash_algo (eg. "sha512").
+ * passed through params->hash_algo (eg. "sha1").
  *
  * Returns the length of the data placed in the signature buffer or an error.
  */
index 487204d394266e74be91e1b47beb25eecfdc8f54..bb0bffa271b53c69410b80d04364f0a6cdc86368 100644 (file)
@@ -198,6 +198,10 @@ int x509_note_sig_algo(void *context, size_t hdrlen, unsigned char tag,
        default:
                return -ENOPKG; /* Unsupported combination */
 
+       case OID_sha1WithRSAEncryption:
+               ctx->cert->sig->hash_algo = "sha1";
+               goto rsa_pkcs1;
+
        case OID_sha256WithRSAEncryption:
                ctx->cert->sig->hash_algo = "sha256";
                goto rsa_pkcs1;
@@ -214,6 +218,10 @@ int x509_note_sig_algo(void *context, size_t hdrlen, unsigned char tag,
                ctx->cert->sig->hash_algo = "sha224";
                goto rsa_pkcs1;
 
+       case OID_id_ecdsa_with_sha1:
+               ctx->cert->sig->hash_algo = "sha1";
+               goto ecdsa;
+
        case OID_id_rsassa_pkcs1_v1_5_with_sha3_256:
                ctx->cert->sig->hash_algo = "sha3-256";
                goto rsa_pkcs1;
index 986f331a5fc2473877fb06bc2e1cdd191f391f8b..12e1c892f36661db5cb4419e53ef1151ec54f6f4 100644 (file)
@@ -653,6 +653,30 @@ static const struct akcipher_testvec rsa_tv_template[] = {
 static const struct akcipher_testvec ecdsa_nist_p192_tv_template[] = {
        {
        .key =
+       "\x04\xf7\x46\xf8\x2f\x15\xf6\x22\x8e\xd7\x57\x4f\xcc\xe7\xbb\xc1"
+       "\xd4\x09\x73\xcf\xea\xd0\x15\x07\x3d\xa5\x8a\x8a\x95\x43\xe4\x68"
+       "\xea\xc6\x25\xc1\xc1\x01\x25\x4c\x7e\xc3\x3c\xa6\x04\x0a\xe7\x08"
+       "\x98",
+       .key_len = 49,
+       .params =
+       "\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86\x48"
+       "\xce\x3d\x03\x01\x01",
+       .param_len = 21,
+       .m =
+       "\xcd\xb9\xd2\x1c\xb7\x6f\xcd\x44\xb3\xfd\x63\xea\xa3\x66\x7f\xae"
+       "\x63\x85\xe7\x82",
+       .m_size = 20,
+       .algo = OID_id_ecdsa_with_sha1,
+       .c =
+       "\x30\x35\x02\x19\x00\xba\xe5\x93\x83\x6e\xb6\x3b\x63\xa0\x27\x91"
+       "\xc6\xf6\x7f\xc3\x09\xad\x59\xad\x88\x27\xd6\x92\x6b\x02\x18\x10"
+       "\x68\x01\x9d\xba\xce\x83\x08\xef\x95\x52\x7b\xa0\x0f\xe4\x18\x86"
+       "\x80\x6f\xa5\x79\x77\xda\xd0",
+       .c_size = 55,
+       .public_key_vec = true,
+       .siggen_sigver_test = true,
+       }, {
+       .key =
        "\x04\xb6\x4b\xb1\xd1\xac\xba\x24\x8f\x65\xb2\x60\x00\x90\xbf\xbd"
        "\x78\x05\x73\xe9\x79\x1d\x6f\x7c\x0b\xd2\xc3\x93\xa7\x28\xe1\x75"
        "\xf7\xd5\x95\x1d\x28\x10\xc0\x75\x50\x5c\x1a\x4f\x3f\x8f\xa5\xee"
@@ -756,6 +780,32 @@ static const struct akcipher_testvec ecdsa_nist_p192_tv_template[] = {
 static const struct akcipher_testvec ecdsa_nist_p256_tv_template[] = {
        {
        .key =
+       "\x04\xb9\x7b\xbb\xd7\x17\x64\xd2\x7e\xfc\x81\x5d\x87\x06\x83\x41"
+       "\x22\xd6\x9a\xaa\x87\x17\xec\x4f\x63\x55\x2f\x94\xba\xdd\x83\xe9"
+       "\x34\x4b\xf3\xe9\x91\x13\x50\xb6\xcb\xca\x62\x08\xe7\x3b\x09\xdc"
+       "\xc3\x63\x4b\x2d\xb9\x73\x53\xe4\x45\xe6\x7c\xad\xe7\x6b\xb0\xe8"
+       "\xaf",
+       .key_len = 65,
+       .params =
+       "\x30\x13\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x08\x2a\x86\x48"
+       "\xce\x3d\x03\x01\x07",
+       .param_len = 21,
+       .m =
+       "\xc2\x2b\x5f\x91\x78\x34\x26\x09\x42\x8d\x6f\x51\xb2\xc5\xaf\x4c"
+       "\x0b\xde\x6a\x42",
+       .m_size = 20,
+       .algo = OID_id_ecdsa_with_sha1,
+       .c =
+       "\x30\x46\x02\x21\x00\xf9\x25\xce\x9f\x3a\xa6\x35\x81\xcf\xd4\xe7"
+       "\xb7\xf0\x82\x56\x41\xf7\xd4\xad\x8d\x94\x5a\x69\x89\xee\xca\x6a"
+       "\x52\x0e\x48\x4d\xcc\x02\x21\x00\xd7\xe4\xef\x52\x66\xd3\x5b\x9d"
+       "\x8a\xfa\x54\x93\x29\xa7\x70\x86\xf1\x03\x03\xf3\x3b\xe2\x73\xf7"
+       "\xfb\x9d\x8b\xde\xd4\x8d\x6f\xad",
+       .c_size = 72,
+       .public_key_vec = true,
+       .siggen_sigver_test = true,
+       }, {
+       .key =
        "\x04\x8b\x6d\xc0\x33\x8e\x2d\x8b\x67\xf5\xeb\xc4\x7f\xa0\xf5\xd9"
        "\x7b\x03\xa5\x78\x9a\xb5\xea\x14\xe4\x23\xd0\xaf\xd7\x0e\x2e\xa0"
        "\xc9\x8b\xdb\x95\xf8\xb3\xaf\xac\x00\x2c\x2c\x1f\x7a\xfd\x95\x88"
@@ -866,6 +916,36 @@ static const struct akcipher_testvec ecdsa_nist_p256_tv_template[] = {
 
 static const struct akcipher_testvec ecdsa_nist_p384_tv_template[] = {
        {
+       .key = /* secp384r1(sha1) */
+       "\x04\x89\x25\xf3\x97\x88\xcb\xb0\x78\xc5\x72\x9a\x14\x6e\x7a\xb1"
+       "\x5a\xa5\x24\xf1\x95\x06\x9e\x28\xfb\xc4\xb9\xbe\x5a\x0d\xd9\x9f"
+       "\xf3\xd1\x4d\x2d\x07\x99\xbd\xda\xa7\x66\xec\xbb\xea\xba\x79\x42"
+       "\xc9\x34\x89\x6a\xe7\x0b\xc3\xf2\xfe\x32\x30\xbe\xba\xf9\xdf\x7e"
+       "\x4b\x6a\x07\x8e\x26\x66\x3f\x1d\xec\xa2\x57\x91\x51\xdd\x17\x0e"
+       "\x0b\x25\xd6\x80\x5c\x3b\xe6\x1a\x98\x48\x91\x45\x7a\x73\xb0\xc3"
+       "\xf1",
+       .key_len = 97,
+       .params =
+       "\x30\x10\x06\x07\x2a\x86\x48\xce\x3d\x02\x01\x06\x05\x2b\x81\x04"
+       "\x00\x22",
+       .param_len = 18,
+       .m =
+       "\x12\x55\x28\xf0\x77\xd5\xb6\x21\x71\x32\x48\xcd\x28\xa8\x25\x22"
+       "\x3a\x69\xc1\x93",
+       .m_size = 20,
+       .algo = OID_id_ecdsa_with_sha1,
+       .c =
+       "\x30\x66\x02\x31\x00\xf5\x0f\x24\x4c\x07\x93\x6f\x21\x57\x55\x07"
+       "\x20\x43\x30\xde\xa0\x8d\x26\x8e\xae\x63\x3f\xbc\x20\x3a\xc6\xf1"
+       "\x32\x3c\xce\x70\x2b\x78\xf1\x4c\x26\xe6\x5b\x86\xcf\xec\x7c\x7e"
+       "\xd0\x87\xd7\xd7\x6e\x02\x31\x00\xcd\xbb\x7e\x81\x5d\x8f\x63\xc0"
+       "\x5f\x63\xb1\xbe\x5e\x4c\x0e\xa1\xdf\x28\x8c\x1b\xfa\xf9\x95\x88"
+       "\x74\xa0\x0f\xbf\xaf\xc3\x36\x76\x4a\xa1\x59\xf1\x1c\xa4\x58\x26"
+       "\x79\x12\x2a\xb7\xc5\x15\x92\xc5",
+       .c_size = 104,
+       .public_key_vec = true,
+       .siggen_sigver_test = true,
+       }, {
        .key = /* secp384r1(sha224) */
        "\x04\x69\x6c\xcf\x62\xee\xd0\x0d\xe5\xb5\x2f\x70\x54\xcf\x26\xa0"
        "\xd9\x98\x8d\x92\x2a\xab\x9b\x11\xcb\x48\x18\xa1\xa9\x0d\xd5\x18"
index b91155ea9c343cd82871b3dc0638a2143a0f11bf..c9131259f717b0cf37f939bb39f5dada23d12ddc 100644 (file)
@@ -550,8 +550,12 @@ acpi_db_walk_for_fields(acpi_handle obj_handle,
        ACPI_FREE(buffer.pointer);
 
        buffer.length = ACPI_ALLOCATE_LOCAL_BUFFER;
-       acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
-
+       status = acpi_evaluate_object(obj_handle, NULL, NULL, &buffer);
+       if (ACPI_FAILURE(status)) {
+               acpi_os_printf("Could Not evaluate object %p\n",
+                              obj_handle);
+               return (AE_OK);
+       }
        /*
         * Since this is a field unit, surround the output in braces
         */
index 66e7f529e92fc2975d744e531f1b84b78de31b8d..01faca3a238a3a6e3953a8b9bc490b25789041fd 100644 (file)
@@ -851,7 +851,7 @@ err_put_table:
        return rc;
 }
 
-static void __exit einj_remove(struct platform_device *pdev)
+static void einj_remove(struct platform_device *pdev)
 {
        struct apei_exec_context ctx;
 
index b0d6e69c4a5b2e0fd66c19804aed7c9c46ab9c21..214b935c2ced796fbcb7bbf70a8b8bee27fd9e3c 100644 (file)
@@ -712,8 +712,10 @@ void ata_scsi_port_error_handler(struct Scsi_Host *host, struct ata_port *ap)
                                ehc->saved_ncq_enabled |= 1 << devno;
 
                        /* If we are resuming, wake up the device */
-                       if (ap->pflags & ATA_PFLAG_RESUMING)
+                       if (ap->pflags & ATA_PFLAG_RESUMING) {
+                               dev->flags |= ATA_DFLAG_RESUMING;
                                ehc->i.dev_action[devno] |= ATA_EH_SET_ACTIVE;
+                       }
                }
        }
 
@@ -3169,6 +3171,7 @@ static int ata_eh_revalidate_and_attach(struct ata_link *link,
        return 0;
 
  err:
+       dev->flags &= ~ATA_DFLAG_RESUMING;
        *r_failed_dev = dev;
        return rc;
 }
index 0a0f483124c3a56af47abb498e67193236416b18..2f4c58837641077f3ad91974cd11affbe6dcd1e8 100644 (file)
@@ -4730,6 +4730,7 @@ void ata_scsi_dev_rescan(struct work_struct *work)
        struct ata_link *link;
        struct ata_device *dev;
        unsigned long flags;
+       bool do_resume;
        int ret = 0;
 
        mutex_lock(&ap->scsi_scan_mutex);
@@ -4751,7 +4752,15 @@ void ata_scsi_dev_rescan(struct work_struct *work)
                        if (scsi_device_get(sdev))
                                continue;
 
+                       do_resume = dev->flags & ATA_DFLAG_RESUMING;
+
                        spin_unlock_irqrestore(ap->lock, flags);
+                       if (do_resume) {
+                               ret = scsi_resume_device(sdev);
+                               if (ret == -EWOULDBLOCK)
+                                       goto unlock;
+                               dev->flags &= ~ATA_DFLAG_RESUMING;
+                       }
                        ret = scsi_rescan_device(sdev);
                        scsi_device_put(sdev);
                        spin_lock_irqsave(ap->lock, flags);
index 1cd304de53881562cdbf7b116a0e54c9c66082a0..b2191ade9011c683145b115158a1fe1a3694d1a4 100644 (file)
@@ -806,6 +806,8 @@ static int save_iaa_wq(struct idxd_wq *wq)
                return -EINVAL;
 
        cpus_per_iaa = (nr_nodes * nr_cpus_per_node) / nr_iaa;
+       if (!cpus_per_iaa)
+               cpus_per_iaa = 1;
 out:
        return 0;
 }
@@ -821,10 +823,12 @@ static void remove_iaa_wq(struct idxd_wq *wq)
                }
        }
 
-       if (nr_iaa)
+       if (nr_iaa) {
                cpus_per_iaa = (nr_nodes * nr_cpus_per_node) / nr_iaa;
-       else
-               cpus_per_iaa = 0;
+               if (!cpus_per_iaa)
+                       cpus_per_iaa = 1;
+       } else
+               cpus_per_iaa = 1;
 }
 
 static int wq_table_add_wqs(int iaa, int cpu)
index 67998dbd1d46b49dc623a0929c262174965bb601..5f3c9c5529b96040da1816a315e94eb00eaf9443 100644 (file)
@@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
          If unsure, or if this kernel is meant for production environments,
          say N.
 
-config CXL_PMU
-       tristate "CXL Performance Monitoring Unit"
-       default CXL_BUS
-       depends on PERF_EVENTS
-       help
-         Support performance monitoring as defined in CXL rev 3.0
-         section 13.2: Performance Monitoring. CXL components may have
-         one or more CXL Performance Monitoring Units (CPMUs).
-
-         Say 'y/m' to enable a driver that will attach to performance
-         monitoring units and provide standard perf based interfaces.
-
-         If unsure say 'm'.
 endif
index 9c2a0c082a768f89ddba627e6a5d61edac512f1b..ed4b323886e430847dcb02dd916793adda0c18ea 100644 (file)
@@ -84,11 +84,11 @@ static int sanitycheck(void *arg)
                return -ENOMEM;
 
        chain = mock_chain(NULL, f, 1);
-       if (!chain)
+       if (chain)
+               dma_fence_enable_sw_signaling(chain);
+       else
                err = -ENOMEM;
 
-       dma_fence_enable_sw_signaling(chain);
-
        dma_fence_signal(f);
        dma_fence_put(f);
 
index a4cae73f20d3d0b52f6b874fd3aa5ef069c440b2..20607ed54243581a60c792b78a5d952fbe0eaa84 100644 (file)
@@ -4,4 +4,4 @@
 #
 
 config DPLL
-  bool
+       bool
index 7e185285955021cb66a1a3a5fb4d6c24fc651b33..c41e7b2091cdd1615f3507f7d186d5893ff683e0 100644 (file)
@@ -120,7 +120,7 @@ efi_status_t efi_random_alloc(unsigned long size,
                        continue;
                }
 
-               target = round_up(max(md->phys_addr, alloc_min), align) + target_slot * align;
+               target = round_up(max_t(u64, md->phys_addr, alloc_min), align) + target_slot * align;
                pages = size / EFI_PAGE_SIZE;
 
                status = efi_bs_call(allocate_pages, EFI_ALLOCATE_ADDRESS,
index 6a6ffc6707bd0eb31e9dd13a995095760883e47c..d5a8182cf2e1cc7f5a90f68e2967c8ef6d1550ff 100644 (file)
@@ -496,6 +496,7 @@ efi_status_t __efiapi efi_pe_entry(efi_handle_t handle,
        hdr->vid_mode   = 0xffff;
 
        hdr->type_of_loader = 0x21;
+       hdr->initrd_addr_max = INT_MAX;
 
        /* Convert unicode cmdline to ascii */
        cmdline_ptr = efi_convert_cmdline(image, &options_size);
index a789af4a5c85f24ec84db02414815e5e5b18e134..8dce78ea71395d56a92c179a35b50bd8c054617f 100644 (file)
@@ -50,7 +50,6 @@ struct brcmstb_gpio_priv {
        struct irq_domain *irq_domain;
        struct irq_chip irq_chip;
        int parent_irq;
-       int gpio_base;
        int num_gpios;
        int parent_wake_irq;
 };
@@ -92,7 +91,7 @@ brcmstb_gpio_get_active_irqs(struct brcmstb_gpio_bank *bank)
 static int brcmstb_gpio_hwirq_to_offset(irq_hw_number_t hwirq,
                                        struct brcmstb_gpio_bank *bank)
 {
-       return hwirq - (bank->gc.base - bank->parent_priv->gpio_base);
+       return hwirq - bank->gc.offset;
 }
 
 static void brcmstb_gpio_set_imask(struct brcmstb_gpio_bank *bank,
@@ -118,7 +117,7 @@ static int brcmstb_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
 {
        struct brcmstb_gpio_priv *priv = brcmstb_gpio_gc_to_priv(gc);
        /* gc_offset is relative to this gpio_chip; want real offset */
-       int hwirq = offset + (gc->base - priv->gpio_base);
+       int hwirq = offset + gc->offset;
 
        if (hwirq >= priv->num_gpios)
                return -ENXIO;
@@ -263,7 +262,7 @@ static void brcmstb_gpio_irq_bank_handler(struct brcmstb_gpio_bank *bank)
 {
        struct brcmstb_gpio_priv *priv = bank->parent_priv;
        struct irq_domain *domain = priv->irq_domain;
-       int hwbase = bank->gc.base - priv->gpio_base;
+       int hwbase = bank->gc.offset;
        unsigned long status;
 
        while ((status = brcmstb_gpio_get_active_irqs(bank))) {
@@ -412,7 +411,7 @@ static int brcmstb_gpio_of_xlate(struct gpio_chip *gc,
        if (WARN_ON(gpiospec->args_count < gc->of_gpio_n_cells))
                return -EINVAL;
 
-       offset = gpiospec->args[0] - (gc->base - priv->gpio_base);
+       offset = gpiospec->args[0] - bank->gc.offset;
        if (offset >= gc->ngpio || offset < 0)
                return -EINVAL;
 
@@ -596,8 +595,8 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
        const __be32 *p;
        u32 bank_width;
        int num_banks = 0;
+       int num_gpios = 0;
        int err;
-       static int gpio_base;
        unsigned long flags = 0;
        bool need_wakeup_event = false;
 
@@ -611,7 +610,6 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
        if (IS_ERR(reg_base))
                return PTR_ERR(reg_base);
 
-       priv->gpio_base = gpio_base;
        priv->reg_base = reg_base;
        priv->pdev = pdev;
 
@@ -651,7 +649,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
                        dev_dbg(dev, "Width 0 found: Empty bank @ %d\n",
                                num_banks);
                        num_banks++;
-                       gpio_base += MAX_GPIO_PER_BANK;
+                       num_gpios += MAX_GPIO_PER_BANK;
                        continue;
                }
 
@@ -691,12 +689,13 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
                        err = -ENOMEM;
                        goto fail;
                }
-               gc->base = gpio_base;
                gc->of_gpio_n_cells = 2;
                gc->of_xlate = brcmstb_gpio_of_xlate;
                /* not all ngpio lines are valid, will use bank width later */
                gc->ngpio = MAX_GPIO_PER_BANK;
                gc->offset = bank->id * MAX_GPIO_PER_BANK;
+               gc->request = gpiochip_generic_request;
+               gc->free = gpiochip_generic_free;
                if (priv->parent_irq > 0)
                        gc->to_irq = brcmstb_gpio_to_irq;
 
@@ -713,7 +712,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
                                        bank->id);
                        goto fail;
                }
-               gpio_base += gc->ngpio;
+               num_gpios += gc->ngpio;
 
                dev_dbg(dev, "bank=%d, base=%d, ngpio=%d, width=%d\n", bank->id,
                        gc->base, gc->ngpio, bank->width);
@@ -724,7 +723,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
                num_banks++;
        }
 
-       priv->num_gpios = gpio_base - priv->gpio_base;
+       priv->num_gpios = num_gpios;
        if (priv->parent_irq > 0) {
                err = brcmstb_gpio_irq_setup(pdev, priv);
                if (err)
index 842e1c060414423c031da13fc628d02028580950..0c09bb54dc0c9e68acd03529621090006b83288c 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/errno.h>
 #include <linux/gpio/driver.h>
 #include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
@@ -197,11 +198,18 @@ static int cros_ec_gpio_probe(struct platform_device *pdev)
        return devm_gpiochip_add_data(dev, gc, cros_ec);
 }
 
+static const struct platform_device_id cros_ec_gpio_id[] = {
+       { "cros-ec-gpio", 0 },
+       {}
+};
+MODULE_DEVICE_TABLE(platform, cros_ec_gpio_id);
+
 static struct platform_driver cros_ec_gpio_driver = {
        .probe = cros_ec_gpio_probe,
        .driver = {
                .name = "cros-ec-gpio",
        },
+       .id_table = cros_ec_gpio_id,
 };
 module_platform_driver(cros_ec_gpio_driver);
 
index 2efd1b1a0805f2c9fa05db1e6905a1ab6b466b4a..7f7f95ad4343d91de13b5c32936bc132f93d6a68 100644 (file)
@@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
        case IDIO_24_CONTROL_REG:
                /* We can only set direction for TTL/CMOS lines */
                if (offset < 48)
-                       return -EOPNOTSUPP;
+                       return -ENOTSUPP;
 
                *reg = IDIO_24_CONTROL_REG;
                *mask = CONTROL_REG_OUT_MODE;
index c08c8e528867eef7b3f6670fbdb4f95963bed5d2..71684dee2ca5d27bc427c0be6f257417ae6e6ca1 100644 (file)
@@ -129,7 +129,7 @@ static int gpio_regmap_get_direction(struct gpio_chip *chip,
                base = gpio_regmap_addr(gpio->reg_dir_in_base);
                invert = 1;
        } else {
-               return -EOPNOTSUPP;
+               return -ENOTSUPP;
        }
 
        ret = gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);
@@ -160,7 +160,7 @@ static int gpio_regmap_set_direction(struct gpio_chip *chip,
                base = gpio_regmap_addr(gpio->reg_dir_in_base);
                invert = 1;
        } else {
-               return -EOPNOTSUPP;
+               return -ENOTSUPP;
        }
 
        ret = gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);
index f384fa2787648e750802f909e810cc340c5efbf6..fa96356102510967cb30538375c9348d122c3910 100644 (file)
@@ -1083,10 +1083,20 @@ static u32 gpio_v2_line_config_debounce_period(struct gpio_v2_line_config *lc,
        return 0;
 }
 
+static inline char *make_irq_label(const char *orig)
+{
+       return kstrdup_and_replace(orig, '/', ':', GFP_KERNEL);
+}
+
+static inline void free_irq_label(const char *label)
+{
+       kfree(label);
+}
+
 static void edge_detector_stop(struct line *line)
 {
        if (line->irq) {
-               free_irq(line->irq, line);
+               free_irq_label(free_irq(line->irq, line));
                line->irq = 0;
        }
 
@@ -1110,6 +1120,7 @@ static int edge_detector_setup(struct line *line,
        unsigned long irqflags = 0;
        u64 eflags;
        int irq, ret;
+       char *label;
 
        eflags = edflags & GPIO_V2_LINE_EDGE_FLAGS;
        if (eflags && !kfifo_initialized(&line->req->events)) {
@@ -1146,11 +1157,17 @@ static int edge_detector_setup(struct line *line,
                        IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
        irqflags |= IRQF_ONESHOT;
 
+       label = make_irq_label(line->req->label);
+       if (!label)
+               return -ENOMEM;
+
        /* Request a thread to read the events */
        ret = request_threaded_irq(irq, edge_irq_handler, edge_irq_thread,
-                                  irqflags, line->req->label, line);
-       if (ret)
+                                  irqflags, label, line);
+       if (ret) {
+               free_irq_label(label);
                return ret;
+       }
 
        line->irq = irq;
        return 0;
@@ -1973,7 +1990,7 @@ static void lineevent_free(struct lineevent_state *le)
                blocking_notifier_chain_unregister(&le->gdev->device_notifier,
                                                   &le->device_unregistered_nb);
        if (le->irq)
-               free_irq(le->irq, le);
+               free_irq_label(free_irq(le->irq, le));
        if (le->desc)
                gpiod_free(le->desc);
        kfree(le->label);
@@ -2114,6 +2131,7 @@ static int lineevent_create(struct gpio_device *gdev, void __user *ip)
        int fd;
        int ret;
        int irq, irqflags = 0;
+       char *label;
 
        if (copy_from_user(&eventreq, ip, sizeof(eventreq)))
                return -EFAULT;
@@ -2198,15 +2216,23 @@ static int lineevent_create(struct gpio_device *gdev, void __user *ip)
        if (ret)
                goto out_free_le;
 
+       label = make_irq_label(le->label);
+       if (!label) {
+               ret = -ENOMEM;
+               goto out_free_le;
+       }
+
        /* Request a thread to read the events */
        ret = request_threaded_irq(irq,
                                   lineevent_irq_handler,
                                   lineevent_irq_thread,
                                   irqflags,
-                                  le->label,
+                                  label,
                                   le);
-       if (ret)
+       if (ret) {
+               free_irq_label(label);
                goto out_free_le;
+       }
 
        le->irq = irq;
 
index b138682fec3d686a6e334b36a82eccfd8b41ebe8..5a9911ae912509c978e800731871ab671a713fbd 100644 (file)
@@ -28,10 +28,9 @@ int gpio_request_one(unsigned gpio, unsigned long flags, const char *label)
        struct gpio_desc *desc;
        int err;
 
-       desc = gpio_to_desc(gpio);
-
        /* Compatibility: assume unavailable "valid" GPIOs will appear later */
-       if (!desc && gpio_is_valid(gpio))
+       desc = gpio_to_desc(gpio);
+       if (!desc)
                return -EPROBE_DEFER;
 
        err = gpiod_request(desc, label);
@@ -63,51 +62,13 @@ EXPORT_SYMBOL_GPL(gpio_request_one);
  */
 int gpio_request(unsigned gpio, const char *label)
 {
-       struct gpio_desc *desc = gpio_to_desc(gpio);
+       struct gpio_desc *desc;
 
        /* Compatibility: assume unavailable "valid" GPIOs will appear later */
-       if (!desc && gpio_is_valid(gpio))
+       desc = gpio_to_desc(gpio);
+       if (!desc)
                return -EPROBE_DEFER;
 
        return gpiod_request(desc, label);
 }
 EXPORT_SYMBOL_GPL(gpio_request);
-
-/**
- * gpio_request_array - request multiple GPIOs in a single call
- * @array:     array of the 'struct gpio'
- * @num:       how many GPIOs in the array
- *
- * **DEPRECATED** This function is deprecated and must not be used in new code.
- */
-int gpio_request_array(const struct gpio *array, size_t num)
-{
-       int i, err;
-
-       for (i = 0; i < num; i++, array++) {
-               err = gpio_request_one(array->gpio, array->flags, array->label);
-               if (err)
-                       goto err_free;
-       }
-       return 0;
-
-err_free:
-       while (i--)
-               gpio_free((--array)->gpio);
-       return err;
-}
-EXPORT_SYMBOL_GPL(gpio_request_array);
-
-/**
- * gpio_free_array - release multiple GPIOs in a single call
- * @array:     array of the 'struct gpio'
- * @num:       how many GPIOs in the array
- *
- * **DEPRECATED** This function is deprecated and must not be used in new code.
- */
-void gpio_free_array(const struct gpio *array, size_t num)
-{
-       while (num--)
-               gpio_free((array++)->gpio);
-}
-EXPORT_SYMBOL_GPL(gpio_free_array);
index cb0cefaec37e8d1e2d7f74fcec15f8fdcac31ebb..d75f6ee370282eb3017993ec561ca35c85ff90a9 100644 (file)
@@ -1037,7 +1037,7 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip)
        struct of_phandle_args pinspec;
        struct pinctrl_dev *pctldev;
        struct device_node *np;
-       int index = 0, ret;
+       int index = 0, ret, trim;
        const char *name;
        static const char group_names_propname[] = "gpio-ranges-group-names";
        struct property *group_names;
@@ -1059,7 +1059,14 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip)
                if (!pctldev)
                        return -EPROBE_DEFER;
 
+               /* Ignore ranges outside of this GPIO chip */
+               if (pinspec.args[0] >= (chip->offset + chip->ngpio))
+                       continue;
+               if (pinspec.args[0] + pinspec.args[2] <= chip->offset)
+                       continue;
+
                if (pinspec.args[2]) {
+                       /* npins != 0: linear range */
                        if (group_names) {
                                of_property_read_string_index(np,
                                                group_names_propname,
@@ -1070,7 +1077,19 @@ static int of_gpiochip_add_pin_range(struct gpio_chip *chip)
                                        break;
                                }
                        }
-                       /* npins != 0: linear range */
+
+                       /* Trim the range to fit this GPIO chip */
+                       if (chip->offset > pinspec.args[0]) {
+                               trim = chip->offset - pinspec.args[0];
+                               pinspec.args[2] -= trim;
+                               pinspec.args[1] += trim;
+                               pinspec.args[0] = 0;
+                       } else {
+                               pinspec.args[0] -= chip->offset;
+                       }
+                       if ((pinspec.args[0] + pinspec.args[2]) > chip->ngpio)
+                               pinspec.args[2] = chip->ngpio - pinspec.args[0];
+
                        ret = gpiochip_add_pin_range(chip,
                                        pinctrl_dev_get_devname(pctldev),
                                        pinspec.args[0],
index 6853ecd98bcb8c5e4a8e3ebaa9448684b0057ad2..26202586fd39dea51c8b1f34643132094cc2fec2 100644 (file)
@@ -412,7 +412,7 @@ static ssize_t base_show(struct device *dev,
 {
        const struct gpio_device *gdev = dev_get_drvdata(dev);
 
-       return sysfs_emit(buf, "%d\n", gdev->base);
+       return sysfs_emit(buf, "%u\n", gdev->base);
 }
 static DEVICE_ATTR_RO(base);
 
index ce94e37bcbee798bd46140257bc7346804e007f9..f749ece2d3cd1d5286fdf86bb05fc186bfee81e6 100644 (file)
@@ -150,9 +150,6 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)
                }
        }
 
-       if (!gpio_is_valid(gpio))
-               pr_warn("invalid GPIO %d\n", gpio);
-
        return NULL;
 }
 EXPORT_SYMBOL_GPL(gpio_to_desc);
@@ -297,10 +294,10 @@ struct gpio_chip *gpio_device_get_chip(struct gpio_device *gdev)
 EXPORT_SYMBOL_GPL(gpio_device_get_chip);
 
 /* dynamic allocation of GPIOs, e.g. on a hotplugged device */
-static int gpiochip_find_base_unlocked(int ngpio)
+static int gpiochip_find_base_unlocked(u16 ngpio)
 {
+       unsigned int base = GPIO_DYNAMIC_BASE;
        struct gpio_device *gdev;
-       int base = GPIO_DYNAMIC_BASE;
 
        list_for_each_entry_srcu(gdev, &gpio_devices, list,
                                 lockdep_is_held(&gpio_devices_lock)) {
@@ -311,9 +308,11 @@ static int gpiochip_find_base_unlocked(int ngpio)
                base = gdev->base + gdev->ngpio;
                if (base < GPIO_DYNAMIC_BASE)
                        base = GPIO_DYNAMIC_BASE;
+               if (base > GPIO_DYNAMIC_MAX - ngpio)
+                       break;
        }
 
-       if (gpio_is_valid(base)) {
+       if (base <= GPIO_DYNAMIC_MAX - ngpio) {
                pr_debug("%s: found new base at %d\n", __func__, base);
                return base;
        } else {
@@ -365,7 +364,10 @@ int gpiod_get_direction(struct gpio_desc *desc)
        if (ret < 0)
                return ret;
 
-       /* GPIOF_DIR_IN or other positive, otherwise GPIOF_DIR_OUT */
+       /*
+        * GPIO_LINE_DIRECTION_IN or other positive,
+        * otherwise GPIO_LINE_DIRECTION_OUT.
+        */
        if (ret > 0)
                ret = 1;
 
@@ -746,7 +748,7 @@ static int gpiochip_setup_dev(struct gpio_device *gdev)
        if (ret)
                goto err_remove_device;
 
-       dev_dbg(&gdev->dev, "registered GPIOs %d to %d on %s\n", gdev->base,
+       dev_dbg(&gdev->dev, "registered GPIOs %u to %u on %s\n", gdev->base,
                gdev->base + gdev->ngpio - 1, gdev->label);
 
        return 0;
@@ -2397,6 +2399,11 @@ char *gpiochip_dup_line_label(struct gpio_chip *gc, unsigned int offset)
 }
 EXPORT_SYMBOL_GPL(gpiochip_dup_line_label);
 
+static inline const char *function_name_or_default(const char *con_id)
+{
+       return con_id ?: "(default)";
+}
+
 /**
  * gpiochip_request_own_desc - Allow GPIO chip to request its own descriptor
  * @gc: GPIO chip
@@ -2425,10 +2432,11 @@ struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
                                            enum gpiod_flags dflags)
 {
        struct gpio_desc *desc = gpiochip_get_desc(gc, hwnum);
+       const char *name = function_name_or_default(label);
        int ret;
 
        if (IS_ERR(desc)) {
-               chip_err(gc, "failed to get GPIO descriptor\n");
+               chip_err(gc, "failed to get GPIO %s descriptor\n", name);
                return desc;
        }
 
@@ -2438,8 +2446,8 @@ struct gpio_desc *gpiochip_request_own_desc(struct gpio_chip *gc,
 
        ret = gpiod_configure_flags(desc, label, lflags, dflags);
        if (ret) {
-               chip_err(gc, "setup of own GPIO %s failed\n", label);
                gpiod_free_commit(desc);
+               chip_err(gc, "setup of own GPIO %s failed\n", name);
                return ERR_PTR(ret);
        }
 
@@ -4153,19 +4161,17 @@ static struct gpio_desc *gpiod_find_by_fwnode(struct fwnode_handle *fwnode,
                                              enum gpiod_flags *flags,
                                              unsigned long *lookupflags)
 {
+       const char *name = function_name_or_default(con_id);
        struct gpio_desc *desc = ERR_PTR(-ENOENT);
 
        if (is_of_node(fwnode)) {
-               dev_dbg(consumer, "using DT '%pfw' for '%s' GPIO lookup\n",
-                       fwnode, con_id);
+               dev_dbg(consumer, "using DT '%pfw' for '%s' GPIO lookup\n", fwnode, name);
                desc = of_find_gpio(to_of_node(fwnode), con_id, idx, lookupflags);
        } else if (is_acpi_node(fwnode)) {
-               dev_dbg(consumer, "using ACPI '%pfw' for '%s' GPIO lookup\n",
-                       fwnode, con_id);
+               dev_dbg(consumer, "using ACPI '%pfw' for '%s' GPIO lookup\n", fwnode, name);
                desc = acpi_find_gpio(fwnode, con_id, idx, flags, lookupflags);
        } else if (is_software_node(fwnode)) {
-               dev_dbg(consumer, "using swnode '%pfw' for '%s' GPIO lookup\n",
-                       fwnode, con_id);
+               dev_dbg(consumer, "using swnode '%pfw' for '%s' GPIO lookup\n", fwnode, name);
                desc = swnode_find_gpio(fwnode, con_id, idx, lookupflags);
        }
 
@@ -4181,6 +4187,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
                                         bool platform_lookup_allowed)
 {
        unsigned long lookupflags = GPIO_LOOKUP_FLAGS_DEFAULT;
+       const char *name = function_name_or_default(con_id);
        /*
         * scoped_guard() is implemented as a for loop, meaning static
         * analyzers will complain about these two not being initialized.
@@ -4203,8 +4210,7 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
                }
 
                if (IS_ERR(desc)) {
-                       dev_dbg(consumer, "No GPIO consumer %s found\n",
-                               con_id);
+                       dev_dbg(consumer, "No GPIO consumer %s found\n", name);
                        return desc;
                }
 
@@ -4226,15 +4232,14 @@ struct gpio_desc *gpiod_find_and_request(struct device *consumer,
                 *
                 * FIXME: Make this more sane and safe.
                 */
-               dev_info(consumer,
-                        "nonexclusive access to GPIO for %s\n", con_id);
+               dev_info(consumer, "nonexclusive access to GPIO for %s\n", name);
                return desc;
        }
 
        ret = gpiod_configure_flags(desc, con_id, lookupflags, flags);
        if (ret < 0) {
-               dev_dbg(consumer, "setup of GPIO %s failed\n", con_id);
                gpiod_put(desc);
+               dev_err(consumer, "setup of GPIO %s failed: %d\n", name, ret);
                return ERR_PTR(ret);
        }
 
@@ -4350,6 +4355,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_optional);
 int gpiod_configure_flags(struct gpio_desc *desc, const char *con_id,
                unsigned long lflags, enum gpiod_flags dflags)
 {
+       const char *name = function_name_or_default(con_id);
        int ret;
 
        if (lflags & GPIO_ACTIVE_LOW)
@@ -4393,7 +4399,7 @@ int gpiod_configure_flags(struct gpio_desc *desc, const char *con_id,
 
        /* No particular flag request, return here... */
        if (!(dflags & GPIOD_FLAGS_BIT_DIR_SET)) {
-               gpiod_dbg(desc, "no flags found for %s\n", con_id);
+               gpiod_dbg(desc, "no flags found for GPIO %s\n", name);
                return 0;
        }
 
@@ -4781,14 +4787,14 @@ static void gpiolib_dbg_show(struct seq_file *s, struct gpio_device *gdev)
                        value = gpio_chip_get_value(gc, desc);
                        is_irq = test_bit(FLAG_USED_AS_IRQ, &desc->flags);
                        active_low = test_bit(FLAG_ACTIVE_LOW, &desc->flags);
-                       seq_printf(s, " gpio-%-3d (%-20.20s|%-20.20s) %s %s %s%s\n",
+                       seq_printf(s, " gpio-%-3u (%-20.20s|%-20.20s) %s %s %s%s\n",
                                   gpio, desc->name ?: "", gpiod_get_label(desc),
                                   is_out ? "out" : "in ",
                                   value >= 0 ? (value ? "hi" : "lo") : "?  ",
                                   is_irq ? "IRQ " : "",
                                   active_low ? "ACTIVE LOW" : "");
                } else if (desc->name) {
-                       seq_printf(s, " gpio-%-3d (%-20.20s)\n", gpio, desc->name);
+                       seq_printf(s, " gpio-%-3u (%-20.20s)\n", gpio, desc->name);
                }
 
                gpio++;
@@ -4860,7 +4866,7 @@ static int gpiolib_seq_show(struct seq_file *s, void *v)
                return 0;
        }
 
-       seq_printf(s, "%s%s: GPIOs %d-%d", priv->newline ? "\n" : "",
+       seq_printf(s, "%s%s: GPIOs %u-%u", priv->newline ? "\n" : "",
                   dev_name(&gdev->dev),
                   gdev->base, gdev->base + gdev->ngpio - 1);
        parent = gc->parent;
index f67d5991ab1c7a58d375b2f6bd3275b41adb8ade..7f94580efdbca29a05f03a53e8305838d63b2f63 100644 (file)
@@ -61,7 +61,7 @@ struct gpio_device {
        struct module           *owner;
        struct gpio_chip __rcu  *chip;
        struct gpio_desc        *descs;
-       int                     base;
+       unsigned int            base;
        u16                     ngpio;
        bool                    can_sleep;
        const char              *label;
index 5dc24c971b41f0a93c7463fbbf397d33e08c5563..aa16d51dd8421b38a0a34fcf89263ffbf08af4fd 100644 (file)
@@ -4539,6 +4539,8 @@ int amdgpu_device_prepare(struct drm_device *dev)
        if (r)
                goto unprepare;
 
+       flush_delayed_work(&adev->gfx.gfx_off_delay_work);
+
        for (i = 0; i < adev->num_ip_blocks; i++) {
                if (!adev->ip_blocks[i].status.valid)
                        continue;
index a07e4b87d4cae01af53ef4cfded4cc4051dbd1c7..fdd36fb027ab6aa04b31c790af80596bb7da0427 100644 (file)
@@ -2237,6 +2237,7 @@ static int amdgpu_discovery_set_umsch_mm_ip_blocks(struct amdgpu_device *adev)
 {
        switch (amdgpu_ip_version(adev, VCN_HWIP, 0)) {
        case IP_VERSION(4, 0, 5):
+       case IP_VERSION(4, 0, 6):
                if (amdgpu_umsch_mm & 0x1) {
                        amdgpu_device_ip_block_add(adev, &umsch_mm_v4_0_ip_block);
                        adev->enable_umsch_mm = true;
index 5505d646f43aa8f963d8d8732846b00fc612a3a7..06f0a6534a94f78196e6f6db7f5f87899e14d071 100644 (file)
@@ -524,46 +524,58 @@ static ssize_t amdgpu_debugfs_mqd_read(struct file *f, char __user *buf,
 {
        struct amdgpu_ring *ring = file_inode(f)->i_private;
        volatile u32 *mqd;
-       int r;
+       u32 *kbuf;
+       int r, i;
        uint32_t value, result;
 
        if (*pos & 3 || size & 3)
                return -EINVAL;
 
-       result = 0;
+       kbuf = kmalloc(ring->mqd_size, GFP_KERNEL);
+       if (!kbuf)
+               return -ENOMEM;
 
        r = amdgpu_bo_reserve(ring->mqd_obj, false);
        if (unlikely(r != 0))
-               return r;
+               goto err_free;
 
        r = amdgpu_bo_kmap(ring->mqd_obj, (void **)&mqd);
-       if (r) {
-               amdgpu_bo_unreserve(ring->mqd_obj);
-               return r;
-       }
+       if (r)
+               goto err_unreserve;
 
+       /*
+        * Copy to local buffer to avoid put_user(), which might fault
+        * and acquire mmap_sem, under reservation_ww_class_mutex.
+        */
+       for (i = 0; i < ring->mqd_size/sizeof(u32); i++)
+               kbuf[i] = mqd[i];
+
+       amdgpu_bo_kunmap(ring->mqd_obj);
+       amdgpu_bo_unreserve(ring->mqd_obj);
+
+       result = 0;
        while (size) {
                if (*pos >= ring->mqd_size)
-                       goto done;
+                       break;
 
-               value = mqd[*pos/4];
+               value = kbuf[*pos/4];
                r = put_user(value, (uint32_t *)buf);
                if (r)
-                       goto done;
+                       goto err_free;
                buf += 4;
                result += 4;
                size -= 4;
                *pos += 4;
        }
 
-done:
-       amdgpu_bo_kunmap(ring->mqd_obj);
-       mqd = NULL;
-       amdgpu_bo_unreserve(ring->mqd_obj);
-       if (r)
-               return r;
-
+       kfree(kbuf);
        return result;
+
+err_unreserve:
+       amdgpu_bo_unreserve(ring->mqd_obj);
+err_free:
+       kfree(kbuf);
+       return r;
 }
 
 static const struct file_operations amdgpu_debugfs_mqd_fops = {
index ab820cf526683b5a15ef94ee28075f20752baeac..0df97c3e3a700dccc7bc84d4688e1dc8e1b8a1e2 100644 (file)
@@ -189,10 +189,13 @@ static void setup_vpe_queue(struct amdgpu_device *adev,
        mqd->rptr_val = 0;
        mqd->unmapped = 1;
 
+       if (adev->vpe.collaborate_mode)
+               memcpy(++mqd, test->mqd_data_cpu_addr, sizeof(struct MQD_INFO));
+
        qinfo->mqd_addr = test->mqd_data_gpu_addr;
        qinfo->csa_addr = test->ctx_data_gpu_addr +
                offsetof(struct umsch_mm_test_ctx_data, vpe_ctx_csa);
-       qinfo->doorbell_offset_0 = (adev->doorbell_index.vpe_ring + 1) << 1;
+       qinfo->doorbell_offset_0 = 0;
        qinfo->doorbell_offset_1 = 0;
 }
 
@@ -287,7 +290,10 @@ static int submit_vpe_queue(struct amdgpu_device *adev, struct umsch_mm_test *te
        ring[5] = 0;
 
        mqd->wptr_val = (6 << 2);
-       // WDOORBELL32(adev->umsch_mm.agdb_index[CONTEXT_PRIORITY_LEVEL_NORMAL], mqd->wptr_val);
+       if (adev->vpe.collaborate_mode)
+               (++mqd)->wptr_val = (6 << 2);
+
+       WDOORBELL32(adev->umsch_mm.agdb_index[CONTEXT_PRIORITY_LEVEL_NORMAL], mqd->wptr_val);
 
        for (i = 0; i < adev->usec_timeout; i++) {
                if (*fence == test_pattern)
@@ -571,6 +577,7 @@ int amdgpu_umsch_mm_init_microcode(struct amdgpu_umsch_mm *umsch)
 
        switch (amdgpu_ip_version(adev, VCN_HWIP, 0)) {
        case IP_VERSION(4, 0, 5):
+       case IP_VERSION(4, 0, 6):
                fw_name = "amdgpu/umsch_mm_4_0_0.bin";
                break;
        default:
@@ -750,6 +757,7 @@ static int umsch_mm_early_init(void *handle)
 
        switch (amdgpu_ip_version(adev, VCN_HWIP, 0)) {
        case IP_VERSION(4, 0, 5):
+       case IP_VERSION(4, 0, 6):
                umsch_mm_v4_0_set_funcs(&adev->umsch_mm);
                break;
        default:
index 8258a43a6236c038e16098089e1de90495f51600..5014b5af95fd970c7ef15ffed4630a2928eb2c08 100644 (file)
@@ -33,13 +33,6 @@ enum UMSCH_SWIP_ENGINE_TYPE {
        UMSCH_SWIP_ENGINE_TYPE_MAX
 };
 
-enum UMSCH_SWIP_AFFINITY_TYPE {
-       UMSCH_SWIP_AFFINITY_TYPE_ANY = 0,
-       UMSCH_SWIP_AFFINITY_TYPE_VCN0 = 1,
-       UMSCH_SWIP_AFFINITY_TYPE_VCN1 = 2,
-       UMSCH_SWIP_AFFINITY_TYPE_MAX
-};
-
 enum UMSCH_CONTEXT_PRIORITY_LEVEL {
        CONTEXT_PRIORITY_LEVEL_IDLE = 0,
        CONTEXT_PRIORITY_LEVEL_NORMAL = 1,
@@ -51,13 +44,15 @@ enum UMSCH_CONTEXT_PRIORITY_LEVEL {
 struct umsch_mm_set_resource_input {
        uint32_t vmid_mask_mm_vcn;
        uint32_t vmid_mask_mm_vpe;
+       uint32_t collaboration_mask_vpe;
        uint32_t logging_vmid;
        uint32_t engine_mask;
        union {
                struct {
                        uint32_t disable_reset : 1;
                        uint32_t disable_umsch_mm_log : 1;
-                       uint32_t reserved : 30;
+                       uint32_t use_rs64mem_for_proc_ctx_csa : 1;
+                       uint32_t reserved : 29;
                };
                uint32_t uint32_all;
        };
@@ -78,15 +73,18 @@ struct umsch_mm_add_queue_input {
        uint32_t doorbell_offset_1;
        enum UMSCH_SWIP_ENGINE_TYPE engine_type;
        uint32_t affinity;
-       enum UMSCH_SWIP_AFFINITY_TYPE affinity_type;
        uint64_t mqd_addr;
        uint64_t h_context;
        uint64_t h_queue;
        uint32_t vm_context_cntl;
 
+       uint32_t process_csa_array_index;
+       uint32_t context_csa_array_index;
+
        struct {
                uint32_t is_context_suspended : 1;
-               uint32_t reserved : 31;
+               uint32_t collaboration_mode : 1;
+               uint32_t reserved : 30;
        };
 };
 
@@ -94,6 +92,7 @@ struct umsch_mm_remove_queue_input {
        uint32_t doorbell_offset_0;
        uint32_t doorbell_offset_1;
        uint64_t context_csa_addr;
+       uint32_t context_csa_array_index;
 };
 
 struct MQD_INFO {
@@ -103,6 +102,7 @@ struct MQD_INFO {
        uint32_t wptr_val;
        uint32_t rptr_val;
        uint32_t unmapped;
+       uint32_t vmid;
 };
 
 struct amdgpu_umsch_mm;
index 7a65a2b128ec4372c5e6c219c70b9ab110b869fc..6695481f870f8a0dc61edfbe0d9947b19288bc25 100644 (file)
@@ -396,6 +396,12 @@ static int vpe_hw_init(void *handle)
        struct amdgpu_vpe *vpe = &adev->vpe;
        int ret;
 
+       /* Power on VPE */
+       ret = amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE,
+                                                    AMD_PG_STATE_UNGATE);
+       if (ret)
+               return ret;
+
        ret = vpe_load_microcode(vpe);
        if (ret)
                return ret;
index 8e7b763cfdb7ef72ba8c98ea4e33515ffa4e8d81..84368cf1e17535c16c031ce6677f53769f9e8f94 100644 (file)
@@ -60,7 +60,7 @@ static int umsch_mm_v4_0_load_microcode(struct amdgpu_umsch_mm *umsch)
 
        umsch->cmd_buf_curr_ptr = umsch->cmd_buf_ptr;
 
-       if (amdgpu_ip_version(adev, VCN_HWIP, 0) == IP_VERSION(4, 0, 5)) {
+       if (amdgpu_ip_version(adev, VCN_HWIP, 0) >= IP_VERSION(4, 0, 5)) {
                WREG32_SOC15(VCN, 0, regUVD_IPX_DLDO_CONFIG,
                        1 << UVD_IPX_DLDO_CONFIG__ONO0_PWR_CONFIG__SHIFT);
                SOC15_WAIT_ON_RREG(VCN, 0, regUVD_IPX_DLDO_STATUS,
@@ -248,7 +248,7 @@ static int umsch_mm_v4_0_ring_stop(struct amdgpu_umsch_mm *umsch)
        data = REG_SET_FIELD(data, VCN_UMSCH_RB_DB_CTRL, EN, 0);
        WREG32_SOC15(VCN, 0, regVCN_UMSCH_RB_DB_CTRL, data);
 
-       if (amdgpu_ip_version(adev, VCN_HWIP, 0) == IP_VERSION(4, 0, 5)) {
+       if (amdgpu_ip_version(adev, VCN_HWIP, 0) >= IP_VERSION(4, 0, 5)) {
                WREG32_SOC15(VCN, 0, regUVD_IPX_DLDO_CONFIG,
                        2 << UVD_IPX_DLDO_CONFIG__ONO0_PWR_CONFIG__SHIFT);
                SOC15_WAIT_ON_RREG(VCN, 0, regUVD_IPX_DLDO_STATUS,
@@ -271,6 +271,8 @@ static int umsch_mm_v4_0_set_hw_resources(struct amdgpu_umsch_mm *umsch)
 
        set_hw_resources.vmid_mask_mm_vcn = umsch->vmid_mask_mm_vcn;
        set_hw_resources.vmid_mask_mm_vpe = umsch->vmid_mask_mm_vpe;
+       set_hw_resources.collaboration_mask_vpe =
+               adev->vpe.collaborate_mode ? 0x3 : 0x0;
        set_hw_resources.engine_mask = umsch->engine_mask;
 
        set_hw_resources.vcn0_hqd_mask[0] = umsch->vcn0_hqd_mask;
@@ -346,6 +348,7 @@ static int umsch_mm_v4_0_add_queue(struct amdgpu_umsch_mm *umsch,
        add_queue.h_queue = input_ptr->h_queue;
        add_queue.vm_context_cntl = input_ptr->vm_context_cntl;
        add_queue.is_context_suspended = input_ptr->is_context_suspended;
+       add_queue.collaboration_mode = adev->vpe.collaborate_mode ? 1 : 0;
 
        add_queue.api_status.api_completion_fence_addr = umsch->ring.fence_drv.gpu_addr;
        add_queue.api_status.api_completion_fence_value = ++umsch->ring.fence_drv.sync_seq;
index dfa8c69532d4704ad1199b9722802ddfaff89841..f9631f4b1a02ca5121d7b382fe128c47c7718ec5 100644 (file)
@@ -1523,7 +1523,7 @@ static int kfd_ioctl_get_dmabuf_info(struct file *filep,
 
        /* Find a KFD GPU device that supports the get_dmabuf_info query */
        for (i = 0; kfd_topology_enum_kfd_devices(i, &dev) == 0; i++)
-               if (dev)
+               if (dev && !kfd_devcgroup_check_permission(dev))
                        break;
        if (!dev)
                return -EINVAL;
@@ -1545,7 +1545,7 @@ static int kfd_ioctl_get_dmabuf_info(struct file *filep,
        if (xcp_id >= 0)
                args->gpu_id = dmabuf_adev->kfd.dev->nodes[xcp_id]->id;
        else
-               args->gpu_id = dmabuf_adev->kfd.dev->nodes[0]->id;
+               args->gpu_id = dev->id;
        args->flags = flags;
 
        /* Copy metadata buffer to user mode */
index 9a06c6fb6605851ae9c26ff4a81c66d358b9a69f..40a21be6c07c9b314a111ff8138203e79591409e 100644 (file)
@@ -339,7 +339,8 @@ static void event_interrupt_wq_v10(struct kfd_node *dev,
                                break;
                        }
                        kfd_signal_event_interrupt(pasid, context_id0 & 0x7fffff, 23);
-               } else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE) {
+               } else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE &&
+                          KFD_DBG_EC_TYPE_IS_PACKET(KFD_DEBUG_CP_BAD_OP_ECODE(context_id0))) {
                        kfd_set_dbg_ev_from_interrupt(dev, pasid,
                                KFD_DEBUG_DOORBELL_ID(context_id0),
                                KFD_EC_MASK(KFD_DEBUG_CP_BAD_OP_ECODE(context_id0)),
index 7e2859736a558fe899c8d1bb438daa07523f2c59..fe2ad0c0de9543dc53292f6d1690c7aabc0c54fd 100644 (file)
@@ -328,7 +328,8 @@ static void event_interrupt_wq_v11(struct kfd_node *dev,
                /* CP */
                if (source_id == SOC15_INTSRC_CP_END_OF_PIPE)
                        kfd_signal_event_interrupt(pasid, context_id0, 32);
-               else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE)
+               else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE &&
+                        KFD_DBG_EC_TYPE_IS_PACKET(KFD_CTXID0_CP_BAD_OP_ECODE(context_id0)))
                        kfd_set_dbg_ev_from_interrupt(dev, pasid,
                                KFD_CTXID0_DOORBELL_ID(context_id0),
                                KFD_EC_MASK(KFD_CTXID0_CP_BAD_OP_ECODE(context_id0)),
index 91dd5e045b511d2aaa42aa4bd9b934e018c407ab..c4c6a29052ac8fd1a90b6a78c884df002fbde093 100644 (file)
@@ -388,7 +388,8 @@ static void event_interrupt_wq_v9(struct kfd_node *dev,
                                break;
                        }
                        kfd_signal_event_interrupt(pasid, sq_int_data, 24);
-               } else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE) {
+               } else if (source_id == SOC15_INTSRC_CP_BAD_OPCODE &&
+                          KFD_DBG_EC_TYPE_IS_PACKET(KFD_DEBUG_CP_BAD_OP_ECODE(context_id0))) {
                        kfd_set_dbg_ev_from_interrupt(dev, pasid,
                                KFD_DEBUG_DOORBELL_ID(context_id0),
                                KFD_EC_MASK(KFD_DEBUG_CP_BAD_OP_ECODE(context_id0)),
index 42d40560cd30d787ba2b1e6487dc6a065c810843..a81ef232fdef96d5b13b7a3be912f504716e3f35 100644 (file)
@@ -1473,7 +1473,7 @@ static inline void kfd_flush_tlb(struct kfd_process_device *pdd,
 
 static inline bool kfd_flush_tlb_after_unmap(struct kfd_dev *dev)
 {
-       return KFD_GC_VERSION(dev) > IP_VERSION(9, 4, 2) ||
+       return KFD_GC_VERSION(dev) >= IP_VERSION(9, 4, 2) ||
               (KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 1) && dev->sdma_fw_version >= 18) ||
               KFD_GC_VERSION(dev) == IP_VERSION(9, 4, 0);
 }
index 2851719d7121612b64842f3da8e84cf82d073454..71d2d44681b218fc5146f3354464ba0f9c08610e 100644 (file)
@@ -6305,9 +6305,8 @@ create_stream_for_sink(struct drm_connector *connector,
 
        if (stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)
                mod_build_hf_vsif_infopacket(stream, &stream->vsp_infopacket);
-       else if (stream->signal == SIGNAL_TYPE_DISPLAY_PORT ||
-                        stream->signal == SIGNAL_TYPE_DISPLAY_PORT_MST ||
-                        stream->signal == SIGNAL_TYPE_EDP) {
+
+       if (stream->link->psr_settings.psr_feature_enabled || stream->link->replay_settings.replay_feature_enabled) {
                //
                // should decide stream support vsc sdp colorimetry capability
                // before building vsc info packet
@@ -6323,9 +6322,8 @@ create_stream_for_sink(struct drm_connector *connector,
                if (stream->out_transfer_func->tf == TRANSFER_FUNCTION_GAMMA22)
                        tf = TRANSFER_FUNC_GAMMA_22;
                mod_build_vsc_infopacket(stream, &stream->vsc_infopacket, stream->output_color_space, tf);
+               aconnector->psr_skip_count = AMDGPU_DM_PSR_ENTRY_DELAY;
 
-               if (stream->link->psr_settings.psr_feature_enabled)
-                       aconnector->psr_skip_count = AMDGPU_DM_PSR_ENTRY_DELAY;
        }
 finish:
        dc_sink_release(sink);
index 1f08c6564c3bfea6dbc047b04eb1ee7603df0ead..286ecd28cc6e6667a5aa532077ae9dc9d03e3068 100644 (file)
@@ -141,9 +141,8 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
  * amdgpu_dm_psr_enable() - enable psr f/w
  * @stream: stream state
  *
- * Return: true if success
  */
-bool amdgpu_dm_psr_enable(struct dc_stream_state *stream)
+void amdgpu_dm_psr_enable(struct dc_stream_state *stream)
 {
        struct dc_link *link = stream->link;
        unsigned int vsync_rate_hz = 0;
@@ -190,7 +189,10 @@ bool amdgpu_dm_psr_enable(struct dc_stream_state *stream)
        if (link->psr_settings.psr_version < DC_PSR_VERSION_SU_1)
                power_opt |= psr_power_opt_z10_static_screen;
 
-       return dc_link_set_psr_allow_active(link, &psr_enable, false, false, &power_opt);
+       dc_link_set_psr_allow_active(link, &psr_enable, false, false, &power_opt);
+
+       if (link->ctx->dc->caps.ips_support)
+               dc_allow_idle_optimizations(link->ctx->dc, true);
 }
 
 /*
index 6806b3c9c84ba05f278e84b6ab9cf4f7135b3162..1fdfd183c0d91aa31b88ae7feba6f673339ac0cb 100644 (file)
@@ -32,7 +32,7 @@
 #define AMDGPU_DM_PSR_ENTRY_DELAY 5
 
 void amdgpu_dm_set_psr_caps(struct dc_link *link);
-bool amdgpu_dm_psr_enable(struct dc_stream_state *stream);
+void amdgpu_dm_psr_enable(struct dc_stream_state *stream);
 bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream);
 bool amdgpu_dm_psr_disable(struct dc_stream_state *stream);
 bool amdgpu_dm_psr_disable_all(struct amdgpu_display_manager *dm);
index c378b879c76d8c062601f87c952668f920750a48..101fe96287cb480bf9ee142ceb998a84ab1027f8 100644 (file)
@@ -73,6 +73,8 @@
 #define CLK1_CLK2_BYPASS_CNTL__CLK2_BYPASS_SEL_MASK            0x00000007L
 #define CLK1_CLK2_BYPASS_CNTL__CLK2_BYPASS_DIV_MASK            0x000F0000L
 
+#define SMU_VER_THRESHOLD 0x5D4A00 //93.74.0
+
 #define REG(reg_name) \
        (ctx->clk_reg_offsets[reg ## reg_name ## _BASE_IDX] + reg ## reg_name)
 
@@ -411,9 +413,12 @@ static void dcn35_dump_clk_registers(struct clk_state_registers_and_bypass *regs
 
 static void init_clk_states(struct clk_mgr *clk_mgr)
 {
+       struct clk_mgr_internal *clk_mgr_int = TO_CLK_MGR_INTERNAL(clk_mgr);
        uint32_t ref_dtbclk = clk_mgr->clks.ref_dtbclk_khz;
        memset(&(clk_mgr->clks), 0, sizeof(struct dc_clocks));
 
+       if (clk_mgr_int->smu_ver >= SMU_VER_THRESHOLD)
+               clk_mgr->clks.dtbclk_en = true; // request DTBCLK disable on first commit
        clk_mgr->clks.ref_dtbclk_khz = ref_dtbclk;      // restore ref_dtbclk
        clk_mgr->clks.p_state_change_support = true;
        clk_mgr->clks.prev_p_state_change_support = true;
@@ -709,7 +714,7 @@ static void dcn35_clk_mgr_helper_populate_bw_params(struct clk_mgr_internal *clk
                clock_table->NumFclkLevelsEnabled;
        max_fclk = find_max_clk_value(clock_table->FclkClocks_Freq, num_fclk);
 
-       num_dcfclk = (clock_table->NumFclkLevelsEnabled > NUM_DCFCLK_DPM_LEVELS) ? NUM_DCFCLK_DPM_LEVELS :
+       num_dcfclk = (clock_table->NumDcfClkLevelsEnabled > NUM_DCFCLK_DPM_LEVELS) ? NUM_DCFCLK_DPM_LEVELS :
                clock_table->NumDcfClkLevelsEnabled;
        for (i = 0; i < num_dcfclk; i++) {
                int j;
index e7dc128f6284b45846f4eff707d3f052dab7b108..03b554e912a20d4ae58e5161d55943eb0bb7a0d9 100644 (file)
@@ -3024,7 +3024,8 @@ static void backup_planes_and_stream_state(
                scratch->blend_tf[i] = *status->plane_states[i]->blend_tf;
        }
        scratch->stream_state = *stream;
-       scratch->out_transfer_func = *stream->out_transfer_func;
+       if (stream->out_transfer_func)
+               scratch->out_transfer_func = *stream->out_transfer_func;
 }
 
 static void restore_planes_and_stream_state(
@@ -3046,7 +3047,8 @@ static void restore_planes_and_stream_state(
                *status->plane_states[i]->blend_tf = scratch->blend_tf[i];
        }
        *stream = scratch->stream_state;
-       *stream->out_transfer_func = scratch->out_transfer_func;
+       if (stream->out_transfer_func)
+               *stream->out_transfer_func = scratch->out_transfer_func;
 }
 
 static bool update_planes_and_stream_state(struct dc *dc,
index f0777d61c2cbb6b93d689392a097da89c80b5ff2..c307f040e48fc6f5c44c8c3be259294091cb285b 100644 (file)
@@ -23,7 +23,7 @@
 # Makefile for the 'controller' sub-component of DAL.
 # It provides the control and status of HW CRTC block.
 
-CFLAGS_$(AMDDALPATH)/dc/dce110/dce110_resource.o = $(call cc-disable-warning, override-init)
+CFLAGS_$(AMDDALPATH)/dc/dce110/dce110_resource.o = -Wno-override-init
 
 DCE110 = dce110_timing_generator.o \
 dce110_compressor.o dce110_opp_regamma_v.o \
index 7e92effec89447e7a8978c7339f02d08a3048f9a..683866797709ba6490b2eb30e13899b758c12176 100644 (file)
@@ -23,7 +23,7 @@
 # Makefile for the 'controller' sub-component of DAL.
 # It provides the control and status of HW CRTC block.
 
-CFLAGS_$(AMDDALPATH)/dc/dce112/dce112_resource.o = $(call cc-disable-warning, override-init)
+CFLAGS_$(AMDDALPATH)/dc/dce112/dce112_resource.o = -Wno-override-init
 
 DCE112 = dce112_compressor.o
 
index 1e3ef68a452a568462cc085845536e6c8c0cb8bc..8f508e66274805be3f400bad8a3231898b9179b9 100644 (file)
@@ -24,7 +24,7 @@
 # It provides the control and status of HW CRTC block.
 
 
-CFLAGS_$(AMDDALPATH)/dc/dce120/dce120_resource.o = $(call cc-disable-warning, override-init)
+CFLAGS_$(AMDDALPATH)/dc/dce120/dce120_resource.o = -Wno-override-init
 
 DCE120 = dce120_timing_generator.o
 
index fee331accc0e7c3d3cefb418f1b5275b8759f9a7..eede83ad91fa0d4131d5f43cbb22e213973cab45 100644 (file)
@@ -23,7 +23,7 @@
 # Makefile for the 'controller' sub-component of DAL.
 # It provides the control and status of HW CRTC block.
 
-CFLAGS_$(AMDDALPATH)/dc/dce60/dce60_resource.o = $(call cc-disable-warning, override-init)
+CFLAGS_$(AMDDALPATH)/dc/dce60/dce60_resource.o = -Wno-override-init
 
 DCE60 = dce60_timing_generator.o dce60_hw_sequencer.o \
        dce60_resource.o
index 7eefffbdc9253f840133a3e0ed6f8c4d74e4fa57..fba189d26652d63306ee0b6b034a84994a4c2def 100644 (file)
@@ -23,7 +23,7 @@
 # Makefile for the 'controller' sub-component of DAL.
 # It provides the control and status of HW CRTC block.
 
-CFLAGS_$(AMDDALPATH)/dc/dce80/dce80_resource.o = $(call cc-disable-warning, override-init)
+CFLAGS_$(AMDDALPATH)/dc/dce80/dce80_resource.o = -Wno-override-init
 
 DCE80 = dce80_timing_generator.o
 
index bf3386cd444d62c5232909f9b88061e6abf98887..5ebb573031304815e7c9ed099d1329511b974368 100644 (file)
 #define NUM_ELEMENTS(a) (sizeof(a) / sizeof((a)[0]))
 
 
+void mpc3_mpc_init(struct mpc *mpc)
+{
+       struct dcn30_mpc *mpc30 = TO_DCN30_MPC(mpc);
+       int opp_id;
+
+       mpc1_mpc_init(mpc);
+
+       for (opp_id = 0; opp_id < MAX_OPP; opp_id++) {
+               if (REG(MUX[opp_id]))
+                       /* disable mpc out rate and flow control */
+                       REG_UPDATE_2(MUX[opp_id], MPC_OUT_RATE_CONTROL_DISABLE,
+                                       1, MPC_OUT_FLOW_CONTROL_COUNT, 0);
+       }
+}
+
+void mpc3_mpc_init_single_inst(struct mpc *mpc, unsigned int mpcc_id)
+{
+       struct dcn30_mpc *mpc30 = TO_DCN30_MPC(mpc);
+
+       mpc1_mpc_init_single_inst(mpc, mpcc_id);
+
+       /* assuming mpc out mux is connected to opp with the same index at this
+        * point in time (e.g. transitioning from vbios to driver)
+        */
+       if (mpcc_id < MAX_OPP && REG(MUX[mpcc_id]))
+               /* disable mpc out rate and flow control */
+               REG_UPDATE_2(MUX[mpcc_id], MPC_OUT_RATE_CONTROL_DISABLE,
+                               1, MPC_OUT_FLOW_CONTROL_COUNT, 0);
+}
+
 bool mpc3_is_dwb_idle(
        struct mpc *mpc,
        int dwb_id)
@@ -80,25 +110,6 @@ void mpc3_disable_dwb_mux(
                MPC_DWB0_MUX, 0xf);
 }
 
-void mpc3_set_out_rate_control(
-       struct mpc *mpc,
-       int opp_id,
-       bool enable,
-       bool rate_2x_mode,
-       struct mpc_dwb_flow_control *flow_control)
-{
-       struct dcn30_mpc *mpc30 = TO_DCN30_MPC(mpc);
-
-       REG_UPDATE_2(MUX[opp_id],
-                       MPC_OUT_RATE_CONTROL_DISABLE, !enable,
-                       MPC_OUT_RATE_CONTROL, rate_2x_mode);
-
-       if (flow_control)
-               REG_UPDATE_2(MUX[opp_id],
-                       MPC_OUT_FLOW_CONTROL_MODE, flow_control->flow_ctrl_mode,
-                       MPC_OUT_FLOW_CONTROL_COUNT, flow_control->flow_ctrl_cnt1);
-}
-
 enum dc_lut_mode mpc3_get_ogam_current(struct mpc *mpc, int mpcc_id)
 {
        /*Contrary to DCN2 and DCN1 wherein a single status register field holds this info;
@@ -1490,8 +1501,8 @@ static const struct mpc_funcs dcn30_mpc_funcs = {
        .read_mpcc_state = mpc3_read_mpcc_state,
        .insert_plane = mpc1_insert_plane,
        .remove_mpcc = mpc1_remove_mpcc,
-       .mpc_init = mpc1_mpc_init,
-       .mpc_init_single_inst = mpc1_mpc_init_single_inst,
+       .mpc_init = mpc3_mpc_init,
+       .mpc_init_single_inst = mpc3_mpc_init_single_inst,
        .update_blending = mpc2_update_blending,
        .cursor_lock = mpc1_cursor_lock,
        .get_mpcc_for_dpp = mpc1_get_mpcc_for_dpp,
@@ -1508,7 +1519,6 @@ static const struct mpc_funcs dcn30_mpc_funcs = {
        .set_dwb_mux = mpc3_set_dwb_mux,
        .disable_dwb_mux = mpc3_disable_dwb_mux,
        .is_dwb_idle = mpc3_is_dwb_idle,
-       .set_out_rate_control = mpc3_set_out_rate_control,
        .set_gamut_remap = mpc3_set_gamut_remap,
        .program_shaper = mpc3_program_shaper,
        .acquire_rmu = mpcc3_acquire_rmu,
index 9cb96ae95a2f753639e3149ee55757dae44bffd3..ce93003dae011325efa0e1e3e5351646a5406017 100644 (file)
@@ -1007,6 +1007,13 @@ void dcn30_mpc_construct(struct dcn30_mpc *mpc30,
        int num_mpcc,
        int num_rmu);
 
+void mpc3_mpc_init(
+       struct mpc *mpc);
+
+void mpc3_mpc_init_single_inst(
+       struct mpc *mpc,
+       unsigned int mpcc_id);
+
 bool mpc3_program_shaper(
                struct mpc *mpc,
                const struct pwl_params *params,
@@ -1078,13 +1085,6 @@ bool mpc3_is_dwb_idle(
        struct mpc *mpc,
        int dwb_id);
 
-void mpc3_set_out_rate_control(
-       struct mpc *mpc,
-       int opp_id,
-       bool enable,
-       bool rate_2x_mode,
-       struct mpc_dwb_flow_control *flow_control);
-
 void mpc3_power_on_ogam_lut(
        struct mpc *mpc, int mpcc_id,
        bool power_on);
index e789e654c38705116bd70f7b023f7b44cf8b1ba9..e408e859b3556166346e0f62d5b3aaaac4c2d2df 100644 (file)
@@ -47,7 +47,7 @@ void mpc32_mpc_init(struct mpc *mpc)
        struct dcn30_mpc *mpc30 = TO_DCN30_MPC(mpc);
        int mpcc_id;
 
-       mpc1_mpc_init(mpc);
+       mpc3_mpc_init(mpc);
 
        if (mpc->ctx->dc->debug.enable_mem_low_power.bits.mpc) {
                if (mpc30->mpc_mask->MPCC_MCM_SHAPER_MEM_LOW_PWR_MODE && mpc30->mpc_mask->MPCC_MCM_3DLUT_MEM_LOW_PWR_MODE) {
@@ -991,7 +991,7 @@ static const struct mpc_funcs dcn32_mpc_funcs = {
        .insert_plane = mpc1_insert_plane,
        .remove_mpcc = mpc1_remove_mpcc,
        .mpc_init = mpc32_mpc_init,
-       .mpc_init_single_inst = mpc1_mpc_init_single_inst,
+       .mpc_init_single_inst = mpc3_mpc_init_single_inst,
        .update_blending = mpc2_update_blending,
        .cursor_lock = mpc1_cursor_lock,
        .get_mpcc_for_dpp = mpc1_get_mpcc_for_dpp,
@@ -1008,7 +1008,6 @@ static const struct mpc_funcs dcn32_mpc_funcs = {
        .set_dwb_mux = mpc3_set_dwb_mux,
        .disable_dwb_mux = mpc3_disable_dwb_mux,
        .is_dwb_idle = mpc3_is_dwb_idle,
-       .set_out_rate_control = mpc3_set_out_rate_control,
        .set_gamut_remap = mpc3_set_gamut_remap,
        .program_shaper = mpc32_program_shaper,
        .program_3dlut = mpc32_program_3dlut,
index 80bebfc268db0f59d2ac9067d3780f6675760afb..21e0eef3269b10fab97ac3cb7e44cf54f33c775d 100644 (file)
@@ -166,8 +166,8 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_5_soc = {
        .num_states = 5,
        .sr_exit_time_us = 28.0,
        .sr_enter_plus_exit_time_us = 30.0,
-       .sr_exit_z8_time_us = 210.0,
-       .sr_enter_plus_exit_z8_time_us = 320.0,
+       .sr_exit_z8_time_us = 250.0,
+       .sr_enter_plus_exit_z8_time_us = 350.0,
        .fclk_change_latency_us = 24.0,
        .usr_retraining_latency_us = 2,
        .writeback_latency_us = 12.0,
index dc9e1b758ed6a1db8e21ad080bc180ea71259373..b3ffab77cf889487f7024c22eb4a18542c7bfbea 100644 (file)
@@ -98,55 +98,114 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_51_soc = {
        .clock_limits = {
                {
                        .state = 0,
-                       .dispclk_mhz = 1200.0,
-                       .dppclk_mhz = 1200.0,
+                       .dcfclk_mhz = 400.0,
+                       .fabricclk_mhz = 400.0,
+                       .socclk_mhz = 600.0,
+                       .dram_speed_mts = 3200.0,
+                       .dispclk_mhz = 600.0,
+                       .dppclk_mhz = 600.0,
                        .phyclk_mhz = 600.0,
                        .phyclk_d18_mhz = 667.0,
-                       .dscclk_mhz = 186.0,
+                       .dscclk_mhz = 200.0,
                        .dtbclk_mhz = 600.0,
                },
                {
                        .state = 1,
-                       .dispclk_mhz = 1200.0,
-                       .dppclk_mhz = 1200.0,
+                       .dcfclk_mhz = 600.0,
+                       .fabricclk_mhz = 1000.0,
+                       .socclk_mhz = 733.0,
+                       .dram_speed_mts = 6400.0,
+                       .dispclk_mhz = 800.0,
+                       .dppclk_mhz = 800.0,
                        .phyclk_mhz = 810.0,
                        .phyclk_d18_mhz = 667.0,
-                       .dscclk_mhz = 209.0,
+                       .dscclk_mhz = 266.7,
                        .dtbclk_mhz = 600.0,
                },
                {
                        .state = 2,
-                       .dispclk_mhz = 1200.0,
-                       .dppclk_mhz = 1200.0,
+                       .dcfclk_mhz = 738.0,
+                       .fabricclk_mhz = 1200.0,
+                       .socclk_mhz = 880.0,
+                       .dram_speed_mts = 7500.0,
+                       .dispclk_mhz = 800.0,
+                       .dppclk_mhz = 800.0,
                        .phyclk_mhz = 810.0,
                        .phyclk_d18_mhz = 667.0,
-                       .dscclk_mhz = 209.0,
+                       .dscclk_mhz = 266.7,
                        .dtbclk_mhz = 600.0,
                },
                {
                        .state = 3,
-                       .dispclk_mhz = 1200.0,
-                       .dppclk_mhz = 1200.0,
+                       .dcfclk_mhz = 800.0,
+                       .fabricclk_mhz = 1400.0,
+                       .socclk_mhz = 978.0,
+                       .dram_speed_mts = 7500.0,
+                       .dispclk_mhz = 960.0,
+                       .dppclk_mhz = 960.0,
                        .phyclk_mhz = 810.0,
                        .phyclk_d18_mhz = 667.0,
-                       .dscclk_mhz = 371.0,
+                       .dscclk_mhz = 320.0,
                        .dtbclk_mhz = 600.0,
                },
                {
                        .state = 4,
+                       .dcfclk_mhz = 873.0,
+                       .fabricclk_mhz = 1600.0,
+                       .socclk_mhz = 1100.0,
+                       .dram_speed_mts = 8533.0,
+                       .dispclk_mhz = 1066.7,
+                       .dppclk_mhz = 1066.7,
+                       .phyclk_mhz = 810.0,
+                       .phyclk_d18_mhz = 667.0,
+                       .dscclk_mhz = 355.6,
+                       .dtbclk_mhz = 600.0,
+               },
+               {
+                       .state = 5,
+                       .dcfclk_mhz = 960.0,
+                       .fabricclk_mhz = 1700.0,
+                       .socclk_mhz = 1257.0,
+                       .dram_speed_mts = 8533.0,
                        .dispclk_mhz = 1200.0,
                        .dppclk_mhz = 1200.0,
                        .phyclk_mhz = 810.0,
                        .phyclk_d18_mhz = 667.0,
-                       .dscclk_mhz = 417.0,
+                       .dscclk_mhz = 400.0,
+                       .dtbclk_mhz = 600.0,
+               },
+               {
+                       .state = 6,
+                       .dcfclk_mhz = 1067.0,
+                       .fabricclk_mhz = 1850.0,
+                       .socclk_mhz = 1257.0,
+                       .dram_speed_mts = 8533.0,
+                       .dispclk_mhz = 1371.4,
+                       .dppclk_mhz = 1371.4,
+                       .phyclk_mhz = 810.0,
+                       .phyclk_d18_mhz = 667.0,
+                       .dscclk_mhz = 457.1,
+                       .dtbclk_mhz = 600.0,
+               },
+               {
+                       .state = 7,
+                       .dcfclk_mhz = 1200.0,
+                       .fabricclk_mhz = 2000.0,
+                       .socclk_mhz = 1467.0,
+                       .dram_speed_mts = 8533.0,
+                       .dispclk_mhz = 1600.0,
+                       .dppclk_mhz = 1600.0,
+                       .phyclk_mhz = 810.0,
+                       .phyclk_d18_mhz = 667.0,
+                       .dscclk_mhz = 533.3,
                        .dtbclk_mhz = 600.0,
                },
        },
-       .num_states = 5,
+       .num_states = 8,
        .sr_exit_time_us = 28.0,
        .sr_enter_plus_exit_time_us = 30.0,
-       .sr_exit_z8_time_us = 210.0,
-       .sr_enter_plus_exit_z8_time_us = 320.0,
+       .sr_exit_z8_time_us = 250.0,
+       .sr_enter_plus_exit_z8_time_us = 350.0,
        .fclk_change_latency_us = 24.0,
        .usr_retraining_latency_us = 2,
        .writeback_latency_us = 12.0,
@@ -177,6 +236,9 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_51_soc = {
        .do_urgent_latency_adjustment = 0,
        .urgent_latency_adjustment_fabric_clock_component_us = 0,
        .urgent_latency_adjustment_fabric_clock_reference_mhz = 0,
+       .num_chans = 4,
+       .dram_clock_change_latency_us = 11.72,
+       .dispclk_dppclk_vco_speed_mhz = 2400.0,
 };
 
 /*
@@ -340,6 +402,8 @@ void dcn351_update_bw_bounding_box_fpu(struct dc *dc,
                                clock_limits[i].socclk_mhz;
                        dc->dml2_options.bbox_overrides.clks_table.clk_entries[i].memclk_mhz =
                                clk_table->entries[i].memclk_mhz * clk_table->entries[i].wck_ratio;
+                       dc->dml2_options.bbox_overrides.clks_table.clk_entries[i].dtbclk_mhz =
+                               clock_limits[i].dtbclk_mhz;
                        dc->dml2_options.bbox_overrides.clks_table.num_entries_per_clk.num_dcfclk_levels =
                                clk_table->num_entries;
                        dc->dml2_options.bbox_overrides.clks_table.num_entries_per_clk.num_fclk_levels =
@@ -352,6 +416,8 @@ void dcn351_update_bw_bounding_box_fpu(struct dc *dc,
                                clk_table->num_entries;
                        dc->dml2_options.bbox_overrides.clks_table.num_entries_per_clk.num_memclk_levels =
                                clk_table->num_entries;
+                       dc->dml2_options.bbox_overrides.clks_table.num_entries_per_clk.num_dtbclk_levels =
+                               clk_table->num_entries;
                }
        }
 
@@ -551,6 +617,7 @@ void dcn351_decide_zstate_support(struct dc *dc, struct dc_state *context)
                if (context->res_ctx.pipe_ctx[i].plane_state)
                        plane_count++;
        }
+
        /*dcn351 does not support z9/z10*/
        if (context->stream_count == 0 || plane_count == 0) {
                support = DCN_ZSTATE_SUPPORT_ALLOW_Z8_ONLY;
@@ -564,11 +631,9 @@ void dcn351_decide_zstate_support(struct dc *dc, struct dc_state *context)
                        dc->debug.minimum_z8_residency_time > 0 ? dc->debug.minimum_z8_residency_time : 1000;
                bool allow_z8 = context->bw_ctx.dml.vba.StutterPeriod > (double)minmum_z8_residency;
 
-
                /*for psr1/psr-su, we allow z8 and z10 based on latency, for replay with IPS enabled, it will enter ips2*/
-                if (is_pwrseq0 && (is_psr || is_replay))
+               if (is_pwrseq0 && (is_psr || is_replay))
                        support = allow_z8 ? allow_z8 : DCN_ZSTATE_SUPPORT_DISALLOW;
-
        }
        context->bw_ctx.bw.dcn.clk.zstate_support = support;
 }
index 17a58f41fc6a8501a4cf998507d9b89f68d0fcc1..a20f28a5d2e7b09db5a02d4641e4f89bfcfcdcd6 100644 (file)
@@ -228,17 +228,13 @@ void dml2_init_socbb_params(struct dml2_context *dml2, const struct dc *in_dc, s
                break;
 
        case dml_project_dcn35:
+       case dml_project_dcn351:
                out->num_chans = 4;
                out->round_trip_ping_latency_dcfclk_cycles = 106;
                out->smn_latency_us = 2;
                out->dispclk_dppclk_vco_speed_mhz = 3600;
                break;
 
-       case dml_project_dcn351:
-               out->num_chans = 16;
-               out->round_trip_ping_latency_dcfclk_cycles = 1100;
-               out->smn_latency_us = 2;
-               break;
        }
        /* ---Overrides if available--- */
        if (dml2->config.bbox_overrides.dram_num_chan)
index 9d5df4c0da59796ebd8a16927cba72f17239c4fc..0ba1feaf96c0d76bceaf02c302e0e0f0f9c756ab 100644 (file)
@@ -1185,7 +1185,8 @@ void dce110_disable_stream(struct pipe_ctx *pipe_ctx)
                if (dccg) {
                        dccg->funcs->disable_symclk32_se(dccg, dp_hpo_inst);
                        dccg->funcs->set_dpstreamclk(dccg, REFCLK, tg->inst, dp_hpo_inst);
-                       dccg->funcs->set_dtbclk_dto(dccg, &dto_params);
+                       if (dccg && dccg->funcs->set_dtbclk_dto)
+                               dccg->funcs->set_dtbclk_dto(dccg, &dto_params);
                }
        } else if (dccg && dccg->funcs->disable_symclk_se) {
                dccg->funcs->disable_symclk_se(dccg, stream_enc->stream_enc_inst,
index 3a9cc8ac0c07938a5b97286e829c378142a6b8ed..093f4387553ce34ed55eb56c337e70b5c8e127bd 100644 (file)
 #define FN(reg_name, field_name) \
        hws->shifts->field_name, hws->masks->field_name
 
-static int calc_mpc_flow_ctrl_cnt(const struct dc_stream_state *stream,
-               int opp_cnt)
-{
-       bool hblank_halved = optc2_is_two_pixels_per_containter(&stream->timing);
-       int flow_ctrl_cnt;
-
-       if (opp_cnt >= 2)
-               hblank_halved = true;
-
-       flow_ctrl_cnt = stream->timing.h_total - stream->timing.h_addressable -
-                       stream->timing.h_border_left -
-                       stream->timing.h_border_right;
-
-       if (hblank_halved)
-               flow_ctrl_cnt /= 2;
-
-       /* ODM combine 4:1 case */
-       if (opp_cnt == 4)
-               flow_ctrl_cnt /= 2;
-
-       return flow_ctrl_cnt;
-}
-
 static void update_dsc_on_stream(struct pipe_ctx *pipe_ctx, bool enable)
 {
        struct display_stream_compressor *dsc = pipe_ctx->stream_res.dsc;
@@ -183,10 +160,6 @@ void dcn314_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx
        struct pipe_ctx *odm_pipe;
        int opp_cnt = 0;
        int opp_inst[MAX_PIPES] = {0};
-       bool rate_control_2x_pclk = (pipe_ctx->stream->timing.flags.INTERLACE || optc2_is_two_pixels_per_containter(&pipe_ctx->stream->timing));
-       struct mpc_dwb_flow_control flow_control;
-       struct mpc *mpc = dc->res_pool->mpc;
-       int i;
 
        opp_cnt = get_odm_config(pipe_ctx, opp_inst);
 
@@ -199,20 +172,6 @@ void dcn314_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx
                pipe_ctx->stream_res.tg->funcs->set_odm_bypass(
                                pipe_ctx->stream_res.tg, &pipe_ctx->stream->timing);
 
-       rate_control_2x_pclk = rate_control_2x_pclk || opp_cnt > 1;
-       flow_control.flow_ctrl_mode = 0;
-       flow_control.flow_ctrl_cnt0 = 0x80;
-       flow_control.flow_ctrl_cnt1 = calc_mpc_flow_ctrl_cnt(pipe_ctx->stream, opp_cnt);
-       if (mpc->funcs->set_out_rate_control) {
-               for (i = 0; i < opp_cnt; ++i) {
-                       mpc->funcs->set_out_rate_control(
-                                       mpc, opp_inst[i],
-                                       true,
-                                       rate_control_2x_pclk,
-                                       &flow_control);
-               }
-       }
-
        for (odm_pipe = pipe_ctx->next_odm_pipe; odm_pipe; odm_pipe = odm_pipe->next_odm_pipe) {
                odm_pipe->stream_res.opp->funcs->opp_pipe_clock_control(
                                odm_pipe->stream_res.opp,
index c0b526cf178654f1c9fedb95e08831e965a911a7..7668229438da22d31daf728d591d8b2b54d7e774 100644 (file)
@@ -966,29 +966,6 @@ void dcn32_init_hw(struct dc *dc)
        }
 }
 
-static int calc_mpc_flow_ctrl_cnt(const struct dc_stream_state *stream,
-               int opp_cnt)
-{
-       bool hblank_halved = optc2_is_two_pixels_per_containter(&stream->timing);
-       int flow_ctrl_cnt;
-
-       if (opp_cnt >= 2)
-               hblank_halved = true;
-
-       flow_ctrl_cnt = stream->timing.h_total - stream->timing.h_addressable -
-                       stream->timing.h_border_left -
-                       stream->timing.h_border_right;
-
-       if (hblank_halved)
-               flow_ctrl_cnt /= 2;
-
-       /* ODM combine 4:1 case */
-       if (opp_cnt == 4)
-               flow_ctrl_cnt /= 2;
-
-       return flow_ctrl_cnt;
-}
-
 static void update_dsc_on_stream(struct pipe_ctx *pipe_ctx, bool enable)
 {
        struct display_stream_compressor *dsc = pipe_ctx->stream_res.dsc;
@@ -1103,10 +1080,6 @@ void dcn32_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx *
        struct pipe_ctx *odm_pipe;
        int opp_cnt = 0;
        int opp_inst[MAX_PIPES] = {0};
-       bool rate_control_2x_pclk = (pipe_ctx->stream->timing.flags.INTERLACE || optc2_is_two_pixels_per_containter(&pipe_ctx->stream->timing));
-       struct mpc_dwb_flow_control flow_control;
-       struct mpc *mpc = dc->res_pool->mpc;
-       int i;
 
        opp_cnt = get_odm_config(pipe_ctx, opp_inst);
 
@@ -1119,20 +1092,6 @@ void dcn32_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx *
                pipe_ctx->stream_res.tg->funcs->set_odm_bypass(
                                pipe_ctx->stream_res.tg, &pipe_ctx->stream->timing);
 
-       rate_control_2x_pclk = rate_control_2x_pclk || opp_cnt > 1;
-       flow_control.flow_ctrl_mode = 0;
-       flow_control.flow_ctrl_cnt0 = 0x80;
-       flow_control.flow_ctrl_cnt1 = calc_mpc_flow_ctrl_cnt(pipe_ctx->stream, opp_cnt);
-       if (mpc->funcs->set_out_rate_control) {
-               for (i = 0; i < opp_cnt; ++i) {
-                       mpc->funcs->set_out_rate_control(
-                                       mpc, opp_inst[i],
-                                       true,
-                                       rate_control_2x_pclk,
-                                       &flow_control);
-               }
-       }
-
        for (odm_pipe = pipe_ctx->next_odm_pipe; odm_pipe; odm_pipe = odm_pipe->next_odm_pipe) {
                odm_pipe->stream_res.opp->funcs->opp_pipe_clock_control(
                                odm_pipe->stream_res.opp,
index 4b92df23ff0db90498e722c0df0d8bbb149e76e2..a5560b3fc39ba9b432e0e5605b3972810de38933 100644 (file)
@@ -358,29 +358,6 @@ void dcn35_init_hw(struct dc *dc)
        }
 }
 
-static int calc_mpc_flow_ctrl_cnt(const struct dc_stream_state *stream,
-               int opp_cnt)
-{
-       bool hblank_halved = optc2_is_two_pixels_per_containter(&stream->timing);
-       int flow_ctrl_cnt;
-
-       if (opp_cnt >= 2)
-               hblank_halved = true;
-
-       flow_ctrl_cnt = stream->timing.h_total - stream->timing.h_addressable -
-                       stream->timing.h_border_left -
-                       stream->timing.h_border_right;
-
-       if (hblank_halved)
-               flow_ctrl_cnt /= 2;
-
-       /* ODM combine 4:1 case */
-       if (opp_cnt == 4)
-               flow_ctrl_cnt /= 2;
-
-       return flow_ctrl_cnt;
-}
-
 static void update_dsc_on_stream(struct pipe_ctx *pipe_ctx, bool enable)
 {
        struct display_stream_compressor *dsc = pipe_ctx->stream_res.dsc;
@@ -474,10 +451,6 @@ void dcn35_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx *
        struct pipe_ctx *odm_pipe;
        int opp_cnt = 0;
        int opp_inst[MAX_PIPES] = {0};
-       bool rate_control_2x_pclk = (pipe_ctx->stream->timing.flags.INTERLACE || optc2_is_two_pixels_per_containter(&pipe_ctx->stream->timing));
-       struct mpc_dwb_flow_control flow_control;
-       struct mpc *mpc = dc->res_pool->mpc;
-       int i;
 
        opp_cnt = get_odm_config(pipe_ctx, opp_inst);
 
@@ -490,20 +463,6 @@ void dcn35_update_odm(struct dc *dc, struct dc_state *context, struct pipe_ctx *
                pipe_ctx->stream_res.tg->funcs->set_odm_bypass(
                                pipe_ctx->stream_res.tg, &pipe_ctx->stream->timing);
 
-       rate_control_2x_pclk = rate_control_2x_pclk || opp_cnt > 1;
-       flow_control.flow_ctrl_mode = 0;
-       flow_control.flow_ctrl_cnt0 = 0x80;
-       flow_control.flow_ctrl_cnt1 = calc_mpc_flow_ctrl_cnt(pipe_ctx->stream, opp_cnt);
-       if (mpc->funcs->set_out_rate_control) {
-               for (i = 0; i < opp_cnt; ++i) {
-                       mpc->funcs->set_out_rate_control(
-                                       mpc, opp_inst[i],
-                                       true,
-                                       rate_control_2x_pclk,
-                                       &flow_control);
-               }
-       }
-
        for (odm_pipe = pipe_ctx->next_odm_pipe; odm_pipe; odm_pipe = odm_pipe->next_odm_pipe) {
                odm_pipe->stream_res.opp->funcs->opp_pipe_clock_control(
                                odm_pipe->stream_res.opp,
index ab17fa1c64e8c5b405ae2f24a93c1ee54abefe10..670255c9bc82287fd39474400874059fa13dc557 100644 (file)
@@ -67,7 +67,7 @@ static const struct hw_sequencer_funcs dcn351_funcs = {
        .prepare_bandwidth = dcn35_prepare_bandwidth,
        .optimize_bandwidth = dcn35_optimize_bandwidth,
        .update_bandwidth = dcn20_update_bandwidth,
-       .set_drr = dcn10_set_drr,
+       .set_drr = dcn35_set_drr,
        .get_position = dcn10_get_position,
        .set_static_screen_control = dcn35_set_static_screen_control,
        .setup_stereo = dcn10_setup_stereo,
index 5b486400dfdb5b725f40952305d4efa964b3ad50..909e14261f9b49aa5453fe0b9b5199d32ddc272a 100644 (file)
@@ -700,6 +700,8 @@ static const struct dc_debug_options debug_defaults_drv = {
        .disable_dcc = DCC_ENABLE,
        .disable_dpp_power_gate = true,
        .disable_hubp_power_gate = true,
+       .disable_optc_power_gate = true, /*should the same as above two*/
+       .disable_hpo_power_gate = true, /*dmubfw force domain25 on*/
        .disable_clock_gate = false,
        .disable_dsc_power_gate = true,
        .vsr_support = true,
@@ -742,12 +744,13 @@ static const struct dc_debug_options debug_defaults_drv = {
        },
        .seamless_boot_odm_combine = DML_FAIL_SOURCE_PIXEL_FORMAT,
        .enable_z9_disable_interface = true, /* Allow support for the PMFW interface for disable Z9*/
+       .minimum_z8_residency_time = 2100,
        .using_dml2 = true,
        .support_eDP1_5 = true,
        .enable_hpo_pg_support = false,
        .enable_legacy_fast_update = true,
        .enable_single_display_2to1_odm_policy = true,
-       .disable_idle_power_optimizations = true,
+       .disable_idle_power_optimizations = false,
        .dmcub_emulation = false,
        .disable_boot_optimizations = false,
        .disable_unbounded_requesting = false,
@@ -758,8 +761,10 @@ static const struct dc_debug_options debug_defaults_drv = {
        .disable_z10 = true,
        .ignore_pg = true,
        .psp_disabled_wa = true,
-       .ips2_eval_delay_us = 200,
-       .ips2_entry_delay_us = 400
+       .ips2_eval_delay_us = 2000,
+       .ips2_entry_delay_us = 800,
+       .disable_dmub_reallow_idle = true,
+       .static_screen_wait_frames = 2,
 };
 
 static const struct dc_panel_config panel_config_defaults = {
index 738ee763f24a516153bf94ba5beaabec1f78fd9f..84f9b412a4f1172d17502395d0f418bae8233d1a 100644 (file)
@@ -147,15 +147,12 @@ void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
        }
 
        /* VSC packet set to 4 for PSR-SU, or 2 for PSR1 */
-       if (stream->link->psr_settings.psr_feature_enabled) {
-               if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1)
-                       vsc_packet_revision = vsc_packet_rev4;
-               else if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_1)
-                       vsc_packet_revision = vsc_packet_rev2;
-       }
-
-       if (stream->link->replay_settings.config.replay_supported)
+       if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_SU_1)
+               vsc_packet_revision = vsc_packet_rev4;
+       else if (stream->link->replay_settings.config.replay_supported)
                vsc_packet_revision = vsc_packet_rev4;
+       else if (stream->link->psr_settings.psr_version == DC_PSR_VERSION_1)
+               vsc_packet_revision = vsc_packet_rev2;
 
        /* Update to revision 5 for extended colorimetry support */
        if (stream->use_vsc_sdp_for_colorimetry)
index beadb9e42850c75c0a32218cdf01c2d63f7bea47..ca83e9e5c3ffb8e2fd4b76995bec26a8b2e68c7a 100644 (file)
@@ -234,7 +234,8 @@ union UMSCHAPI__SET_HW_RESOURCES {
                                uint32_t enable_level_process_quantum_check : 1;
                                uint32_t is_vcn0_enabled : 1;
                                uint32_t is_vcn1_enabled : 1;
-                               uint32_t reserved : 27;
+                               uint32_t use_rs64mem_for_proc_ctx_csa : 1;
+                               uint32_t reserved : 26;
                        };
                        uint32_t uint32_all;
                };
@@ -297,9 +298,12 @@ union UMSCHAPI__ADD_QUEUE {
 
                struct {
                        uint32_t is_context_suspended : 1;
-                       uint32_t reserved : 31;
+                       uint32_t collaboration_mode : 1;
+                       uint32_t reserved : 30;
                };
                struct UMSCH_API_STATUS api_status;
+               uint32_t process_csa_array_index;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
@@ -314,6 +318,7 @@ union UMSCHAPI__REMOVE_QUEUE {
                uint64_t context_csa_addr;
 
                struct UMSCH_API_STATUS api_status;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
@@ -337,6 +342,7 @@ union UMSCHAPI__SUSPEND {
                uint32_t suspend_fence_value;
 
                struct UMSCH_API_STATUS api_status;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
@@ -356,6 +362,7 @@ union UMSCHAPI__RESUME {
                enum UMSCH_ENGINE_TYPE engine_type;
 
                struct UMSCH_API_STATUS api_status;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
@@ -404,6 +411,7 @@ union UMSCHAPI__UPDATE_AFFINITY {
                union UMSCH_AFFINITY affinity;
                uint64_t context_csa_addr;
                struct UMSCH_API_STATUS api_status;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
@@ -417,6 +425,7 @@ union UMSCHAPI__CHANGE_CONTEXT_PRIORITY_LEVEL {
                uint64_t context_quantum;
                uint64_t context_csa_addr;
                struct UMSCH_API_STATUS api_status;
+               uint32_t context_csa_array_index;
        };
 
        uint32_t max_dwords_in_api[API_FRAME_SIZE_IN_DWORDS];
index 8a8a57c56bc0c48f9647bc3a9b6b36be2fc15bff..ca7ce4251482dbdf22b5ea39a5e6ca55e763896d 100644 (file)
 #define PPSMC_MSG_TestMessage                   0x01 ///< To check if PMFW is alive and responding. Requirement specified by PMFW team
 #define PPSMC_MSG_GetPmfwVersion                0x02 ///< Get PMFW version
 #define PPSMC_MSG_GetDriverIfVersion            0x03 ///< Get PMFW_DRIVER_IF version
-#define PPSMC_MSG_SPARE0                        0x04 ///< SPARE
-#define PPSMC_MSG_SPARE1                        0x05 ///< SPARE
-#define PPSMC_MSG_PowerDownVcn                  0x06 ///< Power down VCN
-#define PPSMC_MSG_PowerUpVcn                    0x07 ///< Power up VCN; VCN is power gated by default
-#define PPSMC_MSG_SetHardMinVcn                 0x08 ///< For wireless display
+#define PPSMC_MSG_PowerDownVcn1                 0x04 ///< Power down VCN1
+#define PPSMC_MSG_PowerUpVcn1                   0x05 ///< Power up VCN1; VCN1 is power gated by default
+#define PPSMC_MSG_PowerDownVcn0                 0x06 ///< Power down VCN0
+#define PPSMC_MSG_PowerUpVcn0                   0x07 ///< Power up VCN0; VCN0 is power gated by default
+#define PPSMC_MSG_SetHardMinVcn0                0x08 ///< For wireless display
 #define PPSMC_MSG_SetSoftMinGfxclk              0x09 ///< Set SoftMin for GFXCLK, argument is frequency in MHz
-#define PPSMC_MSG_SPARE2                        0x0A ///< SPARE
-#define PPSMC_MSG_SPARE3                        0x0B ///< SPARE
+#define PPSMC_MSG_SetHardMinVcn1                0x0A ///< For wireless display
+#define PPSMC_MSG_SetSoftMinVcn1                0x0B ///< Set soft min for VCN1 clocks (VCLK1 and DCLK1)
 #define PPSMC_MSG_PrepareMp1ForUnload           0x0C ///< Prepare PMFW for GFX driver unload
 #define PPSMC_MSG_SetDriverDramAddrHigh         0x0D ///< Set high 32 bits of DRAM address for Driver table transfer
 #define PPSMC_MSG_SetDriverDramAddrLow          0x0E ///< Set low 32 bits of DRAM address for Driver table transfer
@@ -71,7 +71,7 @@
 #define PPSMC_MSG_GetEnabledSmuFeatures         0x12 ///< Get enabled features in PMFW
 #define PPSMC_MSG_SetHardMinSocclkByFreq        0x13 ///< Set hard min for SOC CLK
 #define PPSMC_MSG_SetSoftMinFclk                0x14 ///< Set hard min for FCLK
-#define PPSMC_MSG_SetSoftMinVcn                 0x15 ///< Set soft min for VCN clocks (VCLK and DCLK)
+#define PPSMC_MSG_SetSoftMinVcn0                0x15 ///< Set soft min for VCN0 clocks (VCLK0 and DCLK0)
 
 #define PPSMC_MSG_EnableGfxImu                  0x16 ///< Enable GFX IMU
 
 
 #define PPSMC_MSG_SetSoftMaxSocclkByFreq        0x1D ///< Set soft max for SOC CLK
 #define PPSMC_MSG_SetSoftMaxFclkByFreq          0x1E ///< Set soft max for FCLK
-#define PPSMC_MSG_SetSoftMaxVcn                 0x1F ///< Set soft max for VCN clocks (VCLK and DCLK)
+#define PPSMC_MSG_SetSoftMaxVcn0                0x1F ///< Set soft max for VCN0 clocks (VCLK0 and DCLK0)
 #define PPSMC_MSG_spare_0x20                    0x20
-#define PPSMC_MSG_PowerDownJpeg                 0x21 ///< Power down Jpeg
-#define PPSMC_MSG_PowerUpJpeg                   0x22 ///< Power up Jpeg; VCN is power gated by default
+#define PPSMC_MSG_PowerDownJpeg0                0x21 ///< Power down Jpeg of VCN0
+#define PPSMC_MSG_PowerUpJpeg0                  0x22 ///< Power up Jpeg of VCN0; VCN0 is power gated by default
 
 #define PPSMC_MSG_SetHardMinFclkByFreq          0x23 ///< Set hard min for FCLK
 #define PPSMC_MSG_SetSoftMinSocclkByFreq        0x24 ///< Set soft min for SOC CLK
 #define PPSMC_MSG_AllowZstates                  0x25 ///< Inform PMFM of allowing Zstate entry, i.e. no Miracast activity
-#define PPSMC_MSG_Reserved                      0x26 ///< Not used
-#define PPSMC_MSG_Reserved1                     0x27 ///< Not used, previously PPSMC_MSG_RequestActiveWgp
-#define PPSMC_MSG_Reserved2                     0x28 ///< Not used, previously PPSMC_MSG_QueryActiveWgp
+#define PPSMC_MSG_PowerDownJpeg1                0x26 ///< Power down Jpeg of VCN1
+#define PPSMC_MSG_PowerUpJpeg1                  0x27 ///< Power up Jpeg of VCN1; VCN1 is power gated by default
+#define PPSMC_MSG_SetSoftMaxVcn1                0x28 ///< Set soft max for VCN1 clocks (VCLK1 and DCLK1)
 #define PPSMC_MSG_PowerDownIspByTile            0x29 ///< ISP is power gated by default
 #define PPSMC_MSG_PowerUpIspByTile              0x2A ///< This message is used to power up ISP tiles and enable the ISP DPM
 #define PPSMC_MSG_SetHardMinIspiclkByFreq       0x2B ///< Set HardMin by frequency for ISPICLK
index a941fdbf78b6b3a077303b67e0d3b0f95ae9089d..af427cc7dbb8450862484e27010e7d495fa28bb2 100644 (file)
        __SMU_DUMMY_MAP(PowerDownVcn),                 \
        __SMU_DUMMY_MAP(PowerUpJpeg),                  \
        __SMU_DUMMY_MAP(PowerDownJpeg),                \
+       __SMU_DUMMY_MAP(PowerUpJpeg0),                 \
+       __SMU_DUMMY_MAP(PowerDownJpeg0),               \
+       __SMU_DUMMY_MAP(PowerUpJpeg1),                 \
+       __SMU_DUMMY_MAP(PowerDownJpeg1),               \
        __SMU_DUMMY_MAP(BacoAudioD3PME),               \
        __SMU_DUMMY_MAP(ArmD3),                        \
        __SMU_DUMMY_MAP(RunDcBtc),                     \
        __SMU_DUMMY_MAP(PowerUpSdma),                 \
        __SMU_DUMMY_MAP(SetHardMinIspclkByFreq),      \
        __SMU_DUMMY_MAP(SetHardMinVcn),               \
+       __SMU_DUMMY_MAP(SetHardMinVcn0),               \
+       __SMU_DUMMY_MAP(SetHardMinVcn1),               \
        __SMU_DUMMY_MAP(SetAllowFclkSwitch),          \
        __SMU_DUMMY_MAP(SetMinVideoGfxclkFreq),       \
        __SMU_DUMMY_MAP(ActiveProcessNotify),         \
        __SMU_DUMMY_MAP(SetPhyclkVoltageByFreq),      \
        __SMU_DUMMY_MAP(SetDppclkVoltageByFreq),      \
        __SMU_DUMMY_MAP(SetSoftMinVcn),               \
+       __SMU_DUMMY_MAP(SetSoftMinVcn0),              \
+       __SMU_DUMMY_MAP(SetSoftMinVcn1),              \
        __SMU_DUMMY_MAP(EnablePostCode),              \
        __SMU_DUMMY_MAP(GetGfxclkFrequency),          \
        __SMU_DUMMY_MAP(GetFclkFrequency),            \
        __SMU_DUMMY_MAP(SetSoftMaxSocclkByFreq),      \
        __SMU_DUMMY_MAP(SetSoftMaxFclkByFreq),        \
        __SMU_DUMMY_MAP(SetSoftMaxVcn),               \
+       __SMU_DUMMY_MAP(SetSoftMaxVcn0),              \
+       __SMU_DUMMY_MAP(SetSoftMaxVcn1),              \
        __SMU_DUMMY_MAP(PowerGateMmHub),              \
        __SMU_DUMMY_MAP(UpdatePmeRestore),            \
        __SMU_DUMMY_MAP(GpuChangeState),              \
index b06a3cc433054244fb5d3069a8ba6ee8aee61255..9e39f99154f94df84495dbce069e2651f2b7f104 100644 (file)
@@ -1402,9 +1402,22 @@ int smu_v14_0_set_vcn_enable(struct smu_context *smu,
                if (adev->vcn.harvest_config & (1 << i))
                        continue;
 
-               ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
-                                                     SMU_MSG_PowerUpVcn : SMU_MSG_PowerDownVcn,
-                                                     i << 16U, NULL);
+               if (amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 0) ||
+                   amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 1)) {
+                       if (i == 0)
+                               ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                                     SMU_MSG_PowerUpVcn0 : SMU_MSG_PowerDownVcn0,
+                                                                     i << 16U, NULL);
+                       else if (i == 1)
+                               ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                                     SMU_MSG_PowerUpVcn1 : SMU_MSG_PowerDownVcn1,
+                                                                     i << 16U, NULL);
+               } else {
+                       ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                             SMU_MSG_PowerUpVcn : SMU_MSG_PowerDownVcn,
+                                                             i << 16U, NULL);
+               }
+
                if (ret)
                        return ret;
        }
@@ -1415,9 +1428,34 @@ int smu_v14_0_set_vcn_enable(struct smu_context *smu,
 int smu_v14_0_set_jpeg_enable(struct smu_context *smu,
                              bool enable)
 {
-       return smu_cmn_send_smc_msg_with_param(smu, enable ?
-                                              SMU_MSG_PowerUpJpeg : SMU_MSG_PowerDownJpeg,
-                                              0, NULL);
+       struct amdgpu_device *adev = smu->adev;
+       int i, ret = 0;
+
+       for (i = 0; i < adev->jpeg.num_jpeg_inst; i++) {
+               if (adev->jpeg.harvest_config & (1 << i))
+                       continue;
+
+               if (amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 0) ||
+                   amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 1)) {
+                       if (i == 0)
+                               ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                                     SMU_MSG_PowerUpJpeg0 : SMU_MSG_PowerDownJpeg0,
+                                                                     i << 16U, NULL);
+                       else if (i == 1 && amdgpu_ip_version(adev, MP1_HWIP, 0) == IP_VERSION(14, 0, 1))
+                               ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                                     SMU_MSG_PowerUpJpeg1 : SMU_MSG_PowerDownJpeg1,
+                                                                     i << 16U, NULL);
+               } else {
+                       ret = smu_cmn_send_smc_msg_with_param(smu, enable ?
+                                                             SMU_MSG_PowerUpJpeg : SMU_MSG_PowerDownJpeg,
+                                                             i << 16U, NULL);
+               }
+
+               if (ret)
+                       return ret;
+       }
+
+       return ret;
 }
 
 int smu_v14_0_run_btc(struct smu_context *smu)
index 9310c4758e38ce9791ba8d61ce61a2face051fe8..d6de6d97286c6990e24c79b318f533168c967bd0 100644 (file)
@@ -70,9 +70,12 @@ static struct cmn2asic_msg_mapping smu_v14_0_0_message_map[SMU_MSG_MAX_COUNT] =
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                          1),
        MSG_MAP(GetSmuVersion,                  PPSMC_MSG_GetPmfwVersion,                       1),
        MSG_MAP(GetDriverIfVersion,             PPSMC_MSG_GetDriverIfVersion,           1),
-       MSG_MAP(PowerDownVcn,                   PPSMC_MSG_PowerDownVcn,                         1),
-       MSG_MAP(PowerUpVcn,                     PPSMC_MSG_PowerUpVcn,                           1),
-       MSG_MAP(SetHardMinVcn,                  PPSMC_MSG_SetHardMinVcn,                        1),
+       MSG_MAP(PowerDownVcn0,                  PPSMC_MSG_PowerDownVcn0,                        1),
+       MSG_MAP(PowerUpVcn0,                    PPSMC_MSG_PowerUpVcn0,                          1),
+       MSG_MAP(SetHardMinVcn0,                 PPSMC_MSG_SetHardMinVcn0,                       1),
+       MSG_MAP(PowerDownVcn1,                  PPSMC_MSG_PowerDownVcn1,                        1),
+       MSG_MAP(PowerUpVcn1,                    PPSMC_MSG_PowerUpVcn1,                          1),
+       MSG_MAP(SetHardMinVcn1,                 PPSMC_MSG_SetHardMinVcn1,                       1),
        MSG_MAP(SetSoftMinGfxclk,               PPSMC_MSG_SetSoftMinGfxclk,                     1),
        MSG_MAP(PrepareMp1ForUnload,            PPSMC_MSG_PrepareMp1ForUnload,          1),
        MSG_MAP(SetDriverDramAddrHigh,          PPSMC_MSG_SetDriverDramAddrHigh,        1),
@@ -83,7 +86,8 @@ static struct cmn2asic_msg_mapping smu_v14_0_0_message_map[SMU_MSG_MAX_COUNT] =
        MSG_MAP(GetEnabledSmuFeatures,          PPSMC_MSG_GetEnabledSmuFeatures,        1),
        MSG_MAP(SetHardMinSocclkByFreq,         PPSMC_MSG_SetHardMinSocclkByFreq,       1),
        MSG_MAP(SetSoftMinFclk,                 PPSMC_MSG_SetSoftMinFclk,                       1),
-       MSG_MAP(SetSoftMinVcn,                  PPSMC_MSG_SetSoftMinVcn,                        1),
+       MSG_MAP(SetSoftMinVcn0,                 PPSMC_MSG_SetSoftMinVcn0,                       1),
+       MSG_MAP(SetSoftMinVcn1,                 PPSMC_MSG_SetSoftMinVcn1,                       1),
        MSG_MAP(EnableGfxImu,                   PPSMC_MSG_EnableGfxImu,                         1),
        MSG_MAP(AllowGfxOff,                    PPSMC_MSG_AllowGfxOff,                          1),
        MSG_MAP(DisallowGfxOff,                 PPSMC_MSG_DisallowGfxOff,                       1),
@@ -91,9 +95,12 @@ static struct cmn2asic_msg_mapping smu_v14_0_0_message_map[SMU_MSG_MAX_COUNT] =
        MSG_MAP(SetHardMinGfxClk,               PPSMC_MSG_SetHardMinGfxClk,                     1),
        MSG_MAP(SetSoftMaxSocclkByFreq,         PPSMC_MSG_SetSoftMaxSocclkByFreq,       1),
        MSG_MAP(SetSoftMaxFclkByFreq,           PPSMC_MSG_SetSoftMaxFclkByFreq,         1),
-       MSG_MAP(SetSoftMaxVcn,                  PPSMC_MSG_SetSoftMaxVcn,                        1),
-       MSG_MAP(PowerDownJpeg,                  PPSMC_MSG_PowerDownJpeg,                        1),
-       MSG_MAP(PowerUpJpeg,                    PPSMC_MSG_PowerUpJpeg,                          1),
+       MSG_MAP(SetSoftMaxVcn0,                 PPSMC_MSG_SetSoftMaxVcn0,                       1),
+       MSG_MAP(SetSoftMaxVcn1,                 PPSMC_MSG_SetSoftMaxVcn1,                       1),
+       MSG_MAP(PowerDownJpeg0,                 PPSMC_MSG_PowerDownJpeg0,                       1),
+       MSG_MAP(PowerUpJpeg0,                   PPSMC_MSG_PowerUpJpeg0,                         1),
+       MSG_MAP(PowerDownJpeg1,                 PPSMC_MSG_PowerDownJpeg1,                       1),
+       MSG_MAP(PowerUpJpeg1,                   PPSMC_MSG_PowerUpJpeg1,                         1),
        MSG_MAP(SetHardMinFclkByFreq,           PPSMC_MSG_SetHardMinFclkByFreq,         1),
        MSG_MAP(SetSoftMinSocclkByFreq,         PPSMC_MSG_SetSoftMinSocclkByFreq,       1),
        MSG_MAP(PowerDownIspByTile,             PPSMC_MSG_PowerDownIspByTile,           1),
index 266826eac4a75bc50fbbf3ba0830c599bf0c285f..f5d4be897866093a68c0d4f41380b3fdc20aaa85 100644 (file)
@@ -4111,6 +4111,13 @@ int drm_dp_bw_overhead(int lane_count, int hactive,
        u32 overhead = 1000000;
        int symbol_cycles;
 
+       if (lane_count == 0 || hactive == 0 || bpp_x16 == 0) {
+               DRM_DEBUG_KMS("Invalid BW overhead params: lane_count %d, hactive %d, bpp_x16 %d.%04d\n",
+                             lane_count, hactive,
+                             bpp_x16 >> 4, (bpp_x16 & 0xf) * 625);
+               return 0;
+       }
+
        /*
         * DP Standard v2.1 2.6.4.1
         * SSC downspread and ref clock variation margin:
index 3ef6ed41e62b4a05af99cb9e91f8dbe250b7a684..4c2f85632391a669c35012439094250e5e9c6dc5 100644 (file)
@@ -33,9 +33,9 @@ endif
 subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
 
 # Fine grained warnings disable
-CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
-CFLAGS_display/intel_display_device.o = $(call cc-disable-warning, override-init)
-CFLAGS_display/intel_fbdev.o = $(call cc-disable-warning, override-init)
+CFLAGS_i915_pci.o = -Wno-override-init
+CFLAGS_display/intel_display_device.o = -Wno-override-init
+CFLAGS_display/intel_fbdev.o = -Wno-override-init
 
 # Support compiling the display code separately for both i915 and xe
 # drivers. Define I915 when building i915.
index dfe0b07a122d15dec8315dad54e5eace4a2de109..06ec04e667e32f7d56459912a033b4cecbd643db 100644 (file)
@@ -717,7 +717,6 @@ static void g4x_enable_dp(struct intel_atomic_state *state,
 {
        intel_enable_dp(state, encoder, pipe_config, conn_state);
        intel_edp_backlight_on(pipe_config, conn_state);
-       encoder->audio_enable(encoder, pipe_config, conn_state);
 }
 
 static void vlv_enable_dp(struct intel_atomic_state *state,
@@ -726,7 +725,6 @@ static void vlv_enable_dp(struct intel_atomic_state *state,
                          const struct drm_connector_state *conn_state)
 {
        intel_edp_backlight_on(pipe_config, conn_state);
-       encoder->audio_enable(encoder, pipe_config, conn_state);
 }
 
 static void g4x_pre_enable_dp(struct intel_atomic_state *state,
index eda4a8b885904de71bb6e3bb1998fa1242a1b9a7..ac456a2275dbad62cb9a4ac7f706333c73dd03aa 100644 (file)
@@ -1155,7 +1155,6 @@ static void gen11_dsi_powerup_panel(struct intel_encoder *encoder)
        }
 
        intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);
-       intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_ON);
 
        /* ensure all panel commands dispatched before enabling transcoder */
        wait_for_cmds_dispatched_to_panel(encoder);
@@ -1256,6 +1255,8 @@ static void gen11_dsi_enable(struct intel_atomic_state *state,
        /* step6d: enable dsi transcoder */
        gen11_dsi_enable_transcoder(encoder);
 
+       intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_DISPLAY_ON);
+
        /* step7: enable backlight */
        intel_backlight_enable(crtc_state, conn_state);
        intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON);
index fe52c06271ef0588647b4cd68b3bee5689747f29..52bd3576835b6ba15b31d8e17a94e9b65f612b1c 100644 (file)
@@ -1955,16 +1955,12 @@ static int get_init_otp_deassert_fragment_len(struct drm_i915_private *i915,
  * these devices we split the init OTP sequence into a deassert sequence and
  * the actual init OTP part.
  */
-static void fixup_mipi_sequences(struct drm_i915_private *i915,
-                                struct intel_panel *panel)
+static void vlv_fixup_mipi_sequences(struct drm_i915_private *i915,
+                                    struct intel_panel *panel)
 {
        u8 *init_otp;
        int len;
 
-       /* Limit this to VLV for now. */
-       if (!IS_VALLEYVIEW(i915))
-               return;
-
        /* Limit this to v1 vid-mode sequences */
        if (panel->vbt.dsi.config->is_cmd_mode ||
            panel->vbt.dsi.seq_version != 1)
@@ -2000,6 +1996,41 @@ static void fixup_mipi_sequences(struct drm_i915_private *i915,
        panel->vbt.dsi.sequence[MIPI_SEQ_INIT_OTP] = init_otp + len - 1;
 }
 
+/*
+ * Some machines (eg. Lenovo 82TQ) appear to have broken
+ * VBT sequences:
+ * - INIT_OTP is not present at all
+ * - what should be in INIT_OTP is in DISPLAY_ON
+ * - what should be in DISPLAY_ON is in BACKLIGHT_ON
+ *   (along with the actual backlight stuff)
+ *
+ * To make those work we simply swap DISPLAY_ON and INIT_OTP.
+ *
+ * TODO: Do we need to limit this to specific machines,
+ *       or examine the contents of the sequences to
+ *       avoid false positives?
+ */
+static void icl_fixup_mipi_sequences(struct drm_i915_private *i915,
+                                    struct intel_panel *panel)
+{
+       if (!panel->vbt.dsi.sequence[MIPI_SEQ_INIT_OTP] &&
+           panel->vbt.dsi.sequence[MIPI_SEQ_DISPLAY_ON]) {
+               drm_dbg_kms(&i915->drm, "Broken VBT: Swapping INIT_OTP and DISPLAY_ON sequences\n");
+
+               swap(panel->vbt.dsi.sequence[MIPI_SEQ_INIT_OTP],
+                    panel->vbt.dsi.sequence[MIPI_SEQ_DISPLAY_ON]);
+       }
+}
+
+static void fixup_mipi_sequences(struct drm_i915_private *i915,
+                                struct intel_panel *panel)
+{
+       if (DISPLAY_VER(i915) >= 11)
+               icl_fixup_mipi_sequences(i915, panel);
+       else if (IS_VALLEYVIEW(i915))
+               vlv_fixup_mipi_sequences(i915, panel);
+}
+
 static void
 parse_mipi_sequence(struct drm_i915_private *i915,
                    struct intel_panel *panel)
@@ -3351,6 +3382,9 @@ bool intel_bios_encoder_supports_dp_dual_mode(const struct intel_bios_encoder_da
 {
        const struct child_device_config *child = &devdata->child;
 
+       if (!devdata)
+               return false;
+
        if (!intel_bios_encoder_supports_dp(devdata) ||
            !intel_bios_encoder_supports_hdmi(devdata))
                return false;
index f8b33999d43fccdba84fd2f26f650356423d2bc3..0d3da55e1c24d51aa190f4b76aa7b20d5260038d 100644 (file)
@@ -36,12 +36,10 @@ static u32 intel_cursor_base(const struct intel_plane_state *plane_state)
 {
        struct drm_i915_private *dev_priv =
                to_i915(plane_state->uapi.plane->dev);
-       const struct drm_framebuffer *fb = plane_state->hw.fb;
-       struct drm_i915_gem_object *obj = intel_fb_obj(fb);
        u32 base;
 
        if (DISPLAY_INFO(dev_priv)->cursor_needs_physical)
-               base = i915_gem_object_get_dma_address(obj, 0);
+               base = plane_state->phys_dma_addr;
        else
                base = intel_plane_ggtt_offset(plane_state);
 
index e67cd5b02e84ff859588fd152f147c35d4296e42..9104f18753b484fde2b439f85494fc77a3d27c87 100644 (file)
@@ -727,6 +727,7 @@ struct intel_plane_state {
 #define PLANE_HAS_FENCE BIT(0)
 
        struct intel_fb_view view;
+       u32 phys_dma_addr; /* for cursor_needs_physical */
 
        /* Plane pxp decryption state */
        bool decrypt;
index f0c3ed37b350b901d984ec0383e19eee6a23836d..f98ef4b42a448f57d5dfaf0459cba23a00946870 100644 (file)
@@ -67,6 +67,7 @@
 #include "intel_dp_tunnel.h"
 #include "intel_dpio_phy.h"
 #include "intel_dpll.h"
+#include "intel_drrs.h"
 #include "intel_fifo_underrun.h"
 #include "intel_hdcp.h"
 #include "intel_hdmi.h"
@@ -2683,15 +2684,6 @@ intel_dp_compute_hdr_metadata_infoframe_sdp(struct intel_dp *intel_dp,
                intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GAMUT_METADATA);
 }
 
-static bool cpu_transcoder_has_drrs(struct drm_i915_private *i915,
-                                   enum transcoder cpu_transcoder)
-{
-       if (HAS_DOUBLE_BUFFERED_M_N(i915))
-               return true;
-
-       return intel_cpu_transcoder_has_m2_n2(i915, cpu_transcoder);
-}
-
 static bool can_enable_drrs(struct intel_connector *connector,
                            const struct intel_crtc_state *pipe_config,
                            const struct drm_display_mode *downclock_mode)
@@ -2714,7 +2706,7 @@ static bool can_enable_drrs(struct intel_connector *connector,
        if (pipe_config->has_pch_encoder)
                return false;
 
-       if (!cpu_transcoder_has_drrs(i915, pipe_config->cpu_transcoder))
+       if (!intel_cpu_transcoder_has_drrs(i915, pipe_config->cpu_transcoder))
                return false;
 
        return downclock_mode &&
index ff480f171f75a2602673e49c015a1f0441e33a53..b6d24410740f8599418f7b9419f2881b9ede7bc0 100644 (file)
@@ -2554,7 +2554,7 @@ static void icl_wrpll_params_populate(struct skl_wrpll_params *params,
 static bool
 ehl_combo_pll_div_frac_wa_needed(struct drm_i915_private *i915)
 {
-       return (((IS_ELKHARTLAKE(i915) || IS_JASPERLAKE(i915)) &&
+       return ((IS_ELKHARTLAKE(i915) &&
                 IS_DISPLAY_STEP(i915, STEP_B0, STEP_FOREVER)) ||
                 IS_TIGERLAKE(i915) || IS_ALDERLAKE_S(i915) || IS_ALDERLAKE_P(i915)) &&
                 i915->display.dpll.ref_clks.nssc == 38400;
index 169ef38ff1883389032b0084c9c88d8f1dc6a758..597f8bd6aa1a0e5088a82146a188a235536ee591 100644 (file)
@@ -63,6 +63,15 @@ const char *intel_drrs_type_str(enum drrs_type drrs_type)
        return str[drrs_type];
 }
 
+bool intel_cpu_transcoder_has_drrs(struct drm_i915_private *i915,
+                                  enum transcoder cpu_transcoder)
+{
+       if (HAS_DOUBLE_BUFFERED_M_N(i915))
+               return true;
+
+       return intel_cpu_transcoder_has_m2_n2(i915, cpu_transcoder);
+}
+
 static void
 intel_drrs_set_refresh_rate_pipeconf(struct intel_crtc *crtc,
                                     enum drrs_refresh_rate refresh_rate)
@@ -312,9 +321,8 @@ static int intel_drrs_debugfs_status_show(struct seq_file *m, void *unused)
        mutex_lock(&crtc->drrs.mutex);
 
        seq_printf(m, "DRRS capable: %s\n",
-                  str_yes_no(crtc_state->has_drrs ||
-                             HAS_DOUBLE_BUFFERED_M_N(i915) ||
-                             intel_cpu_transcoder_has_m2_n2(i915, crtc_state->cpu_transcoder)));
+                  str_yes_no(intel_cpu_transcoder_has_drrs(i915,
+                                                           crtc_state->cpu_transcoder)));
 
        seq_printf(m, "DRRS enabled: %s\n",
                   str_yes_no(crtc_state->has_drrs));
index 8ef5f93a80ffd52b6e8376972efe47455e64f94c..0982f95eab727a4f48b6da749646e8a6f96147bd 100644 (file)
@@ -9,12 +9,15 @@
 #include <linux/types.h>
 
 enum drrs_type;
+enum transcoder;
 struct drm_i915_private;
 struct intel_atomic_state;
 struct intel_crtc;
 struct intel_crtc_state;
 struct intel_connector;
 
+bool intel_cpu_transcoder_has_drrs(struct drm_i915_private *i915,
+                                  enum transcoder cpu_transcoder);
 const char *intel_drrs_type_str(enum drrs_type drrs_type);
 bool intel_drrs_is_active(struct intel_crtc *crtc);
 void intel_drrs_activate(const struct intel_crtc_state *crtc_state);
index d62e050185e7c3cf4d8ecb4e4ceaabbdc20a0db9..e4515bf920388e317dd60e5fa1e5e40b9efa4de4 100644 (file)
@@ -340,6 +340,17 @@ static int intel_dsb_dewake_scanline(const struct intel_crtc_state *crtc_state)
        return max(0, vblank_start - intel_usecs_to_scanlines(adjusted_mode, latency));
 }
 
+static u32 dsb_chicken(struct intel_crtc *crtc)
+{
+       if (crtc->mode_flags & I915_MODE_FLAG_VRR)
+               return DSB_CTRL_WAIT_SAFE_WINDOW |
+                       DSB_CTRL_NO_WAIT_VBLANK |
+                       DSB_INST_WAIT_SAFE_WINDOW |
+                       DSB_INST_NO_WAIT_VBLANK;
+       else
+               return 0;
+}
+
 static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
                              int dewake_scanline)
 {
@@ -361,6 +372,9 @@ static void _intel_dsb_commit(struct intel_dsb *dsb, u32 ctrl,
        intel_de_write_fw(dev_priv, DSB_CTRL(pipe, dsb->id),
                          ctrl | DSB_ENABLE);
 
+       intel_de_write_fw(dev_priv, DSB_CHICKEN(pipe, dsb->id),
+                         dsb_chicken(crtc));
+
        intel_de_write_fw(dev_priv, DSB_HEAD(pipe, dsb->id),
                          intel_dsb_buffer_ggtt_offset(&dsb->dsb_buf));
 
index 7b42aef37d2f72275603e9f80950ae1edd55d203..b6df9baf481b6958ee42f35457b7b37c294ddb65 100644 (file)
@@ -255,6 +255,16 @@ int intel_plane_pin_fb(struct intel_plane_state *plane_state)
                        return PTR_ERR(vma);
 
                plane_state->ggtt_vma = vma;
+
+               /*
+                * Pre-populate the dma address before we enter the vblank
+                * evade critical section as i915_gem_object_get_dma_address()
+                * will trigger might_sleep() even if it won't actually sleep,
+                * which is the case when the fb has already been pinned.
+                */
+               if (phys_cursor)
+                       plane_state->phys_dma_addr =
+                               i915_gem_object_get_dma_address(intel_fb_obj(fb), 0);
        } else {
                struct intel_framebuffer *intel_fb = to_intel_framebuffer(fb);
 
index 5f9e748adc89ee846de12974195e17ab38e14b21..0cd9c183f6212ff55b3b6902df1ef752dc54f5ee 100644 (file)
@@ -1842,8 +1842,6 @@ static void intel_disable_sdvo(struct intel_atomic_state *state,
        struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->uapi.crtc);
        u32 temp;
 
-       encoder->audio_disable(encoder, old_crtc_state, conn_state);
-
        intel_sdvo_set_active_outputs(intel_sdvo, 0);
        if (0)
                intel_sdvo_set_encoder_power_state(intel_sdvo,
@@ -1935,8 +1933,6 @@ static void intel_enable_sdvo(struct intel_atomic_state *state,
                intel_sdvo_set_encoder_power_state(intel_sdvo,
                                                   DRM_MODE_DPMS_ON);
        intel_sdvo_set_active_outputs(intel_sdvo, intel_sdvo_connector->output_flag);
-
-       encoder->audio_enable(encoder, pipe_config, conn_state);
 }
 
 static enum drm_mode_status
index 5d905f932cb4b3f6bdcc65a249570f510046c162..eb5bd0743902065d9b4bcac060d1fd340d448069 100644 (file)
@@ -187,10 +187,11 @@ void intel_vrr_set_transcoder_timings(const struct intel_crtc_state *crtc_state)
        enum transcoder cpu_transcoder = crtc_state->cpu_transcoder;
 
        /*
-        * TRANS_SET_CONTEXT_LATENCY with VRR enabled
-        * requires this chicken bit on ADL/DG2.
+        * This bit seems to have two meanings depending on the platform:
+        * TGL: generate VRR "safe window" for DSB vblank waits
+        * ADL/DG2: make TRANS_SET_CONTEXT_LATENCY effective with VRR
         */
-       if (DISPLAY_VER(dev_priv) == 13)
+       if (IS_DISPLAY_VER(dev_priv, 12, 13))
                intel_de_rmw(dev_priv, CHICKEN_TRANS(cpu_transcoder),
                             0, PIPE_VBLANK_WITH_DELAY);
 
index e941e2e4fd14c2ce489d5e7a162853723b47b7d4..860574d04f881a02aa183dd831bce1070343c75c 100644 (file)
@@ -2295,6 +2295,9 @@ static u8 skl_get_plane_caps(struct drm_i915_private *i915,
        if (HAS_4TILE(i915))
                caps |= INTEL_PLANE_CAP_TILING_4;
 
+       if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(i915))
+               return caps;
+
        if (skl_plane_has_rc_ccs(i915, pipe, plane_id)) {
                caps |= INTEL_PLANE_CAP_CCS_RC;
                if (DISPLAY_VER(i915) >= 12)
index 96bdb93a948d1b8810485c25e16c122334fbaac8..fb7bff27b45a343fac53d70f587285a1cca4df55 100644 (file)
@@ -279,9 +279,6 @@ static int __engine_park(struct intel_wakeref *wf)
        intel_engine_park_heartbeat(engine);
        intel_breadcrumbs_park(engine->breadcrumbs);
 
-       /* Must be reset upon idling, or we may miss the busy wakeup. */
-       GEM_BUG_ON(engine->sched_engine->queue_priority_hint != INT_MIN);
-
        if (engine->park)
                engine->park(engine);
 
index 42aade0faf2d14d3ff87178c821e0fe24ef23bb1..b061a0a0d6b082021287bcd16a79bed6ed16eb27 100644 (file)
@@ -3272,6 +3272,9 @@ static void execlists_park(struct intel_engine_cs *engine)
 {
        cancel_timer(&engine->execlists.timer);
        cancel_timer(&engine->execlists.preempt);
+
+       /* Reset upon idling, or we may delay the busy wakeup. */
+       WRITE_ONCE(engine->sched_engine->queue_priority_hint, INT_MIN);
 }
 
 static void add_to_engine(struct i915_request *rq)
index d67d44611c2834e5a76df5bee9a972e0974bb589..25413809b9dc99734409210259a9f51f1fffad88 100644 (file)
@@ -1653,6 +1653,7 @@ static void
 xelpg_gt_workarounds_init(struct intel_gt *gt, struct i915_wa_list *wal)
 {
        /* Wa_14018575942 / Wa_18018781329 */
+       wa_mcr_write_or(wal, RENDER_MOD_CTRL, FORCE_MISS_FTLB);
        wa_mcr_write_or(wal, COMP_MOD_CTRL, FORCE_MISS_FTLB);
 
        /* Wa_22016670082 */
index 9ee902d5b72c491152d42f197da8cb85008b00bd..4b9233c07a22c6e12d4705c37a44fe6fe920d40f 100644 (file)
@@ -800,7 +800,7 @@ int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                goto out_cleanup_modeset2;
 
        ret = intel_pxp_init(i915);
-       if (ret != -ENODEV)
+       if (ret && ret != -ENODEV)
                drm_dbg(&i915->drm, "pxp init failed with %d\n", ret);
 
        ret = intel_display_driver_probe(i915);
index 8c3f443c8347e06f5f09700108f4a11c1e903f3b..b758fd110c2045ef8f02a49314ca2d6b6adc7b23 100644 (file)
@@ -72,12 +72,13 @@ hwm_locked_with_pm_intel_uncore_rmw(struct hwm_drvdata *ddat,
        struct intel_uncore *uncore = ddat->uncore;
        intel_wakeref_t wakeref;
 
-       mutex_lock(&hwmon->hwmon_lock);
+       with_intel_runtime_pm(uncore->rpm, wakeref) {
+               mutex_lock(&hwmon->hwmon_lock);
 
-       with_intel_runtime_pm(uncore->rpm, wakeref)
                intel_uncore_rmw(uncore, reg, clear, set);
 
-       mutex_unlock(&hwmon->hwmon_lock);
+               mutex_unlock(&hwmon->hwmon_lock);
+       }
 }
 
 /*
@@ -136,20 +137,21 @@ hwm_energy(struct hwm_drvdata *ddat, long *energy)
        else
                rgaddr = hwmon->rg.energy_status_all;
 
-       mutex_lock(&hwmon->hwmon_lock);
+       with_intel_runtime_pm(uncore->rpm, wakeref) {
+               mutex_lock(&hwmon->hwmon_lock);
 
-       with_intel_runtime_pm(uncore->rpm, wakeref)
                reg_val = intel_uncore_read(uncore, rgaddr);
 
-       if (reg_val >= ei->reg_val_prev)
-               ei->accum_energy += reg_val - ei->reg_val_prev;
-       else
-               ei->accum_energy += UINT_MAX - ei->reg_val_prev + reg_val;
-       ei->reg_val_prev = reg_val;
+               if (reg_val >= ei->reg_val_prev)
+                       ei->accum_energy += reg_val - ei->reg_val_prev;
+               else
+                       ei->accum_energy += UINT_MAX - ei->reg_val_prev + reg_val;
+               ei->reg_val_prev = reg_val;
 
-       *energy = mul_u64_u32_shr(ei->accum_energy, SF_ENERGY,
-                                 hwmon->scl_shift_energy);
-       mutex_unlock(&hwmon->hwmon_lock);
+               *energy = mul_u64_u32_shr(ei->accum_energy, SF_ENERGY,
+                                         hwmon->scl_shift_energy);
+               mutex_unlock(&hwmon->hwmon_lock);
+       }
 }
 
 static ssize_t
@@ -404,6 +406,7 @@ hwm_power_max_write(struct hwm_drvdata *ddat, long val)
 
        /* Block waiting for GuC reset to complete when needed */
        for (;;) {
+               wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
                mutex_lock(&hwmon->hwmon_lock);
 
                prepare_to_wait(&ddat->waitq, &wait, TASK_INTERRUPTIBLE);
@@ -417,14 +420,13 @@ hwm_power_max_write(struct hwm_drvdata *ddat, long val)
                }
 
                mutex_unlock(&hwmon->hwmon_lock);
+               intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
 
                schedule();
        }
        finish_wait(&ddat->waitq, &wait);
        if (ret)
-               goto unlock;
-
-       wakeref = intel_runtime_pm_get(ddat->uncore->rpm);
+               goto exit;
 
        /* Disable PL1 limit and verify, because the limit cannot be disabled on all platforms */
        if (val == PL1_DISABLE) {
@@ -444,9 +446,8 @@ hwm_power_max_write(struct hwm_drvdata *ddat, long val)
        intel_uncore_rmw(ddat->uncore, hwmon->rg.pkg_rapl_limit,
                         PKG_PWR_LIM_1_EN | PKG_PWR_LIM_1, nval);
 exit:
-       intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
-unlock:
        mutex_unlock(&hwmon->hwmon_lock);
+       intel_runtime_pm_put(ddat->uncore->rpm, wakeref);
        return ret;
 }
 
index ba82277254b7622fe733995b6c47207d57d87265..cc41974cee746290799c5721cd57bf95b6b17954 100644 (file)
@@ -25,6 +25,8 @@
 #include <linux/kernel.h>
 #include <linux/string.h>
 #include <linux/cpufeature.h>
+#include <linux/bug.h>
+#include <linux/build_bug.h>
 #include <asm/fpu/api.h>
 
 #include "i915_memcpy.h"
index e00557e1a57f0cc69ed71dd3dc0e29b8c06cebb1..3b2e49ce29ba03d055f32aab83ea8f048b49c3a9 100644 (file)
 #define MTL_CHICKEN_TRANS(trans)       _MMIO_TRANS((trans), \
                                                    _MTL_CHICKEN_TRANS_A, \
                                                    _MTL_CHICKEN_TRANS_B)
-#define   PIPE_VBLANK_WITH_DELAY       REG_BIT(31) /* ADL/DG2 */
+#define   PIPE_VBLANK_WITH_DELAY       REG_BIT(31) /* tgl+ */
 #define   SKL_UNMASK_VBL_TO_PIPE_IN_SRD        REG_BIT(30) /* skl+ */
 #define   HSW_FRAME_START_DELAY_MASK   REG_GENMASK(28, 27)
 #define   HSW_FRAME_START_DELAY(x)     REG_FIELD_PREP(HSW_FRAME_START_DELAY_MASK, x)
index d09aad34ba37fa20c7b6e1db641dbf05e7ba9307..b70715b1411d67bfb48ff70aa5a97b49db035f3b 100644 (file)
@@ -34,6 +34,7 @@
 #include "gt/intel_engine.h"
 #include "gt/intel_engine_heartbeat.h"
 #include "gt/intel_gt.h"
+#include "gt/intel_gt_pm.h"
 #include "gt/intel_gt_requests.h"
 #include "gt/intel_tlb.h"
 
@@ -103,12 +104,42 @@ static inline struct i915_vma *active_to_vma(struct i915_active *ref)
 
 static int __i915_vma_active(struct i915_active *ref)
 {
-       return i915_vma_tryget(active_to_vma(ref)) ? 0 : -ENOENT;
+       struct i915_vma *vma = active_to_vma(ref);
+
+       if (!i915_vma_tryget(vma))
+               return -ENOENT;
+
+       /*
+        * Exclude global GTT VMA from holding a GT wakeref
+        * while active, otherwise GPU never goes idle.
+        */
+       if (!i915_vma_is_ggtt(vma)) {
+               /*
+                * Since we and our _retire() counterpart can be
+                * called asynchronously, storing a wakeref tracking
+                * handle inside struct i915_vma is not safe, and
+                * there is no other good place for that.  Hence,
+                * use untracked variants of intel_gt_pm_get/put().
+                */
+               intel_gt_pm_get_untracked(vma->vm->gt);
+       }
+
+       return 0;
 }
 
 static void __i915_vma_retire(struct i915_active *ref)
 {
-       i915_vma_put(active_to_vma(ref));
+       struct i915_vma *vma = active_to_vma(ref);
+
+       if (!i915_vma_is_ggtt(vma)) {
+               /*
+                * Since we can be called from atomic contexts,
+                * use an async variant of intel_gt_pm_put().
+                */
+               intel_gt_pm_put_async_untracked(vma->vm->gt);
+       }
+
+       i915_vma_put(vma);
 }
 
 static struct i915_vma *
@@ -1404,7 +1435,7 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
        struct i915_vma_work *work = NULL;
        struct dma_fence *moving = NULL;
        struct i915_vma_resource *vma_res = NULL;
-       intel_wakeref_t wakeref = 0;
+       intel_wakeref_t wakeref;
        unsigned int bound;
        int err;
 
@@ -1424,8 +1455,14 @@ int i915_vma_pin_ww(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
        if (err)
                return err;
 
-       if (flags & PIN_GLOBAL)
-               wakeref = intel_runtime_pm_get(&vma->vm->i915->runtime_pm);
+       /*
+        * In case of a global GTT, we must hold a runtime-pm wakeref
+        * while global PTEs are updated.  In other cases, we hold
+        * the rpm reference while the VMA is active.  Since runtime
+        * resume may require allocations, which are forbidden inside
+        * vm->mutex, get the first rpm wakeref outside of the mutex.
+        */
+       wakeref = intel_runtime_pm_get(&vma->vm->i915->runtime_pm);
 
        if (flags & vma->vm->bind_async_flags) {
                /* lock VM */
@@ -1561,8 +1598,7 @@ err_fence:
        if (work)
                dma_fence_work_commit_imm(&work->base);
 err_rpm:
-       if (wakeref)
-               intel_runtime_pm_put(&vma->vm->i915->runtime_pm, wakeref);
+       intel_runtime_pm_put(&vma->vm->i915->runtime_pm, wakeref);
 
        if (moving)
                dma_fence_put(moving);
index 12feecf71e752de075eaa94d7d3de9ec5a9e082b..6fb65b01d778049f9166681e26a7fdf85891e475 100644 (file)
@@ -378,9 +378,9 @@ nouveau_dmem_evict_chunk(struct nouveau_dmem_chunk *chunk)
        dma_addr_t *dma_addrs;
        struct nouveau_fence *fence;
 
-       src_pfns = kcalloc(npages, sizeof(*src_pfns), GFP_KERNEL);
-       dst_pfns = kcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL);
-       dma_addrs = kcalloc(npages, sizeof(*dma_addrs), GFP_KERNEL);
+       src_pfns = kvcalloc(npages, sizeof(*src_pfns), GFP_KERNEL | __GFP_NOFAIL);
+       dst_pfns = kvcalloc(npages, sizeof(*dst_pfns), GFP_KERNEL | __GFP_NOFAIL);
+       dma_addrs = kvcalloc(npages, sizeof(*dma_addrs), GFP_KERNEL | __GFP_NOFAIL);
 
        migrate_device_range(src_pfns, chunk->pagemap.range.start >> PAGE_SHIFT,
                        npages);
@@ -406,11 +406,11 @@ nouveau_dmem_evict_chunk(struct nouveau_dmem_chunk *chunk)
        migrate_device_pages(src_pfns, dst_pfns, npages);
        nouveau_dmem_fence_done(&fence);
        migrate_device_finalize(src_pfns, dst_pfns, npages);
-       kfree(src_pfns);
-       kfree(dst_pfns);
+       kvfree(src_pfns);
+       kvfree(dst_pfns);
        for (i = 0; i < npages; i++)
                dma_unmap_page(chunk->drm->dev->dev, dma_addrs[i], PAGE_SIZE, DMA_BIDIRECTIONAL);
-       kfree(dma_addrs);
+       kvfree(dma_addrs);
 }
 
 void
index 281edab518cdd367852c485c666b7a9d0288e3f0..d6ea01f3797be710da32e5ebb05e30d58e877ca8 100644 (file)
@@ -421,7 +421,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev,
 {
        uint32_t handle;
        int idr_ret;
-       int count = 0;
 again:
        idr_preload(GFP_ATOMIC);
        spin_lock(&qdev->surf_id_idr_lock);
@@ -433,7 +432,6 @@ again:
        handle = idr_ret;
 
        if (handle >= qdev->rom->n_surfaces) {
-               count++;
                spin_lock(&qdev->surf_id_idr_lock);
                idr_remove(&qdev->surf_id_idr, handle);
                spin_unlock(&qdev->surf_id_idr_lock);
index dd0f834d881ce1b4b48249165e42bb73122d81ce..506ae1f5e099ff2a9c21989ea175d8369bda6976 100644 (file)
@@ -145,7 +145,7 @@ static int qxl_process_single_command(struct qxl_device *qdev,
        struct qxl_release *release;
        struct qxl_bo *cmd_bo;
        void *fb_cmd;
-       int i, ret, num_relocs;
+       int i, ret;
        int unwritten;
 
        switch (cmd->type) {
@@ -200,7 +200,6 @@ static int qxl_process_single_command(struct qxl_device *qdev,
        }
 
        /* fill out reloc info structs */
-       num_relocs = 0;
        for (i = 0; i < cmd->relocs_num; ++i) {
                struct drm_qxl_reloc reloc;
                struct drm_qxl_reloc __user *u = u64_to_user_ptr(cmd->relocs);
@@ -230,7 +229,6 @@ static int qxl_process_single_command(struct qxl_device *qdev,
                        reloc_info[i].dst_bo = cmd_bo;
                        reloc_info[i].dst_offset = reloc.dst_offset + release->release_offset;
                }
-               num_relocs++;
 
                /* reserve and validate the reloc dst bo */
                if (reloc.reloc_type == QXL_RELOC_TYPE_BO || reloc.src_handle) {
index 48170694ac6b89335fd40f00c668ab9df7f2d824..18efb3fe1c000f691131dabccb2d6965763c8e07 100644 (file)
@@ -17,9 +17,7 @@
 
 static const uint32_t formats_cluster[] = {
        DRM_FORMAT_XRGB2101010,
-       DRM_FORMAT_ARGB2101010,
        DRM_FORMAT_XBGR2101010,
-       DRM_FORMAT_ABGR2101010,
        DRM_FORMAT_XRGB8888,
        DRM_FORMAT_ARGB8888,
        DRM_FORMAT_XBGR8888,
index 3c4f5a392b0646124a88b81715f4463d4db19ff1..58c8161289fea9dfdb07c5b65a5b3ec682d918a7 100644 (file)
@@ -71,13 +71,19 @@ int drm_sched_entity_init(struct drm_sched_entity *entity,
        entity->guilty = guilty;
        entity->num_sched_list = num_sched_list;
        entity->priority = priority;
+       /*
+        * It's perfectly valid to initialize an entity without having a valid
+        * scheduler attached. It's just not valid to use the scheduler before it
+        * is initialized itself.
+        */
        entity->sched_list = num_sched_list > 1 ? sched_list : NULL;
        RCU_INIT_POINTER(entity->last_scheduled, NULL);
        RB_CLEAR_NODE(&entity->rb_tree_node);
 
-       if (!sched_list[0]->sched_rq) {
-               /* Warn drivers not to do this and to fix their DRM
-                * calling order.
+       if (num_sched_list && !sched_list[0]->sched_rq) {
+               /* Since every entry covered by num_sched_list
+                * should be non-NULL and therefore we warn drivers
+                * not to do this and to fix their DRM calling order.
                 */
                pr_warn("%s: called with uninitialized scheduler\n", __func__);
        } else if (num_sched_list) {
index d3e308fdfd5be80bb5c8a606eccceae82810da9a..c7d90f96d16a67beddf9395cf1ad611cb6f1cf34 100644 (file)
@@ -1444,12 +1444,15 @@ static void vmw_debugfs_resource_managers_init(struct vmw_private *vmw)
                                            root, "system_ttm");
        ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, TTM_PL_VRAM),
                                            root, "vram_ttm");
-       ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_GMR),
-                                           root, "gmr_ttm");
-       ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_MOB),
-                                           root, "mob_ttm");
-       ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_SYSTEM),
-                                           root, "system_mob_ttm");
+       if (vmw->has_gmr)
+               ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_GMR),
+                                                   root, "gmr_ttm");
+       if (vmw->has_mob) {
+               ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_MOB),
+                                                   root, "mob_ttm");
+               ttm_resource_manager_create_debugfs(ttm_manager_type(&vmw->bdev, VMW_PL_SYSTEM),
+                                                   root, "system_mob_ttm");
+       }
 }
 
 static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val,
index 5a428ca00f10f23b72c1b700a88e0da0d4de78d4..c29a850859ad5a6af449d0e05d4ce8c6d3c2173e 100644 (file)
@@ -172,8 +172,8 @@ subdir-ccflags-$(CONFIG_DRM_XE_DISPLAY) += \
        -Ddrm_i915_gem_object=xe_bo \
        -Ddrm_i915_private=xe_device
 
-CFLAGS_i915-display/intel_fbdev.o = $(call cc-disable-warning, override-init)
-CFLAGS_i915-display/intel_display_device.o = $(call cc-disable-warning, override-init)
+CFLAGS_i915-display/intel_fbdev.o = -Wno-override-init
+CFLAGS_i915-display/intel_display_device.o = -Wno-override-init
 
 # Rule to build SOC code shared with i915
 $(obj)/i915-soc/%.o: $(srctree)/drivers/gpu/drm/i915/soc/%.c FORCE
index 6603a0ea79c5af6d55bfdb3e61c7b6784e7b3604..9c0837b6fdfc8de2be8b939ed166623846932722 100644 (file)
@@ -144,9 +144,6 @@ static void try_add_system(struct xe_device *xe, struct xe_bo *bo,
                        .mem_type = XE_PL_TT,
                };
                *c += 1;
-
-               if (bo->props.preferred_mem_type == XE_BO_PROPS_INVALID)
-                       bo->props.preferred_mem_type = XE_PL_TT;
        }
 }
 
@@ -181,25 +178,15 @@ static void add_vram(struct xe_device *xe, struct xe_bo *bo,
        }
        places[*c] = place;
        *c += 1;
-
-       if (bo->props.preferred_mem_type == XE_BO_PROPS_INVALID)
-               bo->props.preferred_mem_type = mem_type;
 }
 
 static void try_add_vram(struct xe_device *xe, struct xe_bo *bo,
                         u32 bo_flags, u32 *c)
 {
-       if (bo->props.preferred_gt == XE_GT1) {
-               if (bo_flags & XE_BO_CREATE_VRAM1_BIT)
-                       add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM1, c);
-               if (bo_flags & XE_BO_CREATE_VRAM0_BIT)
-                       add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM0, c);
-       } else {
-               if (bo_flags & XE_BO_CREATE_VRAM0_BIT)
-                       add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM0, c);
-               if (bo_flags & XE_BO_CREATE_VRAM1_BIT)
-                       add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM1, c);
-       }
+       if (bo_flags & XE_BO_CREATE_VRAM0_BIT)
+               add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM0, c);
+       if (bo_flags & XE_BO_CREATE_VRAM1_BIT)
+               add_vram(xe, bo, bo->placements, bo_flags, XE_PL_VRAM1, c);
 }
 
 static void try_add_stolen(struct xe_device *xe, struct xe_bo *bo,
@@ -223,17 +210,8 @@ static int __xe_bo_placement_for_flags(struct xe_device *xe, struct xe_bo *bo,
 {
        u32 c = 0;
 
-       bo->props.preferred_mem_type = XE_BO_PROPS_INVALID;
-
-       /* The order of placements should indicate preferred location */
-
-       if (bo->props.preferred_mem_class == DRM_XE_MEM_REGION_CLASS_SYSMEM) {
-               try_add_system(xe, bo, bo_flags, &c);
-               try_add_vram(xe, bo, bo_flags, &c);
-       } else {
-               try_add_vram(xe, bo, bo_flags, &c);
-               try_add_system(xe, bo, bo_flags, &c);
-       }
+       try_add_vram(xe, bo, bo_flags, &c);
+       try_add_system(xe, bo, bo_flags, &c);
        try_add_stolen(xe, bo, bo_flags, &c);
 
        if (!c)
@@ -1126,13 +1104,6 @@ static void xe_gem_object_close(struct drm_gem_object *obj,
        }
 }
 
-static bool should_migrate_to_system(struct xe_bo *bo)
-{
-       struct xe_device *xe = xe_bo_device(bo);
-
-       return xe_device_in_fault_mode(xe) && bo->props.cpu_atomic;
-}
-
 static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
 {
        struct ttm_buffer_object *tbo = vmf->vma->vm_private_data;
@@ -1141,7 +1112,7 @@ static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
        struct xe_bo *bo = ttm_to_xe_bo(tbo);
        bool needs_rpm = bo->flags & XE_BO_CREATE_VRAM_MASK;
        vm_fault_t ret;
-       int idx, r = 0;
+       int idx;
 
        if (needs_rpm)
                xe_device_mem_access_get(xe);
@@ -1153,17 +1124,8 @@ static vm_fault_t xe_gem_fault(struct vm_fault *vmf)
        if (drm_dev_enter(ddev, &idx)) {
                trace_xe_bo_cpu_fault(bo);
 
-               if (should_migrate_to_system(bo)) {
-                       r = xe_bo_migrate(bo, XE_PL_TT);
-                       if (r == -EBUSY || r == -ERESTARTSYS || r == -EINTR)
-                               ret = VM_FAULT_NOPAGE;
-                       else if (r)
-                               ret = VM_FAULT_SIGBUS;
-               }
-               if (!ret)
-                       ret = ttm_bo_vm_fault_reserved(vmf,
-                                                      vmf->vma->vm_page_prot,
-                                                      TTM_BO_VM_NUM_PREFAULT);
+               ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
+                                              TTM_BO_VM_NUM_PREFAULT);
                drm_dev_exit(idx);
        } else {
                ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
@@ -1291,9 +1253,6 @@ struct xe_bo *___xe_bo_create_locked(struct xe_device *xe, struct xe_bo *bo,
        bo->flags = flags;
        bo->cpu_caching = cpu_caching;
        bo->ttm.base.funcs = &xe_gem_object_funcs;
-       bo->props.preferred_mem_class = XE_BO_PROPS_INVALID;
-       bo->props.preferred_gt = XE_BO_PROPS_INVALID;
-       bo->props.preferred_mem_type = XE_BO_PROPS_INVALID;
        bo->ttm.priority = XE_BO_PRIORITY_NORMAL;
        INIT_LIST_HEAD(&bo->pinned_link);
 #ifdef CONFIG_PROC_FS
index 14ef13b7b421f327d02d3c114c5a283f7ff169db..86422e113d39625043e16780a831b718f3464584 100644 (file)
@@ -56,25 +56,6 @@ struct xe_bo {
         */
        struct list_head client_link;
 #endif
-       /** @props: BO user controlled properties */
-       struct {
-               /** @preferred_mem: preferred memory class for this BO */
-               s16 preferred_mem_class;
-               /** @prefered_gt: preferred GT for this BO */
-               s16 preferred_gt;
-               /** @preferred_mem_type: preferred memory type */
-               s32 preferred_mem_type;
-               /**
-                * @cpu_atomic: the CPU expects to do atomics operations to
-                * this BO
-                */
-               bool cpu_atomic;
-               /**
-                * @device_atomic: the device expects to do atomics operations
-                * to this BO
-                */
-               bool device_atomic;
-       } props;
        /** @freed: List node for delayed put. */
        struct llist_node freed;
        /** @created: Whether the bo has passed initial creation */
index 14be34d9f5434be0dbb9186b6ae55ac19f7bf7b8..d413bc2c6be5a070d26f9bea32b4e979d5d4a912 100644 (file)
@@ -58,7 +58,7 @@ static inline struct xe_tile *xe_device_get_root_tile(struct xe_device *xe)
 
 static inline struct xe_gt *xe_tile_get_gt(struct xe_tile *tile, u8 gt_id)
 {
-       if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id > XE_MAX_GT_PER_TILE))
+       if (drm_WARN_ON(&tile_to_xe(tile)->drm, gt_id >= XE_MAX_GT_PER_TILE))
                gt_id = 0;
 
        return gt_id ? tile->media_gt : tile->primary_gt;
@@ -79,7 +79,7 @@ static inline struct xe_gt *xe_device_get_gt(struct xe_device *xe, u8 gt_id)
        if (MEDIA_VER(xe) >= 13) {
                gt = xe_tile_get_gt(root_tile, gt_id);
        } else {
-               if (drm_WARN_ON(&xe->drm, gt_id > XE_MAX_TILES_PER_DEVICE))
+               if (drm_WARN_ON(&xe->drm, gt_id >= XE_MAX_TILES_PER_DEVICE))
                        gt_id = 0;
 
                gt = xe->tiles[gt_id].primary_gt;
index 11e150f4c0c1f753bf344224b433f26231efd782..ead25d5e723ea501890761f7c0d96b0c0a79d871 100644 (file)
@@ -448,7 +448,7 @@ find_hw_engine(struct xe_device *xe,
 {
        u32 idx;
 
-       if (eci.engine_class > ARRAY_SIZE(user_to_xe_engine_class))
+       if (eci.engine_class >= ARRAY_SIZE(user_to_xe_engine_class))
                return NULL;
 
        if (eci.gt_id >= xe->info.gt_count)
index ff77bc8da1b27052debc63e06945dc55bd23f100..e2a4c3b5e9ff840c2e1cdce604f5f9f292dc7967 100644 (file)
@@ -1220,7 +1220,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
        init_waitqueue_head(&ge->suspend_wait);
 
        timeout = (q->vm && xe_vm_in_lr_mode(q->vm)) ? MAX_SCHEDULE_TIMEOUT :
-                 q->sched_props.job_timeout_ms;
+                 msecs_to_jiffies(q->sched_props.job_timeout_ms);
        err = xe_sched_init(&ge->sched, &drm_sched_ops, &xe_sched_ops,
                            get_submit_wq(guc),
                            q->lrc[0].ring.size / MAX_JOB_SIZE_BYTES, 64,
index 7ad853b0788af4c5d76411e66cd9d952263918c1..1426febe86eb676305772d7ee444b70af8254848 100644 (file)
@@ -97,7 +97,6 @@ static void set_offsets(u32 *regs,
 #define REG16(x) \
        (((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \
        (((x) >> 2) & 0x7f)
-#define END 0
 {
        const u32 base = hwe->mmio_base;
 
@@ -168,7 +167,7 @@ static const u8 gen12_xcs_offsets[] = {
        REG16(0x274),
        REG16(0x270),
 
-       END
+       0
 };
 
 static const u8 dg2_xcs_offsets[] = {
@@ -202,7 +201,7 @@ static const u8 dg2_xcs_offsets[] = {
        REG16(0x274),
        REG16(0x270),
 
-       END
+       0
 };
 
 static const u8 gen12_rcs_offsets[] = {
@@ -298,7 +297,7 @@ static const u8 gen12_rcs_offsets[] = {
        REG(0x084),
        NOP(1),
 
-       END
+       0
 };
 
 static const u8 xehp_rcs_offsets[] = {
@@ -339,7 +338,7 @@ static const u8 xehp_rcs_offsets[] = {
        LRI(1, 0),
        REG(0x0c8),
 
-       END
+       0
 };
 
 static const u8 dg2_rcs_offsets[] = {
@@ -382,7 +381,7 @@ static const u8 dg2_rcs_offsets[] = {
        LRI(1, 0),
        REG(0x0c8),
 
-       END
+       0
 };
 
 static const u8 mtl_rcs_offsets[] = {
@@ -425,7 +424,7 @@ static const u8 mtl_rcs_offsets[] = {
        LRI(1, 0),
        REG(0x0c8),
 
-       END
+       0
 };
 
 #define XE2_CTX_COMMON \
@@ -471,7 +470,7 @@ static const u8 xe2_rcs_offsets[] = {
        LRI(1, 0),              /* [0x47] */
        REG(0x0c8),             /* [0x48] R_PWR_CLK_STATE */
 
-       END
+       0
 };
 
 static const u8 xe2_bcs_offsets[] = {
@@ -482,16 +481,15 @@ static const u8 xe2_bcs_offsets[] = {
        REG16(0x200),           /* [0x42] BCS_SWCTRL */
        REG16(0x204),           /* [0x44] BLIT_CCTL */
 
-       END
+       0
 };
 
 static const u8 xe2_xcs_offsets[] = {
        XE2_CTX_COMMON,
 
-       END
+       0
 };
 
-#undef END
 #undef REG16
 #undef REG
 #undef LRI
index 92bb06c0586eb47268f826ba15ce24c5c3031d42..075f9eaef03122099433e53b209bf81a02653eb1 100644 (file)
@@ -132,7 +132,7 @@ query_engine_cycles(struct xe_device *xe,
                return -EINVAL;
 
        eci = &resp.eci;
-       if (eci->gt_id > XE_MAX_GT_PER_TILE)
+       if (eci->gt_id >= XE_MAX_GT_PER_TILE)
                return -EINVAL;
 
        gt = xe_device_get_gt(xe, eci->gt_id);
index a6861660cb8ca771f38415c08561f0cbb232588b..79870dd7a0146ead83e325a6f2c6b6a8e41a8b4c 100644 (file)
@@ -536,11 +536,12 @@ static int i801_block_transaction_by_block(struct i801_priv *priv,
 
        if (read_write == I2C_SMBUS_READ ||
            command == I2C_SMBUS_BLOCK_PROC_CALL) {
-               status = i801_get_block_len(priv);
-               if (status < 0)
+               len = i801_get_block_len(priv);
+               if (len < 0) {
+                       status = len;
                        goto out;
+               }
 
-               len = status;
                data->block[0] = len;
                inb_p(SMBHSTCNT(priv)); /* reset the data buffer index */
                for (i = 0; i < len; i++)
index 5ed036225e69bb7e550c72b0d90d02cb4fbea1ec..41f93c3ab160d0f4a6d3c47c061b23156c016aa7 100644 (file)
@@ -1139,7 +1139,8 @@ static void arm_smmu_write_ste(struct arm_smmu_master *master, u32 sid,
                 * requires a breaking update, zero the V bit, write all qwords
                 * but 0, then set qword 0
                 */
-               unused_update.data[0] = entry->data[0] & (~STRTAB_STE_0_V);
+               unused_update.data[0] = entry->data[0] &
+                                       cpu_to_le64(~STRTAB_STE_0_V);
                entry_set(smmu, sid, entry, &unused_update, 0, 1);
                entry_set(smmu, sid, entry, target, 1, num_entry_qwords - 1);
                entry_set(smmu, sid, entry, target, 0, 1);
@@ -1453,14 +1454,17 @@ static void arm_smmu_make_abort_ste(struct arm_smmu_ste *target)
                FIELD_PREP(STRTAB_STE_0_CFG, STRTAB_STE_0_CFG_ABORT));
 }
 
-static void arm_smmu_make_bypass_ste(struct arm_smmu_ste *target)
+static void arm_smmu_make_bypass_ste(struct arm_smmu_device *smmu,
+                                    struct arm_smmu_ste *target)
 {
        memset(target, 0, sizeof(*target));
        target->data[0] = cpu_to_le64(
                STRTAB_STE_0_V |
                FIELD_PREP(STRTAB_STE_0_CFG, STRTAB_STE_0_CFG_BYPASS));
-       target->data[1] = cpu_to_le64(
-               FIELD_PREP(STRTAB_STE_1_SHCFG, STRTAB_STE_1_SHCFG_INCOMING));
+
+       if (smmu->features & ARM_SMMU_FEAT_ATTR_TYPES_OVR)
+               target->data[1] = cpu_to_le64(FIELD_PREP(STRTAB_STE_1_SHCFG,
+                                                        STRTAB_STE_1_SHCFG_INCOMING));
 }
 
 static void arm_smmu_make_cdtable_ste(struct arm_smmu_ste *target,
@@ -1523,6 +1527,7 @@ static void arm_smmu_make_s2_domain_ste(struct arm_smmu_ste *target,
        typeof(&pgtbl_cfg->arm_lpae_s2_cfg.vtcr) vtcr =
                &pgtbl_cfg->arm_lpae_s2_cfg.vtcr;
        u64 vtcr_val;
+       struct arm_smmu_device *smmu = master->smmu;
 
        memset(target, 0, sizeof(*target));
        target->data[0] = cpu_to_le64(
@@ -1531,9 +1536,11 @@ static void arm_smmu_make_s2_domain_ste(struct arm_smmu_ste *target,
 
        target->data[1] = cpu_to_le64(
                FIELD_PREP(STRTAB_STE_1_EATS,
-                          master->ats_enabled ? STRTAB_STE_1_EATS_TRANS : 0) |
-               FIELD_PREP(STRTAB_STE_1_SHCFG,
-                          STRTAB_STE_1_SHCFG_INCOMING));
+                          master->ats_enabled ? STRTAB_STE_1_EATS_TRANS : 0));
+
+       if (smmu->features & ARM_SMMU_FEAT_ATTR_TYPES_OVR)
+               target->data[1] |= cpu_to_le64(FIELD_PREP(STRTAB_STE_1_SHCFG,
+                                                         STRTAB_STE_1_SHCFG_INCOMING));
 
        vtcr_val = FIELD_PREP(STRTAB_STE_2_VTCR_S2T0SZ, vtcr->tsz) |
                   FIELD_PREP(STRTAB_STE_2_VTCR_S2SL0, vtcr->sl) |
@@ -1560,7 +1567,8 @@ static void arm_smmu_make_s2_domain_ste(struct arm_smmu_ste *target,
  * This can safely directly manipulate the STE memory without a sync sequence
  * because the STE table has not been installed in the SMMU yet.
  */
-static void arm_smmu_init_initial_stes(struct arm_smmu_ste *strtab,
+static void arm_smmu_init_initial_stes(struct arm_smmu_device *smmu,
+                                      struct arm_smmu_ste *strtab,
                                       unsigned int nent)
 {
        unsigned int i;
@@ -1569,7 +1577,7 @@ static void arm_smmu_init_initial_stes(struct arm_smmu_ste *strtab,
                if (disable_bypass)
                        arm_smmu_make_abort_ste(strtab);
                else
-                       arm_smmu_make_bypass_ste(strtab);
+                       arm_smmu_make_bypass_ste(smmu, strtab);
                strtab++;
        }
 }
@@ -1597,7 +1605,7 @@ static int arm_smmu_init_l2_strtab(struct arm_smmu_device *smmu, u32 sid)
                return -ENOMEM;
        }
 
-       arm_smmu_init_initial_stes(desc->l2ptr, 1 << STRTAB_SPLIT);
+       arm_smmu_init_initial_stes(smmu, desc->l2ptr, 1 << STRTAB_SPLIT);
        arm_smmu_write_strtab_l1_desc(strtab, desc);
        return 0;
 }
@@ -2637,8 +2645,9 @@ static int arm_smmu_attach_dev_identity(struct iommu_domain *domain,
                                        struct device *dev)
 {
        struct arm_smmu_ste ste;
+       struct arm_smmu_master *master = dev_iommu_priv_get(dev);
 
-       arm_smmu_make_bypass_ste(&ste);
+       arm_smmu_make_bypass_ste(master->smmu, &ste);
        return arm_smmu_attach_dev_ste(dev, &ste);
 }
 
@@ -3264,7 +3273,7 @@ static int arm_smmu_init_strtab_linear(struct arm_smmu_device *smmu)
        reg |= FIELD_PREP(STRTAB_BASE_CFG_LOG2SIZE, smmu->sid_bits);
        cfg->strtab_base_cfg = reg;
 
-       arm_smmu_init_initial_stes(strtab, cfg->num_l1_ents);
+       arm_smmu_init_initial_stes(smmu, strtab, cfg->num_l1_ents);
        return 0;
 }
 
@@ -3777,6 +3786,9 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu)
                return -ENXIO;
        }
 
+       if (reg & IDR1_ATTR_TYPES_OVR)
+               smmu->features |= ARM_SMMU_FEAT_ATTR_TYPES_OVR;
+
        /* Queue sizes, capped to ensure natural alignment */
        smmu->cmdq.q.llq.max_n_shift = min_t(u32, CMDQ_MAX_SZ_SHIFT,
                                             FIELD_GET(IDR1_CMDQS, reg));
@@ -3992,7 +4004,7 @@ static void arm_smmu_rmr_install_bypass_ste(struct arm_smmu_device *smmu)
                         * STE table is not programmed to HW, see
                         * arm_smmu_initial_bypass_stes()
                         */
-                       arm_smmu_make_bypass_ste(
+                       arm_smmu_make_bypass_ste(smmu,
                                arm_smmu_get_step_for_sid(smmu, rmr->sids[i]));
                }
        }
index 23baf117e7e4b5ca0d45d9cb22f1459e894523f5..2a19bb63e5c6d2c8fbc61115f30a6c0c0e83190c 100644 (file)
@@ -44,6 +44,7 @@
 #define IDR1_TABLES_PRESET             (1 << 30)
 #define IDR1_QUEUES_PRESET             (1 << 29)
 #define IDR1_REL                       (1 << 28)
+#define IDR1_ATTR_TYPES_OVR            (1 << 27)
 #define IDR1_CMDQS                     GENMASK(25, 21)
 #define IDR1_EVTQS                     GENMASK(20, 16)
 #define IDR1_PRIQS                     GENMASK(15, 11)
@@ -647,6 +648,7 @@ struct arm_smmu_device {
 #define ARM_SMMU_FEAT_SVA              (1 << 17)
 #define ARM_SMMU_FEAT_E2H              (1 << 18)
 #define ARM_SMMU_FEAT_NESTING          (1 << 19)
+#define ARM_SMMU_FEAT_ATTR_TYPES_OVR   (1 << 20)
        u32                             features;
 
 #define ARM_SMMU_OPT_SKIP_PREFETCH     (1 << 0)
index 098869007c69e51908c2f93024fdc1a21ea66d3f..a95a483def2d2ab01d8f25db356ed6e3ec505d53 100644 (file)
@@ -3354,6 +3354,7 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
 {
        /* Caller must be a probed driver on dev */
        struct iommu_group *group = dev->iommu_group;
+       struct group_device *device;
        void *curr;
        int ret;
 
@@ -3363,10 +3364,18 @@ int iommu_attach_device_pasid(struct iommu_domain *domain,
        if (!group)
                return -ENODEV;
 
-       if (!dev_has_iommu(dev) || dev_iommu_ops(dev) != domain->owner)
+       if (!dev_has_iommu(dev) || dev_iommu_ops(dev) != domain->owner ||
+           pasid == IOMMU_NO_PASID)
                return -EINVAL;
 
        mutex_lock(&group->mutex);
+       for_each_group_device(group, device) {
+               if (pasid >= device->dev->iommu->max_pasids) {
+                       ret = -EINVAL;
+                       goto out_unlock;
+               }
+       }
+
        curr = xa_cmpxchg(&group->pasid_array, pasid, NULL, domain, GFP_KERNEL);
        if (curr) {
                ret = xa_err(curr) ? : -EBUSY;
index a55528469278c77a85cc81503e2b4185e1dca24c..4b021a67bdfe481707291bb3888e7b91eb3c1c56 100644 (file)
@@ -316,7 +316,7 @@ static int armada_370_xp_msi_init(struct device_node *node,
        return 0;
 }
 #else
-static void armada_370_xp_msi_reenable_percpu(void) {}
+static __maybe_unused void armada_370_xp_msi_reenable_percpu(void) {}
 
 static inline int armada_370_xp_msi_init(struct device_node *node,
                                         phys_addr_t main_int_phys_base)
index 37b9f8f1ae1a275763b974a8547ab37efd93eb21..7f3dc8ee6ab8dd89945bdafb54cf222c139bd764 100644 (file)
@@ -4221,7 +4221,7 @@ static int dm_integrity_ctr(struct dm_target *ti, unsigned int argc, char **argv
                } else if (sscanf(opt_string, "sectors_per_bit:%llu%c", &llval, &dummy) == 1) {
                        log2_sectors_per_bitmap_bit = !llval ? 0 : __ilog2_u64(llval);
                } else if (sscanf(opt_string, "bitmap_flush_interval:%u%c", &val, &dummy) == 1) {
-                       if (val >= (uint64_t)UINT_MAX * 1000 / HZ) {
+                       if ((uint64_t)val >= (uint64_t)UINT_MAX * 1000 / HZ) {
                                r = -EINVAL;
                                ti->error = "Invalid bitmap_flush_interval argument";
                                goto bad;
index 00c9b9c050011c69530e35d3f4bbf550f1b08cc5..01d2743444ec6cc7eec0945b69ba1c63195f09b1 100644 (file)
@@ -8,33 +8,14 @@
 
 #include "murmurhash3.h"
 
+#include <asm/unaligned.h>
+
 static inline u64 rotl64(u64 x, s8 r)
 {
        return (x << r) | (x >> (64 - r));
 }
 
 #define ROTL64(x, y) rotl64(x, y)
-static __always_inline u64 getblock64(const u64 *p, int i)
-{
-#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
-       return p[i];
-#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
-       return __builtin_bswap64(p[i]);
-#else
-#error "can't figure out byte order"
-#endif
-}
-
-static __always_inline void putblock64(u64 *p, int i, u64 value)
-{
-#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
-       p[i] = value;
-#elif __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
-       p[i] = __builtin_bswap64(value);
-#else
-#error "can't figure out byte order"
-#endif
-}
 
 /* Finalization mix - force all bits of a hash block to avalanche */
 
@@ -60,6 +41,8 @@ void murmurhash3_128(const void *key, const int len, const u32 seed, void *out)
        const u64 c1 = 0x87c37b91114253d5LLU;
        const u64 c2 = 0x4cf5ad432745937fLLU;
 
+       u64 *hash_out = out;
+
        /* body */
 
        const u64 *blocks = (const u64 *)(data);
@@ -67,8 +50,8 @@ void murmurhash3_128(const void *key, const int len, const u32 seed, void *out)
        int i;
 
        for (i = 0; i < nblocks; i++) {
-               u64 k1 = getblock64(blocks, i * 2 + 0);
-               u64 k2 = getblock64(blocks, i * 2 + 1);
+               u64 k1 = get_unaligned_le64(&blocks[i * 2]);
+               u64 k2 = get_unaligned_le64(&blocks[i * 2 + 1]);
 
                k1 *= c1;
                k1 = ROTL64(k1, 31);
@@ -170,6 +153,6 @@ void murmurhash3_128(const void *key, const int len, const u32 seed, void *out)
        h1 += h2;
        h2 += h1;
 
-       putblock64((u64 *)out, 0, h1);
-       putblock64((u64 *)out, 1, h2);
+       put_unaligned_le64(h1, &hash_out[0]);
+       put_unaligned_le64(h2, &hash_out[1]);
 }
index 64a3492e8002fb110cd7009bd29779fc18c4feb7..90c51b12148e8d6d5f86377c8766959bbf678d18 100644 (file)
@@ -413,7 +413,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user(
        struct mmc_blk_ioc_data *idata;
        int err;
 
-       idata = kmalloc(sizeof(*idata), GFP_KERNEL);
+       idata = kzalloc(sizeof(*idata), GFP_KERNEL);
        if (!idata) {
                err = -ENOMEM;
                goto out;
@@ -488,7 +488,7 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
        if (idata->flags & MMC_BLK_IOC_DROP)
                return 0;
 
-       if (idata->flags & MMC_BLK_IOC_SBC)
+       if (idata->flags & MMC_BLK_IOC_SBC && i > 0)
                prev_idata = idatas[i - 1];
 
        /*
index ab4b964d4058444bd69b70c2990e81da0723910d..1d8f5a76096aeb3c836722b3f97226d7dd2c5201 100644 (file)
@@ -999,6 +999,17 @@ free_pltfm:
        return err;
 }
 
+static void dwcmshc_disable_card_clk(struct sdhci_host *host)
+{
+       u16 ctrl;
+
+       ctrl = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
+       if (ctrl & SDHCI_CLOCK_CARD_EN) {
+               ctrl &= ~SDHCI_CLOCK_CARD_EN;
+               sdhci_writew(host, ctrl, SDHCI_CLOCK_CONTROL);
+       }
+}
+
 static void dwcmshc_remove(struct platform_device *pdev)
 {
        struct sdhci_host *host = platform_get_drvdata(pdev);
@@ -1006,8 +1017,14 @@ static void dwcmshc_remove(struct platform_device *pdev)
        struct dwcmshc_priv *priv = sdhci_pltfm_priv(pltfm_host);
        struct rk35xx_priv *rk_priv = priv->priv;
 
+       pm_runtime_get_sync(&pdev->dev);
+       pm_runtime_disable(&pdev->dev);
+       pm_runtime_put_noidle(&pdev->dev);
+
        sdhci_remove_host(host, 0);
 
+       dwcmshc_disable_card_clk(host);
+
        clk_disable_unprepare(pltfm_host->clk);
        clk_disable_unprepare(priv->bus_clk);
        if (rk_priv)
@@ -1099,17 +1116,6 @@ static void dwcmshc_enable_card_clk(struct sdhci_host *host)
        }
 }
 
-static void dwcmshc_disable_card_clk(struct sdhci_host *host)
-{
-       u16 ctrl;
-
-       ctrl = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
-       if (ctrl & SDHCI_CLOCK_CARD_EN) {
-               ctrl &= ~SDHCI_CLOCK_CARD_EN;
-               sdhci_writew(host, ctrl, SDHCI_CLOCK_CONTROL);
-       }
-}
-
 static int dwcmshc_runtime_suspend(struct device *dev)
 {
        struct sdhci_host *host = dev_get_drvdata(dev);
index e78faef67d7ab5fbdcee2c10be9156d7a57ede23..94076b09557198a4a7b73ed0d42f7cefff2dc083 100644 (file)
@@ -1439,6 +1439,9 @@ static int __maybe_unused sdhci_omap_runtime_suspend(struct device *dev)
        struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
        struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
 
+       if (host->tuning_mode != SDHCI_TUNING_MODE_3)
+               mmc_retune_needed(host->mmc);
+
        if (omap_host->con != -EINVAL)
                sdhci_runtime_suspend_host(host);
 
index 767f66c37f6b5cf63db379232af407b9813428a1..1035820c2377af7d73d401824734e949b7679c8d 100644 (file)
@@ -2268,8 +2268,6 @@ mt7530_setup(struct dsa_switch *ds)
                     SYS_CTRL_PHY_RST | SYS_CTRL_SW_RST |
                     SYS_CTRL_REG_RST);
 
-       mt7530_pll_setup(priv);
-
        /* Lower Tx driving for TRGMII path */
        for (i = 0; i < NUM_TRGMII_CTRL; i++)
                mt7530_write(priv, MT7530_TRGMII_TD_ODT(i),
@@ -2285,6 +2283,9 @@ mt7530_setup(struct dsa_switch *ds)
        val |= MHWTRAP_MANUAL;
        mt7530_write(priv, MT7530_MHWTRAP, val);
 
+       if ((val & HWTRAP_XTAL_MASK) == HWTRAP_XTAL_40MHZ)
+               mt7530_pll_setup(priv);
+
        mt753x_trap_frames(priv);
 
        /* Enable and reset MIB counters */
index dd06b68b33ed617a8de969078b02ce59591b585c..72ea97c5d5d424482fe6812cef1a013158319a70 100644 (file)
@@ -392,7 +392,9 @@ static void umac_reset(struct bcmasp_intf *intf)
        umac_wl(intf, 0x0, UMC_CMD);
        umac_wl(intf, UMC_CMD_SW_RESET, UMC_CMD);
        usleep_range(10, 100);
-       umac_wl(intf, 0x0, UMC_CMD);
+       /* We hold the umac in reset and bring it out of
+        * reset when phy link is up.
+        */
 }
 
 static void umac_set_hw_addr(struct bcmasp_intf *intf,
@@ -412,6 +414,8 @@ static void umac_enable_set(struct bcmasp_intf *intf, u32 mask,
        u32 reg;
 
        reg = umac_rl(intf, UMC_CMD);
+       if (reg & UMC_CMD_SW_RESET)
+               return;
        if (enable)
                reg |= mask;
        else
@@ -430,7 +434,6 @@ static void umac_init(struct bcmasp_intf *intf)
        umac_wl(intf, 0x800, UMC_FRM_LEN);
        umac_wl(intf, 0xffff, UMC_PAUSE_CNTRL);
        umac_wl(intf, 0x800, UMC_RX_MAX_PKT_SZ);
-       umac_enable_set(intf, UMC_CMD_PROMISC, 1);
 }
 
 static int bcmasp_tx_poll(struct napi_struct *napi, int budget)
@@ -658,6 +661,12 @@ static void bcmasp_adj_link(struct net_device *dev)
                        UMC_CMD_HD_EN | UMC_CMD_RX_PAUSE_IGNORE |
                        UMC_CMD_TX_PAUSE_IGNORE);
                reg |= cmd_bits;
+               if (reg & UMC_CMD_SW_RESET) {
+                       reg &= ~UMC_CMD_SW_RESET;
+                       umac_wl(intf, reg, UMC_CMD);
+                       udelay(2);
+                       reg |= UMC_CMD_TX_EN | UMC_CMD_RX_EN | UMC_CMD_PROMISC;
+               }
                umac_wl(intf, reg, UMC_CMD);
 
                active = phy_init_eee(phydev, 0) >= 0;
@@ -1035,19 +1044,12 @@ static int bcmasp_netif_init(struct net_device *dev, bool phy_connect)
 
                /* Indicate that the MAC is responsible for PHY PM */
                phydev->mac_managed_pm = true;
-       } else if (!intf->wolopts) {
-               ret = phy_resume(dev->phydev);
-               if (ret)
-                       goto err_phy_disable;
        }
 
        umac_reset(intf);
 
        umac_init(intf);
 
-       /* Disable the UniMAC RX/TX */
-       umac_enable_set(intf, (UMC_CMD_RX_EN | UMC_CMD_TX_EN), 0);
-
        umac_set_hw_addr(intf, dev->dev_addr);
 
        intf->old_duplex = -1;
@@ -1062,9 +1064,6 @@ static int bcmasp_netif_init(struct net_device *dev, bool phy_connect)
        netif_napi_add(intf->ndev, &intf->rx_napi, bcmasp_rx_poll);
        bcmasp_enable_rx(intf, 1);
 
-       /* Turn on UniMAC TX/RX */
-       umac_enable_set(intf, (UMC_CMD_RX_EN | UMC_CMD_TX_EN), 1);
-
        intf->crc_fwd = !!(umac_rl(intf, UMC_CMD) & UMC_CMD_CRC_FWD);
 
        bcmasp_netif_start(dev);
@@ -1306,7 +1305,14 @@ static void bcmasp_suspend_to_wol(struct bcmasp_intf *intf)
        if (intf->wolopts & WAKE_FILTER)
                bcmasp_netfilt_suspend(intf);
 
-       /* UniMAC receive needs to be turned on */
+       /* Bring UniMAC out of reset if needed and enable RX */
+       reg = umac_rl(intf, UMC_CMD);
+       if (reg & UMC_CMD_SW_RESET)
+               reg &= ~UMC_CMD_SW_RESET;
+
+       reg |= UMC_CMD_RX_EN | UMC_CMD_PROMISC;
+       umac_wl(intf, reg, UMC_CMD);
+
        umac_enable_set(intf, UMC_CMD_RX_EN, 1);
 
        if (intf->parent->wol_irq > 0) {
@@ -1324,7 +1330,6 @@ int bcmasp_interface_suspend(struct bcmasp_intf *intf)
 {
        struct device *kdev = &intf->parent->pdev->dev;
        struct net_device *dev = intf->ndev;
-       int ret = 0;
 
        if (!netif_running(dev))
                return 0;
@@ -1334,10 +1339,6 @@ int bcmasp_interface_suspend(struct bcmasp_intf *intf)
        bcmasp_netif_deinit(dev);
 
        if (!intf->wolopts) {
-               ret = phy_suspend(dev->phydev);
-               if (ret)
-                       goto out;
-
                if (intf->internal_phy)
                        bcmasp_ephy_enable_set(intf, false);
                else
@@ -1354,11 +1355,7 @@ int bcmasp_interface_suspend(struct bcmasp_intf *intf)
 
        clk_disable_unprepare(intf->parent->clk);
 
-       return ret;
-
-out:
-       bcmasp_netif_init(dev, false);
-       return ret;
+       return 0;
 }
 
 static void bcmasp_resume_from_wol(struct bcmasp_intf *intf)
index f3c9395d8351cb31108973e1867332e00026c6ac..618f66d9586b390a4d4ec45aafa4178ec06e5a91 100644 (file)
@@ -85,7 +85,7 @@ int hclge_comm_tqps_update_stats(struct hnae3_handle *handle,
                hclge_comm_cmd_setup_basic_desc(&desc, HCLGE_OPC_QUERY_TX_STATS,
                                                true);
 
-               desc.data[0] = cpu_to_le32(tqp->index & 0x1ff);
+               desc.data[0] = cpu_to_le32(tqp->index);
                ret = hclge_comm_cmd_send(hw, &desc, 1);
                if (ret) {
                        dev_err(&hw->cmq.csq.pdev->dev,
index 999a0ee162a64494f0782b1fc5cbdfff695e83b8..941cb529d671fb2bf2fc12ceb5890fec093dc137 100644 (file)
@@ -78,6 +78,9 @@ static const struct hns3_stats hns3_rxq_stats[] = {
 #define HNS3_NIC_LB_TEST_NO_MEM_ERR    1
 #define HNS3_NIC_LB_TEST_TX_CNT_ERR    2
 #define HNS3_NIC_LB_TEST_RX_CNT_ERR    3
+#define HNS3_NIC_LB_TEST_UNEXECUTED    4
+
+static int hns3_get_sset_count(struct net_device *netdev, int stringset);
 
 static int hns3_lp_setup(struct net_device *ndev, enum hnae3_loop loop, bool en)
 {
@@ -418,18 +421,26 @@ static void hns3_do_external_lb(struct net_device *ndev,
 static void hns3_self_test(struct net_device *ndev,
                           struct ethtool_test *eth_test, u64 *data)
 {
+       int cnt = hns3_get_sset_count(ndev, ETH_SS_TEST);
        struct hns3_nic_priv *priv = netdev_priv(ndev);
        struct hnae3_handle *h = priv->ae_handle;
        int st_param[HNAE3_LOOP_NONE][2];
        bool if_running = netif_running(ndev);
+       int i;
+
+       /* initialize the loopback test result, avoid marking an unexcuted
+        * loopback test as PASS.
+        */
+       for (i = 0; i < cnt; i++)
+               data[i] = HNS3_NIC_LB_TEST_UNEXECUTED;
 
        if (hns3_nic_resetting(ndev)) {
                netdev_err(ndev, "dev resetting!");
-               return;
+               goto failure;
        }
 
        if (!(eth_test->flags & ETH_TEST_FL_OFFLINE))
-               return;
+               goto failure;
 
        if (netif_msg_ifdown(h))
                netdev_info(ndev, "self test start\n");
@@ -451,6 +462,10 @@ static void hns3_self_test(struct net_device *ndev,
 
        if (netif_msg_ifdown(h))
                netdev_info(ndev, "self test end\n");
+       return;
+
+failure:
+       eth_test->flags |= ETH_TEST_FL_FAILED;
 }
 
 static void hns3_update_limit_promisc_mode(struct net_device *netdev,
index b4afb66efe5c5c242e01670128c3ae069bdcaeda..ff6a2ed23ddb6be2c5dd132698d2fd079f5f5827 100644 (file)
@@ -11626,6 +11626,8 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)
        if (ret)
                goto err_pci_uninit;
 
+       devl_lock(hdev->devlink);
+
        /* Firmware command queue initialize */
        ret = hclge_comm_cmd_queue_init(hdev->pdev, &hdev->hw.hw);
        if (ret)
@@ -11805,6 +11807,7 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)
 
        hclge_task_schedule(hdev, round_jiffies_relative(HZ));
 
+       devl_unlock(hdev->devlink);
        return 0;
 
 err_mdiobus_unreg:
@@ -11817,6 +11820,7 @@ err_msi_uninit:
 err_cmd_uninit:
        hclge_comm_cmd_uninit(hdev->ae_dev, &hdev->hw.hw);
 err_devlink_uninit:
+       devl_unlock(hdev->devlink);
        hclge_devlink_uninit(hdev);
 err_pci_uninit:
        pcim_iounmap(pdev, hdev->hw.hw.io_base);
index 8040317c95617efaeaf9ff0ccbe6b07bc13b231a..1f3e7a6903e56e6bc0f452e58a4b3d026737f9a0 100644 (file)
@@ -593,8 +593,9 @@ struct ice_aqc_recipe_data_elem {
 struct ice_aqc_recipe_to_profile {
        __le16 profile_id;
        u8 rsvd[6];
-       DECLARE_BITMAP(recipe_assoc, ICE_MAX_NUM_RECIPES);
+       __le64 recipe_assoc;
 };
+static_assert(sizeof(struct ice_aqc_recipe_to_profile) == 16);
 
 /* Add/Update/Remove/Get switch rules (indirect 0x02A0, 0x02A1, 0x02A2, 0x02A3)
  */
index f97128b69f87ecb26d17d81a44486eab3d194470..f0e76f0a6d6031cd9a656ee4a0d5ea6d4e8e95f7 100644 (file)
@@ -2041,7 +2041,7 @@ int ice_init_lag(struct ice_pf *pf)
        /* associate recipes to profiles */
        for (n = 0; n < ICE_PROFID_IPV6_GTPU_IPV6_TCP_INNER; n++) {
                err = ice_aq_get_recipe_to_profile(&pf->hw, n,
-                                                  (u8 *)&recipe_bits, NULL);
+                                                  &recipe_bits, NULL);
                if (err)
                        continue;
 
@@ -2049,7 +2049,7 @@ int ice_init_lag(struct ice_pf *pf)
                        recipe_bits |= BIT(lag->pf_recipe) |
                                       BIT(lag->lport_recipe);
                        ice_aq_map_recipe_to_profile(&pf->hw, n,
-                                                    (u8 *)&recipe_bits, NULL);
+                                                    recipe_bits, NULL);
                }
        }
 
index ee3f0d3e3f6dbd5e1906cb2ce4f03e5675105c09..558422120312ba858a55e9ed4747b1ba3d4072a2 100644 (file)
@@ -3091,7 +3091,7 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
 {
        struct ice_vsi_cfg_params params = {};
        struct ice_coalesce_stored *coalesce;
-       int prev_num_q_vectors = 0;
+       int prev_num_q_vectors;
        struct ice_pf *pf;
        int ret;
 
@@ -3105,13 +3105,6 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
        if (WARN_ON(vsi->type == ICE_VSI_VF && !vsi->vf))
                return -EINVAL;
 
-       coalesce = kcalloc(vsi->num_q_vectors,
-                          sizeof(struct ice_coalesce_stored), GFP_KERNEL);
-       if (!coalesce)
-               return -ENOMEM;
-
-       prev_num_q_vectors = ice_vsi_rebuild_get_coalesce(vsi, coalesce);
-
        ret = ice_vsi_realloc_stat_arrays(vsi);
        if (ret)
                goto err_vsi_cfg;
@@ -3121,6 +3114,13 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
        if (ret)
                goto err_vsi_cfg;
 
+       coalesce = kcalloc(vsi->num_q_vectors,
+                          sizeof(struct ice_coalesce_stored), GFP_KERNEL);
+       if (!coalesce)
+               return -ENOMEM;
+
+       prev_num_q_vectors = ice_vsi_rebuild_get_coalesce(vsi, coalesce);
+
        ret = ice_vsi_cfg_tc_lan(pf, vsi);
        if (ret) {
                if (vsi_flags & ICE_VSI_FLAG_INIT) {
@@ -3139,8 +3139,8 @@ int ice_vsi_rebuild(struct ice_vsi *vsi, u32 vsi_flags)
 
 err_vsi_cfg_tc_lan:
        ice_vsi_decfg(vsi);
-err_vsi_cfg:
        kfree(coalesce);
+err_vsi_cfg:
        return ret;
 }
 
index d4baae8c3b720ae7fca91b87a43400b858c046b6..b4ea935e8300547f7e24ff0f4a9657b9a1608f98 100644 (file)
@@ -2025,12 +2025,12 @@ error_out:
  * ice_aq_map_recipe_to_profile - Map recipe to packet profile
  * @hw: pointer to the HW struct
  * @profile_id: package profile ID to associate the recipe with
- * @r_bitmap: Recipe bitmap filled in and need to be returned as response
+ * @r_assoc: Recipe bitmap filled in and need to be returned as response
  * @cd: pointer to command details structure or NULL
  * Recipe to profile association (0x0291)
  */
 int
-ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
+ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u64 r_assoc,
                             struct ice_sq_cd *cd)
 {
        struct ice_aqc_recipe_to_profile *cmd;
@@ -2042,7 +2042,7 @@ ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
        /* Set the recipe ID bit in the bitmask to let the device know which
         * profile we are associating the recipe to
         */
-       memcpy(cmd->recipe_assoc, r_bitmap, sizeof(cmd->recipe_assoc));
+       cmd->recipe_assoc = cpu_to_le64(r_assoc);
 
        return ice_aq_send_cmd(hw, &desc, NULL, 0, cd);
 }
@@ -2051,12 +2051,12 @@ ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
  * ice_aq_get_recipe_to_profile - Map recipe to packet profile
  * @hw: pointer to the HW struct
  * @profile_id: package profile ID to associate the recipe with
- * @r_bitmap: Recipe bitmap filled in and need to be returned as response
+ * @r_assoc: Recipe bitmap filled in and need to be returned as response
  * @cd: pointer to command details structure or NULL
  * Associate profile ID with given recipe (0x0293)
  */
 int
-ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
+ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u64 *r_assoc,
                             struct ice_sq_cd *cd)
 {
        struct ice_aqc_recipe_to_profile *cmd;
@@ -2069,7 +2069,7 @@ ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
 
        status = ice_aq_send_cmd(hw, &desc, NULL, 0, cd);
        if (!status)
-               memcpy(r_bitmap, cmd->recipe_assoc, sizeof(cmd->recipe_assoc));
+               *r_assoc = le64_to_cpu(cmd->recipe_assoc);
 
        return status;
 }
@@ -2108,6 +2108,7 @@ int ice_alloc_recipe(struct ice_hw *hw, u16 *rid)
 static void ice_get_recp_to_prof_map(struct ice_hw *hw)
 {
        DECLARE_BITMAP(r_bitmap, ICE_MAX_NUM_RECIPES);
+       u64 recp_assoc;
        u16 i;
 
        for (i = 0; i < hw->switch_info->max_used_prof_index + 1; i++) {
@@ -2115,8 +2116,9 @@ static void ice_get_recp_to_prof_map(struct ice_hw *hw)
 
                bitmap_zero(profile_to_recipe[i], ICE_MAX_NUM_RECIPES);
                bitmap_zero(r_bitmap, ICE_MAX_NUM_RECIPES);
-               if (ice_aq_get_recipe_to_profile(hw, i, (u8 *)r_bitmap, NULL))
+               if (ice_aq_get_recipe_to_profile(hw, i, &recp_assoc, NULL))
                        continue;
+               bitmap_from_arr64(r_bitmap, &recp_assoc, ICE_MAX_NUM_RECIPES);
                bitmap_copy(profile_to_recipe[i], r_bitmap,
                            ICE_MAX_NUM_RECIPES);
                for_each_set_bit(j, r_bitmap, ICE_MAX_NUM_RECIPES)
@@ -5390,22 +5392,24 @@ ice_add_adv_recipe(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
         */
        list_for_each_entry(fvit, &rm->fv_list, list_entry) {
                DECLARE_BITMAP(r_bitmap, ICE_MAX_NUM_RECIPES);
+               u64 recp_assoc;
                u16 j;
 
                status = ice_aq_get_recipe_to_profile(hw, fvit->profile_id,
-                                                     (u8 *)r_bitmap, NULL);
+                                                     &recp_assoc, NULL);
                if (status)
                        goto err_unroll;
 
+               bitmap_from_arr64(r_bitmap, &recp_assoc, ICE_MAX_NUM_RECIPES);
                bitmap_or(r_bitmap, r_bitmap, rm->r_bitmap,
                          ICE_MAX_NUM_RECIPES);
                status = ice_acquire_change_lock(hw, ICE_RES_WRITE);
                if (status)
                        goto err_unroll;
 
+               bitmap_to_arr64(&recp_assoc, r_bitmap, ICE_MAX_NUM_RECIPES);
                status = ice_aq_map_recipe_to_profile(hw, fvit->profile_id,
-                                                     (u8 *)r_bitmap,
-                                                     NULL);
+                                                     recp_assoc, NULL);
                ice_release_change_lock(hw);
 
                if (status)
index db7e501b7e0a486fa046fc2f1afdba2e9350c113..89ffa1b51b5ad111ae6dc73ec64c8a78c38899b1 100644 (file)
@@ -424,10 +424,10 @@ int ice_aq_add_recipe(struct ice_hw *hw,
                      struct ice_aqc_recipe_data_elem *s_recipe_list,
                      u16 num_recipes, struct ice_sq_cd *cd);
 int
-ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
+ice_aq_get_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u64 *r_assoc,
                             struct ice_sq_cd *cd);
 int
-ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u8 *r_bitmap,
+ice_aq_map_recipe_to_profile(struct ice_hw *hw, u32 profile_id, u64 r_assoc,
                             struct ice_sq_cd *cd);
 
 #endif /* _ICE_SWITCH_H_ */
index 2e1cfbd82f4fd55db97e064c0a8343d95f076f6f..35ad40a803cb64a66b983b3a2103a8f15b808df5 100644 (file)
@@ -1642,10 +1642,6 @@ done:
 
        if (unlikely(test_bit(IGC_RING_FLAG_TX_HWTSTAMP, &tx_ring->flags) &&
                     skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {
-               /* FIXME: add support for retrieving timestamps from
-                * the other timer registers before skipping the
-                * timestamping request.
-                */
                unsigned long flags;
                u32 tstamp_flags;
 
index 13a6fca31004a8e1c69d7b8a994b5da93ca08b3c..866024f2b9eeb380d31557b53f2c7e00fe41a15a 100644 (file)
@@ -914,7 +914,13 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
                goto err_out;
        }
 
-       xs = kzalloc(sizeof(*xs), GFP_KERNEL);
+       algo = xfrm_aead_get_byname(aes_gcm_name, IXGBE_IPSEC_AUTH_BITS, 1);
+       if (unlikely(!algo)) {
+               err = -ENOENT;
+               goto err_out;
+       }
+
+       xs = kzalloc(sizeof(*xs), GFP_ATOMIC);
        if (unlikely(!xs)) {
                err = -ENOMEM;
                goto err_out;
@@ -930,14 +936,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
                memcpy(&xs->id.daddr.a4, sam->addr, sizeof(xs->id.daddr.a4));
        xs->xso.dev = adapter->netdev;
 
-       algo = xfrm_aead_get_byname(aes_gcm_name, IXGBE_IPSEC_AUTH_BITS, 1);
-       if (unlikely(!algo)) {
-               err = -ENOENT;
-               goto err_xs;
-       }
-
        aead_len = sizeof(*xs->aead) + IXGBE_IPSEC_KEY_BITS / 8;
-       xs->aead = kzalloc(aead_len, GFP_KERNEL);
+       xs->aead = kzalloc(aead_len, GFP_ATOMIC);
        if (unlikely(!xs->aead)) {
                err = -ENOMEM;
                goto err_xs;
index 3c0f55b3e48ea402959df74c28637a9ca169a382..b86f3224f0b783015367f160f191a81470756345 100644 (file)
@@ -808,6 +808,11 @@ static int cgx_lmac_enadis_pause_frm(void *cgxd, int lmac_id,
        if (!is_lmac_valid(cgx, lmac_id))
                return -ENODEV;
 
+       cfg = cgx_read(cgx, lmac_id, CGXX_GMP_GMI_RXX_FRM_CTL);
+       cfg &= ~CGX_GMP_GMI_RXX_FRM_CTL_CTL_BCK;
+       cfg |= rx_pause ? CGX_GMP_GMI_RXX_FRM_CTL_CTL_BCK : 0x0;
+       cgx_write(cgx, lmac_id, CGXX_GMP_GMI_RXX_FRM_CTL, cfg);
+
        cfg = cgx_read(cgx, lmac_id, CGXX_SMUX_RX_FRM_CTL);
        cfg &= ~CGX_SMUX_RX_FRM_CTL_CTL_BCK;
        cfg |= rx_pause ? CGX_SMUX_RX_FRM_CTL_CTL_BCK : 0x0;
index 28a0016f1a55ba29ed95d99ca834740c68a9f175..4342379e2054d7ae7626befb550c8953f9be2bb3 100644 (file)
@@ -139,13 +139,10 @@ static int mlxbf_gige_open(struct net_device *netdev)
        control |= MLXBF_GIGE_CONTROL_PORT_EN;
        writeq(control, priv->base + MLXBF_GIGE_CONTROL);
 
-       err = mlxbf_gige_request_irqs(priv);
-       if (err)
-               return err;
        mlxbf_gige_cache_stats(priv);
        err = mlxbf_gige_clean_port(priv);
        if (err)
-               goto free_irqs;
+               return err;
 
        /* Clear driver's valid_polarity to match hardware,
         * since the above call to clean_port() resets the
@@ -157,7 +154,7 @@ static int mlxbf_gige_open(struct net_device *netdev)
 
        err = mlxbf_gige_tx_init(priv);
        if (err)
-               goto free_irqs;
+               goto phy_deinit;
        err = mlxbf_gige_rx_init(priv);
        if (err)
                goto tx_deinit;
@@ -166,6 +163,10 @@ static int mlxbf_gige_open(struct net_device *netdev)
        napi_enable(&priv->napi);
        netif_start_queue(netdev);
 
+       err = mlxbf_gige_request_irqs(priv);
+       if (err)
+               goto napi_deinit;
+
        /* Set bits in INT_EN that we care about */
        int_en = MLXBF_GIGE_INT_EN_HW_ACCESS_ERROR |
                 MLXBF_GIGE_INT_EN_TX_CHECKSUM_INPUTS |
@@ -182,11 +183,17 @@ static int mlxbf_gige_open(struct net_device *netdev)
 
        return 0;
 
+napi_deinit:
+       netif_stop_queue(netdev);
+       napi_disable(&priv->napi);
+       netif_napi_del(&priv->napi);
+       mlxbf_gige_rx_deinit(priv);
+
 tx_deinit:
        mlxbf_gige_tx_deinit(priv);
 
-free_irqs:
-       mlxbf_gige_free_irqs(priv);
+phy_deinit:
+       phy_stop(phydev);
        return err;
 }
 
index bd8aa83b47e5eef1bd523440d2b1a76fedb06d67..75a988c0bd794a83bd31d04b7072e841884ee986 100644 (file)
@@ -25,6 +25,8 @@
 #define PCS_POWER_STATE_DOWN   0x6
 #define PCS_POWER_STATE_UP     0x4
 
+#define RFE_RD_FIFO_TH_3_DWORDS        0x3
+
 static void pci11x1x_strap_get_status(struct lan743x_adapter *adapter)
 {
        u32 chip_rev;
@@ -3272,6 +3274,21 @@ static void lan743x_full_cleanup(struct lan743x_adapter *adapter)
        lan743x_pci_cleanup(adapter);
 }
 
+static void pci11x1x_set_rfe_rd_fifo_threshold(struct lan743x_adapter *adapter)
+{
+       u16 rev = adapter->csr.id_rev & ID_REV_CHIP_REV_MASK_;
+
+       if (rev == ID_REV_CHIP_REV_PCI11X1X_B0_) {
+               u32 misc_ctl;
+
+               misc_ctl = lan743x_csr_read(adapter, MISC_CTL_0);
+               misc_ctl &= ~MISC_CTL_0_RFE_READ_FIFO_MASK_;
+               misc_ctl |= FIELD_PREP(MISC_CTL_0_RFE_READ_FIFO_MASK_,
+                                      RFE_RD_FIFO_TH_3_DWORDS);
+               lan743x_csr_write(adapter, MISC_CTL_0, misc_ctl);
+       }
+}
+
 static int lan743x_hardware_init(struct lan743x_adapter *adapter,
                                 struct pci_dev *pdev)
 {
@@ -3287,6 +3304,7 @@ static int lan743x_hardware_init(struct lan743x_adapter *adapter,
                pci11x1x_strap_get_status(adapter);
                spin_lock_init(&adapter->eth_syslock_spinlock);
                mutex_init(&adapter->sgmii_rw_lock);
+               pci11x1x_set_rfe_rd_fifo_threshold(adapter);
        } else {
                adapter->max_tx_channels = LAN743X_MAX_TX_CHANNELS;
                adapter->used_tx_channels = LAN743X_USED_TX_CHANNELS;
index be79cb0ae5af339535704547f15e5d8bc3529551..645bc048e52ef50153a1ece92740827d84f4a3f7 100644 (file)
@@ -26,6 +26,7 @@
 #define ID_REV_CHIP_REV_MASK_          (0x0000FFFF)
 #define ID_REV_CHIP_REV_A0_            (0x00000000)
 #define ID_REV_CHIP_REV_B0_            (0x00000010)
+#define ID_REV_CHIP_REV_PCI11X1X_B0_   (0x000000B0)
 
 #define FPGA_REV                       (0x04)
 #define FPGA_REV_GET_MINOR_(fpga_rev)  (((fpga_rev) >> 8) & 0x000000FF)
 #define SGMII_CTL_LINK_STATUS_SOURCE_  BIT(8)
 #define SGMII_CTL_SGMII_POWER_DN_      BIT(1)
 
+#define MISC_CTL_0                     (0x920)
+#define MISC_CTL_0_RFE_READ_FIFO_MASK_ GENMASK(6, 4)
+
 /* Vendor Specific SGMII MMD details */
 #define SR_VSMMD_PCS_ID1               0x0004
 #define SR_VSMMD_PCS_ID2               0x0005
index 475e1e8c1d35f37845616e8653c01a62b3984491..0786eb0da39143da2ba2a550e3b936fc2669ec5f 100644 (file)
@@ -50,7 +50,7 @@
  * the macros available to do this only define GCC 8.
  */
 __diag_push();
-__diag_ignore(GCC, 8, "-Woverride-init",
+__diag_ignore_all("-Woverride-init",
              "logic to initialize all and then override some is OK");
 static const u16 sh_eth_offset_gigabit[SH_ETH_MAX_REGISTER_OFFSET] = {
        SH_ETH_OFFSET_DEFAULTS,
index 9df39cf8b0975048cd2f53edcb1e4c2336e51f1b..1072e2210aed32dbe8dda8f9d3b045a8a7a3a7ab 100644 (file)
@@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
        }
 
        /* map device registers */
-       lp->regs = devm_platform_ioremap_resource_byname(pdev, 0);
+       lp->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(lp->regs)) {
                dev_err(&pdev->dev, "could not map TEMAC registers\n");
                return -ENOMEM;
index 4717c59d51d042c205218ed32c779a836a86577b..e79657f76bea238ceb79c0b3c45c989b08f7592e 100644 (file)
@@ -797,7 +797,7 @@ static int at8031_parse_dt(struct phy_device *phydev)
 
 static int at8031_probe(struct phy_device *phydev)
 {
-       struct at803x_priv *priv = phydev->priv;
+       struct at803x_priv *priv;
        int mode_cfg;
        int ccr;
        int ret;
@@ -806,6 +806,8 @@ static int at8031_probe(struct phy_device *phydev)
        if (ret)
                return ret;
 
+       priv = phydev->priv;
+
        /* Only supported on AR8031/AR8033, the AR8030/AR8035 use strapping
         * options.
         */
index db6d7013df6654434774e9ec2bb4de33be50f4d2..c3bdf433d8f7b3aea81fd0ee919ad8f7fa8f692a 100644 (file)
@@ -3081,8 +3081,6 @@ static void iwl_fw_dbg_collect_sync(struct iwl_fw_runtime *fwrt, u8 wk_idx)
        struct iwl_fw_dbg_params params = {0};
        struct iwl_fwrt_dump_data *dump_data =
                &fwrt->dump.wks[wk_idx].dump_data;
-       u32 policy;
-       u32 time_point;
        if (!test_bit(wk_idx, &fwrt->dump.active_wks))
                return;
 
@@ -3113,13 +3111,16 @@ static void iwl_fw_dbg_collect_sync(struct iwl_fw_runtime *fwrt, u8 wk_idx)
 
        iwl_fw_dbg_stop_restart_recording(fwrt, &params, false);
 
-       policy = le32_to_cpu(dump_data->trig->apply_policy);
-       time_point = le32_to_cpu(dump_data->trig->time_point);
+       if (iwl_trans_dbg_ini_valid(fwrt->trans)) {
+               u32 policy = le32_to_cpu(dump_data->trig->apply_policy);
+               u32 time_point = le32_to_cpu(dump_data->trig->time_point);
 
-       if (policy & IWL_FW_INI_APPLY_POLICY_DUMP_COMPLETE_CMD) {
-               IWL_DEBUG_FW_INFO(fwrt, "WRT: sending dump complete\n");
-               iwl_send_dbg_dump_complete_cmd(fwrt, time_point, 0);
+               if (policy & IWL_FW_INI_APPLY_POLICY_DUMP_COMPLETE_CMD) {
+                       IWL_DEBUG_FW_INFO(fwrt, "WRT: sending dump complete\n");
+                       iwl_send_dbg_dump_complete_cmd(fwrt, time_point, 0);
+               }
        }
+
        if (fwrt->trans->dbg.last_tp_resetfw == IWL_FW_INI_RESET_FW_MODE_STOP_FW_ONLY)
                iwl_force_nmi(fwrt->trans);
 
index 553c6fffc7c66ddb182f00b75953fff86391c712..52518a47554e7087ded4782c24fd62340a17384a 100644 (file)
@@ -1260,15 +1260,15 @@ static int __iwl_mvm_suspend(struct ieee80211_hw *hw,
        if (IS_ERR_OR_NULL(vif))
                return 1;
 
-       if (ieee80211_vif_is_mld(vif) && vif->cfg.assoc) {
+       if (hweight16(vif->active_links) > 1) {
                /*
-                * Select the 'best' link. May need to revisit, it seems
-                * better to not optimize for throughput but rather range,
-                * reliability and power here - and select 2.4 GHz ...
+                * Select the 'best' link.
+                * May need to revisit, it seems better to not optimize
+                * for throughput but rather range, reliability and
+                * power here - and select 2.4 GHz ...
                 */
-               primary_link =
-                       iwl_mvm_mld_get_primary_link(mvm, vif,
-                                                    vif->active_links);
+               primary_link = iwl_mvm_mld_get_primary_link(mvm, vif,
+                                                           vif->active_links);
 
                if (WARN_ONCE(primary_link < 0, "no primary link in 0x%x\n",
                              vif->active_links))
@@ -1277,6 +1277,8 @@ static int __iwl_mvm_suspend(struct ieee80211_hw *hw,
                ret = ieee80211_set_active_links(vif, BIT(primary_link));
                if (ret)
                        return ret;
+       } else if (vif->active_links) {
+               primary_link = __ffs(vif->active_links);
        } else {
                primary_link = 0;
        }
index 51b01f7528beec1ec99c7a772bd372051e1463d1..7fe57ecd0682b8bcdebbb7c999f655903d498785 100644 (file)
@@ -748,7 +748,9 @@ void iwl_mvm_vif_dbgfs_add_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
 {
        struct dentry *dbgfs_dir = vif->debugfs_dir;
        struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
-       char buf[100];
+       char buf[3 * 3 + 11 + (NL80211_WIPHY_NAME_MAXLEN + 1) +
+                (7 + IFNAMSIZ + 1) + 6 + 1];
+       char name[7 + IFNAMSIZ + 1];
 
        /* this will happen in monitor mode */
        if (!dbgfs_dir)
@@ -761,10 +763,11 @@ void iwl_mvm_vif_dbgfs_add_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
         * find
         * netdev:wlan0 -> ../../../ieee80211/phy0/netdev:wlan0/iwlmvm/
         */
-       snprintf(buf, 100, "../../../%pd3/iwlmvm", dbgfs_dir);
+       snprintf(name, sizeof(name), "%pd", dbgfs_dir);
+       snprintf(buf, sizeof(buf), "../../../%pd3/iwlmvm", dbgfs_dir);
 
-       mvmvif->dbgfs_slink = debugfs_create_symlink(dbgfs_dir->d_name.name,
-                                                    mvm->debugfs_dir, buf);
+       mvmvif->dbgfs_slink =
+               debugfs_create_symlink(name, mvm->debugfs_dir, buf);
 }
 
 void iwl_mvm_vif_dbgfs_rm_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
index f13f13e6b71af17f1b8ca3ac97a40ba3e236b838..9f69e04594e49cb59f3102071c905bd75b93f825 100644 (file)
@@ -46,6 +46,27 @@ static int iwl_mvm_link_cmd_send(struct iwl_mvm *mvm,
        return ret;
 }
 
+int iwl_mvm_set_link_mapping(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
+                            struct ieee80211_bss_conf *link_conf)
+{
+       struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
+       struct iwl_mvm_vif_link_info *link_info =
+               mvmvif->link[link_conf->link_id];
+
+       if (link_info->fw_link_id == IWL_MVM_FW_LINK_ID_INVALID) {
+               link_info->fw_link_id = iwl_mvm_get_free_fw_link_id(mvm,
+                                                                   mvmvif);
+               if (link_info->fw_link_id >=
+                   ARRAY_SIZE(mvm->link_id_to_link_conf))
+                       return -EINVAL;
+
+               rcu_assign_pointer(mvm->link_id_to_link_conf[link_info->fw_link_id],
+                                  link_conf);
+       }
+
+       return 0;
+}
+
 int iwl_mvm_add_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
                     struct ieee80211_bss_conf *link_conf)
 {
@@ -55,19 +76,14 @@ int iwl_mvm_add_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
        struct iwl_link_config_cmd cmd = {};
        unsigned int cmd_id = WIDE_ID(MAC_CONF_GROUP, LINK_CONFIG_CMD);
        u8 cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw, cmd_id, 1);
+       int ret;
 
        if (WARN_ON_ONCE(!link_info))
                return -EINVAL;
 
-       if (link_info->fw_link_id == IWL_MVM_FW_LINK_ID_INVALID) {
-               link_info->fw_link_id = iwl_mvm_get_free_fw_link_id(mvm,
-                                                                   mvmvif);
-               if (link_info->fw_link_id >= ARRAY_SIZE(mvm->link_id_to_link_conf))
-                       return -EINVAL;
-
-               rcu_assign_pointer(mvm->link_id_to_link_conf[link_info->fw_link_id],
-                                  link_conf);
-       }
+       ret = iwl_mvm_set_link_mapping(mvm, vif, link_conf);
+       if (ret)
+               return ret;
 
        /* Update SF - Disable if needed. if this fails, SF might still be on
         * while many macs are bound, which is forbidden - so fail the binding.
@@ -248,6 +264,24 @@ send_cmd:
        return ret;
 }
 
+int iwl_mvm_unset_link_mapping(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
+                              struct ieee80211_bss_conf *link_conf)
+{
+       struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
+       struct iwl_mvm_vif_link_info *link_info =
+               mvmvif->link[link_conf->link_id];
+
+       /* mac80211 thought we have the link, but it was never configured */
+       if (WARN_ON(!link_info ||
+                   link_info->fw_link_id >=
+                   ARRAY_SIZE(mvm->link_id_to_link_conf)))
+               return -EINVAL;
+
+       RCU_INIT_POINTER(mvm->link_id_to_link_conf[link_info->fw_link_id],
+                        NULL);
+       return 0;
+}
+
 int iwl_mvm_remove_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
                        struct ieee80211_bss_conf *link_conf)
 {
@@ -257,13 +291,10 @@ int iwl_mvm_remove_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
        struct iwl_link_config_cmd cmd = {};
        int ret;
 
-       /* mac80211 thought we have the link, but it was never configured */
-       if (WARN_ON(!link_info ||
-                   link_info->fw_link_id >= ARRAY_SIZE(mvm->link_id_to_link_conf)))
+       ret = iwl_mvm_unset_link_mapping(mvm, vif, link_conf);
+       if (ret)
                return 0;
 
-       RCU_INIT_POINTER(mvm->link_id_to_link_conf[link_info->fw_link_id],
-                        NULL);
        cmd.link_id = cpu_to_le32(link_info->fw_link_id);
        iwl_mvm_release_fw_link_id(mvm, link_info->fw_link_id);
        link_info->fw_link_id = IWL_MVM_FW_LINK_ID_INVALID;
index 1935630d3def0092a15b5e0ce755cef1149cdd9f..8f4b063d6243ed98b4ddb2e51b27803bb379d015 100644 (file)
@@ -360,7 +360,7 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm)
        if (mvm->mld_api_is_used && mvm->nvm_data->sku_cap_11be_enable &&
            !iwlwifi_mod_params.disable_11ax &&
            !iwlwifi_mod_params.disable_11be)
-               hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_MLO;
+               hw->wiphy->flags |= WIPHY_FLAG_DISABLE_WEXT;
 
        /* With MLD FW API, it tracks timing by itself,
         * no need for any timing from the host
@@ -1577,8 +1577,14 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw,
        mvmvif->mvm = mvm;
 
        /* the first link always points to the default one */
+       mvmvif->deflink.fw_link_id = IWL_MVM_FW_LINK_ID_INVALID;
+       mvmvif->deflink.active = 0;
        mvmvif->link[0] = &mvmvif->deflink;
 
+       ret = iwl_mvm_set_link_mapping(mvm, vif, &vif->bss_conf);
+       if (ret)
+               goto out;
+
        /*
         * Not much to do here. The stack will not allow interface
         * types or combinations that we didn't advertise, so we
@@ -1783,6 +1789,7 @@ static void iwl_mvm_mac_remove_interface(struct ieee80211_hw *hw,
                mvm->p2p_device_vif = NULL;
        }
 
+       iwl_mvm_unset_link_mapping(mvm, vif, &vif->bss_conf);
        iwl_mvm_mac_ctxt_remove(mvm, vif);
 
        RCU_INIT_POINTER(mvm->vif_id_to_mac[mvmvif->id], NULL);
index 1628bf55458fcb0bf7d812970d619e815a89c950..23e64a757cfe86a06626a32430dc3919c983e91f 100644 (file)
@@ -855,10 +855,15 @@ int iwl_mvm_mld_rm_sta(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
 
 int iwl_mvm_mld_rm_sta_id(struct iwl_mvm *mvm, u8 sta_id)
 {
-       int ret = iwl_mvm_mld_rm_sta_from_fw(mvm, sta_id);
+       int ret;
 
        lockdep_assert_held(&mvm->mutex);
 
+       if (WARN_ON(sta_id == IWL_MVM_INVALID_STA))
+               return 0;
+
+       ret = iwl_mvm_mld_rm_sta_from_fw(mvm, sta_id);
+
        RCU_INIT_POINTER(mvm->fw_id_to_mac_id[sta_id], NULL);
        RCU_INIT_POINTER(mvm->fw_id_to_link_sta[sta_id], NULL);
        return ret;
index 44571114fb154b39ab0e3be14aa41543241a980e..f0b24f00938bd52250a0153791040832ec203d32 100644 (file)
@@ -1916,11 +1916,15 @@ int iwl_mvm_binding_remove_vif(struct iwl_mvm *mvm, struct ieee80211_vif *vif);
 u32 iwl_mvm_get_lmac_id(struct iwl_mvm *mvm, enum nl80211_band band);
 
 /* Links */
+int iwl_mvm_set_link_mapping(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
+                            struct ieee80211_bss_conf *link_conf);
 int iwl_mvm_add_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
                     struct ieee80211_bss_conf *link_conf);
 int iwl_mvm_link_changed(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
                         struct ieee80211_bss_conf *link_conf,
                         u32 changes, bool active);
+int iwl_mvm_unset_link_mapping(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
+                              struct ieee80211_bss_conf *link_conf);
 int iwl_mvm_remove_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
                        struct ieee80211_bss_conf *link_conf);
 int iwl_mvm_disable_link(struct iwl_mvm *mvm, struct ieee80211_vif *vif,
index 2ecd32bed752ff55734d5e9f78f36efc213cb107..045c862a8fc4fc66c0e5c6cfa8333ae4fb968f28 100644 (file)
@@ -132,14 +132,18 @@ struct iwl_rfi_freq_table_resp_cmd *iwl_rfi_get_freq_table(struct iwl_mvm *mvm)
        if (ret)
                return ERR_PTR(ret);
 
-       if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) != resp_size))
+       if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) !=
+                        resp_size)) {
+               iwl_free_resp(&cmd);
                return ERR_PTR(-EIO);
+       }
 
        resp = kmemdup(cmd.resp_pkt->data, resp_size, GFP_KERNEL);
+       iwl_free_resp(&cmd);
+
        if (!resp)
                return ERR_PTR(-ENOMEM);
 
-       iwl_free_resp(&cmd);
        return resp;
 }
 
index 1484eaedf45292d53b349000b274fd25e435c369..ce8d83c771a70d9c93e17a562bb8b4e1e5c7a120 100644 (file)
@@ -236,21 +236,13 @@ static void iwl_mvm_add_rtap_sniffer_config(struct iwl_mvm *mvm,
 static void iwl_mvm_pass_packet_to_mac80211(struct iwl_mvm *mvm,
                                            struct napi_struct *napi,
                                            struct sk_buff *skb, int queue,
-                                           struct ieee80211_sta *sta,
-                                           struct ieee80211_link_sta *link_sta)
+                                           struct ieee80211_sta *sta)
 {
        if (unlikely(iwl_mvm_check_pn(mvm, skb, queue, sta))) {
                kfree_skb(skb);
                return;
        }
 
-       if (sta && sta->valid_links && link_sta) {
-               struct ieee80211_rx_status *rx_status = IEEE80211_SKB_RXCB(skb);
-
-               rx_status->link_valid = 1;
-               rx_status->link_id = link_sta->link_id;
-       }
-
        ieee80211_rx_napi(mvm->hw, sta, skb, napi);
 }
 
@@ -588,7 +580,7 @@ static void iwl_mvm_release_frames(struct iwl_mvm *mvm,
                while ((skb = __skb_dequeue(skb_list))) {
                        iwl_mvm_pass_packet_to_mac80211(mvm, napi, skb,
                                                        reorder_buf->queue,
-                                                       sta, NULL /* FIXME */);
+                                                       sta);
                        reorder_buf->num_stored--;
                }
        }
@@ -2213,6 +2205,11 @@ void iwl_mvm_rx_mpdu_mq(struct iwl_mvm *mvm, struct napi_struct *napi,
                        if (IS_ERR(sta))
                                sta = NULL;
                        link_sta = rcu_dereference(mvm->fw_id_to_link_sta[id]);
+
+                       if (sta && sta->valid_links && link_sta) {
+                               rx_status->link_valid = 1;
+                               rx_status->link_id = link_sta->link_id;
+                       }
                }
        } else if (!is_multicast_ether_addr(hdr->addr2)) {
                /*
@@ -2356,8 +2353,7 @@ void iwl_mvm_rx_mpdu_mq(struct iwl_mvm *mvm, struct napi_struct *napi,
                    !(desc->amsdu_info & IWL_RX_MPDU_AMSDU_LAST_SUBFRAME))
                        rx_status->flag |= RX_FLAG_AMSDU_MORE;
 
-               iwl_mvm_pass_packet_to_mac80211(mvm, napi, skb, queue, sta,
-                                               link_sta);
+               iwl_mvm_pass_packet_to_mac80211(mvm, napi, skb, queue, sta);
        }
 out:
        rcu_read_unlock();
index a59d264a11c52f5174fe4475c6915bf5c49760d4..ad960faceb0d8f6b05160a547b056d45f47563f2 100644 (file)
@@ -879,9 +879,8 @@ void iwl_mvm_rx_session_protect_notif(struct iwl_mvm *mvm,
        struct iwl_rx_packet *pkt = rxb_addr(rxb);
        struct iwl_mvm_session_prot_notif *notif = (void *)pkt->data;
        unsigned int ver =
-               iwl_fw_lookup_cmd_ver(mvm->fw,
-                                     WIDE_ID(MAC_CONF_GROUP,
-                                             SESSION_PROTECTION_CMD), 2);
+               iwl_fw_lookup_notif_ver(mvm->fw, MAC_CONF_GROUP,
+                                       SESSION_PROTECTION_NOTIF, 2);
        int id = le32_to_cpu(notif->mac_link_id);
        struct ieee80211_vif *vif;
        struct iwl_mvm_vif *mvmvif;
index 33973a60d0bf4165e71573807d8791cede555a3d..6229c785c8457616834cac32fc19c59b31f5c24e 100644 (file)
@@ -1589,9 +1589,9 @@ void iwl_txq_reclaim(struct iwl_trans *trans, int txq_id, int ssn,
                return;
 
        tfd_num = iwl_txq_get_cmd_index(txq, ssn);
-       read_ptr = iwl_txq_get_cmd_index(txq, txq->read_ptr);
 
        spin_lock_bh(&txq->lock);
+       read_ptr = iwl_txq_get_cmd_index(txq, txq->read_ptr);
 
        if (!test_bit(txq_id, trans->txqs.queue_used)) {
                IWL_DEBUG_TX_QUEUES(trans, "Q %d inactive - ignoring idx %d\n",
index 367459bd1345742f00e600773e3613abf7e7066c..708132d5be2a6ad179a8361375e1c25f6e785919 100644 (file)
@@ -2233,7 +2233,7 @@ static void rtw8922a_btc_init_cfg(struct rtw89_dev *rtwdev)
                 * Shared-Ant && BTG-path:WL mask(0x55f), others:WL THRU(0x5ff)
                 */
                if (btc->ant_type == BTC_ANT_SHARED && btc->btg_pos == path)
-                       rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff);
+                       rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x55f);
                else
                        rtw8922a_set_trx_mask(rtwdev, path, BTC_BT_TX_GROUP, 0x5ff);
 
index 9f43f256db1d063c45c17dda3d78037be4183f9c..f0a4783baf1f328ed50e629591244f3a4ccb77eb 100644 (file)
@@ -106,7 +106,7 @@ bool t7xx_cldma_tx_addr_is_set(struct t7xx_cldma_hw *hw_info, unsigned int qno)
 {
        u32 offset = REG_CLDMA_UL_START_ADDRL_0 + qno * ADDR_SIZE;
 
-       return ioread64(hw_info->ap_pdn_base + offset);
+       return ioread64_lo_hi(hw_info->ap_pdn_base + offset);
 }
 
 void t7xx_cldma_hw_set_start_addr(struct t7xx_cldma_hw *hw_info, unsigned int qno, u64 address,
@@ -117,7 +117,7 @@ void t7xx_cldma_hw_set_start_addr(struct t7xx_cldma_hw *hw_info, unsigned int qn
 
        reg = tx_rx == MTK_RX ? hw_info->ap_ao_base + REG_CLDMA_DL_START_ADDRL_0 :
                                hw_info->ap_pdn_base + REG_CLDMA_UL_START_ADDRL_0;
-       iowrite64(address, reg + offset);
+       iowrite64_lo_hi(address, reg + offset);
 }
 
 void t7xx_cldma_hw_resume_queue(struct t7xx_cldma_hw *hw_info, unsigned int qno,
index abc41a7089fa4f9e1efb1a51e3375d57321b51c6..97163e1e5783ed26cf7507bb16711dad80bbc430 100644 (file)
@@ -137,8 +137,9 @@ static int t7xx_cldma_gpd_rx_from_q(struct cldma_queue *queue, int budget, bool
                                return -ENODEV;
                        }
 
-                       gpd_addr = ioread64(hw_info->ap_pdn_base + REG_CLDMA_DL_CURRENT_ADDRL_0 +
-                                           queue->index * sizeof(u64));
+                       gpd_addr = ioread64_lo_hi(hw_info->ap_pdn_base +
+                                                 REG_CLDMA_DL_CURRENT_ADDRL_0 +
+                                                 queue->index * sizeof(u64));
                        if (req->gpd_addr == gpd_addr || hwo_polling_count++ >= 100)
                                return 0;
 
@@ -316,8 +317,8 @@ static void t7xx_cldma_txq_empty_hndl(struct cldma_queue *queue)
                struct t7xx_cldma_hw *hw_info = &md_ctrl->hw_info;
 
                /* Check current processing TGPD, 64-bit address is in a table by Q index */
-               ul_curr_addr = ioread64(hw_info->ap_pdn_base + REG_CLDMA_UL_CURRENT_ADDRL_0 +
-                                       queue->index * sizeof(u64));
+               ul_curr_addr = ioread64_lo_hi(hw_info->ap_pdn_base + REG_CLDMA_UL_CURRENT_ADDRL_0 +
+                                             queue->index * sizeof(u64));
                if (req->gpd_addr != ul_curr_addr) {
                        spin_unlock_irqrestore(&md_ctrl->cldma_lock, flags);
                        dev_err(md_ctrl->dev, "CLDMA%d queue %d is not empty\n",
index 76da4c15e3de17c11d0373a26066450b34ee9666..f071ec7ff23d50842b280fae1535863ecfd0740d 100644 (file)
@@ -75,7 +75,7 @@ static void t7xx_pcie_mac_atr_tables_dis(void __iomem *pbase, enum t7xx_atr_src_
        for (i = 0; i < ATR_TABLE_NUM_PER_ATR; i++) {
                offset = ATR_PORT_OFFSET * port + ATR_TABLE_OFFSET * i;
                reg = pbase + ATR_PCIE_WIN0_T0_ATR_PARAM_SRC_ADDR + offset;
-               iowrite64(0, reg);
+               iowrite64_lo_hi(0, reg);
        }
 }
 
@@ -112,17 +112,17 @@ static int t7xx_pcie_mac_atr_cfg(struct t7xx_pci_dev *t7xx_dev, struct t7xx_atr_
 
        reg = pbase + ATR_PCIE_WIN0_T0_TRSL_ADDR + offset;
        value = cfg->trsl_addr & ATR_PCIE_WIN0_ADDR_ALGMT;
-       iowrite64(value, reg);
+       iowrite64_lo_hi(value, reg);
 
        reg = pbase + ATR_PCIE_WIN0_T0_TRSL_PARAM + offset;
        iowrite32(cfg->trsl_id, reg);
 
        reg = pbase + ATR_PCIE_WIN0_T0_ATR_PARAM_SRC_ADDR + offset;
        value = (cfg->src_addr & ATR_PCIE_WIN0_ADDR_ALGMT) | (atr_size << 1) | BIT(0);
-       iowrite64(value, reg);
+       iowrite64_lo_hi(value, reg);
 
        /* Ensure ATR is set */
-       ioread64(reg);
+       ioread64_lo_hi(reg);
        return 0;
 }
 
index 489ea1778353f730e51612f313f6283de36225f2..db2a7600ae2bdeec935f0056db71187b9a73d6b2 100644 (file)
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 # Aspeed pinctrl support
 
-ccflags-y += $(call cc-option,-Woverride-init)
+ccflags-y += -Woverride-init
 obj-$(CONFIG_PINCTRL_ASPEED)   += pinctrl-aspeed.o pinmux-aspeed.o
 obj-$(CONFIG_PINCTRL_ASPEED_G4)        += pinctrl-aspeed-g4.o
 obj-$(CONFIG_PINCTRL_ASPEED_G5)        += pinctrl-aspeed-g5.o
index 49f89b70dcecb4a4465b62aecded05aa3e0b19f7..7f66ec73199a9c155174b2dc3c172112f064d510 100644 (file)
@@ -1159,7 +1159,7 @@ static int amd_gpio_probe(struct platform_device *pdev)
        }
 
        ret = devm_request_irq(&pdev->dev, gpio_dev->irq, amd_gpio_irq_handler,
-                              IRQF_SHARED | IRQF_ONESHOT, KBUILD_MODNAME, gpio_dev);
+                              IRQF_SHARED | IRQF_COND_ONESHOT, KBUILD_MODNAME, gpio_dev);
        if (ret)
                goto out2;
 
index d79a96679a26c92fe04c909e215b34f41128de74..d6596583ed4e780d36f9631f0039445673e629b6 100644 (file)
@@ -284,9 +284,9 @@ static int img_pwm_probe(struct platform_device *pdev)
                return PTR_ERR(imgchip->sys_clk);
        }
 
-       imgchip->pwm_clk = devm_clk_get(&pdev->dev, "imgchip");
+       imgchip->pwm_clk = devm_clk_get(&pdev->dev, "pwm");
        if (IS_ERR(imgchip->pwm_clk)) {
-               dev_err(&pdev->dev, "failed to get imgchip clock\n");
+               dev_err(&pdev->dev, "failed to get pwm clock\n");
                return PTR_ERR(imgchip->pwm_clk);
        }
 
index 2f4ac9591c8f5a24e6630bda848505b19ce5e3ba..271dfad05d6835cb5a52feccdcfd6abfcf1410c3 100644 (file)
@@ -150,6 +150,8 @@ static unsigned int max_nr_fru;
 /* Total length of record including headers and list of descriptor entries. */
 static size_t max_rec_len;
 
+#define FMPM_MAX_REC_LEN (sizeof(struct fru_rec) + (sizeof(struct cper_fru_poison_desc) * 255))
+
 /* Total number of SPA entries across all FRUs. */
 static unsigned int spa_nr_entries;
 
@@ -475,6 +477,16 @@ static void set_rec_fields(struct fru_rec *rec)
        struct cper_section_descriptor  *sec_desc = &rec->sec_desc;
        struct cper_record_header       *hdr      = &rec->hdr;
 
+       /*
+        * This is a saved record created with fewer max_nr_entries.
+        * Update the record lengths and keep everything else as-is.
+        */
+       if (hdr->record_length && hdr->record_length < max_rec_len) {
+               pr_debug("Growing record 0x%016llx from %u to %zu bytes\n",
+                        hdr->record_id, hdr->record_length, max_rec_len);
+               goto update_lengths;
+       }
+
        memcpy(hdr->signature, CPER_SIG_RECORD, CPER_SIG_SIZE);
        hdr->revision                   = CPER_RECORD_REV;
        hdr->signature_end              = CPER_SIG_END;
@@ -489,19 +501,21 @@ static void set_rec_fields(struct fru_rec *rec)
        hdr->error_severity             = CPER_SEV_RECOVERABLE;
 
        hdr->validation_bits            = 0;
-       hdr->record_length              = max_rec_len;
        hdr->creator_id                 = CPER_CREATOR_FMP;
        hdr->notification_type          = CPER_NOTIFY_MCE;
        hdr->record_id                  = cper_next_record_id();
        hdr->flags                      = CPER_HW_ERROR_FLAGS_PREVERR;
 
        sec_desc->section_offset        = sizeof(struct cper_record_header);
-       sec_desc->section_length        = max_rec_len - sizeof(struct cper_record_header);
        sec_desc->revision              = CPER_SEC_REV;
        sec_desc->validation_bits       = 0;
        sec_desc->flags                 = CPER_SEC_PRIMARY;
        sec_desc->section_type          = CPER_SECTION_TYPE_FMP;
        sec_desc->section_severity      = CPER_SEV_RECOVERABLE;
+
+update_lengths:
+       hdr->record_length              = max_rec_len;
+       sec_desc->section_length        = max_rec_len - sizeof(struct cper_record_header);
 }
 
 static int save_new_records(void)
@@ -512,16 +526,18 @@ static int save_new_records(void)
        int ret = 0;
 
        for_each_fru(i, rec) {
-               if (rec->hdr.record_length)
+               /* No need to update saved records that match the current record size. */
+               if (rec->hdr.record_length == max_rec_len)
                        continue;
 
+               if (!rec->hdr.record_length)
+                       set_bit(i, new_records);
+
                set_rec_fields(rec);
 
                ret = update_record_on_storage(rec);
                if (ret)
                        goto out_clear;
-
-               set_bit(i, new_records);
        }
 
        return ret;
@@ -641,12 +657,7 @@ static int get_saved_records(void)
        int ret, pos;
        ssize_t len;
 
-       /*
-        * Assume saved records match current max size.
-        *
-        * However, this may not be true depending on module parameters.
-        */
-       old = kmalloc(max_rec_len, GFP_KERNEL);
+       old = kmalloc(FMPM_MAX_REC_LEN, GFP_KERNEL);
        if (!old) {
                ret = -ENOMEM;
                goto out;
@@ -663,21 +674,31 @@ static int get_saved_records(void)
                 * Make sure to clear temporary buffer between reads to avoid
                 * leftover data from records of various sizes.
                 */
-               memset(old, 0, max_rec_len);
+               memset(old, 0, FMPM_MAX_REC_LEN);
 
-               len = erst_read_record(record_id, &old->hdr, max_rec_len,
+               len = erst_read_record(record_id, &old->hdr, FMPM_MAX_REC_LEN,
                                       sizeof(struct fru_rec), &CPER_CREATOR_FMP);
                if (len < 0)
                        continue;
 
-               if (len > max_rec_len) {
-                       pr_debug("Found record larger than max_rec_len\n");
+               new = get_valid_record(old);
+               if (!new) {
+                       erst_clear(record_id);
                        continue;
                }
 
-               new = get_valid_record(old);
-               if (!new)
-                       erst_clear(record_id);
+               if (len > max_rec_len) {
+                       unsigned int saved_nr_entries;
+
+                       saved_nr_entries  = len - sizeof(struct fru_rec);
+                       saved_nr_entries /= sizeof(struct cper_fru_poison_desc);
+
+                       pr_warn("Saved record found with %u entries.\n", saved_nr_entries);
+                       pr_warn("Please increase max_nr_entries to %u.\n", saved_nr_entries);
+
+                       ret = -EINVAL;
+                       goto out_end;
+               }
 
                /* Restore the record */
                memcpy(new, old, len);
index 4749ccdeeba12236aff3f8178dbed8582764272a..5a2f48439258cd6e2b0f2a92947074b2baf86f40 100644 (file)
@@ -4,6 +4,10 @@
 
 #include <linux/debugfs.h>
 
+#if IS_ENABLED(CONFIG_DEBUG_FS)
 struct dentry *ras_get_debugfs_root(void);
+#else
+static inline struct dentry *ras_get_debugfs_root(void) { return NULL; }
+#endif /* DEBUG_FS */
 
 #endif /* __RAS_DEBUGFS_H__ */
index a0cce6872075d4330578065191804db4f6bd747b..f0b8b709649f29691c3d0976b8a1156da1f6bd81 100644 (file)
@@ -1179,6 +1179,20 @@ static int qeth_check_irb_error(struct qeth_card *card, struct ccw_device *cdev,
        }
 }
 
+/**
+ * qeth_irq() - qeth interrupt handler
+ * @cdev: ccw device
+ * @intparm: expect pointer to iob
+ * @irb: Interruption Response Block
+ *
+ * In the good path:
+ * corresponding qeth channel is locked with last used iob as active_cmd.
+ * But this function is also called for error interrupts.
+ *
+ * Caller ensures that:
+ * Interrupts are disabled; ccw device lock is held;
+ *
+ */
 static void qeth_irq(struct ccw_device *cdev, unsigned long intparm,
                struct irb *irb)
 {
@@ -1220,11 +1234,10 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm,
                iob = (struct qeth_cmd_buffer *) (addr_t)intparm;
        }
 
-       qeth_unlock_channel(card, channel);
-
        rc = qeth_check_irb_error(card, cdev, irb);
        if (rc) {
                /* IO was terminated, free its resources. */
+               qeth_unlock_channel(card, channel);
                if (iob)
                        qeth_cancel_cmd(iob, rc);
                return;
@@ -1268,6 +1281,7 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm,
                rc = qeth_get_problem(card, cdev, irb);
                if (rc) {
                        card->read_or_write_problem = 1;
+                       qeth_unlock_channel(card, channel);
                        if (iob)
                                qeth_cancel_cmd(iob, rc);
                        qeth_clear_ipacmd_list(card);
@@ -1276,6 +1290,26 @@ static void qeth_irq(struct ccw_device *cdev, unsigned long intparm,
                }
        }
 
+       if (scsw_cmd_is_valid_cc(&irb->scsw) && irb->scsw.cmd.cc == 1 && iob) {
+               /* channel command hasn't started: retry.
+                * active_cmd is still set to last iob
+                */
+               QETH_CARD_TEXT(card, 2, "irqcc1");
+               rc = ccw_device_start_timeout(cdev, __ccw_from_cmd(iob),
+                                             (addr_t)iob, 0, 0, iob->timeout);
+               if (rc) {
+                       QETH_DBF_MESSAGE(2,
+                                        "ccw retry on %x failed, rc = %i\n",
+                                        CARD_DEVID(card), rc);
+                       QETH_CARD_TEXT_(card, 2, " err%d", rc);
+                       qeth_unlock_channel(card, channel);
+                       qeth_cancel_cmd(iob, rc);
+               }
+               return;
+       }
+
+       qeth_unlock_channel(card, channel);
+
        if (iob) {
                /* sanity check: */
                if (irb->scsw.cmd.count > iob->length) {
index 2c246e80c1c4d614fafb7183ecd8c5515bc9dd13..d91659811eb3c569e437d61a92a5fb3746d2902e 100644 (file)
@@ -833,7 +833,6 @@ static void bnx2fc_free_session_resc(struct bnx2fc_hba *hba,
 
        BNX2FC_TGT_DBG(tgt, "Freeing up session resources\n");
 
-       spin_lock_bh(&tgt->cq_lock);
        ctx_base_ptr = tgt->ctx_base;
        tgt->ctx_base = NULL;
 
@@ -889,7 +888,6 @@ static void bnx2fc_free_session_resc(struct bnx2fc_hba *hba,
                                    tgt->sq, tgt->sq_dma);
                tgt->sq = NULL;
        }
-       spin_unlock_bh(&tgt->cq_lock);
 
        if (ctx_base_ptr)
                iounmap(ctx_base_ptr);
index 1befcd5b2a0f935afa86935f619bc2cb8ca331ae..fa07a6f54003ee3651a4af982534d0f1135ceed7 100644 (file)
@@ -102,7 +102,9 @@ do {                                                                        \
 
 #define MAX_RETRIES   1
 
-static struct class * ch_sysfs_class;
+static const struct class ch_sysfs_class = {
+       .name = "scsi_changer",
+};
 
 typedef struct {
        struct kref         ref;
@@ -930,7 +932,7 @@ static int ch_probe(struct device *dev)
        mutex_init(&ch->lock);
        kref_init(&ch->ref);
        ch->device = sd;
-       class_dev = device_create(ch_sysfs_class, dev,
+       class_dev = device_create(&ch_sysfs_class, dev,
                                  MKDEV(SCSI_CHANGER_MAJOR, ch->minor), ch,
                                  "s%s", ch->name);
        if (IS_ERR(class_dev)) {
@@ -955,7 +957,7 @@ static int ch_probe(struct device *dev)
 
        return 0;
 destroy_dev:
-       device_destroy(ch_sysfs_class, MKDEV(SCSI_CHANGER_MAJOR, ch->minor));
+       device_destroy(&ch_sysfs_class, MKDEV(SCSI_CHANGER_MAJOR, ch->minor));
 put_device:
        scsi_device_put(sd);
 remove_idr:
@@ -974,7 +976,7 @@ static int ch_remove(struct device *dev)
        dev_set_drvdata(dev, NULL);
        spin_unlock(&ch_index_lock);
 
-       device_destroy(ch_sysfs_class, MKDEV(SCSI_CHANGER_MAJOR,ch->minor));
+       device_destroy(&ch_sysfs_class, MKDEV(SCSI_CHANGER_MAJOR, ch->minor));
        scsi_device_put(ch->device);
        kref_put(&ch->ref, ch_destroy);
        return 0;
@@ -1003,11 +1005,9 @@ static int __init init_ch_module(void)
        int rc;
 
        printk(KERN_INFO "SCSI Media Changer driver v" VERSION " \n");
-        ch_sysfs_class = class_create("scsi_changer");
-        if (IS_ERR(ch_sysfs_class)) {
-               rc = PTR_ERR(ch_sysfs_class);
+       rc = class_register(&ch_sysfs_class);
+       if (rc)
                return rc;
-        }
        rc = register_chrdev(SCSI_CHANGER_MAJOR,"ch",&changer_fops);
        if (rc < 0) {
                printk("Unable to get major %d for SCSI-Changer\n",
@@ -1022,7 +1022,7 @@ static int __init init_ch_module(void)
  fail2:
        unregister_chrdev(SCSI_CHANGER_MAJOR, "ch");
  fail1:
-       class_destroy(ch_sysfs_class);
+       class_unregister(&ch_sysfs_class);
        return rc;
 }
 
@@ -1030,7 +1030,7 @@ static void __exit exit_ch_module(void)
 {
        scsi_unregister_driver(&ch_template.gendrv);
        unregister_chrdev(SCSI_CHANGER_MAJOR, "ch");
-       class_destroy(ch_sysfs_class);
+       class_unregister(&ch_sysfs_class);
        idr_destroy(&ch_index_idr);
 }
 
index debd3697411974aa10b59d222b04aab919b5aeb1..e8382cc5cf23c01515d189b2f8b3580d23a289b6 100644 (file)
@@ -28,7 +28,12 @@ MODULE_AUTHOR("Manoj N. Kumar <manoj@linux.vnet.ibm.com>");
 MODULE_AUTHOR("Matthew R. Ochs <mrochs@linux.vnet.ibm.com>");
 MODULE_LICENSE("GPL");
 
-static struct class *cxlflash_class;
+static char *cxlflash_devnode(const struct device *dev, umode_t *mode);
+static const struct class cxlflash_class = {
+       .name = "cxlflash",
+       .devnode = cxlflash_devnode,
+};
+
 static u32 cxlflash_major;
 static DECLARE_BITMAP(cxlflash_minor, CXLFLASH_MAX_ADAPTERS);
 
@@ -3602,7 +3607,7 @@ static int init_chrdev(struct cxlflash_cfg *cfg)
                goto err1;
        }
 
-       char_dev = device_create(cxlflash_class, NULL, devno,
+       char_dev = device_create(&cxlflash_class, NULL, devno,
                                 NULL, "cxlflash%d", minor);
        if (IS_ERR(char_dev)) {
                rc = PTR_ERR(char_dev);
@@ -3880,14 +3885,12 @@ static int cxlflash_class_init(void)
 
        cxlflash_major = MAJOR(devno);
 
-       cxlflash_class = class_create("cxlflash");
-       if (IS_ERR(cxlflash_class)) {
-               rc = PTR_ERR(cxlflash_class);
+       rc = class_register(&cxlflash_class);
+       if (rc) {
                pr_err("%s: class_create failed rc=%d\n", __func__, rc);
                goto err;
        }
 
-       cxlflash_class->devnode = cxlflash_devnode;
 out:
        pr_debug("%s: returning rc=%d\n", __func__, rc);
        return rc;
@@ -3903,7 +3906,7 @@ static void cxlflash_class_exit(void)
 {
        dev_t devno = MKDEV(cxlflash_major, 0);
 
-       class_destroy(cxlflash_class);
+       class_unregister(&cxlflash_class);
        unregister_chrdev_region(devno, CXLFLASH_MAX_ADAPTERS);
 }
 
index 4f495a41ec4aaed4c52d01ee84fc274c30236a09..2d92549e52431934199ca4319c250798a1884b8e 100644 (file)
@@ -353,12 +353,13 @@ static void scsi_host_dev_release(struct device *dev)
 
        if (shost->shost_state == SHOST_CREATED) {
                /*
-                * Free the shost_dev device name here if scsi_host_alloc()
-                * and scsi_host_put() have been called but neither
+                * Free the shost_dev device name and remove the proc host dir
+                * here if scsi_host_{alloc,put}() have been called but neither
                 * scsi_host_add() nor scsi_remove_host() has been called.
                 * This avoids that the memory allocated for the shost_dev
-                * name is leaked.
+                * name as well as the proc dir structure are leaked.
                 */
+               scsi_proc_hostdir_rm(shost->hostt);
                kfree(dev_name(&shost->shost_dev));
        }
 
index a2204674b6808fa3df84288d7f5b134680232fd1..5c261005b74e47063172d3a0d10fb6e34cf74764 100644 (file)
@@ -1621,6 +1621,16 @@ out_err:
 
 /* ---------- Domain revalidation ---------- */
 
+static void sas_get_sas_addr_and_dev_type(struct smp_disc_resp *disc_resp,
+                                         u8 *sas_addr,
+                                         enum sas_device_type *type)
+{
+       memcpy(sas_addr, disc_resp->disc.attached_sas_addr, SAS_ADDR_SIZE);
+       *type = to_dev_type(&disc_resp->disc);
+       if (*type == SAS_PHY_UNUSED)
+               memset(sas_addr, 0, SAS_ADDR_SIZE);
+}
+
 static int sas_get_phy_discover(struct domain_device *dev,
                                int phy_id, struct smp_disc_resp *disc_resp)
 {
@@ -1674,13 +1684,8 @@ int sas_get_phy_attached_dev(struct domain_device *dev, int phy_id,
                return -ENOMEM;
 
        res = sas_get_phy_discover(dev, phy_id, disc_resp);
-       if (res == 0) {
-               memcpy(sas_addr, disc_resp->disc.attached_sas_addr,
-                      SAS_ADDR_SIZE);
-               *type = to_dev_type(&disc_resp->disc);
-               if (*type == 0)
-                       memset(sas_addr, 0, SAS_ADDR_SIZE);
-       }
+       if (res == 0)
+               sas_get_sas_addr_and_dev_type(disc_resp, sas_addr, type);
        kfree(disc_resp);
        return res;
 }
@@ -1940,6 +1945,7 @@ static int sas_rediscover_dev(struct domain_device *dev, int phy_id,
        struct expander_device *ex = &dev->ex_dev;
        struct ex_phy *phy = &ex->ex_phy[phy_id];
        enum sas_device_type type = SAS_PHY_UNUSED;
+       struct smp_disc_resp *disc_resp;
        u8 sas_addr[SAS_ADDR_SIZE];
        char msg[80] = "";
        int res;
@@ -1951,33 +1957,41 @@ static int sas_rediscover_dev(struct domain_device *dev, int phy_id,
                 SAS_ADDR(dev->sas_addr), phy_id, msg);
 
        memset(sas_addr, 0, SAS_ADDR_SIZE);
-       res = sas_get_phy_attached_dev(dev, phy_id, sas_addr, &type);
+       disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
+       if (!disc_resp)
+               return -ENOMEM;
+
+       res = sas_get_phy_discover(dev, phy_id, disc_resp);
        switch (res) {
        case SMP_RESP_NO_PHY:
                phy->phy_state = PHY_NOT_PRESENT;
                sas_unregister_devs_sas_addr(dev, phy_id, last);
-               return res;
+               goto out_free_resp;
        case SMP_RESP_PHY_VACANT:
                phy->phy_state = PHY_VACANT;
                sas_unregister_devs_sas_addr(dev, phy_id, last);
-               return res;
+               goto out_free_resp;
        case SMP_RESP_FUNC_ACC:
                break;
        case -ECOMM:
                break;
        default:
-               return res;
+               goto out_free_resp;
        }
 
+       if (res == 0)
+               sas_get_sas_addr_and_dev_type(disc_resp, sas_addr, &type);
+
        if ((SAS_ADDR(sas_addr) == 0) || (res == -ECOMM)) {
                phy->phy_state = PHY_EMPTY;
                sas_unregister_devs_sas_addr(dev, phy_id, last);
                /*
-                * Even though the PHY is empty, for convenience we discover
-                * the PHY to update the PHY info, like negotiated linkrate.
+                * Even though the PHY is empty, for convenience we update
+                * the PHY info, like negotiated linkrate.
                 */
-               sas_ex_phy_discover(dev, phy_id);
-               return res;
+               if (res == 0)
+                       sas_set_ex_phy(dev, phy_id, disc_resp);
+               goto out_free_resp;
        } else if (SAS_ADDR(sas_addr) == SAS_ADDR(phy->attached_sas_addr) &&
                   dev_type_flutter(type, phy->attached_dev_type)) {
                struct domain_device *ata_dev = sas_ex_to_ata(dev, phy_id);
@@ -1989,7 +2003,7 @@ static int sas_rediscover_dev(struct domain_device *dev, int phy_id,
                        action = ", needs recovery";
                pr_debug("ex %016llx phy%02d broadcast flutter%s\n",
                         SAS_ADDR(dev->sas_addr), phy_id, action);
-               return res;
+               goto out_free_resp;
        }
 
        /* we always have to delete the old device when we went here */
@@ -1998,7 +2012,10 @@ static int sas_rediscover_dev(struct domain_device *dev, int phy_id,
                SAS_ADDR(phy->attached_sas_addr));
        sas_unregister_devs_sas_addr(dev, phy_id, last);
 
-       return sas_discover_new(dev, phy_id);
+       res = sas_discover_new(dev, phy_id);
+out_free_resp:
+       kfree(disc_resp);
+       return res;
 }
 
 /**
index 30d20d37554f6deb28ce816a7307c41db4ae264a..98ca7df003efb377427ceed6ac431b0c1e6a97d5 100644 (file)
@@ -1333,7 +1333,6 @@ struct lpfc_hba {
        struct timer_list fabric_block_timer;
        unsigned long bit_flags;
        atomic_t num_rsrc_err;
-       atomic_t num_cmd_success;
        unsigned long last_rsrc_error_time;
        unsigned long last_ramp_down_time;
 #ifdef CONFIG_SCSI_LPFC_DEBUG_FS
@@ -1438,6 +1437,7 @@ struct lpfc_hba {
        struct timer_list inactive_vmid_poll;
 
        /* RAS Support */
+       spinlock_t ras_fwlog_lock; /* do not take while holding another lock */
        struct lpfc_ras_fwlog ras_fwlog;
 
        uint32_t iocb_cnt;
index 365c7e96070bb7aec4cad7fa09f17eb0aa8b6345..3c534b3cfe9186857b6109f668c161af704eda6d 100644 (file)
@@ -5865,9 +5865,9 @@ lpfc_ras_fwlog_buffsize_set(struct lpfc_hba  *phba, uint val)
        if (phba->cfg_ras_fwlog_func != PCI_FUNC(phba->pcidev->devfn))
                return -EINVAL;
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        state = phba->ras_fwlog.state;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        if (state == REG_INPROGRESS) {
                lpfc_printf_log(phba, KERN_ERR, LOG_SLI, "6147 RAS Logging "
index d80e6e81053b0a9d61aec5574d2d5d3a2d241e64..529df1768fa89f50dfb3af58b1d72ddb9c5d319e 100644 (file)
@@ -2513,7 +2513,7 @@ static int lpfcdiag_loop_self_reg(struct lpfc_hba *phba, uint16_t *rpi)
                return -ENOMEM;
        }
 
-       dmabuff = (struct lpfc_dmabuf *)mbox->ctx_buf;
+       dmabuff = mbox->ctx_buf;
        mbox->ctx_buf = NULL;
        mbox->ctx_ndlp = NULL;
        status = lpfc_sli_issue_mbox_wait(phba, mbox, LPFC_MBOX_TMO);
@@ -3169,10 +3169,10 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job)
        }
 
        cmdwqe = &cmdiocbq->wqe;
-       memset(cmdwqe, 0, sizeof(union lpfc_wqe));
+       memset(cmdwqe, 0, sizeof(*cmdwqe));
        if (phba->sli_rev < LPFC_SLI_REV4) {
                rspwqe = &rspiocbq->wqe;
-               memset(rspwqe, 0, sizeof(union lpfc_wqe));
+               memset(rspwqe, 0, sizeof(*rspwqe));
        }
 
        INIT_LIST_HEAD(&head);
@@ -3376,7 +3376,7 @@ lpfc_bsg_issue_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq)
        unsigned long flags;
        uint8_t *pmb, *pmb_buf;
 
-       dd_data = pmboxq->ctx_ndlp;
+       dd_data = pmboxq->ctx_u.dd_data;
 
        /*
         * The outgoing buffer is readily referred from the dma buffer,
@@ -3553,7 +3553,7 @@ lpfc_bsg_issue_mbox_ext_handle_job(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq)
        struct lpfc_sli_config_mbox *sli_cfg_mbx;
        uint8_t *pmbx;
 
-       dd_data = pmboxq->ctx_buf;
+       dd_data = pmboxq->ctx_u.dd_data;
 
        /* Determine if job has been aborted */
        spin_lock_irqsave(&phba->ct_ev_lock, flags);
@@ -3940,7 +3940,7 @@ lpfc_bsg_sli_cfg_read_cmd_ext(struct lpfc_hba *phba, struct bsg_job *job,
        pmboxq->mbox_cmpl = lpfc_bsg_issue_read_mbox_ext_cmpl;
 
        /* context fields to callback function */
-       pmboxq->ctx_buf = dd_data;
+       pmboxq->ctx_u.dd_data = dd_data;
        dd_data->type = TYPE_MBOX;
        dd_data->set_job = job;
        dd_data->context_un.mbox.pmboxq = pmboxq;
@@ -4112,7 +4112,7 @@ lpfc_bsg_sli_cfg_write_cmd_ext(struct lpfc_hba *phba, struct bsg_job *job,
                pmboxq->mbox_cmpl = lpfc_bsg_issue_write_mbox_ext_cmpl;
 
                /* context fields to callback function */
-               pmboxq->ctx_buf = dd_data;
+               pmboxq->ctx_u.dd_data = dd_data;
                dd_data->type = TYPE_MBOX;
                dd_data->set_job = job;
                dd_data->context_un.mbox.pmboxq = pmboxq;
@@ -4460,7 +4460,7 @@ lpfc_bsg_write_ebuf_set(struct lpfc_hba *phba, struct bsg_job *job,
                pmboxq->mbox_cmpl = lpfc_bsg_issue_write_mbox_ext_cmpl;
 
                /* context fields to callback function */
-               pmboxq->ctx_buf = dd_data;
+               pmboxq->ctx_u.dd_data = dd_data;
                dd_data->type = TYPE_MBOX;
                dd_data->set_job = job;
                dd_data->context_un.mbox.pmboxq = pmboxq;
@@ -4747,7 +4747,7 @@ lpfc_bsg_issue_mbox(struct lpfc_hba *phba, struct bsg_job *job,
        if (mbox_req->inExtWLen || mbox_req->outExtWLen) {
                from = pmbx;
                ext = from + sizeof(MAILBOX_t);
-               pmboxq->ctx_buf = ext;
+               pmboxq->ext_buf = ext;
                pmboxq->in_ext_byte_len =
                        mbox_req->inExtWLen * sizeof(uint32_t);
                pmboxq->out_ext_byte_len =
@@ -4875,7 +4875,7 @@ lpfc_bsg_issue_mbox(struct lpfc_hba *phba, struct bsg_job *job,
        pmboxq->mbox_cmpl = lpfc_bsg_issue_mbox_cmpl;
 
        /* setup context field to pass wait_queue pointer to wake function */
-       pmboxq->ctx_ndlp = dd_data;
+       pmboxq->ctx_u.dd_data = dd_data;
        dd_data->type = TYPE_MBOX;
        dd_data->set_job = job;
        dd_data->context_un.mbox.pmboxq = pmboxq;
@@ -5070,12 +5070,12 @@ lpfc_bsg_get_ras_config(struct bsg_job *job)
                bsg_reply->reply_data.vendor_reply.vendor_rsp;
 
        /* Current logging state */
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        if (ras_fwlog->state == ACTIVE)
                ras_reply->state = LPFC_RASLOG_STATE_RUNNING;
        else
                ras_reply->state = LPFC_RASLOG_STATE_STOPPED;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        ras_reply->log_level = phba->ras_fwlog.fw_loglevel;
        ras_reply->log_buff_sz = phba->cfg_ras_fwlog_buffsize;
@@ -5132,13 +5132,13 @@ lpfc_bsg_set_ras_config(struct bsg_job *job)
 
        if (action == LPFC_RASACTION_STOP_LOGGING) {
                /* Check if already disabled */
-               spin_lock_irq(&phba->hbalock);
+               spin_lock_irq(&phba->ras_fwlog_lock);
                if (ras_fwlog->state != ACTIVE) {
-                       spin_unlock_irq(&phba->hbalock);
+                       spin_unlock_irq(&phba->ras_fwlog_lock);
                        rc = -ESRCH;
                        goto ras_job_error;
                }
-               spin_unlock_irq(&phba->hbalock);
+               spin_unlock_irq(&phba->ras_fwlog_lock);
 
                /* Disable logging */
                lpfc_ras_stop_fwlog(phba);
@@ -5149,10 +5149,10 @@ lpfc_bsg_set_ras_config(struct bsg_job *job)
                 * FW-logging with new log-level. Return status
                 * "Logging already Running" to caller.
                 **/
-               spin_lock_irq(&phba->hbalock);
+               spin_lock_irq(&phba->ras_fwlog_lock);
                if (ras_fwlog->state != INACTIVE)
                        action_status = -EINPROGRESS;
-               spin_unlock_irq(&phba->hbalock);
+               spin_unlock_irq(&phba->ras_fwlog_lock);
 
                /* Enable logging */
                rc = lpfc_sli4_ras_fwlog_init(phba, log_level,
@@ -5268,13 +5268,13 @@ lpfc_bsg_get_ras_fwlog(struct bsg_job *job)
                goto ras_job_error;
 
        /* Logging to be stopped before reading */
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        if (ras_fwlog->state == ACTIVE) {
-               spin_unlock_irq(&phba->hbalock);
+               spin_unlock_irq(&phba->ras_fwlog_lock);
                rc = -EINPROGRESS;
                goto ras_job_error;
        }
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        if (job->request_len <
            sizeof(struct fc_bsg_request) +
index ab5af10c8a16ca597e1fbde60a3c4562981ea03c..a2d2b02b34187f92a28957b5d1c466e9e31d1a37 100644 (file)
@@ -2194,12 +2194,12 @@ static int lpfc_debugfs_ras_log_data(struct lpfc_hba *phba,
 
        memset(buffer, 0, size);
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        if (phba->ras_fwlog.state != ACTIVE) {
-               spin_unlock_irq(&phba->hbalock);
+               spin_unlock_irq(&phba->ras_fwlog_lock);
                return -EINVAL;
        }
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        list_for_each_entry_safe(dmabuf, next,
                                 &phba->ras_fwlog.fwlog_buff_list, list) {
@@ -2250,13 +2250,13 @@ lpfc_debugfs_ras_log_open(struct inode *inode, struct file *file)
        int size;
        int rc = -ENOMEM;
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        if (phba->ras_fwlog.state != ACTIVE) {
-               spin_unlock_irq(&phba->hbalock);
+               spin_unlock_irq(&phba->ras_fwlog_lock);
                rc = -EINVAL;
                goto out;
        }
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        if (check_mul_overflow(LPFC_RAS_MIN_BUFF_POST_SIZE,
                               phba->cfg_ras_fwlog_buffsize, &size))
index 28e56542e0720e30d1221c3a24e38e68a5aedd08..f7c28dc73bf67d86ea87098c1cc7cf8b53cc6604 100644 (file)
@@ -4437,23 +4437,23 @@ lpfc_els_retry_delay(struct timer_list *t)
        unsigned long flags;
        struct lpfc_work_evt  *evtp = &ndlp->els_retry_evt;
 
+       /* Hold a node reference for outstanding queued work */
+       if (!lpfc_nlp_get(ndlp))
+               return;
+
        spin_lock_irqsave(&phba->hbalock, flags);
        if (!list_empty(&evtp->evt_listp)) {
                spin_unlock_irqrestore(&phba->hbalock, flags);
+               lpfc_nlp_put(ndlp);
                return;
        }
 
-       /* We need to hold the node by incrementing the reference
-        * count until the queued work is done
-        */
-       evtp->evt_arg1  = lpfc_nlp_get(ndlp);
-       if (evtp->evt_arg1) {
-               evtp->evt = LPFC_EVT_ELS_RETRY;
-               list_add_tail(&evtp->evt_listp, &phba->work_list);
-               lpfc_worker_wake_up(phba);
-       }
+       evtp->evt_arg1 = ndlp;
+       evtp->evt = LPFC_EVT_ELS_RETRY;
+       list_add_tail(&evtp->evt_listp, &phba->work_list);
        spin_unlock_irqrestore(&phba->hbalock, flags);
-       return;
+
+       lpfc_worker_wake_up(phba);
 }
 
 /**
@@ -7238,7 +7238,7 @@ lpfc_get_rdp_info(struct lpfc_hba *phba, struct lpfc_rdp_context *rdp_context)
                goto rdp_fail;
        mbox->vport = rdp_context->ndlp->vport;
        mbox->mbox_cmpl = lpfc_mbx_cmpl_rdp_page_a0;
-       mbox->ctx_ndlp = (struct lpfc_rdp_context *)rdp_context;
+       mbox->ctx_u.rdp = rdp_context;
        rc = lpfc_sli_issue_mbox(phba, mbox, MBX_NOWAIT);
        if (rc == MBX_NOT_FINISHED) {
                lpfc_mbox_rsrc_cleanup(phba, mbox, MBOX_THD_UNLOCKED);
@@ -7290,7 +7290,7 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba,
                mbox->in_ext_byte_len = DMP_SFF_PAGE_A0_SIZE;
                mbox->out_ext_byte_len = DMP_SFF_PAGE_A0_SIZE;
                mbox->mbox_offset_word = 5;
-               mbox->ctx_buf = virt;
+               mbox->ext_buf = virt;
        } else {
                bf_set(lpfc_mbx_memory_dump_type3_length,
                       &mbox->u.mqe.un.mem_dump_type3, DMP_SFF_PAGE_A0_SIZE);
@@ -7298,7 +7298,6 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba,
                mbox->u.mqe.un.mem_dump_type3.addr_hi = putPaddrHigh(mp->phys);
        }
        mbox->vport = phba->pport;
-       mbox->ctx_ndlp = (struct lpfc_rdp_context *)rdp_context;
 
        rc = lpfc_sli_issue_mbox_wait(phba, mbox, 30);
        if (rc == MBX_NOT_FINISHED) {
@@ -7307,7 +7306,7 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba,
        }
 
        if (phba->sli_rev == LPFC_SLI_REV4)
-               mp = (struct lpfc_dmabuf *)(mbox->ctx_buf);
+               mp = mbox->ctx_buf;
        else
                mp = mpsave;
 
@@ -7350,7 +7349,7 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba,
                mbox->in_ext_byte_len = DMP_SFF_PAGE_A2_SIZE;
                mbox->out_ext_byte_len = DMP_SFF_PAGE_A2_SIZE;
                mbox->mbox_offset_word = 5;
-               mbox->ctx_buf = virt;
+               mbox->ext_buf = virt;
        } else {
                bf_set(lpfc_mbx_memory_dump_type3_length,
                       &mbox->u.mqe.un.mem_dump_type3, DMP_SFF_PAGE_A2_SIZE);
@@ -7358,7 +7357,6 @@ int lpfc_get_sfp_info_wait(struct lpfc_hba *phba,
                mbox->u.mqe.un.mem_dump_type3.addr_hi = putPaddrHigh(mp->phys);
        }
 
-       mbox->ctx_ndlp = (struct lpfc_rdp_context *)rdp_context;
        rc = lpfc_sli_issue_mbox_wait(phba, mbox, 30);
        if (bf_get(lpfc_mqe_status, &mbox->u.mqe)) {
                rc = 1;
@@ -7500,9 +7498,9 @@ lpfc_els_lcb_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        int rc;
 
        mb = &pmb->u.mb;
-       lcb_context = (struct lpfc_lcb_context *)pmb->ctx_ndlp;
+       lcb_context = pmb->ctx_u.lcb;
        ndlp = lcb_context->ndlp;
-       pmb->ctx_ndlp = NULL;
+       memset(&pmb->ctx_u, 0, sizeof(pmb->ctx_u));
        pmb->ctx_buf = NULL;
 
        shdr = (union lpfc_sli4_cfg_shdr *)
@@ -7642,7 +7640,7 @@ lpfc_sli4_set_beacon(struct lpfc_vport *vport,
        lpfc_sli4_config(phba, mbox, LPFC_MBOX_SUBSYSTEM_COMMON,
                         LPFC_MBOX_OPCODE_SET_BEACON_CONFIG, len,
                         LPFC_SLI4_MBX_EMBED);
-       mbox->ctx_ndlp = (void *)lcb_context;
+       mbox->ctx_u.lcb = lcb_context;
        mbox->vport = phba->pport;
        mbox->mbox_cmpl = lpfc_els_lcb_rsp;
        bf_set(lpfc_mbx_set_beacon_port_num, &mbox->u.mqe.un.beacon_config,
@@ -8639,9 +8637,9 @@ lpfc_els_rsp_rls_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        mb = &pmb->u.mb;
 
        ndlp = pmb->ctx_ndlp;
-       rxid = (uint16_t)((unsigned long)(pmb->ctx_buf) & 0xffff);
-       oxid = (uint16_t)(((unsigned long)(pmb->ctx_buf) >> 16) & 0xffff);
-       pmb->ctx_buf = NULL;
+       rxid = (uint16_t)(pmb->ctx_u.ox_rx_id & 0xffff);
+       oxid = (uint16_t)((pmb->ctx_u.ox_rx_id >> 16) & 0xffff);
+       memset(&pmb->ctx_u, 0, sizeof(pmb->ctx_u));
        pmb->ctx_ndlp = NULL;
 
        if (mb->mbxStatus) {
@@ -8745,8 +8743,7 @@ lpfc_els_rcv_rls(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
        mbox = mempool_alloc(phba->mbox_mem_pool, GFP_ATOMIC);
        if (mbox) {
                lpfc_read_lnk_stat(phba, mbox);
-               mbox->ctx_buf = (void *)((unsigned long)
-                                        (ox_id << 16 | ctx));
+               mbox->ctx_u.ox_rx_id = ox_id << 16 | ctx;
                mbox->ctx_ndlp = lpfc_nlp_get(ndlp);
                if (!mbox->ctx_ndlp)
                        goto node_err;
index a7a2309a629fafa16f20814f434e38e0a324b334..e42fa9c822b50235a9421570a5816599f6463e8b 100644 (file)
@@ -257,7 +257,9 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport)
                if (evtp->evt_arg1) {
                        evtp->evt = LPFC_EVT_DEV_LOSS;
                        list_add_tail(&evtp->evt_listp, &phba->work_list);
+                       spin_unlock_irqrestore(&phba->hbalock, iflags);
                        lpfc_worker_wake_up(phba);
+                       return;
                }
                spin_unlock_irqrestore(&phba->hbalock, iflags);
        } else {
@@ -275,10 +277,7 @@ lpfc_dev_loss_tmo_callbk(struct fc_rport *rport)
                        lpfc_disc_state_machine(vport, ndlp, NULL,
                                                NLP_EVT_DEVICE_RM);
                }
-
        }
-
-       return;
 }
 
 /**
@@ -3429,7 +3428,7 @@ static void
 lpfc_mbx_cmpl_read_sparam(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_dmabuf *mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+       struct lpfc_dmabuf *mp = pmb->ctx_buf;
        struct lpfc_vport  *vport = pmb->vport;
        struct Scsi_Host *shost = lpfc_shost_from_vport(vport);
        struct serv_parm *sp = &vport->fc_sparam;
@@ -3737,7 +3736,7 @@ lpfc_mbx_cmpl_read_topology(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        struct lpfc_mbx_read_top *la;
        struct lpfc_sli_ring *pring;
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_dmabuf *mp = (struct lpfc_dmabuf *)(pmb->ctx_buf);
+       struct lpfc_dmabuf *mp = pmb->ctx_buf;
        uint8_t attn_type;
 
        /* Unblock ELS traffic */
@@ -3851,8 +3850,8 @@ void
 lpfc_mbx_cmpl_reg_login(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        struct lpfc_vport  *vport = pmb->vport;
-       struct lpfc_dmabuf *mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+       struct lpfc_dmabuf *mp = pmb->ctx_buf;
+       struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
 
        /* The driver calls the state machine with the pmb pointer
         * but wants to make sure a stale ctx_buf isn't acted on.
@@ -4066,7 +4065,7 @@ lpfc_create_static_vport(struct lpfc_hba *phba)
                 * the dump routine is a single-use construct.
                 */
                if (pmb->ctx_buf) {
-                       mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+                       mp = pmb->ctx_buf;
                        lpfc_mbuf_free(phba, mp->virt, mp->phys);
                        kfree(mp);
                        pmb->ctx_buf = NULL;
@@ -4089,7 +4088,7 @@ lpfc_create_static_vport(struct lpfc_hba *phba)
 
                if (phba->sli_rev == LPFC_SLI_REV4) {
                        byte_count = pmb->u.mqe.un.mb_words[5];
-                       mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+                       mp = pmb->ctx_buf;
                        if (byte_count > sizeof(struct static_vport_info) -
                                        offset)
                                byte_count = sizeof(struct static_vport_info)
@@ -4169,7 +4168,7 @@ lpfc_mbx_cmpl_fabric_reg_login(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        struct lpfc_vport *vport = pmb->vport;
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+       struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
 
        pmb->ctx_ndlp = NULL;
 
@@ -4307,7 +4306,7 @@ void
 lpfc_mbx_cmpl_ns_reg_login(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+       struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
        struct lpfc_vport *vport = pmb->vport;
        int rc;
 
@@ -4431,7 +4430,7 @@ lpfc_mbx_cmpl_fc_reg_login(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        struct lpfc_vport *vport = pmb->vport;
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+       struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
 
        pmb->ctx_ndlp = NULL;
        if (mb->mbxStatus) {
@@ -5174,7 +5173,7 @@ lpfc_nlp_logo_unreg(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        struct lpfc_vport  *vport = pmb->vport;
        struct lpfc_nodelist *ndlp;
 
-       ndlp = (struct lpfc_nodelist *)(pmb->ctx_ndlp);
+       ndlp = pmb->ctx_ndlp;
        if (!ndlp)
                return;
        lpfc_issue_els_logo(vport, ndlp, 0);
@@ -5496,7 +5495,7 @@ lpfc_cleanup_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
        if ((mb = phba->sli.mbox_active)) {
                if ((mb->u.mb.mbxCommand == MBX_REG_LOGIN64) &&
                   !(mb->mbox_flag & LPFC_MBX_IMED_UNREG) &&
-                  (ndlp == (struct lpfc_nodelist *)mb->ctx_ndlp)) {
+                  (ndlp == mb->ctx_ndlp)) {
                        mb->ctx_ndlp = NULL;
                        mb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
                }
@@ -5507,7 +5506,7 @@ lpfc_cleanup_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
        list_for_each_entry(mb, &phba->sli.mboxq_cmpl, list) {
                if ((mb->u.mb.mbxCommand != MBX_REG_LOGIN64) ||
                        (mb->mbox_flag & LPFC_MBX_IMED_UNREG) ||
-                       (ndlp != (struct lpfc_nodelist *)mb->ctx_ndlp))
+                       (ndlp != mb->ctx_ndlp))
                        continue;
 
                mb->ctx_ndlp = NULL;
@@ -5517,7 +5516,7 @@ lpfc_cleanup_node(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
        list_for_each_entry_safe(mb, nextmb, &phba->sli.mboxq, list) {
                if ((mb->u.mb.mbxCommand == MBX_REG_LOGIN64) &&
                   !(mb->mbox_flag & LPFC_MBX_IMED_UNREG) &&
-                   (ndlp == (struct lpfc_nodelist *)mb->ctx_ndlp)) {
+                   (ndlp == mb->ctx_ndlp)) {
                        list_del(&mb->list);
                        lpfc_mbox_rsrc_cleanup(phba, mb, MBOX_THD_LOCKED);
 
@@ -6357,7 +6356,7 @@ void
 lpfc_mbx_cmpl_fdmi_reg_login(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        MAILBOX_t *mb = &pmb->u.mb;
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+       struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
        struct lpfc_vport    *vport = pmb->vport;
 
        pmb->ctx_ndlp = NULL;
index 88b2e57d90c2e3a671ab2907318bf7a9f6f7144c..f7a0aa3625f4e1b63d0254a925b0cc00f7bf40ad 100644 (file)
@@ -460,7 +460,7 @@ lpfc_config_port_post(struct lpfc_hba *phba)
                return -EIO;
        }
 
-       mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+       mp = pmb->ctx_buf;
 
        /* This dmabuf was allocated by lpfc_read_sparam. The dmabuf is no
         * longer needed.  Prevent unintended ctx_buf access as the mbox is
@@ -2217,7 +2217,7 @@ lpfc_handle_latt(struct lpfc_hba *phba)
        /* Cleanup any outstanding ELS commands */
        lpfc_els_flush_all_cmd(phba);
        psli->slistat.link_event++;
-       lpfc_read_topology(phba, pmb, (struct lpfc_dmabuf *)pmb->ctx_buf);
+       lpfc_read_topology(phba, pmb, pmb->ctx_buf);
        pmb->mbox_cmpl = lpfc_mbx_cmpl_read_topology;
        pmb->vport = vport;
        /* Block ELS IOCBs until we have processed this mbox command */
@@ -5454,7 +5454,7 @@ lpfc_sli4_async_link_evt(struct lpfc_hba *phba,
        phba->sli.slistat.link_event++;
 
        /* Create lpfc_handle_latt mailbox command from link ACQE */
-       lpfc_read_topology(phba, pmb, (struct lpfc_dmabuf *)pmb->ctx_buf);
+       lpfc_read_topology(phba, pmb, pmb->ctx_buf);
        pmb->mbox_cmpl = lpfc_mbx_cmpl_read_topology;
        pmb->vport = phba->pport;
 
@@ -6347,7 +6347,7 @@ lpfc_sli4_async_fc_evt(struct lpfc_hba *phba, struct lpfc_acqe_fc_la *acqe_fc)
        phba->sli.slistat.link_event++;
 
        /* Create lpfc_handle_latt mailbox command from link ACQE */
-       lpfc_read_topology(phba, pmb, (struct lpfc_dmabuf *)pmb->ctx_buf);
+       lpfc_read_topology(phba, pmb, pmb->ctx_buf);
        pmb->mbox_cmpl = lpfc_mbx_cmpl_read_topology;
        pmb->vport = phba->pport;
 
@@ -7705,6 +7705,9 @@ lpfc_setup_driver_resource_phase1(struct lpfc_hba *phba)
                                "NVME" : " "),
                        (phba->nvmet_support ? "NVMET" : " "));
 
+       /* ras_fwlog state */
+       spin_lock_init(&phba->ras_fwlog_lock);
+
        /* Initialize the IO buffer list used by driver for SLI3 SCSI */
        spin_lock_init(&phba->scsi_buf_list_get_lock);
        INIT_LIST_HEAD(&phba->lpfc_scsi_buf_list_get);
@@ -13055,7 +13058,7 @@ lpfc_sli4_enable_msix(struct lpfc_hba *phba)
                rc = request_threaded_irq(eqhdl->irq,
                                          &lpfc_sli4_hba_intr_handler,
                                          &lpfc_sli4_hba_intr_handler_th,
-                                         IRQF_ONESHOT, name, eqhdl);
+                                         0, name, eqhdl);
                if (rc) {
                        lpfc_printf_log(phba, KERN_WARNING, LOG_INIT,
                                        "0486 MSI-X fast-path (%d) "
index f7c41958036bb7c40c01a22eca8571f4443fe206..e98f1c2b22202e9e104c8efee3a5b4cd0be364e8 100644 (file)
@@ -102,7 +102,7 @@ lpfc_mbox_rsrc_cleanup(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox,
 {
        struct lpfc_dmabuf *mp;
 
-       mp = (struct lpfc_dmabuf *)mbox->ctx_buf;
+       mp = mbox->ctx_buf;
        mbox->ctx_buf = NULL;
 
        /* Release the generic BPL buffer memory.  */
@@ -204,10 +204,8 @@ lpfc_dump_mem(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb, uint16_t offset,
                uint16_t region_id)
 {
        MAILBOX_t *mb;
-       void *ctx;
 
        mb = &pmb->u.mb;
-       ctx = pmb->ctx_buf;
 
        /* Setup to dump VPD region */
        memset(pmb, 0, sizeof (LPFC_MBOXQ_t));
@@ -219,7 +217,6 @@ lpfc_dump_mem(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb, uint16_t offset,
        mb->un.varDmp.word_cnt = (DMP_RSP_SIZE / sizeof (uint32_t));
        mb->un.varDmp.co = 0;
        mb->un.varDmp.resp_offset = 0;
-       pmb->ctx_buf = ctx;
        mb->mbxOwner = OWN_HOST;
        return;
 }
@@ -236,11 +233,8 @@ void
 lpfc_dump_wakeup_param(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 {
        MAILBOX_t *mb;
-       void *ctx;
 
        mb = &pmb->u.mb;
-       /* Save context so that we can restore after memset */
-       ctx = pmb->ctx_buf;
 
        /* Setup to dump VPD region */
        memset(pmb, 0, sizeof(LPFC_MBOXQ_t));
@@ -254,7 +248,6 @@ lpfc_dump_wakeup_param(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        mb->un.varDmp.word_cnt = WAKE_UP_PARMS_WORD_SIZE;
        mb->un.varDmp.co = 0;
        mb->un.varDmp.resp_offset = 0;
-       pmb->ctx_buf = ctx;
        return;
 }
 
@@ -372,7 +365,7 @@ lpfc_read_topology(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb,
        /* Save address for later completion and set the owner to host so that
         * the FW knows this mailbox is available for processing.
         */
-       pmb->ctx_buf = (uint8_t *)mp;
+       pmb->ctx_buf = mp;
        mb->mbxOwner = OWN_HOST;
        return (0);
 }
@@ -1816,7 +1809,7 @@ lpfc_sli4_mbox_cmd_free(struct lpfc_hba *phba, struct lpfcMboxq *mbox)
        }
        /* Reinitialize the context pointers to avoid stale usage. */
        mbox->ctx_buf = NULL;
-       mbox->context3 = NULL;
+       memset(&mbox->ctx_u, 0, sizeof(mbox->ctx_u));
        kfree(mbox->sge_array);
        /* Finally, free the mailbox command itself */
        mempool_free(mbox, phba->mbox_mem_pool);
@@ -2366,8 +2359,7 @@ lpfc_mbx_cmpl_rdp_link_stat(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
 {
        MAILBOX_t *mb;
        int rc = FAILURE;
-       struct lpfc_rdp_context *rdp_context =
-                       (struct lpfc_rdp_context *)(mboxq->ctx_ndlp);
+       struct lpfc_rdp_context *rdp_context = mboxq->ctx_u.rdp;
 
        mb = &mboxq->u.mb;
        if (mb->mbxStatus)
@@ -2385,9 +2377,8 @@ mbx_failed:
 static void
 lpfc_mbx_cmpl_rdp_page_a2(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox)
 {
-       struct lpfc_dmabuf *mp = (struct lpfc_dmabuf *)mbox->ctx_buf;
-       struct lpfc_rdp_context *rdp_context =
-                       (struct lpfc_rdp_context *)(mbox->ctx_ndlp);
+       struct lpfc_dmabuf *mp = mbox->ctx_buf;
+       struct lpfc_rdp_context *rdp_context = mbox->ctx_u.rdp;
 
        if (bf_get(lpfc_mqe_status, &mbox->u.mqe))
                goto error_mbox_free;
@@ -2401,7 +2392,7 @@ lpfc_mbx_cmpl_rdp_page_a2(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox)
        /* Save the dma buffer for cleanup in the final completion. */
        mbox->ctx_buf = mp;
        mbox->mbox_cmpl = lpfc_mbx_cmpl_rdp_link_stat;
-       mbox->ctx_ndlp = (struct lpfc_rdp_context *)rdp_context;
+       mbox->ctx_u.rdp = rdp_context;
        if (lpfc_sli_issue_mbox(phba, mbox, MBX_NOWAIT) == MBX_NOT_FINISHED)
                goto error_mbox_free;
 
@@ -2416,9 +2407,8 @@ void
 lpfc_mbx_cmpl_rdp_page_a0(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox)
 {
        int rc;
-       struct lpfc_dmabuf *mp = (struct lpfc_dmabuf *)(mbox->ctx_buf);
-       struct lpfc_rdp_context *rdp_context =
-                       (struct lpfc_rdp_context *)(mbox->ctx_ndlp);
+       struct lpfc_dmabuf *mp = mbox->ctx_buf;
+       struct lpfc_rdp_context *rdp_context = mbox->ctx_u.rdp;
 
        if (bf_get(lpfc_mqe_status, &mbox->u.mqe))
                goto error;
@@ -2448,7 +2438,7 @@ lpfc_mbx_cmpl_rdp_page_a0(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox)
        mbox->u.mqe.un.mem_dump_type3.addr_hi = putPaddrHigh(mp->phys);
 
        mbox->mbox_cmpl = lpfc_mbx_cmpl_rdp_page_a2;
-       mbox->ctx_ndlp = (struct lpfc_rdp_context *)rdp_context;
+       mbox->ctx_u.rdp = rdp_context;
        rc = lpfc_sli_issue_mbox(phba, mbox, MBX_NOWAIT);
        if (rc == MBX_NOT_FINISHED)
                goto error;
index 8e425be7c7c99c05b8f899043e15cac7a937665e..c4172791c267511742a1e68a152abe00d2dfd7cc 100644 (file)
@@ -300,7 +300,7 @@ lpfc_defer_plogi_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *login_mbox)
        int rc;
 
        ndlp = login_mbox->ctx_ndlp;
-       save_iocb = login_mbox->context3;
+       save_iocb = login_mbox->ctx_u.save_iocb;
 
        if (mb->mbxStatus == MBX_SUCCESS) {
                /* Now that REG_RPI completed successfully,
@@ -640,7 +640,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
        if (!login_mbox->ctx_ndlp)
                goto out;
 
-       login_mbox->context3 = save_iocb; /* For PLOGI ACC */
+       login_mbox->ctx_u.save_iocb = save_iocb; /* For PLOGI ACC */
 
        spin_lock_irq(&ndlp->lock);
        ndlp->nlp_flag |= (NLP_ACC_REGLOGIN | NLP_RCV_PLOGI);
@@ -682,8 +682,8 @@ lpfc_mbx_cmpl_resume_rpi(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq)
        struct lpfc_nodelist *ndlp;
        uint32_t cmd;
 
-       elsiocb = (struct lpfc_iocbq *)mboxq->ctx_buf;
-       ndlp = (struct lpfc_nodelist *)mboxq->ctx_ndlp;
+       elsiocb = mboxq->ctx_u.save_iocb;
+       ndlp = mboxq->ctx_ndlp;
        vport = mboxq->vport;
        cmd = elsiocb->drvrTimeout;
 
@@ -1875,7 +1875,7 @@ lpfc_rcv_logo_reglogin_issue(struct lpfc_vport *vport,
        /* cleanup any ndlp on mbox q waiting for reglogin cmpl */
        if ((mb = phba->sli.mbox_active)) {
                if ((mb->u.mb.mbxCommand == MBX_REG_LOGIN64) &&
-                  (ndlp == (struct lpfc_nodelist *)mb->ctx_ndlp)) {
+                  (ndlp == mb->ctx_ndlp)) {
                        ndlp->nlp_flag &= ~NLP_REG_LOGIN_SEND;
                        lpfc_nlp_put(ndlp);
                        mb->ctx_ndlp = NULL;
@@ -1886,7 +1886,7 @@ lpfc_rcv_logo_reglogin_issue(struct lpfc_vport *vport,
        spin_lock_irq(&phba->hbalock);
        list_for_each_entry_safe(mb, nextmb, &phba->sli.mboxq, list) {
                if ((mb->u.mb.mbxCommand == MBX_REG_LOGIN64) &&
-                  (ndlp == (struct lpfc_nodelist *)mb->ctx_ndlp)) {
+                  (ndlp == mb->ctx_ndlp)) {
                        ndlp->nlp_flag &= ~NLP_REG_LOGIN_SEND;
                        lpfc_nlp_put(ndlp);
                        list_del(&mb->list);
index 09c53b85bcb8d6a11128f0cb2c1545afa5cab800..c5792eaf3f64cbd750c43e3dded87b29168c8fac 100644 (file)
@@ -2616,9 +2616,9 @@ lpfc_nvme_unregister_port(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
                /* No concern about the role change on the nvme remoteport.
                 * The transport will update it.
                 */
-               spin_lock_irq(&vport->phba->hbalock);
+               spin_lock_irq(&ndlp->lock);
                ndlp->fc4_xpt_flags |= NVME_XPT_UNREG_WAIT;
-               spin_unlock_irq(&vport->phba->hbalock);
+               spin_unlock_irq(&ndlp->lock);
 
                /* Don't let the host nvme transport keep sending keep-alives
                 * on this remoteport. Vport is unloading, no recovery. The
index 8258b771bd009e2fe4dbc610db2b56971e3a6f4e..561ced5503c6341e35ca696628f033c419f768f4 100644 (file)
@@ -1586,7 +1586,7 @@ lpfc_nvmet_setup_io_context(struct lpfc_hba *phba)
                wqe = &nvmewqe->wqe;
 
                /* Initialize WQE */
-               memset(wqe, 0, sizeof(union lpfc_wqe));
+               memset(wqe, 0, sizeof(*wqe));
 
                ctx_buf->iocbq->cmd_dmabuf = NULL;
                spin_lock(&phba->sli4_hba.sgl_list_lock);
index c0038eaae7b0ae9e40d945c9d99708897c97382e..4a6e5223a22418a9f10c07c104003187b3b727cb 100644 (file)
@@ -167,11 +167,10 @@ lpfc_ramp_down_queue_handler(struct lpfc_hba *phba)
        struct Scsi_Host  *shost;
        struct scsi_device *sdev;
        unsigned long new_queue_depth;
-       unsigned long num_rsrc_err, num_cmd_success;
+       unsigned long num_rsrc_err;
        int i;
 
        num_rsrc_err = atomic_read(&phba->num_rsrc_err);
-       num_cmd_success = atomic_read(&phba->num_cmd_success);
 
        /*
         * The error and success command counters are global per
@@ -186,20 +185,16 @@ lpfc_ramp_down_queue_handler(struct lpfc_hba *phba)
                for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
                        shost = lpfc_shost_from_vport(vports[i]);
                        shost_for_each_device(sdev, shost) {
-                               new_queue_depth =
-                                       sdev->queue_depth * num_rsrc_err /
-                                       (num_rsrc_err + num_cmd_success);
-                               if (!new_queue_depth)
-                                       new_queue_depth = sdev->queue_depth - 1;
+                               if (num_rsrc_err >= sdev->queue_depth)
+                                       new_queue_depth = 1;
                                else
                                        new_queue_depth = sdev->queue_depth -
-                                                               new_queue_depth;
+                                               num_rsrc_err;
                                scsi_change_queue_depth(sdev, new_queue_depth);
                        }
                }
        lpfc_destroy_vport_work_array(phba, vports);
        atomic_set(&phba->num_rsrc_err, 0);
-       atomic_set(&phba->num_cmd_success, 0);
 }
 
 /**
@@ -5336,16 +5331,6 @@ lpfc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *cmnd)
                }
                err = lpfc_bg_scsi_prep_dma_buf(phba, lpfc_cmd);
        } else {
-               if (vport->phba->cfg_enable_bg) {
-                       lpfc_printf_vlog(vport,
-                                        KERN_INFO, LOG_SCSI_CMD,
-                                        "9038 BLKGRD: rcvd PROT_NORMAL cmd: "
-                                        "x%x reftag x%x cnt %u pt %x\n",
-                                        cmnd->cmnd[0],
-                                        scsi_prot_ref_tag(cmnd),
-                                        scsi_logical_block_count(cmnd),
-                                        (cmnd->cmnd[1]>>5));
-               }
                err = lpfc_scsi_prep_dma_buf(phba, lpfc_cmd);
        }
 
index 1f8a9b5945cbae71a32172b4eb0d61e7924e4f0a..a028e008dd1ee8937e448b13db3394be2d562d41 100644 (file)
@@ -1217,9 +1217,9 @@ lpfc_set_rrq_active(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp,
        empty = list_empty(&phba->active_rrq_list);
        list_add_tail(&rrq->list, &phba->active_rrq_list);
        phba->hba_flag |= HBA_RRQ_ACTIVE;
+       spin_unlock_irqrestore(&phba->hbalock, iflags);
        if (empty)
                lpfc_worker_wake_up(phba);
-       spin_unlock_irqrestore(&phba->hbalock, iflags);
        return 0;
 out:
        spin_unlock_irqrestore(&phba->hbalock, iflags);
@@ -2830,7 +2830,7 @@ lpfc_sli_wake_mbox_wait(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq)
         */
        pmboxq->mbox_flag |= LPFC_MBX_WAKE;
        spin_lock_irqsave(&phba->hbalock, drvr_flag);
-       pmbox_done = (struct completion *)pmboxq->context3;
+       pmbox_done = pmboxq->ctx_u.mbox_wait;
        if (pmbox_done)
                complete(pmbox_done);
        spin_unlock_irqrestore(&phba->hbalock, drvr_flag);
@@ -2885,7 +2885,7 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        if (!test_bit(FC_UNLOADING, &phba->pport->load_flag) &&
            pmb->u.mb.mbxCommand == MBX_REG_LOGIN64 &&
            !pmb->u.mb.mbxStatus) {
-               mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+               mp = pmb->ctx_buf;
                if (mp) {
                        pmb->ctx_buf = NULL;
                        lpfc_mbuf_free(phba, mp->virt, mp->phys);
@@ -2914,12 +2914,12 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
        }
 
        if (pmb->u.mb.mbxCommand == MBX_REG_LOGIN64) {
-               ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+               ndlp = pmb->ctx_ndlp;
                lpfc_nlp_put(ndlp);
        }
 
        if (pmb->u.mb.mbxCommand == MBX_UNREG_LOGIN) {
-               ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+               ndlp = pmb->ctx_ndlp;
 
                /* Check to see if there are any deferred events to process */
                if (ndlp) {
@@ -2952,7 +2952,7 @@ lpfc_sli_def_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
 
        /* This nlp_put pairs with lpfc_sli4_resume_rpi */
        if (pmb->u.mb.mbxCommand == MBX_RESUME_RPI) {
-               ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+               ndlp = pmb->ctx_ndlp;
                lpfc_nlp_put(ndlp);
        }
 
@@ -5819,7 +5819,7 @@ lpfc_sli4_read_fcoe_params(struct lpfc_hba *phba)
                goto out_free_mboxq;
        }
 
-       mp = (struct lpfc_dmabuf *)mboxq->ctx_buf;
+       mp = mboxq->ctx_buf;
        rc = lpfc_sli_issue_mbox(phba, mboxq, MBX_POLL);
 
        lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI,
@@ -6849,9 +6849,9 @@ lpfc_ras_stop_fwlog(struct lpfc_hba *phba)
 {
        struct lpfc_ras_fwlog *ras_fwlog = &phba->ras_fwlog;
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        ras_fwlog->state = INACTIVE;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        /* Disable FW logging to host memory */
        writel(LPFC_CTL_PDEV_CTL_DDL_RAS,
@@ -6894,9 +6894,9 @@ lpfc_sli4_ras_dma_free(struct lpfc_hba *phba)
                ras_fwlog->lwpd.virt = NULL;
        }
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        ras_fwlog->state = INACTIVE;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 }
 
 /**
@@ -6998,9 +6998,9 @@ lpfc_sli4_ras_mbox_cmpl(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
                goto disable_ras;
        }
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        ras_fwlog->state = ACTIVE;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
        mempool_free(pmb, phba->mbox_mem_pool);
 
        return;
@@ -7032,9 +7032,9 @@ lpfc_sli4_ras_fwlog_init(struct lpfc_hba *phba,
        uint32_t len = 0, fwlog_buffsize, fwlog_entry_count;
        int rc = 0;
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        ras_fwlog->state = INACTIVE;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
 
        fwlog_buffsize = (LPFC_RAS_MIN_BUFF_POST_SIZE *
                          phba->cfg_ras_fwlog_buffsize);
@@ -7095,9 +7095,9 @@ lpfc_sli4_ras_fwlog_init(struct lpfc_hba *phba,
        mbx_fwlog->u.request.lwpd.addr_lo = putPaddrLow(ras_fwlog->lwpd.phys);
        mbx_fwlog->u.request.lwpd.addr_hi = putPaddrHigh(ras_fwlog->lwpd.phys);
 
-       spin_lock_irq(&phba->hbalock);
+       spin_lock_irq(&phba->ras_fwlog_lock);
        ras_fwlog->state = REG_INPROGRESS;
-       spin_unlock_irq(&phba->hbalock);
+       spin_unlock_irq(&phba->ras_fwlog_lock);
        mbox->vport = phba->pport;
        mbox->mbox_cmpl = lpfc_sli4_ras_mbox_cmpl;
 
@@ -8766,7 +8766,7 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)
 
        mboxq->vport = vport;
        rc = lpfc_sli_issue_mbox(phba, mboxq, MBX_POLL);
-       mp = (struct lpfc_dmabuf *)mboxq->ctx_buf;
+       mp = mboxq->ctx_buf;
        if (rc == MBX_SUCCESS) {
                memcpy(&vport->fc_sparam, mp->virt, sizeof(struct serv_parm));
                rc = 0;
@@ -9548,8 +9548,8 @@ lpfc_sli_issue_mbox_s3(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmbox,
                }
 
                /* Copy the mailbox extension data */
-               if (pmbox->in_ext_byte_len && pmbox->ctx_buf) {
-                       lpfc_sli_pcimem_bcopy(pmbox->ctx_buf,
+               if (pmbox->in_ext_byte_len && pmbox->ext_buf) {
+                       lpfc_sli_pcimem_bcopy(pmbox->ext_buf,
                                              (uint8_t *)phba->mbox_ext,
                                              pmbox->in_ext_byte_len);
                }
@@ -9562,10 +9562,10 @@ lpfc_sli_issue_mbox_s3(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmbox,
                                = MAILBOX_HBA_EXT_OFFSET;
 
                /* Copy the mailbox extension data */
-               if (pmbox->in_ext_byte_len && pmbox->ctx_buf)
+               if (pmbox->in_ext_byte_len && pmbox->ext_buf)
                        lpfc_memcpy_to_slim(phba->MBslimaddr +
                                MAILBOX_HBA_EXT_OFFSET,
-                               pmbox->ctx_buf, pmbox->in_ext_byte_len);
+                               pmbox->ext_buf, pmbox->in_ext_byte_len);
 
                if (mbx->mbxCommand == MBX_CONFIG_PORT)
                        /* copy command data into host mbox for cmpl */
@@ -9688,9 +9688,9 @@ lpfc_sli_issue_mbox_s3(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmbox,
                        lpfc_sli_pcimem_bcopy(phba->mbox, mbx,
                                                MAILBOX_CMD_SIZE);
                        /* Copy the mailbox extension data */
-                       if (pmbox->out_ext_byte_len && pmbox->ctx_buf) {
+                       if (pmbox->out_ext_byte_len && pmbox->ext_buf) {
                                lpfc_sli_pcimem_bcopy(phba->mbox_ext,
-                                                     pmbox->ctx_buf,
+                                                     pmbox->ext_buf,
                                                      pmbox->out_ext_byte_len);
                        }
                } else {
@@ -9698,9 +9698,9 @@ lpfc_sli_issue_mbox_s3(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmbox,
                        lpfc_memcpy_from_slim(mbx, phba->MBslimaddr,
                                                MAILBOX_CMD_SIZE);
                        /* Copy the mailbox extension data */
-                       if (pmbox->out_ext_byte_len && pmbox->ctx_buf) {
+                       if (pmbox->out_ext_byte_len && pmbox->ext_buf) {
                                lpfc_memcpy_from_slim(
-                                       pmbox->ctx_buf,
+                                       pmbox->ext_buf,
                                        phba->MBslimaddr +
                                        MAILBOX_HBA_EXT_OFFSET,
                                        pmbox->out_ext_byte_len);
@@ -11373,18 +11373,18 @@ lpfc_sli_post_recovery_event(struct lpfc_hba *phba,
        unsigned long iflags;
        struct lpfc_work_evt  *evtp = &ndlp->recovery_evt;
 
+       /* Hold a node reference for outstanding queued work */
+       if (!lpfc_nlp_get(ndlp))
+               return;
+
        spin_lock_irqsave(&phba->hbalock, iflags);
        if (!list_empty(&evtp->evt_listp)) {
                spin_unlock_irqrestore(&phba->hbalock, iflags);
+               lpfc_nlp_put(ndlp);
                return;
        }
 
-       /* Incrementing the reference count until the queued work is done. */
-       evtp->evt_arg1  = lpfc_nlp_get(ndlp);
-       if (!evtp->evt_arg1) {
-               spin_unlock_irqrestore(&phba->hbalock, iflags);
-               return;
-       }
+       evtp->evt_arg1 = ndlp;
        evtp->evt = LPFC_EVT_RECOVER_PORT;
        list_add_tail(&evtp->evt_listp, &phba->work_list);
        spin_unlock_irqrestore(&phba->hbalock, iflags);
@@ -13262,9 +13262,9 @@ lpfc_sli_issue_mbox_wait(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq,
        /* setup wake call as IOCB callback */
        pmboxq->mbox_cmpl = lpfc_sli_wake_mbox_wait;
 
-       /* setup context3 field to pass wait_queue pointer to wake function  */
+       /* setup ctx_u field to pass wait_queue pointer to wake function  */
        init_completion(&mbox_done);
-       pmboxq->context3 = &mbox_done;
+       pmboxq->ctx_u.mbox_wait = &mbox_done;
        /* now issue the command */
        retval = lpfc_sli_issue_mbox(phba, pmboxq, MBX_NOWAIT);
        if (retval == MBX_BUSY || retval == MBX_SUCCESS) {
@@ -13272,7 +13272,7 @@ lpfc_sli_issue_mbox_wait(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmboxq,
                                            msecs_to_jiffies(timeout * 1000));
 
                spin_lock_irqsave(&phba->hbalock, flag);
-               pmboxq->context3 = NULL;
+               pmboxq->ctx_u.mbox_wait = NULL;
                /*
                 * if LPFC_MBX_WAKE flag is set the mailbox is completed
                 * else do not free the resources.
@@ -13813,10 +13813,10 @@ lpfc_sli_sp_intr_handler(int irq, void *dev_id)
                                        lpfc_sli_pcimem_bcopy(mbox, pmbox,
                                                        MAILBOX_CMD_SIZE);
                                        if (pmb->out_ext_byte_len &&
-                                               pmb->ctx_buf)
+                                               pmb->ext_buf)
                                                lpfc_sli_pcimem_bcopy(
                                                phba->mbox_ext,
-                                               pmb->ctx_buf,
+                                               pmb->ext_buf,
                                                pmb->out_ext_byte_len);
                                }
                                if (pmb->mbox_flag & LPFC_MBX_IMED_UNREG) {
@@ -13830,10 +13830,8 @@ lpfc_sli_sp_intr_handler(int irq, void *dev_id)
                                                pmbox->un.varWords[0], 0);
 
                                        if (!pmbox->mbxStatus) {
-                                               mp = (struct lpfc_dmabuf *)
-                                                       (pmb->ctx_buf);
-                                               ndlp = (struct lpfc_nodelist *)
-                                                       pmb->ctx_ndlp;
+                                               mp = pmb->ctx_buf;
+                                               ndlp = pmb->ctx_ndlp;
 
                                                /* Reg_LOGIN of dflt RPI was
                                                 * successful. new lets get
@@ -14340,8 +14338,8 @@ lpfc_sli4_sp_handle_mbox_event(struct lpfc_hba *phba, struct lpfc_mcqe *mcqe)
                                      mcqe_status,
                                      pmbox->un.varWords[0], 0);
                if (mcqe_status == MB_CQE_STATUS_SUCCESS) {
-                       mp = (struct lpfc_dmabuf *)(pmb->ctx_buf);
-                       ndlp = (struct lpfc_nodelist *)pmb->ctx_ndlp;
+                       mp = pmb->ctx_buf;
+                       ndlp = pmb->ctx_ndlp;
 
                        /* Reg_LOGIN of dflt RPI was successful. Mark the
                         * node as having an UNREG_LOGIN in progress to stop
@@ -19823,14 +19821,15 @@ lpfc_sli4_remove_rpis(struct lpfc_hba *phba)
  * lpfc_sli4_resume_rpi - Remove the rpi bitmask region
  * @ndlp: pointer to lpfc nodelist data structure.
  * @cmpl: completion call-back.
- * @arg: data to load as MBox 'caller buffer information'
+ * @iocbq: data to load as mbox ctx_u information
  *
  * This routine is invoked to remove the memory region that
  * provided rpi via a bitmask.
  **/
 int
 lpfc_sli4_resume_rpi(struct lpfc_nodelist *ndlp,
-       void (*cmpl)(struct lpfc_hba *, LPFC_MBOXQ_t *), void *arg)
+                    void (*cmpl)(struct lpfc_hba *, LPFC_MBOXQ_t *),
+                    struct lpfc_iocbq *iocbq)
 {
        LPFC_MBOXQ_t *mboxq;
        struct lpfc_hba *phba = ndlp->phba;
@@ -19859,7 +19858,7 @@ lpfc_sli4_resume_rpi(struct lpfc_nodelist *ndlp,
        lpfc_resume_rpi(mboxq, ndlp);
        if (cmpl) {
                mboxq->mbox_cmpl = cmpl;
-               mboxq->ctx_buf = arg;
+               mboxq->ctx_u.save_iocb = iocbq;
        } else
                mboxq->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
        mboxq->ctx_ndlp = ndlp;
@@ -20676,7 +20675,7 @@ lpfc_sli4_get_config_region23(struct lpfc_hba *phba, char *rgn23_data)
        if (lpfc_sli4_dump_cfg_rg23(phba, mboxq))
                goto out;
        mqe = &mboxq->u.mqe;
-       mp = (struct lpfc_dmabuf *)mboxq->ctx_buf;
+       mp = mboxq->ctx_buf;
        rc = lpfc_sli_issue_mbox(phba, mboxq, MBX_POLL);
        if (rc)
                goto out;
@@ -21035,7 +21034,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
                        (mb->u.mb.mbxCommand == MBX_REG_VPI))
                        mb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
                if (mb->u.mb.mbxCommand == MBX_REG_LOGIN64) {
-                       act_mbx_ndlp = (struct lpfc_nodelist *)mb->ctx_ndlp;
+                       act_mbx_ndlp = mb->ctx_ndlp;
 
                        /* This reference is local to this routine.  The
                         * reference is removed at routine exit.
@@ -21064,7 +21063,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
 
                        mb->mbox_cmpl = lpfc_sli_def_mbox_cmpl;
                        if (mb->u.mb.mbxCommand == MBX_REG_LOGIN64) {
-                               ndlp = (struct lpfc_nodelist *)mb->ctx_ndlp;
+                               ndlp = mb->ctx_ndlp;
                                /* Unregister the RPI when mailbox complete */
                                mb->mbox_flag |= LPFC_MBX_IMED_UNREG;
                                restart_loop = 1;
@@ -21084,7 +21083,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
        while (!list_empty(&mbox_cmd_list)) {
                list_remove_head(&mbox_cmd_list, mb, LPFC_MBOXQ_t, list);
                if (mb->u.mb.mbxCommand == MBX_REG_LOGIN64) {
-                       ndlp = (struct lpfc_nodelist *)mb->ctx_ndlp;
+                       ndlp = mb->ctx_ndlp;
                        mb->ctx_ndlp = NULL;
                        if (ndlp) {
                                spin_lock(&ndlp->lock);
index c911a39cb46b8cf00ef95f176c4c8b3503b0d80a..cf7c42ec03067992bf8d658c2575741d2c659f68 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2004-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
@@ -182,11 +182,29 @@ typedef struct lpfcMboxq {
                struct lpfc_mqe mqe;
        } u;
        struct lpfc_vport *vport; /* virtual port pointer */
-       void *ctx_ndlp;           /* an lpfc_nodelist pointer */
-       void *ctx_buf;            /* an lpfc_dmabuf pointer */
-       void *context3;           /* a generic pointer.  Code must
-                                  * accommodate the actual datatype.
-                                  */
+       struct lpfc_nodelist *ctx_ndlp; /* caller ndlp pointer */
+       struct lpfc_dmabuf *ctx_buf;    /* caller buffer information */
+       void *ext_buf;                  /* extended buffer for extended mbox
+                                        * cmds.  Not a generic pointer.
+                                        * Use for storing virtual address.
+                                        */
+
+       /* Pointers that are seldom used during mbox execution, but require
+        * a saved context.
+        */
+       union {
+               unsigned long ox_rx_id;         /* Used in els_rsp_rls_acc */
+               struct lpfc_rdp_context *rdp;   /* Used in get_rdp_info */
+               struct lpfc_lcb_context *lcb;   /* Used in set_beacon */
+               struct completion *mbox_wait;   /* Used in issue_mbox_wait */
+               struct bsg_job_data *dd_data;   /* Used in bsg_issue_mbox_cmpl
+                                                * and
+                                                * bsg_issue_mbox_ext_handle_job
+                                                */
+               struct lpfc_iocbq *save_iocb;   /* Used in defer_plogi_acc and
+                                                * lpfc_mbx_cmpl_resume_rpi
+                                                */
+       } ctx_u;
 
        void (*mbox_cmpl) (struct lpfc_hba *, struct lpfcMboxq *);
        uint8_t mbox_flag;
index 2541a8fba093fa0e0263b211fa7cd29c183d8f65..c1e9ec0243bacbf89ff8c1e938b7923feb8c16fd 100644 (file)
@@ -1,7 +1,7 @@
 /*******************************************************************
  * This file is part of the Emulex Linux Device Driver for         *
  * Fibre Channel Host Bus Adapters.                                *
- * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term *
+ * Copyright (C) 2017-2024 Broadcom. All Rights Reserved. The term *
  * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.     *
  * Copyright (C) 2009-2016 Emulex.  All rights reserved.           *
  * EMULEX and SLI are trademarks of Emulex.                        *
@@ -1118,8 +1118,9 @@ void lpfc_sli4_free_rpi(struct lpfc_hba *, int);
 void lpfc_sli4_remove_rpis(struct lpfc_hba *);
 void lpfc_sli4_async_event_proc(struct lpfc_hba *);
 void lpfc_sli4_fcf_redisc_event_proc(struct lpfc_hba *);
-int lpfc_sli4_resume_rpi(struct lpfc_nodelist *,
-                       void (*)(struct lpfc_hba *, LPFC_MBOXQ_t *), void *);
+int lpfc_sli4_resume_rpi(struct lpfc_nodelist *ndlp,
+                        void (*cmpl)(struct lpfc_hba *, LPFC_MBOXQ_t *),
+                        struct lpfc_iocbq *iocbq);
 void lpfc_sli4_els_xri_abort_event_proc(struct lpfc_hba *phba);
 void lpfc_sli4_nvme_pci_offline_aborted(struct lpfc_hba *phba,
                                        struct lpfc_io_buf *lpfc_ncmd);
index 56f5889dbaf9347cae12a7ab4a6f3f70ee2c58a7..915f2f11fb5585794d59d7947f12a269fed9cf9e 100644 (file)
@@ -20,7 +20,7 @@
  * included with this package.                                     *
  *******************************************************************/
 
-#define LPFC_DRIVER_VERSION "14.4.0.0"
+#define LPFC_DRIVER_VERSION "14.4.0.1"
 #define LPFC_DRIVER_NAME               "lpfc"
 
 /* Used for SLI 2/3 */
index 0f79840b94986146478e61fa4e5ab1cd6eeaa99e..4439167a51882dedf10de9ade9c30c12bca8dfb1 100644 (file)
@@ -166,7 +166,7 @@ lpfc_vport_sparm(struct lpfc_hba *phba, struct lpfc_vport *vport)
                }
        }
 
-       mp = (struct lpfc_dmabuf *)pmb->ctx_buf;
+       mp = pmb->ctx_buf;
        memcpy(&vport->fc_sparam, mp->virt, sizeof (struct serv_parm));
        memcpy(&vport->fc_nodename, &vport->fc_sparam.nodeName,
               sizeof (struct lpfc_name));
@@ -674,10 +674,6 @@ lpfc_vport_delete(struct fc_vport *fc_vport)
        lpfc_free_sysfs_attr(vport);
        lpfc_debugfs_terminate(vport);
 
-       /* Remove FC host to break driver binding. */
-       fc_remove_host(shost);
-       scsi_remove_host(shost);
-
        /* Send the DA_ID and Fabric LOGO to cleanup Nameserver entries. */
        ndlp = lpfc_findnode_did(vport, Fabric_DID);
        if (!ndlp)
@@ -721,6 +717,10 @@ lpfc_vport_delete(struct fc_vport *fc_vport)
 
 skip_logo:
 
+       /* Remove FC host to break driver binding. */
+       fc_remove_host(shost);
+       scsi_remove_host(shost);
+
        lpfc_cleanup(vport);
 
        /* Remove scsi host now.  The nodes are cleaned up. */
index 0380996b5ad27aee4740f03431b4157b3526f6bf..55d590b919476e191dd52c4993d1644945495f66 100644 (file)
@@ -1644,7 +1644,7 @@ static long mpi3mr_bsg_process_mpt_cmds(struct bsg_job *job)
        if ((mpirep_offset != 0xFF) &&
            drv_bufs[mpirep_offset].bsg_buf_len) {
                drv_buf_iter = &drv_bufs[mpirep_offset];
-               drv_buf_iter->kern_buf_len = (sizeof(*bsg_reply_buf) - 1 +
+               drv_buf_iter->kern_buf_len = (sizeof(*bsg_reply_buf) +
                                           mrioc->reply_sz);
                bsg_reply_buf = kzalloc(drv_buf_iter->kern_buf_len, GFP_KERNEL);
 
index e8bcc3a88732a1009d08b2d731289a38736c64ec..0614b7e366b77643f4bb9d879e819b62405e169e 100644 (file)
@@ -61,7 +61,9 @@ static atomic_t pmcraid_adapter_count = ATOMIC_INIT(0);
  * pmcraid_minor - minor number(s) to use
  */
 static unsigned int pmcraid_major;
-static struct class *pmcraid_class;
+static const struct class pmcraid_class = {
+       .name = PMCRAID_DEVFILE,
+};
 static DECLARE_BITMAP(pmcraid_minor, PMCRAID_MAX_ADAPTERS);
 
 /*
@@ -4723,7 +4725,7 @@ static int pmcraid_setup_chrdev(struct pmcraid_instance *pinstance)
        if (error)
                pmcraid_release_minor(minor);
        else
-               device_create(pmcraid_class, NULL, MKDEV(pmcraid_major, minor),
+               device_create(&pmcraid_class, NULL, MKDEV(pmcraid_major, minor),
                              NULL, "%s%u", PMCRAID_DEVFILE, minor);
        return error;
 }
@@ -4739,7 +4741,7 @@ static int pmcraid_setup_chrdev(struct pmcraid_instance *pinstance)
 static void pmcraid_release_chrdev(struct pmcraid_instance *pinstance)
 {
        pmcraid_release_minor(MINOR(pinstance->cdev.dev));
-       device_destroy(pmcraid_class,
+       device_destroy(&pmcraid_class,
                       MKDEV(pmcraid_major, MINOR(pinstance->cdev.dev)));
        cdev_del(&pinstance->cdev);
 }
@@ -5390,10 +5392,10 @@ static int __init pmcraid_init(void)
        }
 
        pmcraid_major = MAJOR(dev);
-       pmcraid_class = class_create(PMCRAID_DEVFILE);
 
-       if (IS_ERR(pmcraid_class)) {
-               error = PTR_ERR(pmcraid_class);
+       error = class_register(&pmcraid_class);
+
+       if (error) {
                pmcraid_err("failed to register with sysfs, error = %x\n",
                            error);
                goto out_unreg_chrdev;
@@ -5402,7 +5404,7 @@ static int __init pmcraid_init(void)
        error = pmcraid_netlink_init();
 
        if (error) {
-               class_destroy(pmcraid_class);
+               class_unregister(&pmcraid_class);
                goto out_unreg_chrdev;
        }
 
@@ -5413,7 +5415,7 @@ static int __init pmcraid_init(void)
 
        pmcraid_err("failed to register pmcraid driver, error = %x\n",
                     error);
-       class_destroy(pmcraid_class);
+       class_unregister(&pmcraid_class);
        pmcraid_netlink_release();
 
 out_unreg_chrdev:
@@ -5432,7 +5434,7 @@ static void __exit pmcraid_exit(void)
        unregister_chrdev_region(MKDEV(pmcraid_major, 0),
                                 PMCRAID_MAX_ADAPTERS);
        pci_unregister_driver(&pmcraid_driver);
-       class_destroy(pmcraid_class);
+       class_unregister(&pmcraid_class);
 }
 
 module_init(pmcraid_init);
index 44449c70a375f34feff9c97df33044831bb7bbc8..76eeba435fd0469f4f32cfbbda1720fad2a44255 100644 (file)
@@ -2741,7 +2741,13 @@ qla2x00_dev_loss_tmo_callbk(struct fc_rport *rport)
                return;
 
        if (unlikely(pci_channel_offline(fcport->vha->hw->pdev))) {
-               qla2x00_abort_all_cmds(fcport->vha, DID_NO_CONNECT << 16);
+               /* Will wait for wind down of adapter */
+               ql_dbg(ql_dbg_aer, fcport->vha, 0x900c,
+                   "%s pci offline detected (id %06x)\n", __func__,
+                   fcport->d_id.b24);
+               qla_pci_set_eeh_busy(fcport->vha);
+               qla2x00_eh_wait_for_pending_commands(fcport->vha, fcport->d_id.b24,
+                   0, WAIT_TARGET);
                return;
        }
 }
@@ -2763,7 +2769,11 @@ qla2x00_terminate_rport_io(struct fc_rport *rport)
        vha = fcport->vha;
 
        if (unlikely(pci_channel_offline(fcport->vha->hw->pdev))) {
-               qla2x00_abort_all_cmds(fcport->vha, DID_NO_CONNECT << 16);
+               /* Will wait for wind down of adapter */
+               ql_dbg(ql_dbg_aer, fcport->vha, 0x900b,
+                   "%s pci offline detected (id %06x)\n", __func__,
+                   fcport->d_id.b24);
+               qla_pci_set_eeh_busy(vha);
                qla2x00_eh_wait_for_pending_commands(fcport->vha, fcport->d_id.b24,
                        0, WAIT_TARGET);
                return;
index deb642607deb6f6d3c0eead3e7688e9381af2e12..2f49baf131e26f3453f580bf4ceeb4c14d9321f7 100644 (file)
@@ -82,7 +82,7 @@ typedef union {
 #include "qla_nvme.h"
 #define QLA2XXX_DRIVER_NAME    "qla2xxx"
 #define QLA2XXX_APIDEV         "ql2xapidev"
-#define QLA2XXX_MANUFACTURER   "Marvell Semiconductor, Inc."
+#define QLA2XXX_MANUFACTURER   "Marvell"
 
 /*
  * We have MAILBOX_REGISTER_COUNT sized arrays in a few places,
index 09cb9413670a5e4034ea13792d8806fdab6cbc73..7309310d2ab94368fcda24f5fc9812aeaafa9397 100644 (file)
@@ -44,7 +44,7 @@ extern int qla2x00_fabric_login(scsi_qla_host_t *, fc_port_t *, uint16_t *);
 extern int qla2x00_local_device_login(scsi_qla_host_t *, fc_port_t *);
 
 extern int qla24xx_els_dcmd_iocb(scsi_qla_host_t *, int, port_id_t);
-extern int qla24xx_els_dcmd2_iocb(scsi_qla_host_t *, int, fc_port_t *, bool);
+extern int qla24xx_els_dcmd2_iocb(scsi_qla_host_t *, int, fc_port_t *);
 extern void qla2x00_els_dcmd2_free(scsi_qla_host_t *vha,
                                   struct els_plogi *els_plogi);
 
index a314cfc5b263f223e4548c4647e1d645208db69f..8377624d76c98ebab3f2127ab0d0d15a19097f62 100644 (file)
@@ -1193,8 +1193,12 @@ int qla24xx_async_gnl(struct scsi_qla_host *vha, fc_port_t *fcport)
        return rval;
 
 done_free_sp:
-       /* ref: INIT */
-       kref_put(&sp->cmd_kref, qla2x00_sp_release);
+       /*
+        * use qla24xx_async_gnl_sp_done to purge all pending gnl request.
+        * kref_put is call behind the scene.
+        */
+       sp->u.iocb_cmd.u.mbx.in_mb[0] = MBS_COMMAND_ERROR;
+       qla24xx_async_gnl_sp_done(sp, QLA_COMMAND_ERROR);
        fcport->flags &= ~(FCF_ASYNC_SENT);
 done:
        fcport->flags &= ~(FCF_ASYNC_ACTIVE);
@@ -2665,6 +2669,40 @@ exit:
        return rval;
 }
 
+static void qla_enable_fce_trace(scsi_qla_host_t *vha)
+{
+       int rval;
+       struct qla_hw_data *ha = vha->hw;
+
+       if (ha->fce) {
+               ha->flags.fce_enabled = 1;
+               memset(ha->fce, 0, fce_calc_size(ha->fce_bufs));
+               rval = qla2x00_enable_fce_trace(vha,
+                   ha->fce_dma, ha->fce_bufs, ha->fce_mb, &ha->fce_bufs);
+
+               if (rval) {
+                       ql_log(ql_log_warn, vha, 0x8033,
+                           "Unable to reinitialize FCE (%d).\n", rval);
+                       ha->flags.fce_enabled = 0;
+               }
+       }
+}
+
+static void qla_enable_eft_trace(scsi_qla_host_t *vha)
+{
+       int rval;
+       struct qla_hw_data *ha = vha->hw;
+
+       if (ha->eft) {
+               memset(ha->eft, 0, EFT_SIZE);
+               rval = qla2x00_enable_eft_trace(vha, ha->eft_dma, EFT_NUM_BUFFERS);
+
+               if (rval) {
+                       ql_log(ql_log_warn, vha, 0x8034,
+                           "Unable to reinitialize EFT (%d).\n", rval);
+               }
+       }
+}
 /*
 * qla2x00_initialize_adapter
 *      Initialize board.
@@ -3668,9 +3706,8 @@ qla24xx_chip_diag(scsi_qla_host_t *vha)
 }
 
 static void
-qla2x00_init_fce_trace(scsi_qla_host_t *vha)
+qla2x00_alloc_fce_trace(scsi_qla_host_t *vha)
 {
-       int rval;
        dma_addr_t tc_dma;
        void *tc;
        struct qla_hw_data *ha = vha->hw;
@@ -3699,27 +3736,17 @@ qla2x00_init_fce_trace(scsi_qla_host_t *vha)
                return;
        }
 
-       rval = qla2x00_enable_fce_trace(vha, tc_dma, FCE_NUM_BUFFERS,
-                                       ha->fce_mb, &ha->fce_bufs);
-       if (rval) {
-               ql_log(ql_log_warn, vha, 0x00bf,
-                      "Unable to initialize FCE (%d).\n", rval);
-               dma_free_coherent(&ha->pdev->dev, FCE_SIZE, tc, tc_dma);
-               return;
-       }
-
        ql_dbg(ql_dbg_init, vha, 0x00c0,
               "Allocated (%d KB) for FCE...\n", FCE_SIZE / 1024);
 
-       ha->flags.fce_enabled = 1;
        ha->fce_dma = tc_dma;
        ha->fce = tc;
+       ha->fce_bufs = FCE_NUM_BUFFERS;
 }
 
 static void
-qla2x00_init_eft_trace(scsi_qla_host_t *vha)
+qla2x00_alloc_eft_trace(scsi_qla_host_t *vha)
 {
-       int rval;
        dma_addr_t tc_dma;
        void *tc;
        struct qla_hw_data *ha = vha->hw;
@@ -3744,14 +3771,6 @@ qla2x00_init_eft_trace(scsi_qla_host_t *vha)
                return;
        }
 
-       rval = qla2x00_enable_eft_trace(vha, tc_dma, EFT_NUM_BUFFERS);
-       if (rval) {
-               ql_log(ql_log_warn, vha, 0x00c2,
-                      "Unable to initialize EFT (%d).\n", rval);
-               dma_free_coherent(&ha->pdev->dev, EFT_SIZE, tc, tc_dma);
-               return;
-       }
-
        ql_dbg(ql_dbg_init, vha, 0x00c3,
               "Allocated (%d KB) EFT ...\n", EFT_SIZE / 1024);
 
@@ -3759,13 +3778,6 @@ qla2x00_init_eft_trace(scsi_qla_host_t *vha)
        ha->eft = tc;
 }
 
-static void
-qla2x00_alloc_offload_mem(scsi_qla_host_t *vha)
-{
-       qla2x00_init_fce_trace(vha);
-       qla2x00_init_eft_trace(vha);
-}
-
 void
 qla2x00_alloc_fw_dump(scsi_qla_host_t *vha)
 {
@@ -3820,10 +3832,10 @@ qla2x00_alloc_fw_dump(scsi_qla_host_t *vha)
                if (ha->tgt.atio_ring)
                        mq_size += ha->tgt.atio_q_length * sizeof(request_t);
 
-               qla2x00_init_fce_trace(vha);
+               qla2x00_alloc_fce_trace(vha);
                if (ha->fce)
                        fce_size = sizeof(struct qla2xxx_fce_chain) + FCE_SIZE;
-               qla2x00_init_eft_trace(vha);
+               qla2x00_alloc_eft_trace(vha);
                if (ha->eft)
                        eft_size = EFT_SIZE;
        }
@@ -4253,7 +4265,6 @@ qla2x00_setup_chip(scsi_qla_host_t *vha)
        struct qla_hw_data *ha = vha->hw;
        struct device_reg_2xxx __iomem *reg = &ha->iobase->isp;
        unsigned long flags;
-       uint16_t fw_major_version;
        int done_once = 0;
 
        if (IS_P3P_TYPE(ha)) {
@@ -4320,7 +4331,6 @@ execute_fw_with_lr:
                                        goto failed;
 
 enable_82xx_npiv:
-                               fw_major_version = ha->fw_major_version;
                                if (IS_P3P_TYPE(ha))
                                        qla82xx_check_md_needed(vha);
                                else
@@ -4349,12 +4359,11 @@ enable_82xx_npiv:
                                if (rval != QLA_SUCCESS)
                                        goto failed;
 
-                               if (!fw_major_version && !(IS_P3P_TYPE(ha)))
-                                       qla2x00_alloc_offload_mem(vha);
-
                                if (ql2xallocfwdump && !(IS_P3P_TYPE(ha)))
                                        qla2x00_alloc_fw_dump(vha);
 
+                               qla_enable_fce_trace(vha);
+                               qla_enable_eft_trace(vha);
                        } else {
                                goto failed;
                        }
@@ -7487,12 +7496,12 @@ qla2x00_abort_isp_cleanup(scsi_qla_host_t *vha)
 int
 qla2x00_abort_isp(scsi_qla_host_t *vha)
 {
-       int rval;
        uint8_t        status = 0;
        struct qla_hw_data *ha = vha->hw;
        struct scsi_qla_host *vp, *tvp;
        struct req_que *req = ha->req_q_map[0];
        unsigned long flags;
+       fc_port_t *fcport;
 
        if (vha->flags.online) {
                qla2x00_abort_isp_cleanup(vha);
@@ -7561,6 +7570,15 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
                               "ISP Abort - ISP reg disconnect post nvmram config, exiting.\n");
                        return status;
                }
+
+               /* User may have updated [fcp|nvme] prefer in flash */
+               list_for_each_entry(fcport, &vha->vp_fcports, list) {
+                       if (NVME_PRIORITY(ha, fcport))
+                               fcport->do_prli_nvme = 1;
+                       else
+                               fcport->do_prli_nvme = 0;
+               }
+
                if (!qla2x00_restart_isp(vha)) {
                        clear_bit(RESET_MARKER_NEEDED, &vha->dpc_flags);
 
@@ -7581,31 +7599,7 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
 
                        if (IS_QLA81XX(ha) || IS_QLA8031(ha))
                                qla2x00_get_fw_version(vha);
-                       if (ha->fce) {
-                               ha->flags.fce_enabled = 1;
-                               memset(ha->fce, 0,
-                                   fce_calc_size(ha->fce_bufs));
-                               rval = qla2x00_enable_fce_trace(vha,
-                                   ha->fce_dma, ha->fce_bufs, ha->fce_mb,
-                                   &ha->fce_bufs);
-                               if (rval) {
-                                       ql_log(ql_log_warn, vha, 0x8033,
-                                           "Unable to reinitialize FCE "
-                                           "(%d).\n", rval);
-                                       ha->flags.fce_enabled = 0;
-                               }
-                       }
 
-                       if (ha->eft) {
-                               memset(ha->eft, 0, EFT_SIZE);
-                               rval = qla2x00_enable_eft_trace(vha,
-                                   ha->eft_dma, EFT_NUM_BUFFERS);
-                               if (rval) {
-                                       ql_log(ql_log_warn, vha, 0x8034,
-                                           "Unable to reinitialize EFT "
-                                           "(%d).\n", rval);
-                               }
-                       }
                } else {        /* failed the ISP abort */
                        vha->flags.online = 1;
                        if (test_bit(ISP_ABORT_RETRY, &vha->dpc_flags)) {
@@ -7655,6 +7649,14 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
                                atomic_inc(&vp->vref_count);
                                spin_unlock_irqrestore(&ha->vport_slock, flags);
 
+                               /* User may have updated [fcp|nvme] prefer in flash */
+                               list_for_each_entry(fcport, &vp->vp_fcports, list) {
+                                       if (NVME_PRIORITY(ha, fcport))
+                                               fcport->do_prli_nvme = 1;
+                                       else
+                                               fcport->do_prli_nvme = 0;
+                               }
+
                                qla2x00_vp_abort_isp(vp);
 
                                spin_lock_irqsave(&ha->vport_slock, flags);
index df90169f82440a3f665164e55153d9b560231b4b..0b41e8a0660262106e67e781d9327d29d6661b40 100644 (file)
@@ -2587,6 +2587,33 @@ void
 qla2x00_sp_release(struct kref *kref)
 {
        struct srb *sp = container_of(kref, struct srb, cmd_kref);
+       struct scsi_qla_host *vha = sp->vha;
+
+       switch (sp->type) {
+       case SRB_CT_PTHRU_CMD:
+               /* GPSC & GFPNID use fcport->ct_desc.ct_sns for both req & rsp */
+               if (sp->u.iocb_cmd.u.ctarg.req &&
+                       (!sp->fcport ||
+                        sp->u.iocb_cmd.u.ctarg.req != sp->fcport->ct_desc.ct_sns)) {
+                       dma_free_coherent(&vha->hw->pdev->dev,
+                           sp->u.iocb_cmd.u.ctarg.req_allocated_size,
+                           sp->u.iocb_cmd.u.ctarg.req,
+                           sp->u.iocb_cmd.u.ctarg.req_dma);
+                       sp->u.iocb_cmd.u.ctarg.req = NULL;
+               }
+               if (sp->u.iocb_cmd.u.ctarg.rsp &&
+                       (!sp->fcport ||
+                        sp->u.iocb_cmd.u.ctarg.rsp != sp->fcport->ct_desc.ct_sns)) {
+                       dma_free_coherent(&vha->hw->pdev->dev,
+                           sp->u.iocb_cmd.u.ctarg.rsp_allocated_size,
+                           sp->u.iocb_cmd.u.ctarg.rsp,
+                           sp->u.iocb_cmd.u.ctarg.rsp_dma);
+                       sp->u.iocb_cmd.u.ctarg.rsp = NULL;
+               }
+               break;
+       default:
+               break;
+       }
 
        sp->free(sp);
 }
@@ -2610,7 +2637,8 @@ static void qla2x00_els_dcmd_sp_free(srb_t *sp)
 {
        struct srb_iocb *elsio = &sp->u.iocb_cmd;
 
-       kfree(sp->fcport);
+       if (sp->fcport)
+               qla2x00_free_fcport(sp->fcport);
 
        if (elsio->u.els_logo.els_logo_pyld)
                dma_free_coherent(&sp->vha->hw->pdev->dev, DMA_POOL_SIZE,
@@ -2692,7 +2720,7 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
         */
        sp = qla2x00_get_sp(vha, fcport, GFP_KERNEL);
        if (!sp) {
-               kfree(fcport);
+               qla2x00_free_fcport(fcport);
                ql_log(ql_log_info, vha, 0x70e6,
                 "SRB allocation failed\n");
                return -ENOMEM;
@@ -2723,6 +2751,7 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
        if (!elsio->u.els_logo.els_logo_pyld) {
                /* ref: INIT */
                kref_put(&sp->cmd_kref, qla2x00_sp_release);
+               qla2x00_free_fcport(fcport);
                return QLA_FUNCTION_FAILED;
        }
 
@@ -2747,6 +2776,7 @@ qla24xx_els_dcmd_iocb(scsi_qla_host_t *vha, int els_opcode,
        if (rval != QLA_SUCCESS) {
                /* ref: INIT */
                kref_put(&sp->cmd_kref, qla2x00_sp_release);
+               qla2x00_free_fcport(fcport);
                return QLA_FUNCTION_FAILED;
        }
 
@@ -3012,7 +3042,7 @@ static void qla2x00_els_dcmd2_sp_done(srb_t *sp, int res)
 
 int
 qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
-    fc_port_t *fcport, bool wait)
+                       fc_port_t *fcport)
 {
        srb_t *sp;
        struct srb_iocb *elsio = NULL;
@@ -3027,8 +3057,7 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
        if (!sp) {
                ql_log(ql_log_info, vha, 0x70e6,
                 "SRB allocation failed\n");
-               fcport->flags &= ~FCF_ASYNC_ACTIVE;
-               return -ENOMEM;
+               goto done;
        }
 
        fcport->flags |= FCF_ASYNC_SENT;
@@ -3037,9 +3066,6 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
        ql_dbg(ql_dbg_io, vha, 0x3073,
               "%s Enter: PLOGI portid=%06x\n", __func__, fcport->d_id.b24);
 
-       if (wait)
-               sp->flags = SRB_WAKEUP_ON_COMP;
-
        sp->type = SRB_ELS_DCMD;
        sp->name = "ELS_DCMD";
        sp->fcport = fcport;
@@ -3055,7 +3081,7 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
 
        if (!elsio->u.els_plogi.els_plogi_pyld) {
                rval = QLA_FUNCTION_FAILED;
-               goto out;
+               goto done_free_sp;
        }
 
        resp_ptr = elsio->u.els_plogi.els_resp_pyld =
@@ -3064,7 +3090,7 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
 
        if (!elsio->u.els_plogi.els_resp_pyld) {
                rval = QLA_FUNCTION_FAILED;
-               goto out;
+               goto done_free_sp;
        }
 
        ql_dbg(ql_dbg_io, vha, 0x3073, "PLOGI %p %p\n", ptr, resp_ptr);
@@ -3080,7 +3106,6 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
 
        if (els_opcode == ELS_DCMD_PLOGI && DBELL_ACTIVE(vha)) {
                struct fc_els_flogi *p = ptr;
-
                p->fl_csp.sp_features |= cpu_to_be16(FC_SP_FT_SEC);
        }
 
@@ -3089,10 +3114,11 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
            (uint8_t *)elsio->u.els_plogi.els_plogi_pyld,
            sizeof(*elsio->u.els_plogi.els_plogi_pyld));
 
-       init_completion(&elsio->u.els_plogi.comp);
        rval = qla2x00_start_sp(sp);
        if (rval != QLA_SUCCESS) {
-               rval = QLA_FUNCTION_FAILED;
+               fcport->flags |= FCF_LOGIN_NEEDED;
+               set_bit(RELOGIN_NEEDED, &vha->dpc_flags);
+               goto done_free_sp;
        } else {
                ql_dbg(ql_dbg_disc, vha, 0x3074,
                    "%s PLOGI sent, hdl=%x, loopid=%x, to port_id %06x from port_id %06x\n",
@@ -3100,21 +3126,15 @@ qla24xx_els_dcmd2_iocb(scsi_qla_host_t *vha, int els_opcode,
                    fcport->d_id.b24, vha->d_id.b24);
        }
 
-       if (wait) {
-               wait_for_completion(&elsio->u.els_plogi.comp);
-
-               if (elsio->u.els_plogi.comp_status != CS_COMPLETE)
-                       rval = QLA_FUNCTION_FAILED;
-       } else {
-               goto done;
-       }
+       return rval;
 
-out:
-       fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE);
+done_free_sp:
        qla2x00_els_dcmd2_free(vha, &elsio->u.els_plogi);
        /* ref: INIT */
        kref_put(&sp->cmd_kref, qla2x00_sp_release);
 done:
+       fcport->flags &= ~(FCF_ASYNC_SENT | FCF_ASYNC_ACTIVE);
+       qla2x00_set_fcport_disc_state(fcport, DSC_DELETED);
        return rval;
 }
 
@@ -3918,7 +3938,7 @@ qla2x00_start_sp(srb_t *sp)
                return -EAGAIN;
        }
 
-       pkt = __qla2x00_alloc_iocbs(sp->qpair, sp);
+       pkt = qla2x00_alloc_iocbs_ready(sp->qpair, sp);
        if (!pkt) {
                rval = -EAGAIN;
                ql_log(ql_log_warn, vha, 0x700c,
index 21ec32b4fb2809321ee6498255e63662cc094fb0..0cd6f3e1488249b4a744ed08b81aeb84b888203f 100644 (file)
@@ -194,7 +194,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp)
        if (ha->flags.purge_mbox || chip_reset != ha->chip_reset ||
            ha->flags.eeh_busy) {
                ql_log(ql_log_warn, vha, 0xd035,
-                      "Error detected: purge[%d] eeh[%d] cmd=0x%x, Exiting.\n",
+                      "Purge mbox: purge[%d] eeh[%d] cmd=0x%x, Exiting.\n",
                       ha->flags.purge_mbox, ha->flags.eeh_busy, mcp->mb[0]);
                rval = QLA_ABORTED;
                goto premature_exit;
index dd674378f2f392216334f7adb90129f2753e8c2a..1e2f52210f60502a31035df335e5c33c359f67e1 100644 (file)
@@ -4602,6 +4602,7 @@ fail_free_init_cb:
        ha->init_cb_dma = 0;
 fail_free_vp_map:
        kfree(ha->vp_map);
+       ha->vp_map = NULL;
 fail:
        ql_log(ql_log_fatal, NULL, 0x0030,
            "Memory allocation failure.\n");
@@ -5583,7 +5584,7 @@ qla2x00_do_work(struct scsi_qla_host *vha)
                        break;
                case QLA_EVT_ELS_PLOGI:
                        qla24xx_els_dcmd2_iocb(vha, ELS_DCMD_PLOGI,
-                           e->u.fcport.fcport, false);
+                           e->u.fcport.fcport);
                        break;
                case QLA_EVT_SA_REPLACE:
                        rc = qla24xx_issue_sa_replace_iocb(vha, e);
index 2ef2dbac0db2739d82c590f4afd987e893230931..d7551b1443e4a7538df5d45beb003a11b0c29b9f 100644 (file)
@@ -1062,6 +1062,16 @@ void qlt_free_session_done(struct work_struct *work)
                    "%s: sess %p logout completed\n", __func__, sess);
        }
 
+       /* check for any straggling io left behind */
+       if (!(sess->flags & FCF_FCP2_DEVICE) &&
+           qla2x00_eh_wait_for_pending_commands(sess->vha, sess->d_id.b24, 0, WAIT_TARGET)) {
+               ql_log(ql_log_warn, vha, 0x3027,
+                   "IO not return. Resetting.\n");
+               set_bit(ISP_ABORT_NEEDED, &vha->dpc_flags);
+               qla2xxx_wake_dpc(vha);
+               qla2x00_wait_for_chip_reset(vha);
+       }
+
        if (sess->logo_ack_needed) {
                sess->logo_ack_needed = 0;
                qla24xx_async_notify_ack(vha, sess,
index d903563e969eb32a0a079f3ea8c3504678afc65a..7627fd807bc3ede71b8bdbc707bed0a476d4c082 100644 (file)
@@ -6,9 +6,9 @@
 /*
  * Driver version
  */
-#define QLA2XXX_VERSION      "10.02.09.100-k"
+#define QLA2XXX_VERSION      "10.02.09.200-k"
 
 #define QLA_DRIVER_MAJOR_VER   10
 #define QLA_DRIVER_MINOR_VER   2
 #define QLA_DRIVER_PATCH_VER   9
-#define QLA_DRIVER_BETA_VER    100
+#define QLA_DRIVER_BETA_VER    200
index 8d06475de17a33a26921a1ff70c57f759986973f..ffd7e7e72933c52255e06acfaa967f2ea4b8b64e 100644 (file)
@@ -1642,6 +1642,40 @@ int scsi_add_device(struct Scsi_Host *host, uint channel,
 }
 EXPORT_SYMBOL(scsi_add_device);
 
+int scsi_resume_device(struct scsi_device *sdev)
+{
+       struct device *dev = &sdev->sdev_gendev;
+       int ret = 0;
+
+       device_lock(dev);
+
+       /*
+        * Bail out if the device or its queue are not running. Otherwise,
+        * the rescan may block waiting for commands to be executed, with us
+        * holding the device lock. This can result in a potential deadlock
+        * in the power management core code when system resume is on-going.
+        */
+       if (sdev->sdev_state != SDEV_RUNNING ||
+           blk_queue_pm_only(sdev->request_queue)) {
+               ret = -EWOULDBLOCK;
+               goto unlock;
+       }
+
+       if (dev->driver && try_module_get(dev->driver->owner)) {
+               struct scsi_driver *drv = to_scsi_driver(dev->driver);
+
+               if (drv->resume)
+                       ret = drv->resume(dev);
+               module_put(dev->driver->owner);
+       }
+
+unlock:
+       device_unlock(dev);
+
+       return ret;
+}
+EXPORT_SYMBOL(scsi_resume_device);
+
 int scsi_rescan_device(struct scsi_device *sdev)
 {
        struct device *dev = &sdev->sdev_gendev;
index ccff8f2e2e75bd4b0286f04c96cb41d588205941..3cf89867029044ede7b2f6a844dca974b8d50e32 100644 (file)
@@ -4108,7 +4108,21 @@ static int sd_suspend_runtime(struct device *dev)
        return sd_suspend_common(dev, true);
 }
 
-static int sd_resume(struct device *dev, bool runtime)
+static int sd_resume(struct device *dev)
+{
+       struct scsi_disk *sdkp = dev_get_drvdata(dev);
+
+       sd_printk(KERN_NOTICE, sdkp, "Starting disk\n");
+
+       if (opal_unlock_from_suspend(sdkp->opal_dev)) {
+               sd_printk(KERN_NOTICE, sdkp, "OPAL unlock failed\n");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int sd_resume_common(struct device *dev, bool runtime)
 {
        struct scsi_disk *sdkp = dev_get_drvdata(dev);
        int ret;
@@ -4124,7 +4138,7 @@ static int sd_resume(struct device *dev, bool runtime)
        sd_printk(KERN_NOTICE, sdkp, "Starting disk\n");
        ret = sd_start_stop_device(sdkp, 1);
        if (!ret) {
-               opal_unlock_from_suspend(sdkp->opal_dev);
+               sd_resume(dev);
                sdkp->suspended = false;
        }
 
@@ -4143,7 +4157,7 @@ static int sd_resume_system(struct device *dev)
                return 0;
        }
 
-       return sd_resume(dev, false);
+       return sd_resume_common(dev, false);
 }
 
 static int sd_resume_runtime(struct device *dev)
@@ -4170,7 +4184,7 @@ static int sd_resume_runtime(struct device *dev)
                                  "Failed to clear sense data\n");
        }
 
-       return sd_resume(dev, true);
+       return sd_resume_common(dev, true);
 }
 
 static const struct dev_pm_ops sd_pm_ops = {
@@ -4193,6 +4207,7 @@ static struct scsi_driver sd_template = {
                .pm             = &sd_pm_ops,
        },
        .rescan                 = sd_rescan,
+       .resume                 = sd_resume,
        .init_command           = sd_init_command,
        .uninit_command         = sd_uninit_command,
        .done                   = sd_done,
index 86210e4dd0d3530c65302723664b9ea5e9a6fc08..386981c6976a53d668632457a47fcf1db609f5fd 100644 (file)
@@ -1424,7 +1424,9 @@ static const struct file_operations sg_fops = {
        .llseek = no_llseek,
 };
 
-static struct class *sg_sysfs_class;
+static const struct class sg_sysfs_class = {
+       .name = "scsi_generic"
+};
 
 static int sg_sysfs_valid = 0;
 
@@ -1526,7 +1528,7 @@ sg_add_device(struct device *cl_dev)
        if (sg_sysfs_valid) {
                struct device *sg_class_member;
 
-               sg_class_member = device_create(sg_sysfs_class, cl_dev->parent,
+               sg_class_member = device_create(&sg_sysfs_class, cl_dev->parent,
                                                MKDEV(SCSI_GENERIC_MAJOR,
                                                      sdp->index),
                                                sdp, "%s", sdp->name);
@@ -1616,7 +1618,7 @@ sg_remove_device(struct device *cl_dev)
        read_unlock_irqrestore(&sdp->sfd_lock, iflags);
 
        sysfs_remove_link(&scsidp->sdev_gendev.kobj, "generic");
-       device_destroy(sg_sysfs_class, MKDEV(SCSI_GENERIC_MAJOR, sdp->index));
+       device_destroy(&sg_sysfs_class, MKDEV(SCSI_GENERIC_MAJOR, sdp->index));
        cdev_del(sdp->cdev);
        sdp->cdev = NULL;
 
@@ -1687,11 +1689,9 @@ init_sg(void)
                                    SG_MAX_DEVS, "sg");
        if (rc)
                return rc;
-        sg_sysfs_class = class_create("scsi_generic");
-        if ( IS_ERR(sg_sysfs_class) ) {
-               rc = PTR_ERR(sg_sysfs_class);
+       rc = class_register(&sg_sysfs_class);
+       if (rc)
                goto err_out;
-        }
        sg_sysfs_valid = 1;
        rc = scsi_register_interface(&sg_interface);
        if (0 == rc) {
@@ -1700,7 +1700,7 @@ init_sg(void)
 #endif                         /* CONFIG_SCSI_PROC_FS */
                return 0;
        }
-       class_destroy(sg_sysfs_class);
+       class_unregister(&sg_sysfs_class);
        register_sg_sysctls();
 err_out:
        unregister_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0), SG_MAX_DEVS);
@@ -1715,7 +1715,7 @@ exit_sg(void)
        remove_proc_subtree("scsi/sg", NULL);
 #endif                         /* CONFIG_SCSI_PROC_FS */
        scsi_unregister_interface(&sg_interface);
-       class_destroy(sg_sysfs_class);
+       class_unregister(&sg_sysfs_class);
        sg_sysfs_valid = 0;
        unregister_chrdev_region(MKDEV(SCSI_GENERIC_MAJOR, 0),
                                 SG_MAX_DEVS);
@@ -2207,6 +2207,7 @@ sg_remove_sfp_usercontext(struct work_struct *work)
 {
        struct sg_fd *sfp = container_of(work, struct sg_fd, ew.work);
        struct sg_device *sdp = sfp->parentdp;
+       struct scsi_device *device = sdp->device;
        Sg_request *srp;
        unsigned long iflags;
 
@@ -2232,8 +2233,9 @@ sg_remove_sfp_usercontext(struct work_struct *work)
                        "sg_remove_sfp: sfp=0x%p\n", sfp));
        kfree(sfp);
 
-       scsi_device_put(sdp->device);
+       WARN_ON_ONCE(kref_read(&sdp->d_ref) != 1);
        kref_put(&sdp->d_ref, sg_device_destroy);
+       scsi_device_put(device);
        module_put(THIS_MODULE);
 }
 
index 338aa8c429682ce2dd58c45b342228efadb81783..5a9bcf8e0792e56198eac5716a97476e53f712e6 100644 (file)
@@ -87,7 +87,7 @@ static int try_rdio = 1;
 static int try_wdio = 1;
 static int debug_flag;
 
-static struct class st_sysfs_class;
+static const struct class st_sysfs_class;
 static const struct attribute_group *st_dev_groups[];
 static const struct attribute_group *st_drv_groups[];
 
@@ -4438,7 +4438,7 @@ static void scsi_tape_release(struct kref *kref)
        return;
 }
 
-static struct class st_sysfs_class = {
+static const struct class st_sysfs_class = {
        .name = "scsi_tape",
        .dev_groups = st_dev_groups,
 };
index 258aa0e37f55441357f83781bccc417b3cb00079..4c3684dd902ed420f0e54aeba4346c683f3e00ce 100644 (file)
@@ -937,8 +937,9 @@ static int create_component(struct vchiq_mmal_instance *instance,
        /* build component create message */
        m.h.type = MMAL_MSG_TYPE_COMPONENT_CREATE;
        m.u.component_create.client_component = component->client_component;
-       strncpy(m.u.component_create.name, name,
-               sizeof(m.u.component_create.name));
+       strscpy_pad(m.u.component_create.name, name,
+                   sizeof(m.u.component_create.name));
+       m.u.component_create.pid = 0;
 
        ret = send_synchronous_mmal_msg(instance, &m,
                                        sizeof(m.u.component_create),
index 6797200211836d5966027f236fd7f7d06c53821f..d9a6242264b787b1bda4e546a4a16bd7650abab3 100644 (file)
@@ -583,7 +583,7 @@ int iscsit_dataout_datapduinorder_no_fbit(
        struct iscsi_pdu *pdu)
 {
        int i, send_recovery_r2t = 0, recovery = 0;
-       u32 length = 0, offset = 0, pdu_count = 0, xfer_len = 0;
+       u32 length = 0, offset = 0, pdu_count = 0;
        struct iscsit_conn *conn = cmd->conn;
        struct iscsi_pdu *first_pdu = NULL;
 
@@ -596,7 +596,6 @@ int iscsit_dataout_datapduinorder_no_fbit(
                        if (cmd->pdu_list[i].seq_no == pdu->seq_no) {
                                if (!first_pdu)
                                        first_pdu = &cmd->pdu_list[i];
-                               xfer_len += cmd->pdu_list[i].length;
                                pdu_count++;
                        } else if (pdu_count)
                                break;
index 50dec24e967a00deddcb77ecf9709ab22c486d62..8fd7cf1932cd44fd7abdbfed80ffee25f574c842 100644 (file)
@@ -214,7 +214,7 @@ static int devfreq_cooling_get_requested_power(struct thermal_cooling_device *cd
 
                res = dfc->power_ops->get_real_power(df, power, freq, voltage);
                if (!res) {
-                       state = dfc->capped_state;
+                       state = dfc->max_state - dfc->capped_state;
 
                        /* Convert EM power into milli-Watts first */
                        rcu_read_lock();
index 09f6050dd04161f2ef5697cf197b771291859079..497abf0d47cac59bbb09db7d40f680cfcffbfe1e 100644 (file)
@@ -65,7 +65,6 @@ void __thermal_zone_set_trips(struct thermal_zone_device *tz)
 {
        const struct thermal_trip *trip;
        int low = -INT_MAX, high = INT_MAX;
-       bool same_trip = false;
        int ret;
 
        lockdep_assert_held(&tz->lock);
@@ -74,36 +73,22 @@ void __thermal_zone_set_trips(struct thermal_zone_device *tz)
                return;
 
        for_each_trip(tz, trip) {
-               bool low_set = false;
                int trip_low;
 
                trip_low = trip->temperature - trip->hysteresis;
 
-               if (trip_low < tz->temperature && trip_low > low) {
+               if (trip_low < tz->temperature && trip_low > low)
                        low = trip_low;
-                       low_set = true;
-                       same_trip = false;
-               }
 
                if (trip->temperature > tz->temperature &&
-                   trip->temperature < high) {
+                   trip->temperature < high)
                        high = trip->temperature;
-                       same_trip = low_set;
-               }
        }
 
        /* No need to change trip points */
        if (tz->prev_low_trip == low && tz->prev_high_trip == high)
                return;
 
-       /*
-        * If "high" and "low" are the same, skip the change unless this is the
-        * first time.
-        */
-       if (same_trip && (tz->prev_low_trip != -INT_MAX ||
-           tz->prev_high_trip != INT_MAX))
-               return;
-
        tz->prev_low_trip = low;
        tz->prev_high_trip = high;
 
index 8db81f1a12d5fc8f39ac7a1010d6a0d1b55a16c9..768bf87cd80d3fe288eeba826ba3db46b4591dd3 100644 (file)
@@ -94,7 +94,7 @@ void ufshcd_mcq_config_mac(struct ufs_hba *hba, u32 max_active_cmds)
 
        val = ufshcd_readl(hba, REG_UFS_MCQ_CFG);
        val &= ~MCQ_CFG_MAC_MASK;
-       val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds);
+       val |= FIELD_PREP(MCQ_CFG_MAC_MASK, max_active_cmds - 1);
        ufshcd_writel(hba, val, REG_UFS_MCQ_CFG);
 }
 EXPORT_SYMBOL_GPL(ufshcd_mcq_config_mac);
index 8d68bd21ae7332409198b06d7c99d2f7e6faaafe..06859e17b67b7777a08d7e5e33b1bfb972cdd6c3 100644 (file)
@@ -1210,8 +1210,10 @@ static int ufs_qcom_set_core_clk_ctrl(struct ufs_hba *hba, bool is_scale_up)
 
        list_for_each_entry(clki, head, list) {
                if (!IS_ERR_OR_NULL(clki->clk) &&
-                       !strcmp(clki->name, "core_clk_unipro")) {
-                       if (is_scale_up)
+                   !strcmp(clki->name, "core_clk_unipro")) {
+                       if (!clki->max_freq)
+                               cycles_in_1us = 150; /* default for backwards compatibility */
+                       else if (is_scale_up)
                                cycles_in_1us = ceil(clki->max_freq, (1000 * 1000));
                        else
                                cycles_in_1us = ceil(clk_get_rate(clki->clk), (1000 * 1000));
index bb77de6fa067efe26280b24b0f62b54ba75bcbca..009158fef2a8f1ed82fb3fb7a4c4a9b5764e723b 100644 (file)
@@ -792,7 +792,7 @@ static int uio_mmap_dma_coherent(struct vm_area_struct *vma)
         */
        vma->vm_pgoff = 0;
 
-       addr = (void *)mem->addr;
+       addr = (void *)(uintptr_t)mem->addr;
        ret = dma_mmap_coherent(mem->dma_device,
                                vma,
                                addr,
index d5f9384df1255f241d27c80ae4cd40be8d1d2609..13cc35ab5d29a7ddc079883b8a853387fcdad63e 100644 (file)
@@ -60,7 +60,7 @@ static int uio_dmem_genirq_open(struct uio_info *info, struct inode *inode)
 
                addr = dma_alloc_coherent(&priv->pdev->dev, uiomem->size,
                                          &uiomem->dma_addr, GFP_KERNEL);
-               uiomem->addr = addr ? (phys_addr_t) addr : DMEM_MAP_ERROR;
+               uiomem->addr = addr ? (uintptr_t) addr : DMEM_MAP_ERROR;
                ++uiomem;
        }
        priv->refcnt++;
@@ -89,7 +89,7 @@ static int uio_dmem_genirq_release(struct uio_info *info, struct inode *inode)
                        break;
                if (uiomem->addr) {
                        dma_free_coherent(uiomem->dma_device, uiomem->size,
-                                         (void *) uiomem->addr,
+                                         (void *) (uintptr_t) uiomem->addr,
                                          uiomem->dma_addr);
                }
                uiomem->addr = DMEM_MAP_ERROR;
index 72b33f7d4c40fcc44bce35962a9b1ec6c2fc7701..f67881cba645ba3d68b8d1023e8008c1920a1e50 100644 (file)
@@ -191,7 +191,7 @@ static int pruss_probe(struct platform_device *pdev)
                p->mem[1].size = sram_pool_sz;
                p->mem[1].memtype = UIO_MEM_PHYS;
 
-               p->mem[2].addr = (phys_addr_t) gdev->ddr_vaddr;
+               p->mem[2].addr = (uintptr_t) gdev->ddr_vaddr;
                p->mem[2].dma_addr = gdev->ddr_paddr;
                p->mem[2].size = extram_pool_sz;
                p->mem[2].memtype = UIO_MEM_DMA_COHERENT;
index c553decb5461078280b5f566a6ccd4035727c4a6..c8262e2f291778c785193b4311ab9613d0c18697 100644 (file)
@@ -485,6 +485,7 @@ out_free_mem:
 static int service_outstanding_interrupt(struct wdm_device *desc)
 {
        int rv = 0;
+       int used;
 
        /* submit read urb only if the device is waiting for it */
        if (!desc->resp_count || !--desc->resp_count)
@@ -499,7 +500,10 @@ static int service_outstanding_interrupt(struct wdm_device *desc)
                goto out;
        }
 
-       set_bit(WDM_RESPONDING, &desc->flags);
+       used = test_and_set_bit(WDM_RESPONDING, &desc->flags);
+       if (used)
+               goto out;
+
        spin_unlock_irq(&desc->iuspin);
        rv = usb_submit_urb(desc->response, GFP_KERNEL);
        spin_lock_irq(&desc->iuspin);
index 3ee8455585b6be66e2312e17f922b57cc4385801..9446660e231bb3f9a79b5cdf1503b13377539227 100644 (file)
@@ -130,7 +130,6 @@ EXPORT_SYMBOL_GPL(ehci_cf_port_reset_rwsem);
 #define HUB_DEBOUNCE_STEP        25
 #define HUB_DEBOUNCE_STABLE     100
 
-static void hub_release(struct kref *kref);
 static int usb_reset_and_verify_device(struct usb_device *udev);
 static int hub_port_disable(struct usb_hub *hub, int port1, int set_state);
 static bool hub_port_warm_reset_required(struct usb_hub *hub, int port1,
@@ -720,14 +719,14 @@ static void kick_hub_wq(struct usb_hub *hub)
         */
        intf = to_usb_interface(hub->intfdev);
        usb_autopm_get_interface_no_resume(intf);
-       kref_get(&hub->kref);
+       hub_get(hub);
 
        if (queue_work(hub_wq, &hub->events))
                return;
 
        /* the work has already been scheduled */
        usb_autopm_put_interface_async(intf);
-       kref_put(&hub->kref, hub_release);
+       hub_put(hub);
 }
 
 void usb_kick_hub_wq(struct usb_device *hdev)
@@ -1095,7 +1094,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
                        goto init2;
                goto init3;
        }
-       kref_get(&hub->kref);
+       hub_get(hub);
 
        /* The superspeed hub except for root hub has to use Hub Depth
         * value as an offset into the route string to locate the bits
@@ -1343,7 +1342,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
                device_unlock(&hdev->dev);
        }
 
-       kref_put(&hub->kref, hub_release);
+       hub_put(hub);
 }
 
 /* Implement the continuations for the delays above */
@@ -1759,6 +1758,16 @@ static void hub_release(struct kref *kref)
        kfree(hub);
 }
 
+void hub_get(struct usb_hub *hub)
+{
+       kref_get(&hub->kref);
+}
+
+void hub_put(struct usb_hub *hub)
+{
+       kref_put(&hub->kref, hub_release);
+}
+
 static unsigned highspeed_hubs;
 
 static void hub_disconnect(struct usb_interface *intf)
@@ -1807,7 +1816,7 @@ static void hub_disconnect(struct usb_interface *intf)
 
        onboard_hub_destroy_pdevs(&hub->onboard_hub_devs);
 
-       kref_put(&hub->kref, hub_release);
+       hub_put(hub);
 }
 
 static bool hub_descriptor_is_sane(struct usb_host_interface *desc)
@@ -5934,7 +5943,7 @@ out_hdev_lock:
 
        /* Balance the stuff in kick_hub_wq() and allow autosuspend */
        usb_autopm_put_interface(intf);
-       kref_put(&hub->kref, hub_release);
+       hub_put(hub);
 
        kcov_remote_stop();
 }
index 43ce21c96a511455b17bea7274354a743b54af10..183b69dc295547ecb5165e9866c6f89f3ffb1bfc 100644 (file)
@@ -129,6 +129,8 @@ extern void usb_hub_remove_port_device(struct usb_hub *hub,
 extern int usb_hub_set_port_power(struct usb_device *hdev, struct usb_hub *hub,
                int port1, bool set);
 extern struct usb_hub *usb_hub_to_struct_hub(struct usb_device *hdev);
+extern void hub_get(struct usb_hub *hub);
+extern void hub_put(struct usb_hub *hub);
 extern int hub_port_debounce(struct usb_hub *hub, int port1,
                bool must_be_connected);
 extern int usb_clear_port_feature(struct usb_device *hdev,
index 5b5e613a11e599bdb05dd121ad073f69a7f5b386..686c01af03e63aa52253be6c44371ac335eb8fcd 100644 (file)
@@ -56,11 +56,22 @@ static ssize_t disable_show(struct device *dev,
        u16 portstatus, unused;
        bool disabled;
        int rc;
+       struct kernfs_node *kn;
 
+       hub_get(hub);
        rc = usb_autopm_get_interface(intf);
        if (rc < 0)
-               return rc;
+               goto out_hub_get;
 
+       /*
+        * Prevent deadlock if another process is concurrently
+        * trying to unregister hdev.
+        */
+       kn = sysfs_break_active_protection(&dev->kobj, &attr->attr);
+       if (!kn) {
+               rc = -ENODEV;
+               goto out_autopm;
+       }
        usb_lock_device(hdev);
        if (hub->disconnected) {
                rc = -ENODEV;
@@ -70,9 +81,13 @@ static ssize_t disable_show(struct device *dev,
        usb_hub_port_status(hub, port1, &portstatus, &unused);
        disabled = !usb_port_is_power_on(hub, portstatus);
 
-out_hdev_lock:
+ out_hdev_lock:
        usb_unlock_device(hdev);
+       sysfs_unbreak_active_protection(kn);
+ out_autopm:
        usb_autopm_put_interface(intf);
+ out_hub_get:
+       hub_put(hub);
 
        if (rc)
                return rc;
@@ -90,15 +105,26 @@ static ssize_t disable_store(struct device *dev, struct device_attribute *attr,
        int port1 = port_dev->portnum;
        bool disabled;
        int rc;
+       struct kernfs_node *kn;
 
        rc = kstrtobool(buf, &disabled);
        if (rc)
                return rc;
 
+       hub_get(hub);
        rc = usb_autopm_get_interface(intf);
        if (rc < 0)
-               return rc;
+               goto out_hub_get;
 
+       /*
+        * Prevent deadlock if another process is concurrently
+        * trying to unregister hdev.
+        */
+       kn = sysfs_break_active_protection(&dev->kobj, &attr->attr);
+       if (!kn) {
+               rc = -ENODEV;
+               goto out_autopm;
+       }
        usb_lock_device(hdev);
        if (hub->disconnected) {
                rc = -ENODEV;
@@ -119,9 +145,13 @@ static ssize_t disable_store(struct device *dev, struct device_attribute *attr,
        if (!rc)
                rc = count;
 
-out_hdev_lock:
+ out_hdev_lock:
        usb_unlock_device(hdev);
+       sysfs_unbreak_active_protection(kn);
+ out_autopm:
        usb_autopm_put_interface(intf);
+ out_hub_get:
+       hub_put(hub);
 
        return rc;
 }
index f98263e21c2a71104664ad21b33e0a2dc2d612cf..d83231d6736ac6f59eb6333ab315cf70e337f35a 100644 (file)
@@ -1217,14 +1217,24 @@ static ssize_t interface_authorized_store(struct device *dev,
 {
        struct usb_interface *intf = to_usb_interface(dev);
        bool val;
+       struct kernfs_node *kn;
 
        if (kstrtobool(buf, &val) != 0)
                return -EINVAL;
 
-       if (val)
+       if (val) {
                usb_authorize_interface(intf);
-       else
-               usb_deauthorize_interface(intf);
+       } else {
+               /*
+                * Prevent deadlock if another process is concurrently
+                * trying to unregister intf.
+                */
+               kn = sysfs_break_active_protection(&dev->kobj, &attr->attr);
+               if (kn) {
+                       usb_deauthorize_interface(intf);
+                       sysfs_unbreak_active_protection(kn);
+               }
+       }
 
        return count;
 }
index c92a1da46a01473ea2f2c9d6f94eabd1f92a8bb0..a141f83aba0ccefed100e62332cbd5c7134fbe63 100644 (file)
@@ -729,8 +729,14 @@ struct dwc2_dregs_backup {
  * struct dwc2_hregs_backup - Holds host registers state before
  * entering partial power down
  * @hcfg:              Backup of HCFG register
+ * @hflbaddr:          Backup of HFLBADDR register
  * @haintmsk:          Backup of HAINTMSK register
+ * @hcchar:            Backup of HCCHAR register
+ * @hcsplt:            Backup of HCSPLT register
  * @hcintmsk:          Backup of HCINTMSK register
+ * @hctsiz:            Backup of HCTSIZ register
+ * @hdma:              Backup of HCDMA register
+ * @hcdmab:            Backup of HCDMAB register
  * @hprt0:             Backup of HPTR0 register
  * @hfir:              Backup of HFIR register
  * @hptxfsiz:          Backup of HPTXFSIZ register
@@ -738,8 +744,14 @@ struct dwc2_dregs_backup {
  */
 struct dwc2_hregs_backup {
        u32 hcfg;
+       u32 hflbaddr;
        u32 haintmsk;
+       u32 hcchar[MAX_EPS_CHANNELS];
+       u32 hcsplt[MAX_EPS_CHANNELS];
        u32 hcintmsk[MAX_EPS_CHANNELS];
+       u32 hctsiz[MAX_EPS_CHANNELS];
+       u32 hcidma[MAX_EPS_CHANNELS];
+       u32 hcidmab[MAX_EPS_CHANNELS];
        u32 hprt0;
        u32 hfir;
        u32 hptxfsiz;
@@ -1086,6 +1098,7 @@ struct dwc2_hsotg {
        bool needs_byte_swap;
 
        /* DWC OTG HW Release versions */
+#define DWC2_CORE_REV_4_30a    0x4f54430a
 #define DWC2_CORE_REV_2_71a    0x4f54271a
 #define DWC2_CORE_REV_2_72a     0x4f54272a
 #define DWC2_CORE_REV_2_80a    0x4f54280a
@@ -1323,6 +1336,7 @@ int dwc2_backup_global_registers(struct dwc2_hsotg *hsotg);
 int dwc2_restore_global_registers(struct dwc2_hsotg *hsotg);
 
 void dwc2_enable_acg(struct dwc2_hsotg *hsotg);
+void dwc2_wakeup_from_lpm_l1(struct dwc2_hsotg *hsotg, bool remotewakeup);
 
 /* This function should be called on every hardware interrupt. */
 irqreturn_t dwc2_handle_common_intr(int irq, void *dev);
index 158ede7538548e4d6daba4fc08d543f434b3ec6d..26d752a4c3ca956c7f7bd7c5dbb4a38f6670b03d 100644 (file)
@@ -297,7 +297,8 @@ static void dwc2_handle_session_req_intr(struct dwc2_hsotg *hsotg)
 
                        /* Exit gadget mode clock gating. */
                        if (hsotg->params.power_down ==
-                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended)
+                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended &&
+                           !hsotg->params.no_clock_gating)
                                dwc2_gadget_exit_clock_gating(hsotg, 0);
                }
 
@@ -322,10 +323,11 @@ static void dwc2_handle_session_req_intr(struct dwc2_hsotg *hsotg)
  * @hsotg: Programming view of DWC_otg controller
  *
  */
-static void dwc2_wakeup_from_lpm_l1(struct dwc2_hsotg *hsotg)
+void dwc2_wakeup_from_lpm_l1(struct dwc2_hsotg *hsotg, bool remotewakeup)
 {
        u32 glpmcfg;
-       u32 i = 0;
+       u32 pcgctl;
+       u32 dctl;
 
        if (hsotg->lx_state != DWC2_L1) {
                dev_err(hsotg->dev, "Core isn't in DWC2_L1 state\n");
@@ -334,37 +336,57 @@ static void dwc2_wakeup_from_lpm_l1(struct dwc2_hsotg *hsotg)
 
        glpmcfg = dwc2_readl(hsotg, GLPMCFG);
        if (dwc2_is_device_mode(hsotg)) {
-               dev_dbg(hsotg->dev, "Exit from L1 state\n");
+               dev_dbg(hsotg->dev, "Exit from L1 state, remotewakeup=%d\n", remotewakeup);
                glpmcfg &= ~GLPMCFG_ENBLSLPM;
-               glpmcfg &= ~GLPMCFG_HIRD_THRES_EN;
+               glpmcfg &= ~GLPMCFG_HIRD_THRES_MASK;
                dwc2_writel(hsotg, glpmcfg, GLPMCFG);
 
-               do {
-                       glpmcfg = dwc2_readl(hsotg, GLPMCFG);
+               pcgctl = dwc2_readl(hsotg, PCGCTL);
+               pcgctl &= ~PCGCTL_ENBL_SLEEP_GATING;
+               dwc2_writel(hsotg, pcgctl, PCGCTL);
 
-                       if (!(glpmcfg & (GLPMCFG_COREL1RES_MASK |
-                                        GLPMCFG_L1RESUMEOK | GLPMCFG_SLPSTS)))
-                               break;
+               glpmcfg = dwc2_readl(hsotg, GLPMCFG);
+               if (glpmcfg & GLPMCFG_ENBESL) {
+                       glpmcfg |= GLPMCFG_RSTRSLPSTS;
+                       dwc2_writel(hsotg, glpmcfg, GLPMCFG);
+               }
+
+               if (remotewakeup) {
+                       if (dwc2_hsotg_wait_bit_set(hsotg, GLPMCFG, GLPMCFG_L1RESUMEOK, 1000)) {
+                               dev_warn(hsotg->dev, "%s: timeout GLPMCFG_L1RESUMEOK\n", __func__);
+                               goto fail;
+                               return;
+                       }
+
+                       dctl = dwc2_readl(hsotg, DCTL);
+                       dctl |= DCTL_RMTWKUPSIG;
+                       dwc2_writel(hsotg, dctl, DCTL);
 
-                       udelay(1);
-               } while (++i < 200);
+                       if (dwc2_hsotg_wait_bit_set(hsotg, GINTSTS, GINTSTS_WKUPINT, 1000)) {
+                               dev_warn(hsotg->dev, "%s: timeout GINTSTS_WKUPINT\n", __func__);
+                               goto fail;
+                               return;
+                       }
+               }
 
-               if (i == 200) {
-                       dev_err(hsotg->dev, "Failed to exit L1 sleep state in 200us.\n");
+               glpmcfg = dwc2_readl(hsotg, GLPMCFG);
+               if (glpmcfg & GLPMCFG_COREL1RES_MASK || glpmcfg & GLPMCFG_SLPSTS ||
+                   glpmcfg & GLPMCFG_L1RESUMEOK) {
+                       goto fail;
                        return;
                }
-               dwc2_gadget_init_lpm(hsotg);
+
+               /* Inform gadget to exit from L1 */
+               call_gadget(hsotg, resume);
+               /* Change to L0 state */
+               hsotg->lx_state = DWC2_L0;
+               hsotg->bus_suspended = false;
+fail:          dwc2_gadget_init_lpm(hsotg);
        } else {
                /* TODO */
                dev_err(hsotg->dev, "Host side LPM is not supported.\n");
                return;
        }
-
-       /* Change to L0 state */
-       hsotg->lx_state = DWC2_L0;
-
-       /* Inform gadget to exit from L1 */
-       call_gadget(hsotg, resume);
 }
 
 /*
@@ -385,7 +407,7 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
        dev_dbg(hsotg->dev, "%s lxstate = %d\n", __func__, hsotg->lx_state);
 
        if (hsotg->lx_state == DWC2_L1) {
-               dwc2_wakeup_from_lpm_l1(hsotg);
+               dwc2_wakeup_from_lpm_l1(hsotg, false);
                return;
        }
 
@@ -408,7 +430,8 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
 
                        /* Exit gadget mode clock gating. */
                        if (hsotg->params.power_down ==
-                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended)
+                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended &&
+                           !hsotg->params.no_clock_gating)
                                dwc2_gadget_exit_clock_gating(hsotg, 0);
                } else {
                        /* Change to L0 state */
@@ -425,7 +448,8 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
                        }
 
                        if (hsotg->params.power_down ==
-                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended)
+                           DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended &&
+                           !hsotg->params.no_clock_gating)
                                dwc2_host_exit_clock_gating(hsotg, 1);
 
                        /*
index b517a7216de22ae420405ae7ceae2fd04f74f2b3..b2f6da5b65ccd0190fb2a9f789b4a9352c53a15e 100644 (file)
@@ -1415,6 +1415,10 @@ static int dwc2_hsotg_ep_queue(struct usb_ep *ep, struct usb_request *req,
                ep->name, req, req->length, req->buf, req->no_interrupt,
                req->zero, req->short_not_ok);
 
+       if (hs->lx_state == DWC2_L1) {
+               dwc2_wakeup_from_lpm_l1(hs, true);
+       }
+
        /* Prevent new request submission when controller is suspended */
        if (hs->lx_state != DWC2_L0) {
                dev_dbg(hs->dev, "%s: submit request only in active state\n",
@@ -3727,6 +3731,12 @@ irq_retry:
                if (hsotg->in_ppd && hsotg->lx_state == DWC2_L2)
                        dwc2_exit_partial_power_down(hsotg, 0, true);
 
+               /* Exit gadget mode clock gating. */
+               if (hsotg->params.power_down ==
+                   DWC2_POWER_DOWN_PARAM_NONE && hsotg->bus_suspended &&
+                   !hsotg->params.no_clock_gating)
+                       dwc2_gadget_exit_clock_gating(hsotg, 0);
+
                hsotg->lx_state = DWC2_L0;
        }
 
index 35c7a4df8e71754f88d36f2f551d2e1e9eecef56..dd5b1c5691e11efa8e9300a289a32839e9212300 100644 (file)
@@ -2701,8 +2701,11 @@ enum dwc2_transaction_type dwc2_hcd_select_transactions(
                        hsotg->available_host_channels--;
                }
                qh = list_entry(qh_ptr, struct dwc2_qh, qh_list_entry);
-               if (dwc2_assign_and_init_hc(hsotg, qh))
+               if (dwc2_assign_and_init_hc(hsotg, qh)) {
+                       if (hsotg->params.uframe_sched)
+                               hsotg->available_host_channels++;
                        break;
+               }
 
                /*
                 * Move the QH from the periodic ready schedule to the
@@ -2735,8 +2738,11 @@ enum dwc2_transaction_type dwc2_hcd_select_transactions(
                        hsotg->available_host_channels--;
                }
 
-               if (dwc2_assign_and_init_hc(hsotg, qh))
+               if (dwc2_assign_and_init_hc(hsotg, qh)) {
+                       if (hsotg->params.uframe_sched)
+                               hsotg->available_host_channels++;
                        break;
+               }
 
                /*
                 * Move the QH from the non-periodic inactive schedule to the
@@ -4143,6 +4149,8 @@ void dwc2_host_complete(struct dwc2_hsotg *hsotg, struct dwc2_qtd *qtd,
                         urb->actual_length);
 
        if (usb_pipetype(urb->pipe) == PIPE_ISOCHRONOUS) {
+               if (!hsotg->params.dma_desc_enable)
+                       urb->start_frame = qtd->qh->start_active_frame;
                urb->error_count = dwc2_hcd_urb_get_error_count(qtd->urb);
                for (i = 0; i < urb->number_of_packets; ++i) {
                        urb->iso_frame_desc[i].actual_length =
@@ -4649,7 +4657,7 @@ static int _dwc2_hcd_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
        }
 
        if (hsotg->params.power_down == DWC2_POWER_DOWN_PARAM_NONE &&
-           hsotg->bus_suspended) {
+           hsotg->bus_suspended && !hsotg->params.no_clock_gating) {
                if (dwc2_is_device_mode(hsotg))
                        dwc2_gadget_exit_clock_gating(hsotg, 0);
                else
@@ -5406,9 +5414,16 @@ int dwc2_backup_host_registers(struct dwc2_hsotg *hsotg)
        /* Backup Host regs */
        hr = &hsotg->hr_backup;
        hr->hcfg = dwc2_readl(hsotg, HCFG);
+       hr->hflbaddr = dwc2_readl(hsotg, HFLBADDR);
        hr->haintmsk = dwc2_readl(hsotg, HAINTMSK);
-       for (i = 0; i < hsotg->params.host_channels; ++i)
+       for (i = 0; i < hsotg->params.host_channels; ++i) {
+               hr->hcchar[i] = dwc2_readl(hsotg, HCCHAR(i));
+               hr->hcsplt[i] = dwc2_readl(hsotg, HCSPLT(i));
                hr->hcintmsk[i] = dwc2_readl(hsotg, HCINTMSK(i));
+               hr->hctsiz[i] = dwc2_readl(hsotg, HCTSIZ(i));
+               hr->hcidma[i] = dwc2_readl(hsotg, HCDMA(i));
+               hr->hcidmab[i] = dwc2_readl(hsotg, HCDMAB(i));
+       }
 
        hr->hprt0 = dwc2_read_hprt0(hsotg);
        hr->hfir = dwc2_readl(hsotg, HFIR);
@@ -5442,10 +5457,17 @@ int dwc2_restore_host_registers(struct dwc2_hsotg *hsotg)
        hr->valid = false;
 
        dwc2_writel(hsotg, hr->hcfg, HCFG);
+       dwc2_writel(hsotg, hr->hflbaddr, HFLBADDR);
        dwc2_writel(hsotg, hr->haintmsk, HAINTMSK);
 
-       for (i = 0; i < hsotg->params.host_channels; ++i)
+       for (i = 0; i < hsotg->params.host_channels; ++i) {
+               dwc2_writel(hsotg, hr->hcchar[i], HCCHAR(i));
+               dwc2_writel(hsotg, hr->hcsplt[i], HCSPLT(i));
                dwc2_writel(hsotg, hr->hcintmsk[i], HCINTMSK(i));
+               dwc2_writel(hsotg, hr->hctsiz[i], HCTSIZ(i));
+               dwc2_writel(hsotg, hr->hcidma[i], HCDMA(i));
+               dwc2_writel(hsotg, hr->hcidmab[i], HCDMAB(i));
+       }
 
        dwc2_writel(hsotg, hr->hprt0, HPRT0);
        dwc2_writel(hsotg, hr->hfir, HFIR);
@@ -5610,10 +5632,12 @@ int dwc2_host_exit_hibernation(struct dwc2_hsotg *hsotg, int rem_wakeup,
        dwc2_writel(hsotg, hr->hcfg, HCFG);
 
        /* De-assert Wakeup Logic */
-       gpwrdn = dwc2_readl(hsotg, GPWRDN);
-       gpwrdn &= ~GPWRDN_PMUACTV;
-       dwc2_writel(hsotg, gpwrdn, GPWRDN);
-       udelay(10);
+       if (!(rem_wakeup && hsotg->hw_params.snpsid >= DWC2_CORE_REV_4_30a)) {
+               gpwrdn = dwc2_readl(hsotg, GPWRDN);
+               gpwrdn &= ~GPWRDN_PMUACTV;
+               dwc2_writel(hsotg, gpwrdn, GPWRDN);
+               udelay(10);
+       }
 
        hprt0 = hr->hprt0;
        hprt0 |= HPRT0_PWR;
@@ -5638,6 +5662,13 @@ int dwc2_host_exit_hibernation(struct dwc2_hsotg *hsotg, int rem_wakeup,
                hprt0 |= HPRT0_RES;
                dwc2_writel(hsotg, hprt0, HPRT0);
 
+               /* De-assert Wakeup Logic */
+               if ((rem_wakeup && hsotg->hw_params.snpsid >= DWC2_CORE_REV_4_30a)) {
+                       gpwrdn = dwc2_readl(hsotg, GPWRDN);
+                       gpwrdn &= ~GPWRDN_PMUACTV;
+                       dwc2_writel(hsotg, gpwrdn, GPWRDN);
+                       udelay(10);
+               }
                /* Wait for Resume time and then program HPRT again */
                mdelay(100);
                hprt0 &= ~HPRT0_RES;
index 6b4d825e97a2d91bbafd04ada5fdce4a1ab52c0c..79582b102c7eda2eb72f6da3c293615cdad50b56 100644 (file)
@@ -559,7 +559,7 @@ static void dwc2_init_isoc_dma_desc(struct dwc2_hsotg *hsotg,
        idx = qh->td_last;
        inc = qh->host_interval;
        hsotg->frame_number = dwc2_hcd_get_frame_number(hsotg);
-       cur_idx = dwc2_frame_list_idx(hsotg->frame_number);
+       cur_idx = idx;
        next_idx = dwc2_desclist_idx_inc(qh->td_last, inc, qh->dev_speed);
 
        /*
@@ -866,6 +866,8 @@ static int dwc2_cmpl_host_isoc_dma_desc(struct dwc2_hsotg *hsotg,
 {
        struct dwc2_dma_desc *dma_desc;
        struct dwc2_hcd_iso_packet_desc *frame_desc;
+       u16 frame_desc_idx;
+       struct urb *usb_urb = qtd->urb->priv;
        u16 remain = 0;
        int rc = 0;
 
@@ -878,8 +880,11 @@ static int dwc2_cmpl_host_isoc_dma_desc(struct dwc2_hsotg *hsotg,
                                DMA_FROM_DEVICE);
 
        dma_desc = &qh->desc_list[idx];
+       frame_desc_idx = (idx - qtd->isoc_td_first) & (usb_urb->number_of_packets - 1);
 
-       frame_desc = &qtd->urb->iso_descs[qtd->isoc_frame_index_last];
+       frame_desc = &qtd->urb->iso_descs[frame_desc_idx];
+       if (idx == qtd->isoc_td_first)
+               usb_urb->start_frame = dwc2_hcd_get_frame_number(hsotg);
        dma_desc->buf = (u32)(qtd->urb->dma + frame_desc->offset);
        if (chan->ep_is_in)
                remain = (dma_desc->status & HOST_DMA_ISOC_NBYTES_MASK) >>
@@ -900,7 +905,7 @@ static int dwc2_cmpl_host_isoc_dma_desc(struct dwc2_hsotg *hsotg,
                frame_desc->status = 0;
        }
 
-       if (++qtd->isoc_frame_index == qtd->urb->packet_count) {
+       if (++qtd->isoc_frame_index == usb_urb->number_of_packets) {
                /*
                 * urb->status is not used for isoc transfers here. The
                 * individual frame_desc status are used instead.
@@ -1005,11 +1010,11 @@ static void dwc2_complete_isoc_xfer_ddma(struct dwc2_hsotg *hsotg,
                                return;
                        idx = dwc2_desclist_idx_inc(idx, qh->host_interval,
                                                    chan->speed);
-                       if (!rc)
+                       if (rc == 0)
                                continue;
 
-                       if (rc == DWC2_CMPL_DONE)
-                               break;
+                       if (rc == DWC2_CMPL_DONE || rc == DWC2_CMPL_STOP)
+                               goto stop_scan;
 
                        /* rc == DWC2_CMPL_STOP */
 
index 13abdd5f6752999cc20603fa404b02c3d84bac20..12f8c7f86dc980fc8fb754a7c6d82eab9f88bc7a 100644 (file)
 #define TXSTS_QTOP_TOKEN_MASK          (0x3 << 25)
 #define TXSTS_QTOP_TOKEN_SHIFT         25
 #define TXSTS_QTOP_TERMINATE           BIT(24)
-#define TXSTS_QSPCAVAIL_MASK           (0xff << 16)
+#define TXSTS_QSPCAVAIL_MASK           (0x7f << 16)
 #define TXSTS_QSPCAVAIL_SHIFT          16
 #define TXSTS_FSPCAVAIL_MASK           (0xffff << 0)
 #define TXSTS_FSPCAVAIL_SHIFT          0
index b1d48019e944f3ea4166aa748d2053a4ea4312dc..7b84416dfc2b11eca6e4c9699571bb6379cce150 100644 (file)
@@ -331,7 +331,7 @@ static void dwc2_driver_remove(struct platform_device *dev)
 
        /* Exit clock gating when driver is removed. */
        if (hsotg->params.power_down == DWC2_POWER_DOWN_PARAM_NONE &&
-           hsotg->bus_suspended) {
+           hsotg->bus_suspended && !hsotg->params.no_clock_gating) {
                if (dwc2_is_device_mode(hsotg))
                        dwc2_gadget_exit_clock_gating(hsotg, 0);
                else
index 3e55838c0001443845d975d297dcf25877fe34d5..31684cdaaae3056c6cf9b16d31cc0eb4f217b7bb 100644 (file)
@@ -1519,6 +1519,8 @@ static void dwc3_get_properties(struct dwc3 *dwc)
        else
                dwc->sysdev = dwc->dev;
 
+       dwc->sys_wakeup = device_may_wakeup(dwc->sysdev);
+
        ret = device_property_read_string(dev, "usb-psy-name", &usb_psy_name);
        if (ret >= 0) {
                dwc->usb_psy = power_supply_get_by_name(usb_psy_name);
index c07edfc954f72e8bd5bb654a96ae731b1411ecf0..7e80dd3d466b88538f597a5f1534fd020ac23763 100644 (file)
@@ -1133,6 +1133,7 @@ struct dwc3_scratchpad_array {
  *     3       - Reserved
  * @dis_metastability_quirk: set to disable metastability quirk.
  * @dis_split_quirk: set to disable split boundary.
+ * @sys_wakeup: set if the device may do system wakeup.
  * @wakeup_configured: set if the device is configured for remote wakeup.
  * @suspended: set to track suspend event due to U3/L2.
  * @imod_interval: set the interrupt moderation interval in 250ns
@@ -1357,6 +1358,7 @@ struct dwc3 {
 
        unsigned                dis_split_quirk:1;
        unsigned                async_callbacks:1;
+       unsigned                sys_wakeup:1;
        unsigned                wakeup_configured:1;
        unsigned                suspended:1;
 
index 39564e17f3b07a228d54e503f0926c7b9bb810cf..497deed38c0c1edb0b0720bbad09f6775a56811a 100644 (file)
@@ -51,7 +51,6 @@
 #define PCI_DEVICE_ID_INTEL_MTLP               0x7ec1
 #define PCI_DEVICE_ID_INTEL_MTLS               0x7f6f
 #define PCI_DEVICE_ID_INTEL_MTL                        0x7e7e
-#define PCI_DEVICE_ID_INTEL_ARLH               0x7ec1
 #define PCI_DEVICE_ID_INTEL_ARLH_PCH           0x777e
 #define PCI_DEVICE_ID_INTEL_TGL                        0x9a15
 #define PCI_DEVICE_ID_AMD_MR                   0x163a
@@ -423,7 +422,6 @@ static const struct pci_device_id dwc3_pci_id_table[] = {
        { PCI_DEVICE_DATA(INTEL, MTLP, &dwc3_pci_intel_swnode) },
        { PCI_DEVICE_DATA(INTEL, MTL, &dwc3_pci_intel_swnode) },
        { PCI_DEVICE_DATA(INTEL, MTLS, &dwc3_pci_intel_swnode) },
-       { PCI_DEVICE_DATA(INTEL, ARLH, &dwc3_pci_intel_swnode) },
        { PCI_DEVICE_DATA(INTEL, ARLH_PCH, &dwc3_pci_intel_swnode) },
        { PCI_DEVICE_DATA(INTEL, TGL, &dwc3_pci_intel_swnode) },
 
index 40c52dbc28d3b4a1b2ff9580dc183e0db1152bdd..4df2661f66751bd56a3717d9f0d2705a29f07738 100644 (file)
@@ -2955,6 +2955,9 @@ static int dwc3_gadget_start(struct usb_gadget *g,
        dwc->gadget_driver      = driver;
        spin_unlock_irqrestore(&dwc->lock, flags);
 
+       if (dwc->sys_wakeup)
+               device_wakeup_enable(dwc->sysdev);
+
        return 0;
 }
 
@@ -2970,6 +2973,9 @@ static int dwc3_gadget_stop(struct usb_gadget *g)
        struct dwc3             *dwc = gadget_to_dwc(g);
        unsigned long           flags;
 
+       if (dwc->sys_wakeup)
+               device_wakeup_disable(dwc->sysdev);
+
        spin_lock_irqsave(&dwc->lock, flags);
        dwc->gadget_driver      = NULL;
        dwc->max_cfg_eps = 0;
@@ -4651,6 +4657,10 @@ int dwc3_gadget_init(struct dwc3 *dwc)
        else
                dwc3_gadget_set_speed(dwc->gadget, dwc->maximum_speed);
 
+       /* No system wakeup if no gadget driver bound */
+       if (dwc->sys_wakeup)
+               device_wakeup_disable(dwc->sysdev);
+
        return 0;
 
 err5:
index 5a5cb6ce9946d36e8b3de702fec7b3ab102f0779..0204787df81d50b9291b1701c554795c3d97bca8 100644 (file)
@@ -173,6 +173,14 @@ int dwc3_host_init(struct dwc3 *dwc)
                goto err;
        }
 
+       if (dwc->sys_wakeup) {
+               /* Restore wakeup setting if switched from device */
+               device_wakeup_enable(dwc->sysdev);
+
+               /* Pass on wakeup setting to the new xhci platform device */
+               device_init_wakeup(&xhci->dev, true);
+       }
+
        return 0;
 err:
        platform_device_put(xhci);
@@ -181,6 +189,9 @@ err:
 
 void dwc3_host_exit(struct dwc3 *dwc)
 {
+       if (dwc->sys_wakeup)
+               device_init_wakeup(&dwc->xhci->dev, false);
+
        platform_device_unregister(dwc->xhci);
        dwc->xhci = NULL;
 }
index 9d4150124fdb82b91dcbddc3e8ee9dc24abee7ba..b3a9d18a8dcd190767d8cc7c58072280949b1c58 100644 (file)
@@ -292,7 +292,9 @@ int usb_ep_queue(struct usb_ep *ep,
 {
        int ret = 0;
 
-       if (WARN_ON_ONCE(!ep->enabled && ep->address)) {
+       if (!ep->enabled && ep->address) {
+               pr_debug("USB gadget: queue request to disabled ep 0x%x (%s)\n",
+                                ep->address, ep->name);
                ret = -ESHUTDOWN;
                goto out;
        }
index 35770e608c6497bbb1e5eeb73da1f8e6ef89cb72..2d30fc1be30669c81c7208a50ae5b4fa8f841fca 100644 (file)
@@ -518,8 +518,10 @@ static int ljca_new_client_device(struct ljca_adapter *adap, u8 type, u8 id,
        int ret;
 
        client = kzalloc(sizeof *client, GFP_KERNEL);
-       if (!client)
+       if (!client) {
+               kfree(data);
                return -ENOMEM;
+       }
 
        client->type = type;
        client->id = id;
@@ -535,8 +537,10 @@ static int ljca_new_client_device(struct ljca_adapter *adap, u8 type, u8 id,
        auxdev->dev.release = ljca_auxdev_release;
 
        ret = auxiliary_device_init(auxdev);
-       if (ret)
+       if (ret) {
+               kfree(data);
                goto err_free;
+       }
 
        ljca_auxdev_acpi_bind(adap, auxdev, adr, id);
 
@@ -590,12 +594,8 @@ static int ljca_enumerate_gpio(struct ljca_adapter *adap)
                valid_pin[i] = get_unaligned_le32(&desc->bank_desc[i].valid_pins);
        bitmap_from_arr32(gpio_info->valid_pin_map, valid_pin, gpio_num);
 
-       ret = ljca_new_client_device(adap, LJCA_CLIENT_GPIO, 0, "ljca-gpio",
+       return ljca_new_client_device(adap, LJCA_CLIENT_GPIO, 0, "ljca-gpio",
                                     gpio_info, LJCA_GPIO_ACPI_ADR);
-       if (ret)
-               kfree(gpio_info);
-
-       return ret;
 }
 
 static int ljca_enumerate_i2c(struct ljca_adapter *adap)
@@ -629,10 +629,8 @@ static int ljca_enumerate_i2c(struct ljca_adapter *adap)
                ret = ljca_new_client_device(adap, LJCA_CLIENT_I2C, i,
                                             "ljca-i2c", i2c_info,
                                             LJCA_I2C1_ACPI_ADR + i);
-               if (ret) {
-                       kfree(i2c_info);
+               if (ret)
                        return ret;
-               }
        }
 
        return 0;
@@ -669,10 +667,8 @@ static int ljca_enumerate_spi(struct ljca_adapter *adap)
                ret = ljca_new_client_device(adap, LJCA_CLIENT_SPI, i,
                                             "ljca-spi", spi_info,
                                             LJCA_SPI1_ACPI_ADR + i);
-               if (ret) {
-                       kfree(spi_info);
+               if (ret)
                        return ret;
-               }
        }
 
        return 0;
index 8f735a86cd197275480ef69145ef0dee9f739a27..fdcffebf415cda91f0c65bd9a048f0a8a988da15 100644 (file)
@@ -262,13 +262,6 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop)
                return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
                                     "could not get vbus regulator\n");
 
-       nop->vbus_draw = devm_regulator_get_exclusive(dev, "vbus");
-       if (PTR_ERR(nop->vbus_draw) == -ENODEV)
-               nop->vbus_draw = NULL;
-       if (IS_ERR(nop->vbus_draw))
-               return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
-                                    "could not get vbus regulator\n");
-
        nop->dev                = dev;
        nop->phy.dev            = nop->dev;
        nop->phy.label          = "nop-xceiv";
index 71ace274761f182f0cbb942676e74d7e2c26d7a1..08953f0d4532aa72cf0d36ea96b2128cc4519de6 100644 (file)
@@ -533,7 +533,7 @@ static struct urb *uas_alloc_cmd_urb(struct uas_dev_info *devinfo, gfp_t gfp,
  * daft to me.
  */
 
-static struct urb *uas_submit_sense_urb(struct scsi_cmnd *cmnd, gfp_t gfp)
+static int uas_submit_sense_urb(struct scsi_cmnd *cmnd, gfp_t gfp)
 {
        struct uas_dev_info *devinfo = cmnd->device->hostdata;
        struct urb *urb;
@@ -541,30 +541,28 @@ static struct urb *uas_submit_sense_urb(struct scsi_cmnd *cmnd, gfp_t gfp)
 
        urb = uas_alloc_sense_urb(devinfo, gfp, cmnd);
        if (!urb)
-               return NULL;
+               return -ENOMEM;
        usb_anchor_urb(urb, &devinfo->sense_urbs);
        err = usb_submit_urb(urb, gfp);
        if (err) {
                usb_unanchor_urb(urb);
                uas_log_cmd_state(cmnd, "sense submit err", err);
                usb_free_urb(urb);
-               return NULL;
        }
-       return urb;
+       return err;
 }
 
 static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                           struct uas_dev_info *devinfo)
 {
        struct uas_cmd_info *cmdinfo = scsi_cmd_priv(cmnd);
-       struct urb *urb;
        int err;
 
        lockdep_assert_held(&devinfo->lock);
        if (cmdinfo->state & SUBMIT_STATUS_URB) {
-               urb = uas_submit_sense_urb(cmnd, GFP_ATOMIC);
-               if (!urb)
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+               err = uas_submit_sense_urb(cmnd, GFP_ATOMIC);
+               if (err)
+                       return err;
                cmdinfo->state &= ~SUBMIT_STATUS_URB;
        }
 
@@ -572,7 +570,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                cmdinfo->data_in_urb = uas_alloc_data_urb(devinfo, GFP_ATOMIC,
                                                        cmnd, DMA_FROM_DEVICE);
                if (!cmdinfo->data_in_urb)
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return -ENOMEM;
                cmdinfo->state &= ~ALLOC_DATA_IN_URB;
        }
 
@@ -582,7 +580,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                if (err) {
                        usb_unanchor_urb(cmdinfo->data_in_urb);
                        uas_log_cmd_state(cmnd, "data in submit err", err);
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return err;
                }
                cmdinfo->state &= ~SUBMIT_DATA_IN_URB;
                cmdinfo->state |= DATA_IN_URB_INFLIGHT;
@@ -592,7 +590,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                cmdinfo->data_out_urb = uas_alloc_data_urb(devinfo, GFP_ATOMIC,
                                                        cmnd, DMA_TO_DEVICE);
                if (!cmdinfo->data_out_urb)
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return -ENOMEM;
                cmdinfo->state &= ~ALLOC_DATA_OUT_URB;
        }
 
@@ -602,7 +600,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                if (err) {
                        usb_unanchor_urb(cmdinfo->data_out_urb);
                        uas_log_cmd_state(cmnd, "data out submit err", err);
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return err;
                }
                cmdinfo->state &= ~SUBMIT_DATA_OUT_URB;
                cmdinfo->state |= DATA_OUT_URB_INFLIGHT;
@@ -611,7 +609,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
        if (cmdinfo->state & ALLOC_CMD_URB) {
                cmdinfo->cmd_urb = uas_alloc_cmd_urb(devinfo, GFP_ATOMIC, cmnd);
                if (!cmdinfo->cmd_urb)
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return -ENOMEM;
                cmdinfo->state &= ~ALLOC_CMD_URB;
        }
 
@@ -621,7 +619,7 @@ static int uas_submit_urbs(struct scsi_cmnd *cmnd,
                if (err) {
                        usb_unanchor_urb(cmdinfo->cmd_urb);
                        uas_log_cmd_state(cmnd, "cmd submit err", err);
-                       return SCSI_MLQUEUE_DEVICE_BUSY;
+                       return err;
                }
                cmdinfo->cmd_urb = NULL;
                cmdinfo->state &= ~SUBMIT_CMD_URB;
@@ -698,7 +696,7 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd)
         * of queueing, no matter how fatal the error
         */
        if (err == -ENODEV) {
-               set_host_byte(cmnd, DID_ERROR);
+               set_host_byte(cmnd, DID_NO_CONNECT);
                scsi_done(cmnd);
                goto zombie;
        }
index 389c7f0b8d9358431890bc843e8007b6e92e9d97..9610e647a8d48006e776019c1ddc9eb6a7fddd4a 100644 (file)
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 {
        struct typec_port *port = to_typec_port(dev);
        struct usb_power_delivery *pd;
+       int ret;
 
        if (!port->ops || !port->ops->pd_set)
                return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
        if (!pd)
                return -EINVAL;
 
-       return port->ops->pd_set(port, pd);
+       ret = port->ops->pd_set(port, pd);
+       if (ret)
+               return ret;
+
+       return size;
 }
 
 static ssize_t select_usb_power_delivery_show(struct device *dev,
index ae2b6c94482d5fab23f26be2b12491a52b15419d..c26fb70c3ec6c09397ed4ac6c74300ac49fcc070 100644 (file)
@@ -6861,7 +6861,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
 
        if (data->source_desc.pdo[0]) {
                for (i = 0; i < PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++)
-                       port->snk_pdo[i] = data->source_desc.pdo[i];
+                       port->src_pdo[i] = data->source_desc.pdo[i];
                port->nr_src_pdo = i + 1;
        }
 
@@ -6910,7 +6910,9 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
 
        port->port_source_caps = data->source_cap;
        port->port_sink_caps = data->sink_cap;
+       typec_port_set_usb_power_delivery(p, NULL);
        port->selected_pd = pd;
+       typec_port_set_usb_power_delivery(p, port->selected_pd);
 unlock:
        mutex_unlock(&port->lock);
        return ret;
@@ -6943,9 +6945,7 @@ static void tcpm_port_unregister_pd(struct tcpm_port *port)
        port->port_source_caps = NULL;
        for (i = 0; i < port->pd_count; i++) {
                usb_power_delivery_unregister_capabilities(port->pd_list[i]->sink_cap);
-               kfree(port->pd_list[i]->sink_cap);
                usb_power_delivery_unregister_capabilities(port->pd_list[i]->source_cap);
-               kfree(port->pd_list[i]->source_cap);
                devm_kfree(port->dev, port->pd_list[i]);
                port->pd_list[i] = NULL;
                usb_power_delivery_unregister(port->pds[i]);
index cf52cb34d28592ccc76044a18a2cecc7f6280fda..31d8a46ae5e7cb4c5fee6f7b663517a6c367d348 100644 (file)
@@ -151,8 +151,12 @@ static int ucsi_exec_command(struct ucsi *ucsi, u64 cmd)
        if (!(cci & UCSI_CCI_COMMAND_COMPLETE))
                return -EIO;
 
-       if (cci & UCSI_CCI_NOT_SUPPORTED)
+       if (cci & UCSI_CCI_NOT_SUPPORTED) {
+               if (ucsi_acknowledge_command(ucsi) < 0)
+                       dev_err(ucsi->dev,
+                               "ACK of unsupported command failed\n");
                return -EOPNOTSUPP;
+       }
 
        if (cci & UCSI_CCI_ERROR) {
                if (cmd == UCSI_GET_ERROR_STATUS)
@@ -1133,17 +1137,21 @@ static int ucsi_check_cable(struct ucsi_connector *con)
        if (ret < 0)
                return ret;
 
-       ret = ucsi_get_cable_identity(con);
-       if (ret < 0)
-               return ret;
+       if (con->ucsi->cap.features & UCSI_CAP_GET_PD_MESSAGE) {
+               ret = ucsi_get_cable_identity(con);
+               if (ret < 0)
+                       return ret;
+       }
 
-       ret = ucsi_register_plug(con);
-       if (ret < 0)
-               return ret;
+       if (con->ucsi->cap.features & UCSI_CAP_ALT_MODE_DETAILS) {
+               ret = ucsi_register_plug(con);
+               if (ret < 0)
+                       return ret;
 
-       ret = ucsi_register_altmodes(con, UCSI_RECIPIENT_SOP_P);
-       if (ret < 0)
-               return ret;
+               ret = ucsi_register_altmodes(con, UCSI_RECIPIENT_SOP_P);
+               if (ret < 0)
+                       return ret;
+       }
 
        return 0;
 }
@@ -1189,8 +1197,10 @@ static void ucsi_handle_connector_change(struct work_struct *work)
                        ucsi_register_partner(con);
                        ucsi_partner_task(con, ucsi_check_connection, 1, HZ);
                        ucsi_partner_task(con, ucsi_check_connector_capability, 1, HZ);
-                       ucsi_partner_task(con, ucsi_get_partner_identity, 1, HZ);
-                       ucsi_partner_task(con, ucsi_check_cable, 1, HZ);
+                       if (con->ucsi->cap.features & UCSI_CAP_GET_PD_MESSAGE)
+                               ucsi_partner_task(con, ucsi_get_partner_identity, 1, HZ);
+                       if (con->ucsi->cap.features & UCSI_CAP_CABLE_DETAILS)
+                               ucsi_partner_task(con, ucsi_check_cable, 1, HZ);
 
                        if (UCSI_CONSTAT_PWR_OPMODE(con->status.flags) ==
                            UCSI_CONSTAT_PWR_OPMODE_PD)
@@ -1215,11 +1225,11 @@ static void ucsi_handle_connector_change(struct work_struct *work)
        if (con->status.change & UCSI_CONSTAT_CAM_CHANGE)
                ucsi_partner_task(con, ucsi_check_altmodes, 1, 0);
 
-       clear_bit(EVENT_PENDING, &con->ucsi->flags);
-
        mutex_lock(&ucsi->ppm_lock);
+       clear_bit(EVENT_PENDING, &con->ucsi->flags);
        ret = ucsi_acknowledge_connector_change(ucsi);
        mutex_unlock(&ucsi->ppm_lock);
+
        if (ret)
                dev_err(ucsi->dev, "%s: ACK failed (%d)", __func__, ret);
 
@@ -1237,7 +1247,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num)
        struct ucsi_connector *con = &ucsi->connector[num - 1];
 
        if (!(ucsi->ntfy & UCSI_ENABLE_NTFY_CONNECTOR_CHANGE)) {
-               dev_dbg(ucsi->dev, "Bogus connector change event\n");
+               dev_dbg(ucsi->dev, "Early connector change event\n");
                return;
        }
 
@@ -1260,13 +1270,47 @@ static int ucsi_reset_connector(struct ucsi_connector *con, bool hard)
 
 static int ucsi_reset_ppm(struct ucsi *ucsi)
 {
-       u64 command = UCSI_PPM_RESET;
+       u64 command;
        unsigned long tmo;
        u32 cci;
        int ret;
 
        mutex_lock(&ucsi->ppm_lock);
 
+       ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci));
+       if (ret < 0)
+               goto out;
+
+       /*
+        * If UCSI_CCI_RESET_COMPLETE is already set we must clear
+        * the flag before we start another reset. Send a
+        * UCSI_SET_NOTIFICATION_ENABLE command to achieve this.
+        * Ignore a timeout and try the reset anyway if this fails.
+        */
+       if (cci & UCSI_CCI_RESET_COMPLETE) {
+               command = UCSI_SET_NOTIFICATION_ENABLE;
+               ret = ucsi->ops->async_write(ucsi, UCSI_CONTROL, &command,
+                                            sizeof(command));
+               if (ret < 0)
+                       goto out;
+
+               tmo = jiffies + msecs_to_jiffies(UCSI_TIMEOUT_MS);
+               do {
+                       ret = ucsi->ops->read(ucsi, UCSI_CCI,
+                                             &cci, sizeof(cci));
+                       if (ret < 0)
+                               goto out;
+                       if (cci & UCSI_CCI_COMMAND_COMPLETE)
+                               break;
+                       if (time_is_before_jiffies(tmo))
+                               break;
+                       msleep(20);
+               } while (1);
+
+               WARN_ON(cci & UCSI_CCI_RESET_COMPLETE);
+       }
+
+       command = UCSI_PPM_RESET;
        ret = ucsi->ops->async_write(ucsi, UCSI_CONTROL, &command,
                                     sizeof(command));
        if (ret < 0)
@@ -1589,8 +1633,10 @@ static int ucsi_register_port(struct ucsi *ucsi, struct ucsi_connector *con)
                ucsi_register_partner(con);
                ucsi_pwr_opmode_change(con);
                ucsi_port_psy_changed(con);
-               ucsi_get_partner_identity(con);
-               ucsi_check_cable(con);
+               if (con->ucsi->cap.features & UCSI_CAP_GET_PD_MESSAGE)
+                       ucsi_get_partner_identity(con);
+               if (con->ucsi->cap.features & UCSI_CAP_CABLE_DETAILS)
+                       ucsi_check_cable(con);
        }
 
        /* Only notify USB controller if partner supports USB data */
@@ -1636,6 +1682,7 @@ static int ucsi_init(struct ucsi *ucsi)
 {
        struct ucsi_connector *con, *connector;
        u64 command, ntfy;
+       u32 cci;
        int ret;
        int i;
 
@@ -1688,6 +1735,13 @@ static int ucsi_init(struct ucsi *ucsi)
 
        ucsi->connector = connector;
        ucsi->ntfy = ntfy;
+
+       ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci));
+       if (ret)
+               return ret;
+       if (UCSI_CCI_CONNECTOR(READ_ONCE(cci)))
+               ucsi_connector_change(ucsi, cci);
+
        return 0;
 
 err_unregister:
index 32daf5f5865053d8a239d6be911644ce481d9e69..0e7c92eb1b227844d7d3be8c8c31e4dbfdccaefc 100644 (file)
@@ -206,7 +206,7 @@ struct ucsi_capability {
 #define UCSI_CAP_ATTR_POWER_OTHER              BIT(10)
 #define UCSI_CAP_ATTR_POWER_VBUS               BIT(14)
        u8 num_connectors;
-       u8 features;
+       u16 features;
 #define UCSI_CAP_SET_UOM                       BIT(0)
 #define UCSI_CAP_SET_PDM                       BIT(1)
 #define UCSI_CAP_ALT_MODE_DETAILS              BIT(2)
@@ -215,7 +215,8 @@ struct ucsi_capability {
 #define UCSI_CAP_CABLE_DETAILS                 BIT(5)
 #define UCSI_CAP_EXT_SUPPLY_NOTIFICATIONS      BIT(6)
 #define UCSI_CAP_PD_RESET                      BIT(7)
-       u16 reserved_1;
+#define UCSI_CAP_GET_PD_MESSAGE                BIT(8)
+       u8 reserved_1;
        u8 num_alt_modes;
        u8 reserved_2;
        u16 bc_version;
index 928eacbeb21ac4cc5b8857644969bff7aba7a8a1..7b3ac133ef86180823bf92e8a5f85cfe3e03b4dd 100644 (file)
@@ -23,10 +23,11 @@ struct ucsi_acpi {
        void *base;
        struct completion complete;
        unsigned long flags;
+#define UCSI_ACPI_SUPPRESS_EVENT       0
+#define UCSI_ACPI_COMMAND_PENDING      1
+#define UCSI_ACPI_ACK_PENDING          2
        guid_t guid;
        u64 cmd;
-       bool dell_quirk_probed;
-       bool dell_quirk_active;
 };
 
 static int ucsi_acpi_dsm(struct ucsi_acpi *ua, int func)
@@ -79,9 +80,9 @@ static int ucsi_acpi_sync_write(struct ucsi *ucsi, unsigned int offset,
        int ret;
 
        if (ack)
-               set_bit(ACK_PENDING, &ua->flags);
+               set_bit(UCSI_ACPI_ACK_PENDING, &ua->flags);
        else
-               set_bit(COMMAND_PENDING, &ua->flags);
+               set_bit(UCSI_ACPI_COMMAND_PENDING, &ua->flags);
 
        ret = ucsi_acpi_async_write(ucsi, offset, val, val_len);
        if (ret)
@@ -92,9 +93,9 @@ static int ucsi_acpi_sync_write(struct ucsi *ucsi, unsigned int offset,
 
 out_clear_bit:
        if (ack)
-               clear_bit(ACK_PENDING, &ua->flags);
+               clear_bit(UCSI_ACPI_ACK_PENDING, &ua->flags);
        else
-               clear_bit(COMMAND_PENDING, &ua->flags);
+               clear_bit(UCSI_ACPI_COMMAND_PENDING, &ua->flags);
 
        return ret;
 }
@@ -129,51 +130,40 @@ static const struct ucsi_operations ucsi_zenbook_ops = {
 };
 
 /*
- * Some Dell laptops expect that an ACK command with the
- * UCSI_ACK_CONNECTOR_CHANGE bit set is followed by a (separate)
- * ACK command that only has the UCSI_ACK_COMMAND_COMPLETE bit set.
- * If this is not done events are not delivered to OSPM and
- * subsequent commands will timeout.
+ * Some Dell laptops don't like ACK commands with the
+ * UCSI_ACK_CONNECTOR_CHANGE but not the UCSI_ACK_COMMAND_COMPLETE
+ * bit set. To work around this send a dummy command and bundle the
+ * UCSI_ACK_CONNECTOR_CHANGE with the UCSI_ACK_COMMAND_COMPLETE
+ * for the dummy command.
  */
 static int
 ucsi_dell_sync_write(struct ucsi *ucsi, unsigned int offset,
                     const void *val, size_t val_len)
 {
        struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
-       u64 cmd = *(u64 *)val, ack = 0;
+       u64 cmd = *(u64 *)val;
+       u64 dummycmd = UCSI_GET_CAPABILITY;
        int ret;
 
-       if (UCSI_COMMAND(cmd) == UCSI_ACK_CC_CI &&
-           cmd & UCSI_ACK_CONNECTOR_CHANGE)
-               ack = UCSI_ACK_CC_CI | UCSI_ACK_COMMAND_COMPLETE;
-
-       ret = ucsi_acpi_sync_write(ucsi, offset, val, val_len);
-       if (ret != 0)
-               return ret;
-       if (ack == 0)
-               return ret;
-
-       if (!ua->dell_quirk_probed) {
-               ua->dell_quirk_probed = true;
-
-               cmd = UCSI_GET_CAPABILITY;
-               ret = ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &cmd,
-                                          sizeof(cmd));
-               if (ret == 0)
-                       return ucsi_acpi_sync_write(ucsi, UCSI_CONTROL,
-                                                   &ack, sizeof(ack));
-               if (ret != -ETIMEDOUT)
+       if (cmd == (UCSI_ACK_CC_CI | UCSI_ACK_CONNECTOR_CHANGE)) {
+               cmd |= UCSI_ACK_COMMAND_COMPLETE;
+
+               /*
+                * The UCSI core thinks it is sending a connector change ack
+                * and will accept new connector change events. We don't want
+                * this to happen for the dummy command as its response will
+                * still report the very event that the core is trying to clear.
+                */
+               set_bit(UCSI_ACPI_SUPPRESS_EVENT, &ua->flags);
+               ret = ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &dummycmd,
+                                          sizeof(dummycmd));
+               clear_bit(UCSI_ACPI_SUPPRESS_EVENT, &ua->flags);
+
+               if (ret < 0)
                        return ret;
-
-               ua->dell_quirk_active = true;
-               dev_err(ua->dev, "Firmware bug: Additional ACK required after ACKing a connector change.\n");
-               dev_err(ua->dev, "Firmware bug: Enabling workaround\n");
        }
 
-       if (!ua->dell_quirk_active)
-               return ret;
-
-       return ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &ack, sizeof(ack));
+       return ucsi_acpi_sync_write(ucsi, UCSI_CONTROL, &cmd, sizeof(cmd));
 }
 
 static const struct ucsi_operations ucsi_dell_ops = {
@@ -209,13 +199,14 @@ static void ucsi_acpi_notify(acpi_handle handle, u32 event, void *data)
        if (ret)
                return;
 
-       if (UCSI_CCI_CONNECTOR(cci))
+       if (UCSI_CCI_CONNECTOR(cci) &&
+           !test_bit(UCSI_ACPI_SUPPRESS_EVENT, &ua->flags))
                ucsi_connector_change(ua->ucsi, UCSI_CCI_CONNECTOR(cci));
 
        if (cci & UCSI_CCI_ACK_COMPLETE && test_bit(ACK_PENDING, &ua->flags))
                complete(&ua->complete);
        if (cci & UCSI_CCI_COMMAND_COMPLETE &&
-           test_bit(COMMAND_PENDING, &ua->flags))
+           test_bit(UCSI_ACPI_COMMAND_PENDING, &ua->flags))
                complete(&ua->complete);
 }
 
index 932e7bf694473586b06d311311c2720ff9143a85..ce08eb33e5becab84460f5c1aba232f5c875f9a3 100644 (file)
@@ -255,6 +255,20 @@ static void pmic_glink_ucsi_notify(struct work_struct *work)
 static void pmic_glink_ucsi_register(struct work_struct *work)
 {
        struct pmic_glink_ucsi *ucsi = container_of(work, struct pmic_glink_ucsi, register_work);
+       int orientation;
+       int i;
+
+       for (i = 0; i < PMIC_GLINK_MAX_PORTS; i++) {
+               if (!ucsi->port_orientation[i])
+                       continue;
+               orientation = gpiod_get_value(ucsi->port_orientation[i]);
+
+               if (orientation >= 0) {
+                       typec_switch_set(ucsi->port_switch[i],
+                                        orientation ? TYPEC_ORIENTATION_REVERSE
+                                            : TYPEC_ORIENTATION_NORMAL);
+               }
+       }
 
        ucsi_register(ucsi->ucsi);
 }
index e3179e987cdb32b16b317b199238057ed187f125..197b6d5268e941c2b272c2b4d353907ce4c0b768 100644 (file)
@@ -494,6 +494,7 @@ config FB_SBUS_HELPERS
        select FB_CFB_COPYAREA
        select FB_CFB_FILLRECT
        select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_FOPS
 
 config FB_BW2
        bool "BWtwo support"
@@ -514,6 +515,7 @@ config FB_CG6
        depends on (FB = y) && (SPARC && FB_SBUS)
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_FOPS
        help
          This is the frame buffer device driver for the CGsix (GX, TurboGX)
          frame buffer.
@@ -523,6 +525,7 @@ config FB_FFB
        depends on FB_SBUS && SPARC64
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_FOPS
        help
          This is the frame buffer device driver for the Creator, Creator3D,
          and Elite3D graphics boards.
index 360a5304ec03ce53e5bab61e2177a5f325569ebf..b01b1bbf24937168f6fdabe920ddbad0bae3e5d9 100644 (file)
@@ -344,17 +344,21 @@ void v9fs_evict_inode(struct inode *inode)
        struct v9fs_inode __maybe_unused *v9inode = V9FS_I(inode);
        __le32 __maybe_unused version;
 
-       truncate_inode_pages_final(&inode->i_data);
+       if (!is_bad_inode(inode)) {
+               truncate_inode_pages_final(&inode->i_data);
 
-       version = cpu_to_le32(v9inode->qid.version);
-       netfs_clear_inode_writeback(inode, &version);
+               version = cpu_to_le32(v9inode->qid.version);
+               netfs_clear_inode_writeback(inode, &version);
 
-       clear_inode(inode);
-       filemap_fdatawrite(&inode->i_data);
+               clear_inode(inode);
+               filemap_fdatawrite(&inode->i_data);
 
 #ifdef CONFIG_9P_FSCACHE
-       fscache_relinquish_cookie(v9fs_inode_cookie(v9inode), false);
+               if (v9fs_inode_cookie(v9inode))
+                       fscache_relinquish_cookie(v9fs_inode_cookie(v9inode), false);
 #endif
+       } else
+               clear_inode(inode);
 }
 
 struct inode *v9fs_fid_iget(struct super_block *sb, struct p9_fid *fid)
index ef9db3e035062b189be8e408c15372e0dd11b3c6..55dde186041a38d98c997e2ea728e2004c2a9606 100644 (file)
@@ -78,11 +78,11 @@ struct inode *v9fs_fid_iget_dotl(struct super_block *sb, struct p9_fid *fid)
 
        retval = v9fs_init_inode(v9ses, inode, &fid->qid,
                                 st->st_mode, new_decode_dev(st->st_rdev));
+       v9fs_stat2inode_dotl(st, inode, 0);
        kfree(st);
        if (retval)
                goto error;
 
-       v9fs_stat2inode_dotl(st, inode, 0);
        v9fs_set_netfs_context(inode);
        v9fs_cache_inode_get_cookie(inode);
        retval = v9fs_get_acl(inode, fid);
@@ -297,7 +297,6 @@ static int v9fs_vfs_mkdir_dotl(struct mnt_idmap *idmap,
                               umode_t omode)
 {
        int err;
-       struct v9fs_session_info *v9ses;
        struct p9_fid *fid = NULL, *dfid = NULL;
        kgid_t gid;
        const unsigned char *name;
@@ -307,7 +306,6 @@ static int v9fs_vfs_mkdir_dotl(struct mnt_idmap *idmap,
        struct posix_acl *dacl = NULL, *pacl = NULL;
 
        p9_debug(P9_DEBUG_VFS, "name %pd\n", dentry);
-       v9ses = v9fs_inode2v9ses(dir);
 
        omode |= S_IFDIR;
        if (dir->i_mode & S_ISGID)
@@ -739,7 +737,6 @@ v9fs_vfs_mknod_dotl(struct mnt_idmap *idmap, struct inode *dir,
        kgid_t gid;
        const unsigned char *name;
        umode_t mode;
-       struct v9fs_session_info *v9ses;
        struct p9_fid *fid = NULL, *dfid = NULL;
        struct inode *inode;
        struct p9_qid qid;
@@ -749,7 +746,6 @@ v9fs_vfs_mknod_dotl(struct mnt_idmap *idmap, struct inode *dir,
                 dir->i_ino, dentry, omode,
                 MAJOR(rdev), MINOR(rdev));
 
-       v9ses = v9fs_inode2v9ses(dir);
        dfid = v9fs_parent_fid(dentry);
        if (IS_ERR(dfid)) {
                err = PTR_ERR(dfid);
index 1920ed69279b5805f21ba66772dd661b6e3042e8..3314249e867474ff81075b4e007030caaf0fcd2e 100644 (file)
@@ -1359,7 +1359,7 @@ static int fill_psinfo(struct elf_prpsinfo *psinfo, struct task_struct *p,
        SET_UID(psinfo->pr_uid, from_kuid_munged(cred->user_ns, cred->uid));
        SET_GID(psinfo->pr_gid, from_kgid_munged(cred->user_ns, cred->gid));
        rcu_read_unlock();
-       strncpy(psinfo->pr_fname, p->comm, sizeof(psinfo->pr_fname));
+       get_task_comm(psinfo->pr_fname, p);
 
        return 0;
 }
index 5f7587ca1ca7720d26a7cd192fdcd7ccd97c55bd..1e09aeea69c22e011b5a8f305421b342d04aa8b4 100644 (file)
@@ -1559,7 +1559,8 @@ void btrfs_delete_unused_bgs(struct btrfs_fs_info *fs_info)
                 * needing to allocate extents from the block group.
                 */
                used = btrfs_space_info_used(space_info, true);
-               if (space_info->total_bytes - block_group->length < used) {
+               if (space_info->total_bytes - block_group->length < used &&
+                   block_group->zone_unusable < block_group->length) {
                        /*
                         * Add a reference for the list, compensate for the ref
                         * drop under the "next" label for the
index 7441245b1ceb1508558782a88759fd34ddb84818..61594eaf1f8969fc3ba04604e3470a8932450767 100644 (file)
@@ -4333,6 +4333,19 @@ int read_extent_buffer_pages(struct extent_buffer *eb, int wait, int mirror_num,
        if (test_and_set_bit(EXTENT_BUFFER_READING, &eb->bflags))
                goto done;
 
+       /*
+        * Between the initial test_bit(EXTENT_BUFFER_UPTODATE) and the above
+        * test_and_set_bit(EXTENT_BUFFER_READING), someone else could have
+        * started and finished reading the same eb.  In this case, UPTODATE
+        * will now be set, and we shouldn't read it in again.
+        */
+       if (unlikely(test_bit(EXTENT_BUFFER_UPTODATE, &eb->bflags))) {
+               clear_bit(EXTENT_BUFFER_READING, &eb->bflags);
+               smp_mb__after_atomic();
+               wake_up_bit(&eb->bflags, EXTENT_BUFFER_READING);
+               return 0;
+       }
+
        clear_bit(EXTENT_BUFFER_READ_ERR, &eb->bflags);
        eb->read_mirror = 0;
        check_buffer_tree_ref(eb);
index 347ca13d15a97586b36669e823e2ed3bec86449f..445f7716f1e2f70b3f780e7c1f03d020f0eb6346 100644 (file)
@@ -309,7 +309,7 @@ int unpin_extent_cache(struct btrfs_inode *inode, u64 start, u64 len, u64 gen)
                btrfs_warn(fs_info,
 "no extent map found for inode %llu (root %lld) when unpinning extent range [%llu, %llu), generation %llu",
                           btrfs_ino(inode), btrfs_root_id(inode->root),
-                          start, len, gen);
+                          start, start + len, gen);
                ret = -ENOENT;
                goto out;
        }
@@ -318,7 +318,7 @@ int unpin_extent_cache(struct btrfs_inode *inode, u64 start, u64 len, u64 gen)
                btrfs_warn(fs_info,
 "found extent map for inode %llu (root %lld) with unexpected start offset %llu when unpinning extent range [%llu, %llu), generation %llu",
                           btrfs_ino(inode), btrfs_root_id(inode->root),
-                          em->start, start, len, gen);
+                          em->start, start, start + len, gen);
                ret = -EUCLEAN;
                goto out;
        }
@@ -340,9 +340,9 @@ int unpin_extent_cache(struct btrfs_inode *inode, u64 start, u64 len, u64 gen)
                em->mod_len = em->len;
        }
 
-       free_extent_map(em);
 out:
        write_unlock(&tree->lock);
+       free_extent_map(em);
        return ret;
 
 }
@@ -629,13 +629,13 @@ int btrfs_add_extent_mapping(struct btrfs_fs_info *fs_info,
                         */
                        ret = merge_extent_mapping(em_tree, existing,
                                                   em, start);
-                       if (ret) {
+                       if (WARN_ON(ret)) {
                                free_extent_map(em);
                                *em_in = NULL;
-                               WARN_ONCE(ret,
-"extent map merge error existing [%llu, %llu) with em [%llu, %llu) start %llu\n",
-                                         existing->start, existing->len,
-                                         orig_start, orig_len, start);
+                               btrfs_warn(fs_info,
+"extent map merge error existing [%llu, %llu) with em [%llu, %llu) start %llu",
+                                          existing->start, extent_map_end(existing),
+                                          orig_start, orig_start + orig_len, start);
                        }
                        free_extent_map(existing);
                }
index c4bd0e60db59253f280236740d23ed1c5b7b92f7..fa25004ab04e7b28d73dee024303c0dab4077db6 100644 (file)
@@ -2812,7 +2812,17 @@ static noinline_for_stack int scrub_supers(struct scrub_ctx *sctx,
                gen = btrfs_get_last_trans_committed(fs_info);
 
        for (i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++) {
-               bytenr = btrfs_sb_offset(i);
+               ret = btrfs_sb_log_location(scrub_dev, i, 0, &bytenr);
+               if (ret == -ENOENT)
+                       break;
+
+               if (ret) {
+                       spin_lock(&sctx->stat_lock);
+                       sctx->stat.super_errors++;
+                       spin_unlock(&sctx->stat_lock);
+                       continue;
+               }
+
                if (bytenr + BTRFS_SUPER_INFO_SIZE >
                    scrub_dev->commit_total_bytes)
                        break;
index 1dc1f1946ae0eb3158a38b2d214746e7cc4a09ee..f15591f3e54fa4cd7e92103e17b0ae74eb1a54f9 100644 (file)
@@ -692,6 +692,16 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
        device->bdev = file_bdev(bdev_file);
        clear_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
 
+       if (device->devt != device->bdev->bd_dev) {
+               btrfs_warn(NULL,
+                          "device %s maj:min changed from %d:%d to %d:%d",
+                          device->name->str, MAJOR(device->devt),
+                          MINOR(device->devt), MAJOR(device->bdev->bd_dev),
+                          MINOR(device->bdev->bd_dev));
+
+               device->devt = device->bdev->bd_dev;
+       }
+
        fs_devices->open_devices++;
        if (test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state) &&
            device->devid != BTRFS_DEV_REPLACE_DEVID) {
@@ -1174,23 +1184,30 @@ static int open_fs_devices(struct btrfs_fs_devices *fs_devices,
        struct btrfs_device *device;
        struct btrfs_device *latest_dev = NULL;
        struct btrfs_device *tmp_device;
+       int ret = 0;
 
        list_for_each_entry_safe(device, tmp_device, &fs_devices->devices,
                                 dev_list) {
-               int ret;
+               int ret2;
 
-               ret = btrfs_open_one_device(fs_devices, device, flags, holder);
-               if (ret == 0 &&
+               ret2 = btrfs_open_one_device(fs_devices, device, flags, holder);
+               if (ret2 == 0 &&
                    (!latest_dev || device->generation > latest_dev->generation)) {
                        latest_dev = device;
-               } else if (ret == -ENODATA) {
+               } else if (ret2 == -ENODATA) {
                        fs_devices->num_devices--;
                        list_del(&device->dev_list);
                        btrfs_free_device(device);
                }
+               if (ret == 0 && ret2 != 0)
+                       ret = ret2;
        }
-       if (fs_devices->open_devices == 0)
+
+       if (fs_devices->open_devices == 0) {
+               if (ret)
+                       return ret;
                return -EINVAL;
+       }
 
        fs_devices->opened = 1;
        fs_devices->latest_dev = latest_dev;
index 5a3d5ec75c5a94262c2431fce61c84d1e95f7512..4cba80b34387c102a15299a69f1bd11fc0caff2f 100644 (file)
@@ -1574,11 +1574,7 @@ int btrfs_load_block_group_zone_info(struct btrfs_block_group *cache, bool new)
        if (!map)
                return -EINVAL;
 
-       cache->physical_map = btrfs_clone_chunk_map(map, GFP_NOFS);
-       if (!cache->physical_map) {
-               ret = -ENOMEM;
-               goto out;
-       }
+       cache->physical_map = map;
 
        zone_info = kcalloc(map->num_stripes, sizeof(*zone_info), GFP_NOFS);
        if (!zone_info) {
@@ -1690,7 +1686,6 @@ out:
        }
        bitmap_free(active);
        kfree(zone_info);
-       btrfs_free_chunk_map(map);
 
        return ret;
 }
@@ -2175,6 +2170,7 @@ static int do_zone_finish(struct btrfs_block_group *block_group, bool fully_writ
        struct btrfs_chunk_map *map;
        const bool is_metadata = (block_group->flags &
                        (BTRFS_BLOCK_GROUP_METADATA | BTRFS_BLOCK_GROUP_SYSTEM));
+       struct btrfs_dev_replace *dev_replace = &fs_info->dev_replace;
        int ret = 0;
        int i;
 
@@ -2250,6 +2246,7 @@ static int do_zone_finish(struct btrfs_block_group *block_group, bool fully_writ
        btrfs_clear_data_reloc_bg(block_group);
        spin_unlock(&block_group->lock);
 
+       down_read(&dev_replace->rwsem);
        map = block_group->physical_map;
        for (i = 0; i < map->num_stripes; i++) {
                struct btrfs_device *device = map->stripes[i].dev;
@@ -2266,13 +2263,16 @@ static int do_zone_finish(struct btrfs_block_group *block_group, bool fully_writ
                                       zinfo->zone_size >> SECTOR_SHIFT);
                memalloc_nofs_restore(nofs_flags);
 
-               if (ret)
+               if (ret) {
+                       up_read(&dev_replace->rwsem);
                        return ret;
+               }
 
                if (!(block_group->flags & BTRFS_BLOCK_GROUP_DATA))
                        zinfo->reserved_active_zones++;
                btrfs_dev_clear_active_zone(device, physical);
        }
+       up_read(&dev_replace->rwsem);
 
        if (!fully_written)
                btrfs_dec_block_group_ro(block_group);
index 69308fd73e4a92154b82759e750fddb3ac5adb33..c0eb139adb07a8ce852edd56370a79e5760036d9 100644 (file)
@@ -430,7 +430,6 @@ static bool erofs_fc_set_dax_mode(struct fs_context *fc, unsigned int mode)
 
        switch (mode) {
        case EROFS_MOUNT_DAX_ALWAYS:
-               warnfc(fc, "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
                set_opt(&ctx->opt, DAX_ALWAYS);
                clear_opt(&ctx->opt, DAX_NEVER);
                return true;
index ff6f26671cfc0207961267ee1b95155d0733e835..cf1df7f16e55cc7516236c724bd64f10affe9407 100644 (file)
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -895,6 +895,7 @@ int transfer_args_to_stack(struct linux_binprm *bprm,
                        goto out;
        }
 
+       bprm->exec += *sp_location - MAX_ARG_PAGES * PAGE_SIZE;
        *sp_location = sp;
 
 out:
index 789af5c8fade9d86354f86a6a7ffe696a9f5447d..aa1626955b2cf5b9bbedc0f8c118938dd97009b6 100644 (file)
@@ -1718,7 +1718,8 @@ static int punch_hole(struct gfs2_inode *ip, u64 offset, u64 length)
        struct buffer_head *dibh, *bh;
        struct gfs2_holder rd_gh;
        unsigned int bsize_shift = sdp->sd_sb.sb_bsize_shift;
-       u64 lblock = (offset + (1 << bsize_shift) - 1) >> bsize_shift;
+       unsigned int bsize = 1 << bsize_shift;
+       u64 lblock = (offset + bsize - 1) >> bsize_shift;
        __u16 start_list[GFS2_MAX_META_HEIGHT];
        __u16 __end_list[GFS2_MAX_META_HEIGHT], *end_list = NULL;
        unsigned int start_aligned, end_aligned;
@@ -1729,7 +1730,7 @@ static int punch_hole(struct gfs2_inode *ip, u64 offset, u64 length)
        u64 prev_bnr = 0;
        __be64 *start, *end;
 
-       if (offset >= maxsize) {
+       if (offset + bsize - 1 >= maxsize) {
                /*
                 * The starting point lies beyond the allocated metadata;
                 * there are no blocks to deallocate.
index 1a93c7fcf76c55ee2a34a99ec72f48b2c167c0f8..2391ab3c3231975bde1606875339b7736975054f 100644 (file)
@@ -3831,15 +3831,20 @@ nfsd4_create_session(struct svc_rqst *rqstp,
        else
                cs_slot = &unconf->cl_cs_slot;
        status = check_slot_seqid(cr_ses->seqid, cs_slot->sl_seqid, 0);
-       if (status) {
-               if (status == nfserr_replay_cache) {
-                       status = nfsd4_replay_create_session(cr_ses, cs_slot);
-                       goto out_free_conn;
-               }
+       switch (status) {
+       case nfs_ok:
+               cs_slot->sl_seqid++;
+               cr_ses->seqid = cs_slot->sl_seqid;
+               break;
+       case nfserr_replay_cache:
+               status = nfsd4_replay_create_session(cr_ses, cs_slot);
+               fallthrough;
+       case nfserr_jukebox:
+               /* The server MUST NOT cache NFS4ERR_DELAY */
+               goto out_free_conn;
+       default:
                goto out_cache_error;
        }
-       cs_slot->sl_seqid++;
-       cr_ses->seqid = cs_slot->sl_seqid;
 
        /* RFC 8881 Section 18.36.4 Phase 3: Client ID confirmation. */
        if (conf) {
@@ -3859,10 +3864,8 @@ nfsd4_create_session(struct svc_rqst *rqstp,
                old = find_confirmed_client_by_name(&unconf->cl_name, nn);
                if (old) {
                        status = mark_client_expired_locked(old);
-                       if (status) {
-                               old = NULL;
-                               goto out_cache_error;
-                       }
+                       if (status)
+                               goto out_expired_error;
                        trace_nfsd_clid_replaced(&old->cl_clientid);
                }
                move_to_confirmed(unconf);
@@ -3894,6 +3897,17 @@ nfsd4_create_session(struct svc_rqst *rqstp,
                expire_client(old);
        return status;
 
+out_expired_error:
+       old = NULL;
+       /*
+        * Revert the slot seq_nr change so the server will process
+        * the client's resend instead of returning a cached response.
+        */
+       if (status == nfserr_jukebox) {
+               cs_slot->sl_seqid--;
+               cr_ses->seqid = cs_slot->sl_seqid;
+               goto out_free_conn;
+       }
 out_cache_error:
        nfsd4_cache_create_session(cr_ses, cs_slot, status);
 out_free_conn:
index 6a9464262fae6bea461c4764ce98c53ca20f9754..2e41eb4c3cec76f00227f5f689bda39430a90b04 100644 (file)
@@ -1852,7 +1852,7 @@ retry:
        trap = lock_rename(tdentry, fdentry);
        if (IS_ERR(trap)) {
                err = (rqstp->rq_vers == 2) ? nfserr_acces : nfserr_xdev;
-               goto out;
+               goto out_want_write;
        }
        err = fh_fill_pre_attrs(ffhp);
        if (err != nfs_ok)
@@ -1922,6 +1922,7 @@ retry:
        }
 out_unlock:
        unlock_rename(tdentry, fdentry);
+out_want_write:
        fh_drop_write(ffhp);
 
        /*
index bd08616ed8bad7937173183eb08634c9526a4e90..7b4db9c56e6a77d3f0abd4a4e687542a734bb8d7 100644 (file)
@@ -5,7 +5,7 @@
 
 obj-y   += proc.o
 
-CFLAGS_task_mmu.o      += $(call cc-option,-Wno-override-init,)
+CFLAGS_task_mmu.o      += -Wno-override-init
 proc-y                 := nommu.o task_nommu.o
 proc-$(CONFIG_MMU)     := task_mmu.o
 
index 89333d9bce36eb85d952a387a499c566e1041f72..d11dc3aa458ba2d545c5a80786230b54cb62166b 100644 (file)
@@ -612,11 +612,18 @@ int cifs_mknod(struct mnt_idmap *idmap, struct inode *inode,
                goto mknod_out;
        }
 
+       trace_smb3_mknod_enter(xid, tcon->ses->Suid, tcon->tid, full_path);
+
        rc = tcon->ses->server->ops->make_node(xid, inode, direntry, tcon,
                                               full_path, mode,
                                               device_number);
 
 mknod_out:
+       if (rc)
+               trace_smb3_mknod_err(xid,  tcon->ses->Suid, tcon->tid, rc);
+       else
+               trace_smb3_mknod_done(xid, tcon->ses->Suid, tcon->tid);
+
        free_dentry_path(page);
        free_xid(xid);
        cifs_put_tlink(tlink);
index c4a3cb736881ae73fe2e002fcb2f5cadbe6cd731..340efce8f052951a308329b70b5846d9e57477f5 100644 (file)
 #include "cifs_fs_sb.h"
 #include "cifsproto.h"
 
+/*
+ * Key for fscache inode.  [!] Contents must match comparisons in cifs_find_inode().
+ */
+struct cifs_fscache_inode_key {
+
+       __le64  uniqueid;       /* server inode number */
+       __le64  createtime;     /* creation time on server */
+       u8      type;           /* S_IFMT file type */
+} __packed;
+
 static void cifs_fscache_fill_volume_coherency(
        struct cifs_tcon *tcon,
        struct cifs_fscache_volume_coherency_data *cd)
@@ -97,15 +107,19 @@ void cifs_fscache_release_super_cookie(struct cifs_tcon *tcon)
 void cifs_fscache_get_inode_cookie(struct inode *inode)
 {
        struct cifs_fscache_inode_coherency_data cd;
+       struct cifs_fscache_inode_key key;
        struct cifsInodeInfo *cifsi = CIFS_I(inode);
        struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
        struct cifs_tcon *tcon = cifs_sb_master_tcon(cifs_sb);
 
+       key.uniqueid    = cpu_to_le64(cifsi->uniqueid);
+       key.createtime  = cpu_to_le64(cifsi->createtime);
+       key.type        = (inode->i_mode & S_IFMT) >> 12;
        cifs_fscache_fill_coherency(&cifsi->netfs.inode, &cd);
 
        cifsi->netfs.cache =
                fscache_acquire_cookie(tcon->fscache, 0,
-                                      &cifsi->uniqueid, sizeof(cifsi->uniqueid),
+                                      &key, sizeof(key),
                                       &cd, sizeof(cd),
                                       i_size_read(&cifsi->netfs.inode));
        if (cifsi->netfs.cache)
index d28ab0af60493623f3d209c4f36b5ccea14973bb..91b07ef9e25ca1c195bef21d06c92f5193633022 100644 (file)
@@ -1351,6 +1351,8 @@ cifs_find_inode(struct inode *inode, void *opaque)
 {
        struct cifs_fattr *fattr = opaque;
 
+       /* [!] The compared values must be the same in struct cifs_fscache_inode_key. */
+
        /* don't match inode with different uniqueid */
        if (CIFS_I(inode)->uniqueid != fattr->cf_uniqueid)
                return 0;
index f9c1fd32d0b8c3d5cc34ad11895a8c302039cf73..5e83cb9da9028e0d15383e6e19413ea1da31e553 100644 (file)
@@ -375,6 +375,7 @@ DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(get_reparse_compound_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(delete_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(mkdir_enter);
 DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(tdis_enter);
+DEFINE_SMB3_INF_COMPOUND_ENTER_EVENT(mknod_enter);
 
 DECLARE_EVENT_CLASS(smb3_inf_compound_done_class,
        TP_PROTO(unsigned int xid,
@@ -415,7 +416,7 @@ DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(query_wsl_ea_compound_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(delete_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(mkdir_done);
 DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(tdis_done);
-
+DEFINE_SMB3_INF_COMPOUND_DONE_EVENT(mknod_done);
 
 DECLARE_EVENT_CLASS(smb3_inf_compound_err_class,
        TP_PROTO(unsigned int xid,
@@ -461,6 +462,7 @@ DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(query_wsl_ea_compound_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(mkdir_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(delete_err);
 DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(tdis_err);
+DEFINE_SMB3_INF_COMPOUND_ERR_EVENT(mknod_err);
 
 /*
  * For logging SMB3 Status code and Command for responses which return errors
index d991eec05436835d4ae2423c4bdf0053044dec88..73a4b895de6704252fc4efbb00b68c3440d3cd4b 100644 (file)
@@ -530,7 +530,8 @@ xfs_validate_sb_common(
        }
 
        if (!xfs_validate_stripe_geometry(mp, XFS_FSB_TO_B(mp, sbp->sb_unit),
-                       XFS_FSB_TO_B(mp, sbp->sb_width), 0, false))
+                       XFS_FSB_TO_B(mp, sbp->sb_width), 0,
+                       xfs_buf_daddr(bp) == XFS_SB_DADDR, false))
                return -EFSCORRUPTED;
 
        /*
@@ -1323,8 +1324,10 @@ xfs_sb_get_secondary(
 }
 
 /*
- * sunit, swidth, sectorsize(optional with 0) should be all in bytes,
- * so users won't be confused by values in error messages.
+ * sunit, swidth, sectorsize(optional with 0) should be all in bytes, so users
+ * won't be confused by values in error messages.  This function returns false
+ * if the stripe geometry is invalid and the caller is unable to repair the
+ * stripe configuration later in the mount process.
  */
 bool
 xfs_validate_stripe_geometry(
@@ -1332,20 +1335,21 @@ xfs_validate_stripe_geometry(
        __s64                   sunit,
        __s64                   swidth,
        int                     sectorsize,
+       bool                    may_repair,
        bool                    silent)
 {
        if (swidth > INT_MAX) {
                if (!silent)
                        xfs_notice(mp,
 "stripe width (%lld) is too large", swidth);
-               return false;
+               goto check_override;
        }
 
        if (sunit > swidth) {
                if (!silent)
                        xfs_notice(mp,
 "stripe unit (%lld) is larger than the stripe width (%lld)", sunit, swidth);
-               return false;
+               goto check_override;
        }
 
        if (sectorsize && (int)sunit % sectorsize) {
@@ -1353,21 +1357,21 @@ xfs_validate_stripe_geometry(
                        xfs_notice(mp,
 "stripe unit (%lld) must be a multiple of the sector size (%d)",
                                   sunit, sectorsize);
-               return false;
+               goto check_override;
        }
 
        if (sunit && !swidth) {
                if (!silent)
                        xfs_notice(mp,
 "invalid stripe unit (%lld) and stripe width of 0", sunit);
-               return false;
+               goto check_override;
        }
 
        if (!sunit && swidth) {
                if (!silent)
                        xfs_notice(mp,
 "invalid stripe width (%lld) and stripe unit of 0", swidth);
-               return false;
+               goto check_override;
        }
 
        if (sunit && (int)swidth % (int)sunit) {
@@ -1375,9 +1379,27 @@ xfs_validate_stripe_geometry(
                        xfs_notice(mp,
 "stripe width (%lld) must be a multiple of the stripe unit (%lld)",
                                   swidth, sunit);
-               return false;
+               goto check_override;
        }
        return true;
+
+check_override:
+       if (!may_repair)
+               return false;
+       /*
+        * During mount, mp->m_dalign will not be set unless the sunit mount
+        * option was set. If it was set, ignore the bad stripe alignment values
+        * and allow the validation and overwrite later in the mount process to
+        * attempt to overwrite the bad stripe alignment values with the values
+        * supplied by mount options.
+        */
+       if (!mp->m_dalign)
+               return false;
+       if (!silent)
+               xfs_notice(mp,
+"Will try to correct with specified mount options sunit (%d) and swidth (%d)",
+                       BBTOB(mp->m_dalign), BBTOB(mp->m_swidth));
+       return true;
 }
 
 /*
index 2e8e8d63d4eb2249d148b8f6d50f2a71726911f5..37b1ed1bc2095e42561764196a932cb11fb4d7f7 100644 (file)
@@ -35,8 +35,9 @@ extern int    xfs_sb_get_secondary(struct xfs_mount *mp,
                                struct xfs_trans *tp, xfs_agnumber_t agno,
                                struct xfs_buf **bpp);
 
-extern bool    xfs_validate_stripe_geometry(struct xfs_mount *mp,
-               __s64 sunit, __s64 swidth, int sectorsize, bool silent);
+bool   xfs_validate_stripe_geometry(struct xfs_mount *mp,
+               __s64 sunit, __s64 swidth, int sectorsize, bool may_repair,
+               bool silent);
 
 uint8_t xfs_compute_rextslog(xfs_rtbxlen_t rtextents);
 
index abff79a77c72b632649f40efdba51e3fcd3498de..47a20cf5205f00f9f99cb77c78fe36bcd6db6407 100644 (file)
@@ -1044,9 +1044,7 @@ xchk_irele(
        struct xfs_scrub        *sc,
        struct xfs_inode        *ip)
 {
-       if (current->journal_info != NULL) {
-               ASSERT(current->journal_info == sc->tp);
-
+       if (sc->tp) {
                /*
                 * If we are in a transaction, we /cannot/ drop the inode
                 * ourselves, because the VFS will trigger writeback, which
index 1698507d1ac73a0a4985322e00c52e61539d5317..3f428620ebf2a395d8efdcb3094f8c940cdc3310 100644 (file)
@@ -503,13 +503,6 @@ xfs_vm_writepages(
 {
        struct xfs_writepage_ctx wpc = { };
 
-       /*
-        * Writing back data in a transaction context can result in recursive
-        * transactions. This is bad, so issue a warning and get out of here.
-        */
-       if (WARN_ON_ONCE(current->journal_info))
-               return 0;
-
        xfs_iflags_clear(XFS_I(mapping->host), XFS_ITRUNCATED);
        return iomap_writepages(mapping, wbc, &wpc.ctx, &xfs_writeback_ops);
 }
index e64265bc0b3371244c25b84424b0a486fc6b0202..74f1812b03cbd2e94da4992296da5280e8d22701 100644 (file)
@@ -2039,8 +2039,10 @@ xfs_inodegc_want_queue_work(
  *  - Memory shrinkers queued the inactivation worker and it hasn't finished.
  *  - The queue depth exceeds the maximum allowable percpu backlog.
  *
- * Note: If the current thread is running a transaction, we don't ever want to
- * wait for other transactions because that could introduce a deadlock.
+ * Note: If we are in a NOFS context here (e.g. current thread is running a
+ * transaction) the we don't want to block here as inodegc progress may require
+ * filesystem resources we hold to make progress and that could result in a
+ * deadlock. Hence we skip out of here if we are in a scoped NOFS context.
  */
 static inline bool
 xfs_inodegc_want_flush_work(
@@ -2048,7 +2050,7 @@ xfs_inodegc_want_flush_work(
        unsigned int            items,
        unsigned int            shrinker_hits)
 {
-       if (current->journal_info)
+       if (current->flags & PF_MEMALLOC_NOFS)
                return false;
 
        if (shrinker_hits > 0)
index 3f7e3a09a49ff402c8ac7996921f2bd46af01d59..1636663707dc04dd1eb9ab4f5dc3ce37ddfba974 100644 (file)
@@ -268,19 +268,14 @@ static inline void
 xfs_trans_set_context(
        struct xfs_trans        *tp)
 {
-       ASSERT(current->journal_info == NULL);
        tp->t_pflags = memalloc_nofs_save();
-       current->journal_info = tp;
 }
 
 static inline void
 xfs_trans_clear_context(
        struct xfs_trans        *tp)
 {
-       if (current->journal_info == tp) {
-               memalloc_nofs_restore(tp->t_pflags);
-               current->journal_info = NULL;
-       }
+       memalloc_nofs_restore(tp->t_pflags);
 }
 
 static inline void
@@ -288,10 +283,8 @@ xfs_trans_switch_context(
        struct xfs_trans        *old_tp,
        struct xfs_trans        *new_tp)
 {
-       ASSERT(current->journal_info == old_tp);
        new_tp->t_pflags = old_tp->t_pflags;
        old_tp->t_pflags = 0;
-       current->journal_info = new_tp;
 }
 
 #endif /* __XFS_TRANS_H__ */
diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
deleted file mode 100644 (file)
index 570cd4d..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef __ASM_GENERIC_EXPORT_H
-#define __ASM_GENERIC_EXPORT_H
-
-/*
- * <asm/export.h> and <asm-generic/export.h> are deprecated.
- * Please include <linux/export.h> directly.
- */
-#include <linux/export.h>
-
-#endif
index 9a9b88962c296fd2f45b7a7a7da760973991cf15..2b85fe9e7f9a76332f100832a72d4be99adbcdf6 100644 (file)
@@ -181,12 +181,12 @@ static inline int framer_notifier_unregister(struct framer *framer,
        return -ENOSYS;
 }
 
-struct framer *framer_get(struct device *dev, const char *con_id)
+static inline struct framer *framer_get(struct device *dev, const char *con_id)
 {
        return ERR_PTR(-ENOSYS);
 }
 
-void framer_put(struct device *dev, struct framer *framer)
+static inline void framer_put(struct device *dev, struct framer *framer)
 {
 }
 
index 7ecc25c543cef36b24425b479492dc366a7003da..56ac7e7a288903fd39c2567f98ff2987ba022b18 100644 (file)
@@ -74,6 +74,12 @@ static inline bool gpio_is_valid(int number)
  * Until they are all fixed, leave 0-512 space for them.
  */
 #define GPIO_DYNAMIC_BASE      512
+/*
+ * Define the maximum of the possible GPIO in the global numberspace.
+ * While the GPIO base and numbers are positive, we limit it with signed
+ * maximum as a lot of code is using negative values for special cases.
+ */
+#define GPIO_DYNAMIC_MAX       INT_MAX
 
 /* Always use the library code for GPIO management calls,
  * or when sleeping may be involved.
@@ -114,8 +120,6 @@ static inline int gpio_to_irq(unsigned gpio)
 }
 
 int gpio_request_one(unsigned gpio, unsigned long flags, const char *label);
-int gpio_request_array(const struct gpio *array, size_t num);
-void gpio_free_array(const struct gpio *array, size_t num);
 
 /* CONFIG_GPIOLIB: bindings for managed devices that want to request gpios */
 
@@ -146,11 +150,6 @@ static inline int gpio_request_one(unsigned gpio,
        return -ENOSYS;
 }
 
-static inline int gpio_request_array(const struct gpio *array, size_t num)
-{
-       return -ENOSYS;
-}
-
 static inline void gpio_free(unsigned gpio)
 {
        might_sleep();
@@ -159,14 +158,6 @@ static inline void gpio_free(unsigned gpio)
        WARN_ON(1);
 }
 
-static inline void gpio_free_array(const struct gpio *array, size_t num)
-{
-       might_sleep();
-
-       /* GPIO can never have been requested */
-       WARN_ON(1);
-}
-
 static inline int gpio_direction_input(unsigned gpio)
 {
        return -ENOSYS;
index dc75f802e2847646004b5528a63ade12858a0efa..f8617eaf08bad7d1c04aaba0a0dbe535909ce759 100644 (file)
@@ -646,8 +646,6 @@ int devm_gpiochip_add_data_with_key(struct device *dev, struct gpio_chip *gc,
 struct gpio_device *gpio_device_find(const void *data,
                                int (*match)(struct gpio_chip *gc,
                                             const void *data));
-struct gpio_device *gpio_device_find_by_label(const char *label);
-struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnode);
 
 struct gpio_device *gpio_device_get(struct gpio_device *gdev);
 void gpio_device_put(struct gpio_device *gdev);
@@ -814,6 +812,9 @@ struct gpio_device *gpiod_to_gpio_device(struct gpio_desc *desc);
 int gpio_device_get_base(struct gpio_device *gdev);
 const char *gpio_device_get_label(struct gpio_device *gdev);
 
+struct gpio_device *gpio_device_find_by_label(const char *label);
+struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnode);
+
 #else /* CONFIG_GPIOLIB */
 
 #include <asm/bug.h>
@@ -843,6 +844,18 @@ static inline const char *gpio_device_get_label(struct gpio_device *gdev)
        return NULL;
 }
 
+static inline struct gpio_device *gpio_device_find_by_label(const char *label)
+{
+       WARN_ON(1);
+       return NULL;
+}
+
+static inline struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnode)
+{
+       WARN_ON(1);
+       return NULL;
+}
+
 static inline int gpiochip_lock_as_irq(struct gpio_chip *gc,
                                       unsigned int offset)
 {
index 76121c2bb4f824ba793f3ed442060add0e2ee6d7..5c9bdd3ffccc89254fcc31c1b1f34d81f8374234 100644 (file)
@@ -67,6 +67,8 @@
  *                later.
  * IRQF_NO_DEBUG - Exclude from runnaway detection for IPI and similar handlers,
  *                depends on IRQF_PERCPU.
+ * IRQF_COND_ONESHOT - Agree to do IRQF_ONESHOT if already set for a shared
+ *                 interrupt.
  */
 #define IRQF_SHARED            0x00000080
 #define IRQF_PROBE_SHARED      0x00000100
@@ -82,6 +84,7 @@
 #define IRQF_COND_SUSPEND      0x00040000
 #define IRQF_NO_AUTOEN         0x00080000
 #define IRQF_NO_DEBUG          0x00100000
+#define IRQF_COND_ONESHOT      0x00200000
 
 #define IRQF_TIMER             (__IRQF_TIMER | IRQF_NO_SUSPEND | IRQF_NO_THREAD)
 
index 26d68115afb826b65a9fd11ce329635161e39cca..324d792e7c7864c662b5f1af6cdedfa8a143c60f 100644 (file)
@@ -107,6 +107,7 @@ enum {
 
        ATA_DFLAG_NCQ_PRIO_ENABLED = (1 << 20), /* Priority cmds sent to dev */
        ATA_DFLAG_CDL_ENABLED   = (1 << 21), /* cmd duration limits is enabled */
+       ATA_DFLAG_RESUMING      = (1 << 22),  /* Device is resuming */
        ATA_DFLAG_DETACH        = (1 << 24),
        ATA_DFLAG_DETACHED      = (1 << 25),
        ATA_DFLAG_DA            = (1 << 26), /* device supports Device Attention */
index dc7048824be81d628ca12f0874c1a7508da0d5c1..bcb201ab7a412e02254f98e51d830cfef1c31c06 100644 (file)
@@ -162,6 +162,14 @@ calc_vm_flag_bits(unsigned long flags)
 
 unsigned long vm_commit_limit(void);
 
+#ifndef arch_memory_deny_write_exec_supported
+static inline bool arch_memory_deny_write_exec_supported(void)
+{
+       return true;
+}
+#define arch_memory_deny_write_exec_supported arch_memory_deny_write_exec_supported
+#endif
+
 /*
  * Denies creating a writable executable mapping or gaining executable permissions.
  *
index 3921fbed0b28685cccfa0251e5b2d1cd4785324c..51421fdbb0bad449e28d27d6b6238aac4b03690e 100644 (file)
  *       build_OID_registry.pl to generate the data for look_up_OID().
  */
 enum OID {
+       OID_id_dsa_with_sha1,           /* 1.2.840.10030.4.3 */
        OID_id_dsa,                     /* 1.2.840.10040.4.1 */
        OID_id_ecPublicKey,             /* 1.2.840.10045.2.1 */
        OID_id_prime192v1,              /* 1.2.840.10045.3.1.1 */
        OID_id_prime256v1,              /* 1.2.840.10045.3.1.7 */
+       OID_id_ecdsa_with_sha1,         /* 1.2.840.10045.4.1 */
        OID_id_ecdsa_with_sha224,       /* 1.2.840.10045.4.3.1 */
        OID_id_ecdsa_with_sha256,       /* 1.2.840.10045.4.3.2 */
        OID_id_ecdsa_with_sha384,       /* 1.2.840.10045.4.3.3 */
@@ -28,6 +30,7 @@ enum OID {
 
        /* PKCS#1 {iso(1) member-body(2) us(840) rsadsi(113549) pkcs(1) pkcs-1(1)} */
        OID_rsaEncryption,              /* 1.2.840.113549.1.1.1 */
+       OID_sha1WithRSAEncryption,      /* 1.2.840.113549.1.1.5 */
        OID_sha256WithRSAEncryption,    /* 1.2.840.113549.1.1.11 */
        OID_sha384WithRSAEncryption,    /* 1.2.840.113549.1.1.12 */
        OID_sha512WithRSAEncryption,    /* 1.2.840.113549.1.1.13 */
@@ -64,6 +67,7 @@ enum OID {
        OID_PKU2U,                      /* 1.3.5.1.5.2.7 */
        OID_Scram,                      /* 1.3.6.1.5.5.14 */
        OID_certAuthInfoAccess,         /* 1.3.6.1.5.5.7.1.1 */
+       OID_sha1,                       /* 1.3.14.3.2.26 */
        OID_id_ansip384r1,              /* 1.3.132.0.34 */
        OID_sha256,                     /* 2.16.840.1.101.3.4.2.1 */
        OID_sha384,                     /* 2.16.840.1.101.3.4.2.2 */
index fcc06c300a72c3797751279dbeaec17b1e3f65aa..5d3a0cccc6bf8dbe0a1fcd294cf3f39d9955259c 100644 (file)
@@ -11,8 +11,8 @@
 
 #include <linux/types.h>
 
-/* 15 pointers + header align the folio_batch structure to a power of two */
-#define PAGEVEC_SIZE   15
+/* 31 pointers + header align the folio_batch structure to a power of two */
+#define PAGEVEC_SIZE   31
 
 struct folio;
 
index 0c7c67b3a87b2351a3a65408c6d00b6eadf583bb..9d24aec064e888316b5a5cf450cf25ffdd391183 100644 (file)
@@ -753,8 +753,6 @@ typedef unsigned char *sk_buff_data_t;
  *     @list: queue head
  *     @ll_node: anchor in an llist (eg socket defer_list)
  *     @sk: Socket we are owned by
- *     @ip_defrag_offset: (aka @sk) alternate use of @sk, used in
- *             fragmentation management
  *     @dev: Device we arrived on/are leaving by
  *     @dev_scratch: (aka @dev) alternate use of @dev when @dev would be %NULL
  *     @cb: Control buffer. Free for use by every layer. Put private vars here
@@ -875,10 +873,7 @@ struct sk_buff {
                struct llist_node       ll_node;
        };
 
-       union {
-               struct sock             *sk;
-               int                     ip_defrag_offset;
-       };
+       struct sock             *sk;
 
        union {
                ktime_t         tstamp;
index 2e2be4fd2bb6531dfd8965c8706a2cb33ff0e888..1e09329acc426873861d0bf5755dbba462a56b65 100644 (file)
@@ -4991,6 +4991,7 @@ struct cfg80211_ops {
  *     set this flag to update channels on beacon hints.
  * @WIPHY_FLAG_SUPPORTS_NSTR_NONPRIMARY: support connection to non-primary link
  *     of an NSTR mobile AP MLD.
+ * @WIPHY_FLAG_DISABLE_WEXT: disable wireless extensions for this device
  */
 enum wiphy_flags {
        WIPHY_FLAG_SUPPORTS_EXT_KEK_KCK         = BIT(0),
@@ -5002,6 +5003,7 @@ enum wiphy_flags {
        WIPHY_FLAG_4ADDR_STATION                = BIT(6),
        WIPHY_FLAG_CONTROL_PORT_PROTOCOL        = BIT(7),
        WIPHY_FLAG_IBSS_RSN                     = BIT(8),
+       WIPHY_FLAG_DISABLE_WEXT                 = BIT(9),
        WIPHY_FLAG_MESH_AUTH                    = BIT(10),
        WIPHY_FLAG_SUPPORTS_EXT_KCK_32          = BIT(11),
        WIPHY_FLAG_SUPPORTS_NSTR_NONPRIMARY     = BIT(12),
index 9ab4bf704e864358215d2370d33d3d9668681923..ccf171f7eb60d462e0ebf49c9e876016e963ffa5 100644 (file)
@@ -175,6 +175,7 @@ void inet_csk_init_xmit_timers(struct sock *sk,
                               void (*delack_handler)(struct timer_list *),
                               void (*keepalive_handler)(struct timer_list *));
 void inet_csk_clear_xmit_timers(struct sock *sk);
+void inet_csk_clear_xmit_timers_sync(struct sock *sk);
 
 static inline void inet_csk_schedule_ack(struct sock *sk)
 {
index b5e00702acc1f037df7eb8ad085d00e0b18079a8..f57bfd8a2ad2deaedf3f351325ab9336ae040504 100644 (file)
@@ -1759,6 +1759,13 @@ static inline void sock_owned_by_me(const struct sock *sk)
 #endif
 }
 
+static inline void sock_not_owned_by_me(const struct sock *sk)
+{
+#ifdef CONFIG_LOCKDEP
+       WARN_ON_ONCE(lockdep_sock_is_held(sk) && debug_locks);
+#endif
+}
+
 static inline bool sock_owned_by_user(const struct sock *sk)
 {
        sock_owned_by_me(sk);
index 3cb4dc9bd70e44bcce5f9cb3119de61e933967ab..3d54de168a6d9d57d1f7001c648fbc25af10965a 100644 (file)
@@ -188,6 +188,8 @@ static inline void xsk_tx_metadata_complete(struct xsk_tx_metadata_compl *compl,
 {
        if (!compl)
                return;
+       if (!compl->tx_timestamp)
+               return;
 
        *compl->tx_timestamp = ops->tmo_fill_timestamp(priv);
 }
index 4ce1988b2ba01c6a92a09f998346ea4c0ea29b19..f40915d2eceef44b46bb209270a878906255c998 100644 (file)
@@ -12,6 +12,7 @@ struct request;
 struct scsi_driver {
        struct device_driver    gendrv;
 
+       int (*resume)(struct device *);
        void (*rescan)(struct device *);
        blk_status_t (*init_command)(struct scsi_cmnd *);
        void (*uninit_command)(struct scsi_cmnd *);
index b259d42a1e1affd9d82be3975782b1b526e97437..129001f600fc956685745c61ee9156a524cf6065 100644 (file)
@@ -767,6 +767,7 @@ scsi_template_proc_dir(const struct scsi_host_template *sht);
 #define scsi_template_proc_dir(sht) NULL
 #endif
 extern void scsi_scan_host(struct Scsi_Host *);
+extern int scsi_resume_device(struct scsi_device *sdev);
 extern int scsi_rescan_device(struct scsi_device *sdev);
 extern void scsi_remove_host(struct Scsi_Host *);
 extern struct Scsi_Host *scsi_host_get(struct Scsi_Host *);
index 53470d6a28d659db09e9e58e85e24ffe5e862db5..24dbe16684ae3349bae5a7f74ac5c80fd16e6211 100644 (file)
@@ -143,6 +143,9 @@ intel_nhlt_get_endpoint_blob(struct device *dev, struct nhlt_acpi_table *nhlt,
                             u32 bus_id, u8 link_type, u8 vbps, u8 bps,
                             u8 num_ch, u32 rate, u8 dir, u8 dev_type);
 
+int intel_nhlt_ssp_device_type(struct device *dev, struct nhlt_acpi_table *nhlt,
+                              u8 virtual_bus_id);
+
 #else
 
 static inline struct nhlt_acpi_table *intel_nhlt_init(struct device *dev)
@@ -184,6 +187,13 @@ intel_nhlt_get_endpoint_blob(struct device *dev, struct nhlt_acpi_table *nhlt,
        return NULL;
 }
 
+static inline int intel_nhlt_ssp_device_type(struct device *dev,
+                                            struct nhlt_acpi_table *nhlt,
+                                            u8 virtual_bus_id)
+{
+       return -EINVAL;
+}
+
 #endif
 
 #endif
index 9ce46edc62a5b1ac5558b3009f7867643d822a2c..2040a470ddb41bfe9af0fe2abd4c5b53c4a6687c 100644 (file)
@@ -913,14 +913,25 @@ enum kfd_dbg_trap_exception_code {
                                 KFD_EC_MASK(EC_DEVICE_NEW))
 #define KFD_EC_MASK_PROCESS    (KFD_EC_MASK(EC_PROCESS_RUNTIME) |      \
                                 KFD_EC_MASK(EC_PROCESS_DEVICE_REMOVE))
+#define KFD_EC_MASK_PACKET     (KFD_EC_MASK(EC_QUEUE_PACKET_DISPATCH_DIM_INVALID) |    \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_DISPATCH_GROUP_SEGMENT_SIZE_INVALID) |     \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_DISPATCH_CODE_INVALID) |   \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_RESERVED) |        \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_UNSUPPORTED) |     \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_DISPATCH_WORK_GROUP_SIZE_INVALID) |        \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_DISPATCH_REGISTER_INVALID) |       \
+                                KFD_EC_MASK(EC_QUEUE_PACKET_VENDOR_UNSUPPORTED))
 
 /* Checks for exception code types for KFD search */
+#define KFD_DBG_EC_IS_VALID(ecode) (ecode > EC_NONE && ecode < EC_MAX)
 #define KFD_DBG_EC_TYPE_IS_QUEUE(ecode)                                        \
-                       (!!(KFD_EC_MASK(ecode) & KFD_EC_MASK_QUEUE))
+                       (KFD_DBG_EC_IS_VALID(ecode) && !!(KFD_EC_MASK(ecode) & KFD_EC_MASK_QUEUE))
 #define KFD_DBG_EC_TYPE_IS_DEVICE(ecode)                               \
-                       (!!(KFD_EC_MASK(ecode) & KFD_EC_MASK_DEVICE))
+                       (KFD_DBG_EC_IS_VALID(ecode) && !!(KFD_EC_MASK(ecode) & KFD_EC_MASK_DEVICE))
 #define KFD_DBG_EC_TYPE_IS_PROCESS(ecode)                              \
-                       (!!(KFD_EC_MASK(ecode) & KFD_EC_MASK_PROCESS))
+                       (KFD_DBG_EC_IS_VALID(ecode) && !!(KFD_EC_MASK(ecode) & KFD_EC_MASK_PROCESS))
+#define KFD_DBG_EC_TYPE_IS_PACKET(ecode)                               \
+                       (KFD_DBG_EC_IS_VALID(ecode) && !!(KFD_EC_MASK(ecode) & KFD_EC_MASK_PACKET))
 
 
 /* Runtime enable states */
index c72ce387286ad9506de5e93ec9147e46e85a7752..30a5c1a593764565212fc5fc2a1ec46ea2d3271a 100644 (file)
@@ -382,7 +382,7 @@ struct mpi3mr_bsg_in_reply_buf {
        __u8    mpi_reply_type;
        __u8    rsvd1;
        __u16   rsvd2;
-       __u8    reply_buf[1];
+       __u8    reply_buf[];
 };
 
 /**
index cb2afcebbdf5147c9f5f6c36f25f13084d3102a9..a35e12f8e68baa8b1baf45d5234dff62af91813e 100644 (file)
@@ -328,6 +328,7 @@ struct ufs_pwr_mode_info {
  * @op_runtime_config: called to config Operation and runtime regs Pointers
  * @get_outstanding_cqs: called to get outstanding completion queues
  * @config_esi: called to config Event Specific Interrupt
+ * @config_scsi_dev: called to configure SCSI device parameters
  */
 struct ufs_hba_variant_ops {
        const char *name;
index da79760b8be3a67378deb49a8ae8588bc19ddce0..3127e0bf7bbd15487ea6b50bd277801f6c01ae7e 100644 (file)
@@ -682,7 +682,7 @@ static void __init populate_initrd_image(char *err)
 
        printk(KERN_INFO "rootfs image is not initramfs (%s); looks like an initrd\n",
                        err);
-       file = filp_open("/initrd.image", O_WRONLY | O_CREAT, 0700);
+       file = filp_open("/initrd.image", O_WRONLY|O_CREAT|O_LARGEFILE, 0700);
        if (IS_ERR(file))
                return;
 
index 368c5d86b5b7c81da952e5fd5fe3bab06d9d748b..e497011261b897784db588160df007554552a60d 100644 (file)
@@ -4,7 +4,7 @@ ifneq ($(CONFIG_BPF_JIT_ALWAYS_ON),y)
 # ___bpf_prog_run() needs GCSE disabled on x86; see 3193c0836f203 for details
 cflags-nogcse-$(CONFIG_X86)$(CONFIG_CC_IS_GCC) := -fno-gcse
 endif
-CFLAGS_core.o += $(call cc-disable-warning, override-init) $(cflags-nogcse-yy)
+CFLAGS_core.o += -Wno-override-init $(cflags-nogcse-yy)
 
 obj-$(CONFIG_BPF_SYSCALL) += syscall.o verifier.o inode.o helpers.o tnum.o log.o token.o
 obj-$(CONFIG_BPF_SYSCALL) += bpf_iter.o map_iter.o task_iter.o prog_iter.o link_iter.o
index 86571e760dd613b6f7315e02b19069ece475645d..343c3456c8ddf0e6352a5f2614627c316078077a 100644 (file)
@@ -38,7 +38,7 @@
 
 /* number of bytes addressable by LDX/STX insn with 16-bit 'off' field */
 #define GUARD_SZ (1ull << sizeof(((struct bpf_insn *)0)->off) * 8)
-#define KERN_VM_SZ ((1ull << 32) + GUARD_SZ)
+#define KERN_VM_SZ (SZ_4G + GUARD_SZ)
 
 struct bpf_arena {
        struct bpf_map map;
@@ -110,7 +110,7 @@ static struct bpf_map *arena_map_alloc(union bpf_attr *attr)
                return ERR_PTR(-EINVAL);
 
        vm_range = (u64)attr->max_entries * PAGE_SIZE;
-       if (vm_range > (1ull << 32))
+       if (vm_range > SZ_4G)
                return ERR_PTR(-E2BIG);
 
        if ((attr->map_extra >> 32) != ((attr->map_extra + vm_range - 1) >> 32))
@@ -301,7 +301,7 @@ static unsigned long arena_get_unmapped_area(struct file *filp, unsigned long ad
 
        if (pgoff)
                return -EINVAL;
-       if (len > (1ull << 32))
+       if (len > SZ_4G)
                return -E2BIG;
 
        /* if user_vm_start was specified at arena creation time */
@@ -322,7 +322,7 @@ static unsigned long arena_get_unmapped_area(struct file *filp, unsigned long ad
        if (WARN_ON_ONCE(arena->user_vm_start))
                /* checks at map creation time should prevent this */
                return -EFAULT;
-       return round_up(ret, 1ull << 32);
+       return round_up(ret, SZ_4G);
 }
 
 static int arena_map_mmap(struct bpf_map *map, struct vm_area_struct *vma)
@@ -346,7 +346,7 @@ static int arena_map_mmap(struct bpf_map *map, struct vm_area_struct *vma)
                return -EBUSY;
 
        /* Earlier checks should prevent this */
-       if (WARN_ON_ONCE(vma->vm_end - vma->vm_start > (1ull << 32) || vma->vm_pgoff))
+       if (WARN_ON_ONCE(vma->vm_end - vma->vm_start > SZ_4G || vma->vm_pgoff))
                return -EFAULT;
 
        if (remember_vma(arena, vma))
@@ -420,7 +420,7 @@ static long arena_alloc_pages(struct bpf_arena *arena, long uaddr, long page_cnt
                if (uaddr & ~PAGE_MASK)
                        return 0;
                pgoff = compute_pgoff(arena, uaddr);
-               if (pgoff + page_cnt > page_cnt_max)
+               if (pgoff > page_cnt_max - page_cnt)
                        /* requested address will be outside of user VMA */
                        return 0;
        }
@@ -447,7 +447,13 @@ static long arena_alloc_pages(struct bpf_arena *arena, long uaddr, long page_cnt
                goto out;
 
        uaddr32 = (u32)(arena->user_vm_start + pgoff * PAGE_SIZE);
-       /* Earlier checks make sure that uaddr32 + page_cnt * PAGE_SIZE will not overflow 32-bit */
+       /* Earlier checks made sure that uaddr32 + page_cnt * PAGE_SIZE - 1
+        * will not overflow 32-bit. Lower 32-bit need to represent
+        * contiguous user address range.
+        * Map these pages at kern_vm_start base.
+        * kern_vm_start + uaddr32 + page_cnt * PAGE_SIZE - 1 can overflow
+        * lower 32-bit and it's ok.
+        */
        ret = vm_area_map_pages(arena->kern_vm, kern_vm_start + uaddr32,
                                kern_vm_start + uaddr32 + page_cnt * PAGE_SIZE, pages);
        if (ret) {
@@ -510,6 +516,11 @@ static void arena_free_pages(struct bpf_arena *arena, long uaddr, long page_cnt)
                if (!page)
                        continue;
                if (page_cnt == 1 && page_mapped(page)) /* mapped by some user process */
+                       /* Optimization for the common case of page_cnt==1:
+                        * If page wasn't mapped into some user vma there
+                        * is no need to call zap_pages which is slow. When
+                        * page_cnt is big it's faster to do the batched zap.
+                        */
                        zap_pages(arena, full_uaddr, 1);
                vm_area_unmap_pages(arena->kern_vm, kaddr, kaddr + PAGE_SIZE);
                __free_page(page);
index addf3dd57b59b574653a8ad3a374d6ef0f27b51b..35e1ddca74d21067bc158436470138f0b2ad984c 100644 (file)
@@ -80,6 +80,18 @@ static int bloom_map_get_next_key(struct bpf_map *map, void *key, void *next_key
        return -EOPNOTSUPP;
 }
 
+/* Called from syscall */
+static int bloom_map_alloc_check(union bpf_attr *attr)
+{
+       if (attr->value_size > KMALLOC_MAX_SIZE)
+               /* if value_size is bigger, the user space won't be able to
+                * access the elements.
+                */
+               return -E2BIG;
+
+       return 0;
+}
+
 static struct bpf_map *bloom_map_alloc(union bpf_attr *attr)
 {
        u32 bitset_bytes, bitset_mask, nr_hash_funcs, nr_bits;
@@ -191,6 +203,7 @@ static u64 bloom_map_mem_usage(const struct bpf_map *map)
 BTF_ID_LIST_SINGLE(bpf_bloom_map_btf_ids, struct, bpf_bloom_filter)
 const struct bpf_map_ops bloom_filter_map_ops = {
        .map_meta_equal = bpf_map_meta_equal,
+       .map_alloc_check = bloom_map_alloc_check,
        .map_alloc = bloom_map_alloc,
        .map_free = bloom_map_free,
        .map_get_next_key = bloom_map_get_next_key,
index a895878595710b41c4d80e5a1d74ba9bb4ee0b73..449b9a5d3fe3f3fd0a88e945e0039f850d5225b2 100644 (file)
@@ -2548,7 +2548,7 @@ __bpf_kfunc void bpf_throw(u64 cookie)
 __bpf_kfunc_end_defs();
 
 BTF_KFUNCS_START(generic_btf_ids)
-#ifdef CONFIG_KEXEC_CORE
+#ifdef CONFIG_CRASH_DUMP
 BTF_ID_FLAGS(func, crash_kexec, KF_DESTRUCTIVE)
 #endif
 BTF_ID_FLAGS(func, bpf_obj_new_impl, KF_ACQUIRE | KF_RET_NULL)
index 63749ad5ac6b8d63f108b92690897f032c7eacb6..353985b2b6a279f0d5a1784d753b10002cfb216e 100644 (file)
@@ -5682,6 +5682,13 @@ static bool is_flow_key_reg(struct bpf_verifier_env *env, int regno)
        return reg->type == PTR_TO_FLOW_KEYS;
 }
 
+static bool is_arena_reg(struct bpf_verifier_env *env, int regno)
+{
+       const struct bpf_reg_state *reg = reg_state(env, regno);
+
+       return reg->type == PTR_TO_ARENA;
+}
+
 static u32 *reg2btf_ids[__BPF_REG_TYPE_MAX] = {
 #ifdef CONFIG_NET
        [PTR_TO_SOCKET] = &btf_sock_ids[BTF_SOCK_TYPE_SOCK],
@@ -6694,6 +6701,11 @@ static int check_stack_access_within_bounds(
        err = check_stack_slot_within_bounds(env, min_off, state, type);
        if (!err && max_off > 0)
                err = -EINVAL; /* out of stack access into non-negative offsets */
+       if (!err && access_size < 0)
+               /* access_size should not be negative (or overflow an int); others checks
+                * along the way should have prevented such an access.
+                */
+               err = -EFAULT; /* invalid negative access size; integer overflow? */
 
        if (err) {
                if (tnum_is_const(reg->var_off)) {
@@ -7019,7 +7031,8 @@ static int check_atomic(struct bpf_verifier_env *env, int insn_idx, struct bpf_i
        if (is_ctx_reg(env, insn->dst_reg) ||
            is_pkt_reg(env, insn->dst_reg) ||
            is_flow_key_reg(env, insn->dst_reg) ||
-           is_sk_reg(env, insn->dst_reg)) {
+           is_sk_reg(env, insn->dst_reg) ||
+           is_arena_reg(env, insn->dst_reg)) {
                verbose(env, "BPF_ATOMIC stores into R%d %s is not allowed\n",
                        insn->dst_reg,
                        reg_type_str(env, reg_state(env, insn->dst_reg)->type));
@@ -14014,6 +14027,10 @@ static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
                                        verbose(env, "addr_space_cast insn can only convert between address space 1 and 0\n");
                                        return -EINVAL;
                                }
+                               if (!env->prog->aux->arena) {
+                                       verbose(env, "addr_space_cast insn can only be used in a program that has an associated arena\n");
+                                       return -EINVAL;
+                               }
                        } else {
                                if ((insn->off != 0 && insn->off != 8 && insn->off != 16 &&
                                     insn->off != 32) || insn->imm) {
@@ -14046,8 +14063,11 @@ static int check_alu_op(struct bpf_verifier_env *env, struct bpf_insn *insn)
                                if (insn->imm) {
                                        /* off == BPF_ADDR_SPACE_CAST */
                                        mark_reg_unknown(env, regs, insn->dst_reg);
-                                       if (insn->imm == 1) /* cast from as(1) to as(0) */
+                                       if (insn->imm == 1) /* cast from as(1) to as(0) */
                                                dst_reg->type = PTR_TO_ARENA;
+                                               /* PTR_TO_ARENA is 32-bit */
+                                               dst_reg->subreg_def = env->insn_idx + 1;
+                                       }
                                } else if (insn->off == 0) {
                                        /* case: R1 = R2
                                         * copy register state to dest reg
@@ -19601,8 +19621,9 @@ static int do_misc_fixups(struct bpf_verifier_env *env)
                            (((struct bpf_map *)env->prog->aux->arena)->map_flags & BPF_F_NO_USER_CONV)) {
                                /* convert to 32-bit mov that clears upper 32-bit */
                                insn->code = BPF_ALU | BPF_MOV | BPF_X;
-                               /* clear off, so it's a normal 'wX = wY' from JIT pov */
+                               /* clear off and imm, so it's a normal 'wX = wY' from JIT pov */
                                insn->off = 0;
+                               insn->imm = 0;
                        } /* cast from as(0) to as(1) should be handled by JIT */
                        goto next_insn;
                }
index bbb6c3cb00e4605eced285ccbb292dc726a74bdd..066668799f757286d46a97ae5fee451ef03f8c86 100644 (file)
@@ -366,7 +366,9 @@ static int __init reserve_crashkernel_low(unsigned long long low_size)
 
        crashk_low_res.start = low_base;
        crashk_low_res.end   = low_base + low_size - 1;
+#ifdef HAVE_ARCH_ADD_CRASH_RES_TO_IOMEM_EARLY
        insert_resource(&iomem_resource, &crashk_low_res);
+#endif
 #endif
        return 0;
 }
@@ -448,8 +450,12 @@ retry:
 
        crashk_res.start = crash_base;
        crashk_res.end = crash_base + crash_size - 1;
+#ifdef HAVE_ARCH_ADD_CRASH_RES_TO_IOMEM_EARLY
+       insert_resource(&iomem_resource, &crashk_res);
+#endif
 }
 
+#ifndef HAVE_ARCH_ADD_CRASH_RES_TO_IOMEM_EARLY
 static __init int insert_crashkernel_resources(void)
 {
        if (crashk_res.start < crashk_res.end)
@@ -462,3 +468,4 @@ static __init int insert_crashkernel_resources(void)
 }
 early_initcall(insert_crashkernel_resources);
 #endif
+#endif
index ad3eaf2ab959616104fb7192c3cb64e935ca43f3..bf9ae8a8686ff65fd3a9a9eb588bbc831bd2d824 100644 (file)
@@ -1643,8 +1643,13 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
                }
 
                if (!((old->flags & new->flags) & IRQF_SHARED) ||
-                   (oldtype != (new->flags & IRQF_TRIGGER_MASK)) ||
-                   ((old->flags ^ new->flags) & IRQF_ONESHOT))
+                   (oldtype != (new->flags & IRQF_TRIGGER_MASK)))
+                       goto mismatch;
+
+               if ((old->flags & IRQF_ONESHOT) &&
+                   (new->flags & IRQF_COND_ONESHOT))
+                       new->flags |= IRQF_ONESHOT;
+               else if ((old->flags ^ new->flags) & IRQF_ONESHOT)
                        goto mismatch;
 
                /* All handlers must agree on per-cpuness */
index c3ced519e14ba44b15df3d9a42ecb0102b8e3cf6..f3e0329337f61ccfbba7e7e44ddcb89678e3796c 100644 (file)
@@ -236,6 +236,10 @@ choice
          possible to load a signed module containing the algorithm to check
          the signature on that module.
 
+config MODULE_SIG_SHA1
+       bool "Sign modules with SHA-1"
+       select CRYPTO_SHA1
+
 config MODULE_SIG_SHA256
        bool "Sign modules with SHA-256"
        select CRYPTO_SHA256
@@ -265,6 +269,7 @@ endchoice
 config MODULE_SIG_HASH
        string
        depends on MODULE_SIG || IMA_APPRAISE_MODSIG
+       default "sha1" if MODULE_SIG_SHA1
        default "sha256" if MODULE_SIG_SHA256
        default "sha384" if MODULE_SIG_SHA384
        default "sha512" if MODULE_SIG_SHA512
index ca5146006b94c6742ac770323aaf123688d65572..adf99c05adcafc494a003294e0de525005271df6 100644 (file)
@@ -2009,6 +2009,12 @@ static int console_trylock_spinning(void)
         */
        mutex_acquire(&console_lock_dep_map, 0, 1, _THIS_IP_);
 
+       /*
+        * Update @console_may_schedule for trylock because the previous
+        * owner may have been schedulable.
+        */
+       console_may_schedule = 0;
+
        return 1;
 }
 
index f8e543f1e38a06dc3a4aa2f777c7e88d444e5565..8bb106a56b3a5f7b519598343bc0fd48e81cfbb7 100644 (file)
@@ -2408,8 +2408,11 @@ static inline int prctl_set_mdwe(unsigned long bits, unsigned long arg3,
        if (bits & PR_MDWE_NO_INHERIT && !(bits & PR_MDWE_REFUSE_EXEC_GAIN))
                return -EINVAL;
 
-       /* PARISC cannot allow mdwe as it needs writable stacks */
-       if (IS_ENABLED(CONFIG_PARISC))
+       /*
+        * EOPNOTSUPP might be more appropriate here in principle, but
+        * existing userspace depends on EINVAL specifically.
+        */
+       if (!arch_memory_deny_write_exec_supported())
                return -EINVAL;
 
        current_bits = get_current_mdwe();
index 9de66bbbb3d1555603ad169fad883af1c55b9d85..4782edcbe7b9b445e932897ce97d799d73762154 100644 (file)
@@ -129,15 +129,17 @@ static int posix_clock_open(struct inode *inode, struct file *fp)
                goto out;
        }
        pccontext->clk = clk;
-       fp->private_data = pccontext;
-       if (clk->ops.open)
+       if (clk->ops.open) {
                err = clk->ops.open(pccontext, fp->f_mode);
-       else
-               err = 0;
-
-       if (!err) {
-               get_device(clk->dev);
+               if (err) {
+                       kfree(pccontext);
+                       goto out;
+               }
        }
+
+       fp->private_data = pccontext;
+       get_device(clk->dev);
+       err = 0;
 out:
        up_read(&clk->rwsem);
        return err;
index 217169de0920ed93778ea93e7995a0863c097ef7..dfe3ee6035ecc74da70ebd8104d23f1ef2a25cde 100644 (file)
@@ -839,7 +839,7 @@ out:
 void store_trace_entry_data(void *edata, struct trace_probe *tp, struct pt_regs *regs)
 {
        struct probe_entry_arg *earg = tp->entry_arg;
-       unsigned long val;
+       unsigned long val = 0;
        int i;
 
        if (!earg)
index e4b5b75aaec9c1192e3a60e922d90f0704155615..4abb40b911ec43c60cce7971ea69de9917f2c277 100644 (file)
@@ -29,8 +29,7 @@ KCOV_INSTRUMENT_mmzone.o := n
 KCOV_INSTRUMENT_vmstat.o := n
 KCOV_INSTRUMENT_failslab.o := n
 
-CFLAGS_init-mm.o += $(call cc-disable-warning, override-init)
-CFLAGS_init-mm.o += $(call cc-disable-warning, initializer-overrides)
+CFLAGS_init-mm.o += -Wno-override-init
 
 mmu-y                  := nommu.o
 mmu-$(CONFIG_MMU)      := highmem.o memory.o mincore.o \
index 7437b2bd75c1ab48b093d390017e809af963f1e2..30de18c4fd28a907184695e3cf0f60079e956d89 100644 (file)
@@ -4197,7 +4197,23 @@ static void filemap_cachestat(struct address_space *mapping,
                                /* shmem file - in swap cache */
                                swp_entry_t swp = radix_to_swp_entry(folio);
 
+                               /* swapin error results in poisoned entry */
+                               if (non_swap_entry(swp))
+                                       goto resched;
+
+                               /*
+                                * Getting a swap entry from the shmem
+                                * inode means we beat
+                                * shmem_unuse(). rcu_read_lock()
+                                * ensures swapoff waits for us before
+                                * freeing the swapper space. However,
+                                * we can race with swapping and
+                                * invalidation, so there might not be
+                                * a shadow in the swapcache (yet).
+                                */
                                shadow = get_shadow_from_swap_cache(swp);
+                               if (!shadow)
+                                       goto resched;
                        }
 #endif
                        if (workingset_test_recent(shadow, true, &workingset))
index df83182ec72d5d77bb86b6571814a23fe244945a..af8edadc05d1b87200050bd34ff3d58ec52abd52 100644 (file)
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1653,20 +1653,22 @@ long populate_vma_page_range(struct vm_area_struct *vma,
        if (vma->vm_flags & VM_LOCKONFAULT)
                return nr_pages;
 
+       /* ... similarly, we've never faulted in PROT_NONE pages */
+       if (!vma_is_accessible(vma))
+               return -EFAULT;
+
        gup_flags = FOLL_TOUCH;
        /*
         * We want to touch writable mappings with a write fault in order
         * to break COW, except for shared mappings because these don't COW
         * and we would not want to dirty them for nothing.
+        *
+        * Otherwise, do a read fault, and use FOLL_FORCE in case it's not
+        * readable (ie write-only or executable).
         */
        if ((vma->vm_flags & (VM_WRITE | VM_SHARED)) == VM_WRITE)
                gup_flags |= FOLL_WRITE;
-
-       /*
-        * We want mlock to succeed for regions that have any permissions
-        * other than PROT_NONE.
-        */
-       if (vma_is_accessible(vma))
+       else
                gup_flags |= FOLL_FORCE;
 
        if (locked)
index f2bc6dd15eb830b9c8a0b6602746e2947a6997e6..904f70b994985a7682b59a917522f284fd786950 100644 (file)
@@ -1536,7 +1536,9 @@ static inline int zap_present_ptes(struct mmu_gather *tlb,
                ptep_get_and_clear_full(mm, addr, pte, tlb->fullmm);
                arch_check_zapped_pte(vma, ptent);
                tlb_remove_tlb_entry(tlb, pte, addr);
-               VM_WARN_ON_ONCE(userfaultfd_wp(vma));
+               if (userfaultfd_pte_wp(vma, ptent))
+                       zap_install_uffd_wp_if_needed(vma, addr, pte, 1,
+                                                     details, ptent);
                ksm_might_unmap_zero_page(mm, ptent);
                return 1;
        }
index e7139952ffd9dee593fd51fa88a9c69d8d830cd3..d17d1351ec84af6ae4f49dc34d4c27c56bf77468 100644 (file)
@@ -54,6 +54,22 @@ static depot_stack_handle_t early_handle;
 
 static void init_early_allocated_pages(void);
 
+static inline void set_current_in_page_owner(void)
+{
+       /*
+        * Avoid recursion.
+        *
+        * We might need to allocate more memory from page_owner code, so make
+        * sure to signal it in order to avoid recursion.
+        */
+       current->in_page_owner = 1;
+}
+
+static inline void unset_current_in_page_owner(void)
+{
+       current->in_page_owner = 0;
+}
+
 static int __init early_page_owner_param(char *buf)
 {
        int ret = kstrtobool(buf, &page_owner_enabled);
@@ -133,23 +149,16 @@ static noinline depot_stack_handle_t save_stack(gfp_t flags)
        depot_stack_handle_t handle;
        unsigned int nr_entries;
 
-       /*
-        * Avoid recursion.
-        *
-        * Sometimes page metadata allocation tracking requires more
-        * memory to be allocated:
-        * - when new stack trace is saved to stack depot
-        */
        if (current->in_page_owner)
                return dummy_handle;
-       current->in_page_owner = 1;
 
+       set_current_in_page_owner();
        nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 2);
        handle = stack_depot_save(entries, nr_entries, flags);
        if (!handle)
                handle = failure_handle;
+       unset_current_in_page_owner();
 
-       current->in_page_owner = 0;
        return handle;
 }
 
@@ -164,9 +173,13 @@ static void add_stack_record_to_list(struct stack_record *stack_record,
        gfp_mask &= (GFP_ATOMIC | GFP_KERNEL);
        gfp_mask |= __GFP_NOWARN;
 
+       set_current_in_page_owner();
        stack = kmalloc(sizeof(*stack), gfp_mask);
-       if (!stack)
+       if (!stack) {
+               unset_current_in_page_owner();
                return;
+       }
+       unset_current_in_page_owner();
 
        stack->stack_record = stack_record;
        stack->next = NULL;
index 062d1c1097ae35fdb9fc87faa722bb403c1804fd..ce514e700d2f65f4b23ae9d579b78790505cc540 100644 (file)
@@ -116,7 +116,7 @@ static int shmem_free_file_info(struct super_block *sb, int type)
 static int shmem_get_next_id(struct super_block *sb, struct kqid *qid)
 {
        struct mem_dqinfo *info = sb_dqinfo(sb, qid->type);
-       struct rb_node *node = ((struct rb_root *)info->dqi_priv)->rb_node;
+       struct rb_node *node;
        qid_t id = from_kqid(&init_user_ns, *qid);
        struct quota_info *dqopt = sb_dqopt(sb);
        struct quota_id *entry = NULL;
@@ -126,6 +126,7 @@ static int shmem_get_next_id(struct super_block *sb, struct kqid *qid)
                return -ESRCH;
 
        down_read(&dqopt->dqio_sem);
+       node = ((struct rb_root *)info->dqi_priv)->rb_node;
        while (node) {
                entry = rb_entry(node, struct quota_id, node);
 
@@ -165,7 +166,7 @@ out_unlock:
 static int shmem_acquire_dquot(struct dquot *dquot)
 {
        struct mem_dqinfo *info = sb_dqinfo(dquot->dq_sb, dquot->dq_id.type);
-       struct rb_node **n = &((struct rb_root *)info->dqi_priv)->rb_node;
+       struct rb_node **n;
        struct shmem_sb_info *sbinfo = dquot->dq_sb->s_fs_info;
        struct rb_node *parent = NULL, *new_node = NULL;
        struct quota_id *new_entry, *entry;
@@ -176,6 +177,8 @@ static int shmem_acquire_dquot(struct dquot *dquot)
        mutex_lock(&dquot->dq_lock);
 
        down_write(&dqopt->dqio_sem);
+       n = &((struct rb_root *)info->dqi_priv)->rb_node;
+
        while (*n) {
                parent = *n;
                entry = rb_entry(parent, struct quota_id, node);
@@ -264,7 +267,7 @@ static bool shmem_is_empty_dquot(struct dquot *dquot)
 static int shmem_release_dquot(struct dquot *dquot)
 {
        struct mem_dqinfo *info = sb_dqinfo(dquot->dq_sb, dquot->dq_id.type);
-       struct rb_node *node = ((struct rb_root *)info->dqi_priv)->rb_node;
+       struct rb_node *node;
        qid_t id = from_kqid(&init_user_ns, dquot->dq_id);
        struct quota_info *dqopt = sb_dqopt(dquot->dq_sb);
        struct quota_id *entry = NULL;
@@ -275,6 +278,7 @@ static int shmem_release_dquot(struct dquot *dquot)
                goto out_dqlock;
 
        down_write(&dqopt->dqio_sem);
+       node = ((struct rb_root *)info->dqi_priv)->rb_node;
        while (node) {
                entry = rb_entry(node, struct quota_id, node);
 
index 712160cd41ecac1a875ad4afb5b565dddc4bc2f2..3c3539c573e7fec47b2ac883e18d7644d40197c3 100644 (file)
@@ -1444,7 +1444,8 @@ static int uffd_move_lock(struct mm_struct *mm,
                 */
                down_read(&(*dst_vmap)->vm_lock->lock);
                if (*dst_vmap != *src_vmap)
-                       down_read(&(*src_vmap)->vm_lock->lock);
+                       down_read_nested(&(*src_vmap)->vm_lock->lock,
+                                        SINGLE_DEPTH_NESTING);
        }
        mmap_read_unlock(mm);
        return err;
index 9dec853647c8e4c6fc1d0a4b0de0849ea3102a47..caed028945b046cf4caa4c842abfc900ef0a45fb 100644 (file)
@@ -1080,7 +1080,17 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page)
        mutex_lock(&acomp_ctx->mutex);
 
        src = zpool_map_handle(zpool, entry->handle, ZPOOL_MM_RO);
-       if (acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) {
+       /*
+        * If zpool_map_handle is atomic, we cannot reliably utilize its mapped buffer
+        * to do crypto_acomp_decompress() which might sleep. In such cases, we must
+        * resort to copying the buffer to a temporary one.
+        * Meanwhile, zpool_map_handle() might return a non-linearly mapped buffer,
+        * such as a kmap address of high memory or even ever a vmap address.
+        * However, sg_init_one is only equipped to handle linearly mapped low memory.
+        * In such cases, we also must copy the buffer to a temporary and lowmem one.
+        */
+       if ((acomp_ctx->is_sleepable && !zpool_can_sleep_mapped(zpool)) ||
+           !virt_addr_valid(src)) {
                memcpy(acomp_ctx->buffer, src, entry->length);
                src = acomp_ctx->buffer;
                zpool_unmap_handle(zpool, entry->handle);
@@ -1094,7 +1104,7 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page)
        BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE);
        mutex_unlock(&acomp_ctx->mutex);
 
-       if (!acomp_ctx->is_sleepable || zpool_can_sleep_mapped(zpool))
+       if (src != acomp_ctx->buffer)
                zpool_unmap_handle(zpool, entry->handle);
 }
 
@@ -1313,6 +1323,14 @@ static unsigned long zswap_shrinker_count(struct shrinker *shrinker,
        if (!zswap_shrinker_enabled || !mem_cgroup_zswap_writeback_enabled(memcg))
                return 0;
 
+       /*
+        * The shrinker resumes swap writeback, which will enter block
+        * and may enter fs. XXX: Harmonize with vmscan.c __GFP_FS
+        * rules (may_enter_fs()), which apply on a per-folio basis.
+        */
+       if (!gfp_has_io_fs(sc->gfp_mask))
+               return 0;
+
 #ifdef CONFIG_MEMCG_KMEM
        mem_cgroup_flush_stats(memcg);
        nr_backing = memcg_page_state(memcg, MEMCG_ZSWAP_B) >> PAGE_SHIFT;
@@ -1618,6 +1636,7 @@ bool zswap_load(struct folio *folio)
        swp_entry_t swp = folio->swap;
        pgoff_t offset = swp_offset(swp);
        struct page *page = &folio->page;
+       bool swapcache = folio_test_swapcache(folio);
        struct zswap_tree *tree = swap_zswap_tree(swp);
        struct zswap_entry *entry;
        u8 *dst;
@@ -1630,7 +1649,20 @@ bool zswap_load(struct folio *folio)
                spin_unlock(&tree->lock);
                return false;
        }
-       zswap_rb_erase(&tree->rbroot, entry);
+       /*
+        * When reading into the swapcache, invalidate our entry. The
+        * swapcache can be the authoritative owner of the page and
+        * its mappings, and the pressure that results from having two
+        * in-memory copies outweighs any benefits of caching the
+        * compression work.
+        *
+        * (Most swapins go through the swapcache. The notable
+        * exception is the singleton fault on SWP_SYNCHRONOUS_IO
+        * files, which reads into a private page and may free it if
+        * the fault fails. We remain the primary owner of the entry.)
+        */
+       if (swapcache)
+               zswap_rb_erase(&tree->rbroot, entry);
        spin_unlock(&tree->lock);
 
        if (entry->length)
@@ -1645,9 +1677,10 @@ bool zswap_load(struct folio *folio)
        if (entry->objcg)
                count_objcg_event(entry->objcg, ZSWPIN);
 
-       zswap_entry_free(entry);
-
-       folio_mark_dirty(folio);
+       if (swapcache) {
+               zswap_entry_free(entry);
+               folio_mark_dirty(folio);
+       }
 
        return true;
 }
index 43bf3818c19e829b47d3989d36e2e1b3bf985438..0963689a59506ac3309ad9a86d06b729948ad357 100644 (file)
@@ -482,7 +482,7 @@ int __sock_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
        unsigned long flags;
        struct sk_buff_head *list = &sk->sk_receive_queue;
 
-       if (atomic_read(&sk->sk_rmem_alloc) >= sk->sk_rcvbuf) {
+       if (atomic_read(&sk->sk_rmem_alloc) >= READ_ONCE(sk->sk_rcvbuf)) {
                atomic_inc(&sk->sk_drops);
                trace_sock_rcvqueue_full(sk, skb);
                return -ENOMEM;
@@ -552,7 +552,7 @@ int __sk_receive_skb(struct sock *sk, struct sk_buff *skb,
 
        skb->dev = NULL;
 
-       if (sk_rcvqueues_full(sk, sk->sk_rcvbuf)) {
+       if (sk_rcvqueues_full(sk, READ_ONCE(sk->sk_rcvbuf))) {
                atomic_inc(&sk->sk_drops);
                goto discard_and_relse;
        }
index e5742f2a2d522a432092216a596fe7a4ef91f1da..1b6457f357bdb274d74d696823f61306fd7429c2 100644 (file)
@@ -220,7 +220,8 @@ void hsr_del_port(struct hsr_port *port)
                netdev_update_features(master->dev);
                dev_set_mtu(master->dev, hsr_get_max_mtu(hsr));
                netdev_rx_handler_unregister(port->dev);
-               dev_set_promiscuity(port->dev, -1);
+               if (!port->hsr->fwd_offloaded)
+                       dev_set_promiscuity(port->dev, -1);
                netdev_upper_dev_unlink(port->dev, master->dev);
        }
 
index 7d8090f109ef4e794a13fb6ab5d180b16bafb59d..c038e28e2f1e66bf10c7f67ffe073e6790b2d6ce 100644 (file)
@@ -771,6 +771,20 @@ void inet_csk_clear_xmit_timers(struct sock *sk)
 }
 EXPORT_SYMBOL(inet_csk_clear_xmit_timers);
 
+void inet_csk_clear_xmit_timers_sync(struct sock *sk)
+{
+       struct inet_connection_sock *icsk = inet_csk(sk);
+
+       /* ongoing timer handlers need to acquire socket lock. */
+       sock_not_owned_by_me(sk);
+
+       icsk->icsk_pending = icsk->icsk_ack.pending = 0;
+
+       sk_stop_timer_sync(sk, &icsk->icsk_retransmit_timer);
+       sk_stop_timer_sync(sk, &icsk->icsk_delack_timer);
+       sk_stop_timer_sync(sk, &sk->sk_timer);
+}
+
 void inet_csk_delete_keepalive_timer(struct sock *sk)
 {
        sk_stop_timer(sk, &sk->sk_timer);
index 7072fc0783ef56e59c886a2f2516e7db7d10c942..c88c9034d63004e7763f60b3211dc319172c8d06 100644 (file)
@@ -24,6 +24,8 @@
 #include <net/ip.h>
 #include <net/ipv6.h>
 
+#include "../core/sock_destructor.h"
+
 /* Use skb->cb to track consecutive/adjacent fragments coming at
  * the end of the queue. Nodes in the rb-tree queue will
  * contain "runs" of one or more adjacent fragments.
@@ -39,6 +41,7 @@ struct ipfrag_skb_cb {
        };
        struct sk_buff          *next_frag;
        int                     frag_run_len;
+       int                     ip_defrag_offset;
 };
 
 #define FRAG_CB(skb)           ((struct ipfrag_skb_cb *)((skb)->cb))
@@ -396,12 +399,12 @@ int inet_frag_queue_insert(struct inet_frag_queue *q, struct sk_buff *skb,
         */
        if (!last)
                fragrun_create(q, skb);  /* First fragment. */
-       else if (last->ip_defrag_offset + last->len < end) {
+       else if (FRAG_CB(last)->ip_defrag_offset + last->len < end) {
                /* This is the common case: skb goes to the end. */
                /* Detect and discard overlaps. */
-               if (offset < last->ip_defrag_offset + last->len)
+               if (offset < FRAG_CB(last)->ip_defrag_offset + last->len)
                        return IPFRAG_OVERLAP;
-               if (offset == last->ip_defrag_offset + last->len)
+               if (offset == FRAG_CB(last)->ip_defrag_offset + last->len)
                        fragrun_append_to_last(q, skb);
                else
                        fragrun_create(q, skb);
@@ -418,13 +421,13 @@ int inet_frag_queue_insert(struct inet_frag_queue *q, struct sk_buff *skb,
 
                        parent = *rbn;
                        curr = rb_to_skb(parent);
-                       curr_run_end = curr->ip_defrag_offset +
+                       curr_run_end = FRAG_CB(curr)->ip_defrag_offset +
                                        FRAG_CB(curr)->frag_run_len;
-                       if (end <= curr->ip_defrag_offset)
+                       if (end <= FRAG_CB(curr)->ip_defrag_offset)
                                rbn = &parent->rb_left;
                        else if (offset >= curr_run_end)
                                rbn = &parent->rb_right;
-                       else if (offset >= curr->ip_defrag_offset &&
+                       else if (offset >= FRAG_CB(curr)->ip_defrag_offset &&
                                 end <= curr_run_end)
                                return IPFRAG_DUP;
                        else
@@ -438,7 +441,7 @@ int inet_frag_queue_insert(struct inet_frag_queue *q, struct sk_buff *skb,
                rb_insert_color(&skb->rbnode, &q->rb_fragments);
        }
 
-       skb->ip_defrag_offset = offset;
+       FRAG_CB(skb)->ip_defrag_offset = offset;
 
        return IPFRAG_OK;
 }
@@ -448,13 +451,28 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
                              struct sk_buff *parent)
 {
        struct sk_buff *fp, *head = skb_rb_first(&q->rb_fragments);
-       struct sk_buff **nextp;
+       void (*destructor)(struct sk_buff *);
+       unsigned int orig_truesize = 0;
+       struct sk_buff **nextp = NULL;
+       struct sock *sk = skb->sk;
        int delta;
 
+       if (sk && is_skb_wmem(skb)) {
+               /* TX: skb->sk might have been passed as argument to
+                * dst->output and must remain valid until tx completes.
+                *
+                * Move sk to reassembled skb and fix up wmem accounting.
+                */
+               orig_truesize = skb->truesize;
+               destructor = skb->destructor;
+       }
+
        if (head != skb) {
                fp = skb_clone(skb, GFP_ATOMIC);
-               if (!fp)
-                       return NULL;
+               if (!fp) {
+                       head = skb;
+                       goto out_restore_sk;
+               }
                FRAG_CB(fp)->next_frag = FRAG_CB(skb)->next_frag;
                if (RB_EMPTY_NODE(&skb->rbnode))
                        FRAG_CB(parent)->next_frag = fp;
@@ -463,6 +481,12 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
                                        &q->rb_fragments);
                if (q->fragments_tail == skb)
                        q->fragments_tail = fp;
+
+               if (orig_truesize) {
+                       /* prevent skb_morph from releasing sk */
+                       skb->sk = NULL;
+                       skb->destructor = NULL;
+               }
                skb_morph(skb, head);
                FRAG_CB(skb)->next_frag = FRAG_CB(head)->next_frag;
                rb_replace_node(&head->rbnode, &skb->rbnode,
@@ -470,13 +494,13 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
                consume_skb(head);
                head = skb;
        }
-       WARN_ON(head->ip_defrag_offset != 0);
+       WARN_ON(FRAG_CB(head)->ip_defrag_offset != 0);
 
        delta = -head->truesize;
 
        /* Head of list must not be cloned. */
        if (skb_unclone(head, GFP_ATOMIC))
-               return NULL;
+               goto out_restore_sk;
 
        delta += head->truesize;
        if (delta)
@@ -492,7 +516,7 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
 
                clone = alloc_skb(0, GFP_ATOMIC);
                if (!clone)
-                       return NULL;
+                       goto out_restore_sk;
                skb_shinfo(clone)->frag_list = skb_shinfo(head)->frag_list;
                skb_frag_list_init(head);
                for (i = 0; i < skb_shinfo(head)->nr_frags; i++)
@@ -509,6 +533,21 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
                nextp = &skb_shinfo(head)->frag_list;
        }
 
+out_restore_sk:
+       if (orig_truesize) {
+               int ts_delta = head->truesize - orig_truesize;
+
+               /* if this reassembled skb is fragmented later,
+                * fraglist skbs will get skb->sk assigned from head->sk,
+                * and each frag skb will be released via sock_wfree.
+                *
+                * Update sk_wmem_alloc.
+                */
+               head->sk = sk;
+               head->destructor = destructor;
+               refcount_add(ts_delta, &sk->sk_wmem_alloc);
+       }
+
        return nextp;
 }
 EXPORT_SYMBOL(inet_frag_reasm_prepare);
@@ -516,6 +555,8 @@ EXPORT_SYMBOL(inet_frag_reasm_prepare);
 void inet_frag_reasm_finish(struct inet_frag_queue *q, struct sk_buff *head,
                            void *reasm_data, bool try_coalesce)
 {
+       struct sock *sk = is_skb_wmem(head) ? head->sk : NULL;
+       const unsigned int head_truesize = head->truesize;
        struct sk_buff **nextp = reasm_data;
        struct rb_node *rbn;
        struct sk_buff *fp;
@@ -579,6 +620,9 @@ void inet_frag_reasm_finish(struct inet_frag_queue *q, struct sk_buff *head,
        head->prev = NULL;
        head->tstamp = q->stamp;
        head->mono_delivery_time = q->mono_delivery_time;
+
+       if (sk)
+               refcount_add(sum_truesize - head_truesize, &sk->sk_wmem_alloc);
 }
 EXPORT_SYMBOL(inet_frag_reasm_finish);
 
index a4941f53b523725cd777d213500b8f6918287920..fb947d1613fe2b8b5262ff809255d3b754b57e59 100644 (file)
@@ -384,6 +384,7 @@ static int ip_frag_queue(struct ipq *qp, struct sk_buff *skb)
        }
 
        skb_dst_drop(skb);
+       skb_orphan(skb);
        return -EINPROGRESS;
 
 insert_error:
@@ -487,7 +488,6 @@ int ip_defrag(struct net *net, struct sk_buff *skb, u32 user)
        struct ipq *qp;
 
        __IP_INC_STATS(net, IPSTATS_MIB_REASMREQDS);
-       skb_orphan(skb);
 
        /* Lookup (or create) queue header */
        qp = ip_find(net, ip_hdr(skb), user, vif);
index 8f6e950163a792dce4606749853d429fd46ec155..1b991b889506a9929980e6c91a493d976a7de0ed 100644 (file)
@@ -329,6 +329,7 @@ config NFT_COMPAT_ARP
 config IP_NF_ARPFILTER
        tristate "arptables-legacy packet filtering support"
        select IP_NF_ARPTABLES
+       select NETFILTER_FAMILY_ARP
        depends on NETFILTER_XTABLES
        help
          ARP packet filtering defines a table `filter', which has a series of
index 74928a9d1aa48bae5fe4f56ac05d2a32cd8d6a7e..535856b0f0edce6d8dae47126b42125c178df889 100644 (file)
@@ -768,8 +768,10 @@ static int nh_grp_hw_stats_update(struct nexthop *nh, bool *hw_stats_used)
        struct net *net = nh->net;
        int err;
 
-       if (nexthop_notifiers_is_empty(net))
+       if (nexthop_notifiers_is_empty(net)) {
+               *hw_stats_used = false;
                return 0;
+       }
 
        err = nh_notifier_grp_hw_stats_init(&info, nh);
        if (err)
index d20b62d521712ae7982b1e73fddf7d4be0df696d..e767721b3a588b5d56567ae7badf5dffcd35a76a 100644 (file)
@@ -2931,6 +2931,8 @@ void tcp_close(struct sock *sk, long timeout)
        lock_sock(sk);
        __tcp_close(sk, timeout);
        release_sock(sk);
+       if (!sk->sk_net_refcnt)
+               inet_csk_clear_xmit_timers_sync(sk);
        sock_put(sk);
 }
 EXPORT_SYMBOL(tcp_close);
index 247bd4d8ee45a66a391b99e8e5f2ca56b55ec404..92db9b474f2bdb0a2efc91ab2be6c83c8a46372d 100644 (file)
@@ -5416,10 +5416,11 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb,
 
                err = 0;
                if (fillargs.ifindex) {
-                       err = -ENODEV;
                        dev = dev_get_by_index_rcu(tgt_net, fillargs.ifindex);
-                       if (!dev)
+                       if (!dev) {
+                               err = -ENODEV;
                                goto done;
+                       }
                        idev = __in6_dev_get(dev);
                        if (idev)
                                err = in6_dump_addrs(idev, skb, cb,
index 1a51a44571c372184fb4dabc967dedb44cde976b..d0dcbaca19943a2170f1ea6c621168f4eb8aeb67 100644 (file)
@@ -294,6 +294,7 @@ static int nf_ct_frag6_queue(struct frag_queue *fq, struct sk_buff *skb,
        }
 
        skb_dst_drop(skb);
+       skb_orphan(skb);
        return -EINPROGRESS;
 
 insert_error:
@@ -469,7 +470,6 @@ int nf_ct_frag6_gather(struct net *net, struct sk_buff *skb, u32 user)
        hdr = ipv6_hdr(skb);
        fhdr = (struct frag_hdr *)skb_transport_header(skb);
 
-       skb_orphan(skb);
        fq = fq_find(net, fhdr->identification, user, hdr,
                     skb->dev ? skb->dev->ifindex : 0);
        if (fq == NULL) {
index f03452dc716d5d9588fe5c50a09888ae78c75402..f67c1d0218121dc98b67af7201686a0c0b2ad817 100644 (file)
@@ -2199,15 +2199,14 @@ static int ieee80211_change_station(struct wiphy *wiphy,
                }
 
                if (sta->sdata->vif.type == NL80211_IFTYPE_AP_VLAN &&
-                   sta->sdata->u.vlan.sta) {
-                       ieee80211_clear_fast_rx(sta);
+                   sta->sdata->u.vlan.sta)
                        RCU_INIT_POINTER(sta->sdata->u.vlan.sta, NULL);
-               }
 
                if (test_sta_flag(sta, WLAN_STA_AUTHORIZED))
                        ieee80211_vif_dec_num_mcast(sta->sdata);
 
                sta->sdata = vlansdata;
+               ieee80211_check_fast_rx(sta);
                ieee80211_check_fast_xmit(sta);
 
                if (test_sta_flag(sta, WLAN_STA_AUTHORIZED)) {
index 49da401c53408b0f517425109663f507e763775e..35a8ba25fa57fdb70f111c7d80ac13df7a2a8c9b 100644 (file)
@@ -158,7 +158,7 @@ do {                                                                        \
                        _sdata_dbg(print, sdata, "[link %d] " fmt,      \
                                   link_id, ##__VA_ARGS__);             \
                else                                                    \
-                       _sdata_dbg(1, sdata, fmt, ##__VA_ARGS__);       \
+                       _sdata_dbg(print, sdata, fmt, ##__VA_ARGS__);   \
        } while (0)
 #define link_dbg(link, fmt, ...)                                       \
        _link_id_dbg(1, (link)->sdata, (link)->link_id,                 \
index b6fead612b66b51df10c52e0dad6a3ed05aaabbf..bd507d6b65e3f6b67f6b6883d049f30b0c1ae67a 100644 (file)
@@ -131,7 +131,7 @@ struct ieee80211_bss {
 };
 
 /**
- * enum ieee80211_corrupt_data_flags - BSS data corruption flags
+ * enum ieee80211_bss_corrupt_data_flags - BSS data corruption flags
  * @IEEE80211_BSS_CORRUPT_BEACON: last beacon frame received was corrupted
  * @IEEE80211_BSS_CORRUPT_PROBE_RESP: last probe response received was corrupted
  *
@@ -144,7 +144,7 @@ enum ieee80211_bss_corrupt_data_flags {
 };
 
 /**
- * enum ieee80211_valid_data_flags - BSS valid data flags
+ * enum ieee80211_bss_valid_data_flags - BSS valid data flags
  * @IEEE80211_BSS_VALID_WMM: WMM/UAPSD data was gathered from non-corrupt IE
  * @IEEE80211_BSS_VALID_RATES: Supported rates were gathered from non-corrupt IE
  * @IEEE80211_BSS_VALID_ERP: ERP flag was gathered from non-corrupt IE
index 47a2cba8313f04c3d86c6ce424395a0aca2b7cc1..96b70006b7fc0b11b12f423fb74ec32a030d91af 100644 (file)
@@ -5874,6 +5874,15 @@ static int ieee80211_ttlm_set_links(struct ieee80211_sub_if_data *sdata,
        }
 
        if (sdata->vif.active_links != active_links) {
+               /* usable links are affected when active_links are changed,
+                * so notify the driver about the status change
+                */
+               changed |= BSS_CHANGED_MLD_VALID_LINKS;
+               active_links &= sdata->vif.active_links;
+               if (!active_links)
+                       active_links =
+                               BIT(__ffs(sdata->vif.valid_links &
+                                   ~dormant_links));
                ret = ieee80211_set_active_links(&sdata->vif, active_links);
                if (ret) {
                        sdata_info(sdata, "Failed to set TTLM active links\n");
@@ -5888,7 +5897,6 @@ static int ieee80211_ttlm_set_links(struct ieee80211_sub_if_data *sdata,
                goto out;
        }
 
-       changed |= BSS_CHANGED_MLD_VALID_LINKS;
        sdata->vif.suspended_links = suspended_links;
        if (sdata->vif.suspended_links)
                changed |= BSS_CHANGED_MLD_TTLM;
@@ -7652,7 +7660,7 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
                        sdata_info(sdata,
                                   "failed to insert STA entry for the AP (error %d)\n",
                                   err);
-                       goto out_err;
+                       goto out_release_chan;
                }
        } else
                WARN_ON_ONCE(!ether_addr_equal(link->u.mgd.bssid, cbss->bssid));
@@ -7663,8 +7671,9 @@ static int ieee80211_prep_connection(struct ieee80211_sub_if_data *sdata,
 
        return 0;
 
+out_release_chan:
+       ieee80211_link_release_channel(link);
 out_err:
-       ieee80211_link_release_channel(&sdata->deflink);
        ieee80211_vif_set_links(sdata, 0, 0);
        return err;
 }
index 5fa3d3540c93c003737fb16ef1e6e7514580e97a..fd86f2720c9e776b08db64c6f1083a425c289754 100644 (file)
@@ -1200,6 +1200,25 @@ static void nf_tables_table_disable(struct net *net, struct nft_table *table)
                                         __NFT_TABLE_F_WAS_AWAKEN | \
                                         __NFT_TABLE_F_WAS_ORPHAN)
 
+static bool nft_table_pending_update(const struct nft_ctx *ctx)
+{
+       struct nftables_pernet *nft_net = nft_pernet(ctx->net);
+       struct nft_trans *trans;
+
+       if (ctx->table->flags & __NFT_TABLE_F_UPDATE)
+               return true;
+
+       list_for_each_entry(trans, &nft_net->commit_list, list) {
+               if ((trans->msg_type == NFT_MSG_NEWCHAIN ||
+                    trans->msg_type == NFT_MSG_DELCHAIN) &&
+                   trans->ctx.table == ctx->table &&
+                   nft_trans_chain_update(trans))
+                       return true;
+       }
+
+       return false;
+}
+
 static int nf_tables_updtable(struct nft_ctx *ctx)
 {
        struct nft_trans *trans;
@@ -1226,7 +1245,7 @@ static int nf_tables_updtable(struct nft_ctx *ctx)
                return -EOPNOTSUPP;
 
        /* No dormant off/on/off/on games in single transaction */
-       if (ctx->table->flags & __NFT_TABLE_F_UPDATE)
+       if (nft_table_pending_update(ctx))
                return -EINVAL;
 
        trans = nft_trans_alloc(ctx, NFT_MSG_NEWTABLE,
@@ -2631,6 +2650,13 @@ static int nf_tables_updchain(struct nft_ctx *ctx, u8 genmask, u8 policy,
                }
        }
 
+       if (table->flags & __NFT_TABLE_F_UPDATE &&
+           !list_empty(&hook.list)) {
+               NL_SET_BAD_ATTR(extack, attr);
+               err = -EOPNOTSUPP;
+               goto err_hooks;
+       }
+
        if (!(table->flags & NFT_TABLE_F_DORMANT) &&
            nft_is_base_chain(chain) &&
            !list_empty(&hook.list)) {
@@ -2860,6 +2886,9 @@ static int nft_delchain_hook(struct nft_ctx *ctx,
        struct nft_trans *trans;
        int err;
 
+       if (ctx->table->flags & __NFT_TABLE_F_UPDATE)
+               return -EOPNOTSUPP;
+
        err = nft_chain_parse_hook(ctx->net, basechain, nla, &chain_hook,
                                   ctx->family, chain->flags, extack);
        if (err < 0)
@@ -2944,7 +2973,8 @@ static int nf_tables_delchain(struct sk_buff *skb, const struct nfnl_info *info,
        nft_ctx_init(&ctx, net, skb, info->nlh, family, table, chain, nla);
 
        if (nla[NFTA_CHAIN_HOOK]) {
-               if (chain->flags & NFT_CHAIN_HW_OFFLOAD)
+               if (NFNL_MSG_TYPE(info->nlh->nlmsg_type) == NFT_MSG_DESTROYCHAIN ||
+                   chain->flags & NFT_CHAIN_HW_OFFLOAD)
                        return -EOPNOTSUPP;
 
                if (nft_is_base_chain(chain)) {
@@ -10182,9 +10212,11 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)
                        if (nft_trans_chain_update(trans)) {
                                nf_tables_chain_notify(&trans->ctx, NFT_MSG_DELCHAIN,
                                                       &nft_trans_chain_hooks(trans));
-                               nft_netdev_unregister_hooks(net,
-                                                           &nft_trans_chain_hooks(trans),
-                                                           true);
+                               if (!(trans->ctx.table->flags & NFT_TABLE_F_DORMANT)) {
+                                       nft_netdev_unregister_hooks(net,
+                                                                   &nft_trans_chain_hooks(trans),
+                                                                   true);
+                               }
                        } else {
                                nft_chain_del(trans->ctx.chain);
                                nf_tables_chain_notify(&trans->ctx, NFT_MSG_DELCHAIN,
@@ -10460,9 +10492,11 @@ static int __nf_tables_abort(struct net *net, enum nfnl_abort_action action)
                        break;
                case NFT_MSG_NEWCHAIN:
                        if (nft_trans_chain_update(trans)) {
-                               nft_netdev_unregister_hooks(net,
-                                                           &nft_trans_chain_hooks(trans),
-                                                           true);
+                               if (!(trans->ctx.table->flags & NFT_TABLE_F_DORMANT)) {
+                                       nft_netdev_unregister_hooks(net,
+                                                                   &nft_trans_chain_hooks(trans),
+                                                                   true);
+                               }
                                free_percpu(nft_trans_chain_stats(trans));
                                kfree(nft_trans_chain_name(trans));
                                nft_trans_destroy(trans);
index cdad47b140fa4bd54ac0571457ab16ab505a3a11..0d26c8ec9993ea18af0beeeff5ac1a8cd3ef72f6 100644 (file)
@@ -1516,6 +1516,11 @@ static void nci_rx_work(struct work_struct *work)
                nfc_send_to_raw_sock(ndev->nfc_dev, skb,
                                     RAW_PAYLOAD_NCI, NFC_DIRECTION_RX);
 
+               if (!nci_plen(skb->data)) {
+                       kfree_skb(skb);
+                       break;
+               }
+
                /* Process frame */
                switch (nci_mt(skb->data)) {
                case NCI_MT_RSP_PKT:
index b2c1b683a88ee2ece3f5f84ff0af7468f437e13b..d2b02710ab0709dfc92b4ce8e1bc0d892016594e 100644 (file)
@@ -921,8 +921,6 @@ out_err:
  * Caller provides the truncation length of the output token (h) in
  * cksumout.len.
  *
- * Note that for RPCSEC, the "initial cipher state" is always all zeroes.
- *
  * Return values:
  *   %GSS_S_COMPLETE: Digest computed, @cksumout filled in
  *   %GSS_S_FAILURE: Call failed
@@ -933,19 +931,22 @@ u32 krb5_etm_checksum(struct crypto_sync_skcipher *cipher,
                      int body_offset, struct xdr_netobj *cksumout)
 {
        unsigned int ivsize = crypto_sync_skcipher_ivsize(cipher);
-       static const u8 iv[GSS_KRB5_MAX_BLOCKSIZE];
        struct ahash_request *req;
        struct scatterlist sg[1];
+       u8 *iv, *checksumdata;
        int err = -ENOMEM;
-       u8 *checksumdata;
 
        checksumdata = kmalloc(crypto_ahash_digestsize(tfm), GFP_KERNEL);
        if (!checksumdata)
                return GSS_S_FAILURE;
+       /* For RPCSEC, the "initial cipher state" is always all zeroes. */
+       iv = kzalloc(ivsize, GFP_KERNEL);
+       if (!iv)
+               goto out_free_mem;
 
        req = ahash_request_alloc(tfm, GFP_KERNEL);
        if (!req)
-               goto out_free_cksumdata;
+               goto out_free_mem;
        ahash_request_set_callback(req, CRYPTO_TFM_REQ_MAY_SLEEP, NULL, NULL);
        err = crypto_ahash_init(req);
        if (err)
@@ -969,7 +970,8 @@ u32 krb5_etm_checksum(struct crypto_sync_skcipher *cipher,
 
 out_free_ahash:
        ahash_request_free(req);
-out_free_cksumdata:
+out_free_mem:
+       kfree(iv);
        kfree_sensitive(checksumdata);
        return err ? GSS_S_FAILURE : GSS_S_COMPLETE;
 }
index 211f57164cb611fd2665f682906be96aa35463ed..b783231668c6512015070bfb090ef89ce5ca6458 100644 (file)
@@ -1976,10 +1976,10 @@ int tls_sw_recvmsg(struct sock *sk,
        if (unlikely(flags & MSG_ERRQUEUE))
                return sock_recv_errqueue(sk, msg, len, SOL_IP, IP_RECVERR);
 
-       psock = sk_psock_get(sk);
        err = tls_rx_reader_lock(sk, ctx, flags & MSG_DONTWAIT);
        if (err < 0)
                return err;
+       psock = sk_psock_get(sk);
        bpf_strp_enabled = sk_psock_strp_enabled(psock);
 
        /* If crypto failed the connection is broken */
@@ -2152,12 +2152,15 @@ recv_end:
                }
 
                /* Drain records from the rx_list & copy if required */
-               if (is_peek || is_kvec)
+               if (is_peek)
                        err = process_rx_list(ctx, msg, &control, copied + peeked,
                                              decrypted - peeked, is_peek, NULL);
                else
                        err = process_rx_list(ctx, msg, &control, 0,
                                              async_copy_bytes, is_peek, NULL);
+
+               /* we could have copied less than we wanted, and possibly nothing */
+               decrypted += max(err, 0) - async_copy_bytes;
        }
 
        copied += decrypted;
index e039e66ab37774bc45e77ef9eb0abe8bf6311ae5..cbbf347c6b2e099802b135266ca7fae59bd467f9 100644 (file)
@@ -1024,7 +1024,7 @@ TRACE_EVENT(rdev_get_mpp,
 TRACE_EVENT(rdev_dump_mpp,
        TP_PROTO(struct wiphy *wiphy, struct net_device *netdev, int _idx,
                 u8 *dst, u8 *mpp),
-       TP_ARGS(wiphy, netdev, _idx, mpp, dst),
+       TP_ARGS(wiphy, netdev, _idx, dst, mpp),
        TP_STRUCT__entry(
                WIPHY_ENTRY
                NETDEV_ENTRY
index a161c64d1765e6cb2e2a4ae08e5534b22c8aa457..838ad6541a17d8acaa531aa62a8acceb39c959ad 100644 (file)
@@ -4,6 +4,7 @@
  * Authors :   Jean Tourrilhes - HPL - <jt@hpl.hp.com>
  * Copyright (c) 1997-2007 Jean Tourrilhes, All Rights Reserved.
  * Copyright   2009 Johannes Berg <johannes@sipsolutions.net>
+ * Copyright (C) 2024 Intel Corporation
  *
  * (As all part of the Linux kernel, this file is GPL)
  */
@@ -662,7 +663,8 @@ struct iw_statistics *get_wireless_stats(struct net_device *dev)
            dev->ieee80211_ptr->wiphy->wext &&
            dev->ieee80211_ptr->wiphy->wext->get_wireless_stats) {
                wireless_warn_cfg80211_wext();
-               if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO)
+               if (dev->ieee80211_ptr->wiphy->flags & (WIPHY_FLAG_SUPPORTS_MLO |
+                                                       WIPHY_FLAG_DISABLE_WEXT))
                        return NULL;
                return dev->ieee80211_ptr->wiphy->wext->get_wireless_stats(dev);
        }
@@ -704,7 +706,8 @@ static iw_handler get_handler(struct net_device *dev, unsigned int cmd)
 #ifdef CONFIG_CFG80211_WEXT
        if (dev->ieee80211_ptr && dev->ieee80211_ptr->wiphy) {
                wireless_warn_cfg80211_wext();
-               if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO)
+               if (dev->ieee80211_ptr->wiphy->flags & (WIPHY_FLAG_SUPPORTS_MLO |
+                                                       WIPHY_FLAG_DISABLE_WEXT))
                        return NULL;
                handlers = dev->ieee80211_ptr->wiphy->wext;
        }
index 3ce5d503a6da98efe3b7ec8b62138c5e12eb258c..c5af566e911ae77f7b4838b78a8ef8348d5360db 100644 (file)
@@ -114,6 +114,8 @@ KBUILD_CFLAGS += $(call cc-disable-warning, format-overflow)
 KBUILD_CFLAGS += $(call cc-disable-warning, format-truncation)
 KBUILD_CFLAGS += $(call cc-disable-warning, stringop-truncation)
 
+KBUILD_CFLAGS += -Wno-override-init # alias for -Wno-initializer-overrides in clang
+
 ifdef CONFIG_CC_IS_CLANG
 # Clang before clang-16 would warn on default argument promotions.
 ifneq ($(call clang-min-version, 160000),y)
@@ -151,10 +153,6 @@ KBUILD_CFLAGS += -Wtype-limits
 KBUILD_CFLAGS += $(call cc-option, -Wmaybe-uninitialized)
 KBUILD_CFLAGS += $(call cc-option, -Wunused-macros)
 
-ifdef CONFIG_CC_IS_CLANG
-KBUILD_CFLAGS += -Winitializer-overrides
-endif
-
 KBUILD_CPPFLAGS += -DKBUILD_EXTRA_WARN2
 
 else
@@ -164,9 +162,7 @@ KBUILD_CFLAGS += -Wno-missing-field-initializers
 KBUILD_CFLAGS += -Wno-type-limits
 KBUILD_CFLAGS += -Wno-shift-negative-value
 
-ifdef CONFIG_CC_IS_CLANG
-KBUILD_CFLAGS += -Wno-initializer-overrides
-else
+ifdef CONFIG_CC_IS_GCC
 KBUILD_CFLAGS += -Wno-maybe-uninitialized
 endif
 
index 8568d256d6fbff5dfc4b9553f9b829ed92b258e3..79fcf27316864f467cca39e1853f5579b16e148a 100644 (file)
@@ -23,7 +23,7 @@ modname = $(notdir $(@:.mod.o=))
 part-of-module = y
 
 quiet_cmd_cc_o_c = CC [M]  $@
-      cmd_cc_o_c = $(CC) $(filter-out $(CC_FLAGS_CFI) $(CFLAGS_GCOV), $(c_flags)) -c -o $@ $<
+      cmd_cc_o_c = $(CC) $(filter-out $(CC_FLAGS_CFI) $(CFLAGS_GCOV) $(CFLAGS_KCSAN), $(c_flags)) -c -o $@ $<
 
 %.mod.o: %.mod.c FORCE
        $(call if_changed_dep,cc_o_c)
index 4606944984ee2e79035084d2175ca7ae553a0c34..c55878bddfddc445a8f4548e4c763991585b1844 100755 (executable)
@@ -414,8 +414,8 @@ class PrinterRST(Printer):
             version = version.stdout.decode().rstrip()
         except:
             try:
-                version = subprocess.run(['make', 'kernelversion'], cwd=linuxRoot,
-                                         capture_output=True, check=True)
+                version = subprocess.run(['make', '-s', '--no-print-directory', 'kernelversion'],
+                                         cwd=linuxRoot, capture_output=True, check=True)
                 version = version.stdout.decode().rstrip()
             except:
                 return 'Linux'
index b5730061872baea05947ca95ec94391a0a468e36..965bb40c50e5170a1341d662e5be7607a866e928 100644 (file)
@@ -552,11 +552,6 @@ static int conf_choice(struct menu *menu)
                        continue;
                }
                sym_set_tristate_value(child->sym, yes);
-               for (child = child->list; child; child = child->next) {
-                       indent += 2;
-                       conf(child);
-                       indent -= 2;
-               }
                return 1;
        }
 }
index e69d7c59d930272e177618e440c42bee1e8bbce6..e7cc9e985c4f0679db316f09d0afb001cc07de7c 100644 (file)
@@ -89,7 +89,7 @@ void menu_add_visibility(struct expr *dep);
 struct property *menu_add_prompt(enum prop_type type, char *prompt, struct expr *dep);
 void menu_add_expr(enum prop_type type, struct expr *expr, struct expr *dep);
 void menu_add_symbol(enum prop_type type, struct symbol *sym, struct expr *dep);
-void menu_finalize(struct menu *parent);
+void menu_finalize(void);
 void menu_set_type(int type);
 
 extern struct menu rootmenu;
index 31d0a89fbeb7ac69e2348b902047226cd9551ba0..75493302fb857027dd086b7336ec7372415e24b7 100644 (file)
@@ -119,7 +119,7 @@ int dialog_checklist(const char *title, const char *prompt, int height,
        }
 
 do_resize:
-       if (getmaxy(stdscr) < (height + CHECKLIST_HEIGTH_MIN))
+       if (getmaxy(stdscr) < (height + CHECKLIST_HEIGHT_MIN))
                return -ERRDISPLAYTOOSMALL;
        if (getmaxx(stdscr) < (width + CHECKLIST_WIDTH_MIN))
                return -ERRDISPLAYTOOSMALL;
index 2d15ba893fbf8945147e15b43190bd60cbf0ecfa..f6c2ebe6d1f91d9f6086245c2469a158a8a4b9fa 100644 (file)
@@ -162,17 +162,17 @@ int on_key_esc(WINDOW *win);
 int on_key_resize(void);
 
 /* minimum (re)size values */
-#define CHECKLIST_HEIGTH_MIN 6 /* For dialog_checklist() */
+#define CHECKLIST_HEIGHT_MIN 6 /* For dialog_checklist() */
 #define CHECKLIST_WIDTH_MIN 6
-#define INPUTBOX_HEIGTH_MIN 2  /* For dialog_inputbox() */
+#define INPUTBOX_HEIGHT_MIN 2  /* For dialog_inputbox() */
 #define INPUTBOX_WIDTH_MIN 2
-#define MENUBOX_HEIGTH_MIN 15  /* For dialog_menu() */
+#define MENUBOX_HEIGHT_MIN 15  /* For dialog_menu() */
 #define MENUBOX_WIDTH_MIN 65
-#define TEXTBOX_HEIGTH_MIN 8   /* For dialog_textbox() */
+#define TEXTBOX_HEIGHT_MIN 8   /* For dialog_textbox() */
 #define TEXTBOX_WIDTH_MIN 8
-#define YESNO_HEIGTH_MIN 4     /* For dialog_yesno() */
+#define YESNO_HEIGHT_MIN 4     /* For dialog_yesno() */
 #define YESNO_WIDTH_MIN 4
-#define WINDOW_HEIGTH_MIN 19   /* For init_dialog() */
+#define WINDOW_HEIGHT_MIN 19   /* For init_dialog() */
 #define WINDOW_WIDTH_MIN 80
 
 int init_dialog(const char *backtitle);
index 1dcfb288ee63630e7e73be6fe28f1fd1a3bc5857..3c6e24b20f5be618164a1c7025fc2ed6bed8a4a5 100644 (file)
@@ -43,7 +43,7 @@ int dialog_inputbox(const char *title, const char *prompt, int height, int width
                strcpy(instr, init);
 
 do_resize:
-       if (getmaxy(stdscr) <= (height - INPUTBOX_HEIGTH_MIN))
+       if (getmaxy(stdscr) <= (height - INPUTBOX_HEIGHT_MIN))
                return -ERRDISPLAYTOOSMALL;
        if (getmaxx(stdscr) <= (width - INPUTBOX_WIDTH_MIN))
                return -ERRDISPLAYTOOSMALL;
index 0e333284e947bcf35b1c69043d83df205e8e98f7..6e6244df0c56e395fde3e8a15b2ef22da81069a9 100644 (file)
@@ -172,7 +172,7 @@ int dialog_menu(const char *title, const char *prompt,
 do_resize:
        height = getmaxy(stdscr);
        width = getmaxx(stdscr);
-       if (height < MENUBOX_HEIGTH_MIN || width < MENUBOX_WIDTH_MIN)
+       if (height < MENUBOX_HEIGHT_MIN || width < MENUBOX_WIDTH_MIN)
                return -ERRDISPLAYTOOSMALL;
 
        height -= 4;
index 058ed0e5bbd545fe1c18baf339b5e71cc9b6702d..0abaf635978f9856f2683bf7bb2cd2ef0c6e7701 100644 (file)
@@ -175,7 +175,7 @@ int dialog_textbox(const char *title, const char *tbuf, int initial_height,
 
 do_resize:
        getmaxyx(stdscr, height, width);
-       if (height < TEXTBOX_HEIGTH_MIN || width < TEXTBOX_WIDTH_MIN)
+       if (height < TEXTBOX_HEIGHT_MIN || width < TEXTBOX_WIDTH_MIN)
                return -ERRDISPLAYTOOSMALL;
        if (initial_height != 0)
                height = initial_height;
index 3fb7508b68a240f69e31f06c5f9c753fc7129a34..f18e2a89f6135dad5fadfba1e80c06ac6c800e6e 100644 (file)
@@ -291,7 +291,7 @@ int init_dialog(const char *backtitle)
        getyx(stdscr, saved_y, saved_x);
 
        getmaxyx(stdscr, height, width);
-       if (height < WINDOW_HEIGTH_MIN || width < WINDOW_WIDTH_MIN) {
+       if (height < WINDOW_HEIGHT_MIN || width < WINDOW_WIDTH_MIN) {
                endwin();
                return -ERRDISPLAYTOOSMALL;
        }
index bcaac9b7bab2cafb17b82d5e447ae778c68ff618..b57d25e1549fe4308d062bc74214042b9b539d0a 100644 (file)
@@ -32,7 +32,7 @@ int dialog_yesno(const char *title, const char *prompt, int height, int width)
        WINDOW *dialog;
 
 do_resize:
-       if (getmaxy(stdscr) < (height + YESNO_HEIGTH_MIN))
+       if (getmaxy(stdscr) < (height + YESNO_HEIGHT_MIN))
                return -ERRDISPLAYTOOSMALL;
        if (getmaxx(stdscr) < (width + YESNO_WIDTH_MIN))
                return -ERRDISPLAYTOOSMALL;
index f4bb391d50cf997c0a66ca3e54ceb062f6cea54e..c0969097447da5bf735e05c59d23db8cb916964a 100644 (file)
@@ -659,9 +659,9 @@ static void conf_choice(struct menu *menu)
                dialog_clear();
                res = dialog_checklist(prompt ? prompt : "Main Menu",
                                        radiolist_instructions,
-                                       MENUBOX_HEIGTH_MIN,
+                                       MENUBOX_HEIGHT_MIN,
                                        MENUBOX_WIDTH_MIN,
-                                       CHECKLIST_HEIGTH_MIN);
+                                       CHECKLIST_HEIGHT_MIN);
                selected = item_activate_selected();
                switch (res) {
                case 0:
index 8498481e6afe36786b969efb6551528c1156ea05..3b822cd110f478376e7ee4fe518f368023863f3d 100644 (file)
@@ -282,7 +282,7 @@ static void sym_check_prop(struct symbol *sym)
        }
 }
 
-void menu_finalize(struct menu *parent)
+static void _menu_finalize(struct menu *parent, bool inside_choice)
 {
        struct menu *menu, *last_menu;
        struct symbol *sym;
@@ -296,7 +296,12 @@ void menu_finalize(struct menu *parent)
                 * and propagate parent dependencies before moving on.
                 */
 
-               if (sym && sym_is_choice(sym)) {
+               bool is_choice = false;
+
+               if (sym && sym_is_choice(sym))
+                       is_choice = true;
+
+               if (is_choice) {
                        if (sym->type == S_UNKNOWN) {
                                /* find the first choice value to find out choice type */
                                current_entry = parent;
@@ -394,7 +399,7 @@ void menu_finalize(struct menu *parent)
                        }
                }
 
-               if (sym && sym_is_choice(sym))
+               if (is_choice)
                        expr_free(parentdep);
 
                /*
@@ -402,8 +407,8 @@ void menu_finalize(struct menu *parent)
                 * moving on
                 */
                for (menu = parent->list; menu; menu = menu->next)
-                       menu_finalize(menu);
-       } else if (sym) {
+                       _menu_finalize(menu, is_choice);
+       } else if (!inside_choice && sym) {
                /*
                 * Automatic submenu creation. If sym is a symbol and A, B, C,
                 * ... are consecutive items (symbols, menus, ifs, etc.) that
@@ -463,7 +468,7 @@ void menu_finalize(struct menu *parent)
                        /* Superset, put in submenu */
                        expr_free(dep2);
                next:
-                       menu_finalize(menu);
+                       _menu_finalize(menu, false);
                        menu->parent = parent;
                        last_menu = menu;
                }
@@ -582,6 +587,11 @@ void menu_finalize(struct menu *parent)
        }
 }
 
+void menu_finalize(void)
+{
+       _menu_finalize(&rootmenu, false);
+}
+
 bool menu_has_prompt(struct menu *menu)
 {
        if (!menu->prompt)
index b45bfaf0a02b1234f49dd328a350a1de8f2641df..7fb996612c966075883d945f4a8174653f025d66 100644 (file)
@@ -515,7 +515,7 @@ void conf_parse(const char *name)
                menu_add_prompt(P_MENU, "Main menu", NULL);
        }
 
-       menu_finalize(&rootmenu);
+       menu_finalize();
 
        menu = &rootmenu;
        while (menu) {
index 6b37039c9e927bc3ffcad77b82e3e9f95d7bf0a7..2f5b91da5afa9ea768caaf0c3e1d1e253fcdfc48 100644 (file)
@@ -1007,6 +1007,8 @@ static Elf_Sym *find_fromsym(struct elf_info *elf, Elf_Addr addr,
 
 static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
 {
+       Elf_Sym *new_sym;
+
        /* If the supplied symbol has a valid name, return it */
        if (is_valid_name(elf, sym))
                return sym;
@@ -1015,8 +1017,9 @@ static Elf_Sym *find_tosym(struct elf_info *elf, Elf_Addr addr, Elf_Sym *sym)
         * Strive to find a better symbol name, but the resulting name may not
         * match the symbol referenced in the original code.
         */
-       return symsearch_find_nearest(elf, addr, get_secindex(elf, sym),
-                                     true, 20);
+       new_sym = symsearch_find_nearest(elf, addr, get_secindex(elf, sym),
+                                        true, 20);
+       return new_sym ? new_sym : sym;
 }
 
 static bool is_executable_section(struct elf_info *elf, unsigned int secndx)
index b8ff5cccd0c811fd76050be0f9cf50efa899a3cc..5431d2c49421067e0185158f9aa3e004f619c91e 100644 (file)
@@ -158,7 +158,7 @@ static int i2sbus_add_dev(struct macio_dev *macio,
        struct device_node *child, *sound = NULL;
        struct resource *r;
        int i, layout = 0, rlen, ok = force;
-       char node_name[6];
+       char node_name[8];
        static const char *rnames[] = { "i2sbus: %pOFn (control)",
                                        "i2sbus: %pOFn (tx)",
                                        "i2sbus: %pOFn (rx)" };
index 696a958d93e9c336dea68748e59685e4c0569ee9..088cff799e0bee5003f8d09ae0cb0087cc46ab33 100644 (file)
@@ -343,3 +343,29 @@ intel_nhlt_get_endpoint_blob(struct device *dev, struct nhlt_acpi_table *nhlt,
        return NULL;
 }
 EXPORT_SYMBOL(intel_nhlt_get_endpoint_blob);
+
+int intel_nhlt_ssp_device_type(struct device *dev, struct nhlt_acpi_table *nhlt,
+                              u8 virtual_bus_id)
+{
+       struct nhlt_endpoint *epnt;
+       int i;
+
+       if (!nhlt)
+               return -EINVAL;
+
+       epnt = (struct nhlt_endpoint *)nhlt->desc;
+       for (i = 0; i < nhlt->endpoint_count; i++) {
+               /* for SSP link the virtual bus id is the SSP port number */
+               if (epnt->linktype == NHLT_LINK_SSP &&
+                   epnt->virtual_bus_id == virtual_bus_id) {
+                       dev_dbg(dev, "SSP%d: dev_type=%d\n", virtual_bus_id,
+                               epnt->device_type);
+                       return epnt->device_type;
+               }
+
+               epnt = (struct nhlt_endpoint *)((u8 *)epnt + epnt->length);
+       }
+
+       return -EINVAL;
+}
+EXPORT_SYMBOL(intel_nhlt_ssp_device_type);
index 41974b3897a723ccd429a8e51032245d35ec2e48..1a3f84599cb584331f9766ca6bd5b00bacaa580d 100644 (file)
@@ -1024,8 +1024,8 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
                goto err;
        }
 
-       dev_dbg(cs35l56->base.dev, "DSP system name: '%s', amp name: '%s'\n",
-               cs35l56->system_name, cs35l56->amp_name);
+       dev_info(cs35l56->base.dev, "DSP system name: '%s', amp name: '%s'\n",
+                cs35l56->system_name, cs35l56->amp_name);
 
        regmap_multi_reg_write(cs35l56->base.regmap, cs35l56_hda_dai_config,
                               ARRAY_SIZE(cs35l56_hda_dai_config));
@@ -1045,14 +1045,14 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int hid, int id)
        pm_runtime_mark_last_busy(cs35l56->base.dev);
        pm_runtime_enable(cs35l56->base.dev);
 
+       cs35l56->base.init_done = true;
+
        ret = component_add(cs35l56->base.dev, &cs35l56_hda_comp_ops);
        if (ret) {
                dev_err(cs35l56->base.dev, "Register component failed: %d\n", ret);
                goto pm_err;
        }
 
-       cs35l56->base.init_done = true;
-
        return 0;
 
 pm_err:
index 4475cea8e9f70382113c3e6f496eebc854c92b40..48dae3339305048fca2262821e5ebfea6bcf237a 100644 (file)
@@ -89,7 +89,7 @@ struct tas2781_hda {
        struct snd_kcontrol *dsp_prog_ctl;
        struct snd_kcontrol *dsp_conf_ctl;
        struct snd_kcontrol *prof_ctl;
-       struct snd_kcontrol *snd_ctls[3];
+       struct snd_kcontrol *snd_ctls[2];
 };
 
 static int tas2781_get_i2c_res(struct acpi_resource *ares, void *data)
@@ -161,8 +161,6 @@ static void tas2781_hda_playback_hook(struct device *dev, int action)
                pm_runtime_put_autosuspend(dev);
                break;
        default:
-               dev_dbg(tas_hda->dev, "Playback action not supported: %d\n",
-                       action);
                break;
        }
 }
@@ -185,8 +183,15 @@ static int tasdevice_get_profile_id(struct snd_kcontrol *kcontrol,
 {
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
 
+       mutex_lock(&tas_priv->codec_lock);
+
        ucontrol->value.integer.value[0] = tas_priv->rcabin.profile_cfg_id;
 
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
+               __func__, kcontrol->id.name, tas_priv->rcabin.profile_cfg_id);
+
+       mutex_unlock(&tas_priv->codec_lock);
+
        return 0;
 }
 
@@ -200,11 +205,19 @@ static int tasdevice_set_profile_id(struct snd_kcontrol *kcontrol,
 
        val = clamp(nr_profile, 0, max);
 
+       mutex_lock(&tas_priv->codec_lock);
+
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
+               __func__, kcontrol->id.name,
+               tas_priv->rcabin.profile_cfg_id, val);
+
        if (tas_priv->rcabin.profile_cfg_id != val) {
                tas_priv->rcabin.profile_cfg_id = val;
                ret = 1;
        }
 
+       mutex_unlock(&tas_priv->codec_lock);
+
        return ret;
 }
 
@@ -241,8 +254,15 @@ static int tasdevice_program_get(struct snd_kcontrol *kcontrol,
 {
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
 
+       mutex_lock(&tas_priv->codec_lock);
+
        ucontrol->value.integer.value[0] = tas_priv->cur_prog;
 
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
+               __func__, kcontrol->id.name, tas_priv->cur_prog);
+
+       mutex_unlock(&tas_priv->codec_lock);
+
        return 0;
 }
 
@@ -257,11 +277,18 @@ static int tasdevice_program_put(struct snd_kcontrol *kcontrol,
 
        val = clamp(nr_program, 0, max);
 
+       mutex_lock(&tas_priv->codec_lock);
+
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
+               __func__, kcontrol->id.name, tas_priv->cur_prog, val);
+
        if (tas_priv->cur_prog != val) {
                tas_priv->cur_prog = val;
                ret = 1;
        }
 
+       mutex_unlock(&tas_priv->codec_lock);
+
        return ret;
 }
 
@@ -270,8 +297,15 @@ static int tasdevice_config_get(struct snd_kcontrol *kcontrol,
 {
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
 
+       mutex_lock(&tas_priv->codec_lock);
+
        ucontrol->value.integer.value[0] = tas_priv->cur_conf;
 
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
+               __func__, kcontrol->id.name, tas_priv->cur_conf);
+
+       mutex_unlock(&tas_priv->codec_lock);
+
        return 0;
 }
 
@@ -286,54 +320,39 @@ static int tasdevice_config_put(struct snd_kcontrol *kcontrol,
 
        val = clamp(nr_config, 0, max);
 
+       mutex_lock(&tas_priv->codec_lock);
+
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
+               __func__, kcontrol->id.name, tas_priv->cur_conf, val);
+
        if (tas_priv->cur_conf != val) {
                tas_priv->cur_conf = val;
                ret = 1;
        }
 
+       mutex_unlock(&tas_priv->codec_lock);
+
        return ret;
 }
 
-/*
- * tas2781_digital_getvol - get the volum control
- * @kcontrol: control pointer
- * @ucontrol: User data
- * Customer Kcontrol for tas2781 is primarily for regmap booking, paging
- * depends on internal regmap mechanism.
- * tas2781 contains book and page two-level register map, especially
- * book switching will set the register BXXP00R7F, after switching to the
- * correct book, then leverage the mechanism for paging to access the
- * register.
- */
-static int tas2781_digital_getvol(struct snd_kcontrol *kcontrol,
+static int tas2781_amp_getvol(struct snd_kcontrol *kcontrol,
        struct snd_ctl_elem_value *ucontrol)
 {
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
+       int ret;
 
-       return tasdevice_digital_getvol(tas_priv, ucontrol, mc);
-}
+       mutex_lock(&tas_priv->codec_lock);
 
-static int tas2781_amp_getvol(struct snd_kcontrol *kcontrol,
-       struct snd_ctl_elem_value *ucontrol)
-{
-       struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
-       struct soc_mixer_control *mc =
-               (struct soc_mixer_control *)kcontrol->private_value;
+       ret = tasdevice_amp_getvol(tas_priv, ucontrol, mc);
 
-       return tasdevice_amp_getvol(tas_priv, ucontrol, mc);
-}
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %ld\n",
+               __func__, kcontrol->id.name, ucontrol->value.integer.value[0]);
 
-static int tas2781_digital_putvol(struct snd_kcontrol *kcontrol,
-       struct snd_ctl_elem_value *ucontrol)
-{
-       struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
-       struct soc_mixer_control *mc =
-               (struct soc_mixer_control *)kcontrol->private_value;
+       mutex_unlock(&tas_priv->codec_lock);
 
-       /* The check of the given value is in tasdevice_digital_putvol. */
-       return tasdevice_digital_putvol(tas_priv, ucontrol, mc);
+       return ret;
 }
 
 static int tas2781_amp_putvol(struct snd_kcontrol *kcontrol,
@@ -342,9 +361,19 @@ static int tas2781_amp_putvol(struct snd_kcontrol *kcontrol,
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
+       int ret;
+
+       mutex_lock(&tas_priv->codec_lock);
+
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: -> %ld\n",
+               __func__, kcontrol->id.name, ucontrol->value.integer.value[0]);
 
        /* The check of the given value is in tasdevice_amp_putvol. */
-       return tasdevice_amp_putvol(tas_priv, ucontrol, mc);
+       ret = tasdevice_amp_putvol(tas_priv, ucontrol, mc);
+
+       mutex_unlock(&tas_priv->codec_lock);
+
+       return ret;
 }
 
 static int tas2781_force_fwload_get(struct snd_kcontrol *kcontrol,
@@ -352,9 +381,13 @@ static int tas2781_force_fwload_get(struct snd_kcontrol *kcontrol,
 {
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
 
+       mutex_lock(&tas_priv->codec_lock);
+
        ucontrol->value.integer.value[0] = (int)tas_priv->force_fwload_status;
-       dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__,
-                       tas_priv->force_fwload_status ? "ON" : "OFF");
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d\n",
+               __func__, kcontrol->id.name, tas_priv->force_fwload_status);
+
+       mutex_unlock(&tas_priv->codec_lock);
 
        return 0;
 }
@@ -365,14 +398,20 @@ static int tas2781_force_fwload_put(struct snd_kcontrol *kcontrol,
        struct tasdevice_priv *tas_priv = snd_kcontrol_chip(kcontrol);
        bool change, val = (bool)ucontrol->value.integer.value[0];
 
+       mutex_lock(&tas_priv->codec_lock);
+
+       dev_dbg(tas_priv->dev, "%s: kcontrol %s: %d -> %d\n",
+               __func__, kcontrol->id.name,
+               tas_priv->force_fwload_status, val);
+
        if (tas_priv->force_fwload_status == val)
                change = false;
        else {
                change = true;
                tas_priv->force_fwload_status = val;
        }
-       dev_dbg(tas_priv->dev, "%s : Force FWload %s\n", __func__,
-               tas_priv->force_fwload_status ? "ON" : "OFF");
+
+       mutex_unlock(&tas_priv->codec_lock);
 
        return change;
 }
@@ -381,9 +420,6 @@ static const struct snd_kcontrol_new tas2781_snd_controls[] = {
        ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Gain", TAS2781_AMP_LEVEL,
                1, 0, 20, 0, tas2781_amp_getvol,
                tas2781_amp_putvol, amp_vol_tlv),
-       ACARD_SINGLE_RANGE_EXT_TLV("Speaker Digital Gain", TAS2781_DVC_LVL,
-               0, 0, 200, 1, tas2781_digital_getvol,
-               tas2781_digital_putvol, dvc_tlv),
        ACARD_SINGLE_BOOL_EXT("Speaker Force Firmware Load", 0,
                tas2781_force_fwload_get, tas2781_force_fwload_put),
 };
index 320ac792c7fe2459b10024afd05719af2082772d..3182c634464d4288dd1bb8faca39481b5806e85e 100644 (file)
@@ -278,7 +278,8 @@ static void run_spu_dma(struct work_struct *work)
                dreamcastcard->clicks++;
                if (unlikely(dreamcastcard->clicks >= AICA_PERIOD_NUMBER))
                        dreamcastcard->clicks %= AICA_PERIOD_NUMBER;
-               mod_timer(&dreamcastcard->timer, jiffies + 1);
+               if (snd_pcm_running(dreamcastcard->substream))
+                       mod_timer(&dreamcastcard->timer, jiffies + 1);
        }
 }
 
@@ -290,6 +291,8 @@ static void aica_period_elapsed(struct timer_list *t)
        /*timer function - so cannot sleep */
        int play_period;
        struct snd_pcm_runtime *runtime;
+       if (!snd_pcm_running(substream))
+               return;
        runtime = substream->runtime;
        dreamcastcard = substream->pcm->private_data;
        /* Have we played out an additional period? */
@@ -350,12 +353,19 @@ static int snd_aicapcm_pcm_open(struct snd_pcm_substream
        return 0;
 }
 
+static int snd_aicapcm_pcm_sync_stop(struct snd_pcm_substream *substream)
+{
+       struct snd_card_aica *dreamcastcard = substream->pcm->private_data;
+
+       del_timer_sync(&dreamcastcard->timer);
+       cancel_work_sync(&dreamcastcard->spu_dma_work);
+       return 0;
+}
+
 static int snd_aicapcm_pcm_close(struct snd_pcm_substream
                                 *substream)
 {
        struct snd_card_aica *dreamcastcard = substream->pcm->private_data;
-       flush_work(&(dreamcastcard->spu_dma_work));
-       del_timer(&dreamcastcard->timer);
        dreamcastcard->substream = NULL;
        kfree(dreamcastcard->channel);
        spu_disable();
@@ -401,6 +411,7 @@ static const struct snd_pcm_ops snd_aicapcm_playback_ops = {
        .prepare = snd_aicapcm_pcm_prepare,
        .trigger = snd_aicapcm_pcm_trigger,
        .pointer = snd_aicapcm_pcm_pointer,
+       .sync_stop = snd_aicapcm_pcm_sync_stop,
 };
 
 /* TO DO: set up to handle more than one pcm instance */
index da4a83afb87a8a2c4163f34a8d6e9993b92bde77..f28edd9830c1b3e25961add70dff87a489cfa119 100644 (file)
@@ -1356,6 +1356,7 @@ static int snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_s
        int sample_rate, channel_count;
        int bit_depth, ret;
        u32 nhlt_type;
+       int dev_type = 0;
 
        /* convert to NHLT type */
        switch (linktype) {
@@ -1371,18 +1372,30 @@ static int snd_sof_get_nhlt_endpoint_data(struct snd_sof_dev *sdev, struct snd_s
                                                   &bit_depth);
                if (ret < 0)
                        return ret;
+
+               /*
+                * We need to know the type of the external device attached to a SSP
+                * port to retrieve the blob from NHLT. However, device type is not
+                * specified in topology.
+                * Query the type for the port and then pass that information back
+                * to the blob lookup function.
+                */
+               dev_type = intel_nhlt_ssp_device_type(sdev->dev, ipc4_data->nhlt,
+                                                     dai_index);
+               if (dev_type < 0)
+                       return dev_type;
                break;
        default:
                return 0;
        }
 
-       dev_dbg(sdev->dev, "dai index %d nhlt type %d direction %d\n",
-               dai_index, nhlt_type, dir);
+       dev_dbg(sdev->dev, "dai index %d nhlt type %d direction %d dev type %d\n",
+               dai_index, nhlt_type, dir, dev_type);
 
        /* find NHLT blob with matching params */
        cfg = intel_nhlt_get_endpoint_blob(sdev->dev, ipc4_data->nhlt, dai_index, nhlt_type,
                                           bit_depth, bit_depth, channel_count, sample_rate,
-                                          dir, 0);
+                                          dir, dev_type);
 
        if (!cfg) {
                dev_err(sdev->dev,
index 37e9f6804832641c176afe5ef150031748a77e9a..276f5d0d53a447f6bacaf1ed22b895554e1e3e9a 100644 (file)
@@ -11,7 +11,6 @@ help:
        @echo ''
        @echo '  acpi                   - ACPI tools'
        @echo '  bpf                    - misc BPF tools'
-       @echo '  cgroup                 - cgroup tools'
        @echo '  counter                - counter tools'
        @echo '  cpupower               - a tool for all things x86 CPU power'
        @echo '  debugging              - tools for debugging'
@@ -69,7 +68,7 @@ acpi: FORCE
 cpupower: FORCE
        $(call descend,power/$@)
 
-cgroup counter firewire hv guest bootconfig spi usb virtio mm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE
+counter firewire hv guest bootconfig spi usb virtio mm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE
        $(call descend,$@)
 
 bpf/%: FORCE
@@ -116,7 +115,7 @@ freefall: FORCE
 kvm_stat: FORCE
        $(call descend,kvm/$@)
 
-all: acpi cgroup counter cpupower gpio hv firewire \
+all: acpi counter cpupower gpio hv firewire \
                perf selftests bootconfig spi turbostat usb \
                virtio mm bpf x86_energy_perf_policy \
                tmon freefall iio objtool kvm_stat wmi \
@@ -128,7 +127,7 @@ acpi_install:
 cpupower_install:
        $(call descend,power/$(@:_install=),install)
 
-cgroup_install counter_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install mm_install bpf_install objtool_install wmi_install pci_install debugging_install tracing_install:
+counter_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install mm_install bpf_install objtool_install wmi_install pci_install debugging_install tracing_install:
        $(call descend,$(@:_install=),install)
 
 selftests_install:
@@ -155,7 +154,7 @@ freefall_install:
 kvm_stat_install:
        $(call descend,kvm/$(@:_install=),install)
 
-install: acpi_install cgroup_install counter_install cpupower_install gpio_install \
+install: acpi_install counter_install cpupower_install gpio_install \
                hv_install firewire_install iio_install \
                perf_install selftests_install turbostat_install usb_install \
                virtio_install mm_install bpf_install x86_energy_perf_policy_install \
@@ -169,7 +168,7 @@ acpi_clean:
 cpupower_clean:
        $(call descend,power/cpupower,clean)
 
-cgroup_clean counter_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean mm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean tracing_clean:
+counter_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean mm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean tracing_clean:
        $(call descend,$(@:_clean=),clean)
 
 libapi_clean:
@@ -209,7 +208,7 @@ freefall_clean:
 build_clean:
        $(call descend,build,clean)
 
-clean: acpi_clean cgroup_clean counter_clean cpupower_clean hv_clean firewire_clean \
+clean: acpi_clean counter_clean cpupower_clean hv_clean firewire_clean \
                perf_clean selftests_clean turbostat_clean bootconfig_clean spi_clean usb_clean virtio_clean \
                mm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \
                freefall_clean build_clean libbpf_clean libsubcmd_clean \
index 4fa4ade1ce7445eadac1cc92437218db97697e33..540c0f2c4fda07cef798769e4795cfb0fb574d3e 100644 (file)
@@ -121,7 +121,7 @@ static bool get_datasec_ident(const char *sec_name, char *buf, size_t buf_sz)
        int i, n;
 
        /* recognize hard coded LLVM section name */
-       if (strcmp(sec_name, ".arena.1") == 0) {
+       if (strcmp(sec_name, ".addr_space.1") == 0) {
                /* this is the name to use in skeleton */
                snprintf(buf, buf_sz, "arena");
                return true;
index efab29b8935bd9f7027859efee6a1383046105f4..a2061fcd612d7f67d22daa1f86168104f92d11e2 100644 (file)
@@ -498,7 +498,7 @@ struct bpf_struct_ops {
 #define KSYMS_SEC ".ksyms"
 #define STRUCT_OPS_SEC ".struct_ops"
 #define STRUCT_OPS_LINK_SEC ".struct_ops.link"
-#define ARENA_SEC ".arena.1"
+#define ARENA_SEC ".addr_space.1"
 
 enum libbpf_map_type {
        LIBBPF_MAP_UNSPEC,
@@ -1650,6 +1650,10 @@ static int sys_memfd_create(const char *name, unsigned flags)
        return syscall(__NR_memfd_create, name, flags);
 }
 
+#ifndef MFD_CLOEXEC
+#define MFD_CLOEXEC 0x0001U
+#endif
+
 static int create_placeholder_fd(void)
 {
        int fd;
@@ -5352,8 +5356,8 @@ retry:
                                        goto err_out;
                        }
                        if (map->def.type == BPF_MAP_TYPE_ARENA) {
-                               map->mmaped = mmap((void *)map->map_extra, bpf_map_mmap_sz(map),
-                                                  PROT_READ | PROT_WRITE,
+                               map->mmaped = mmap((void *)(long)map->map_extra,
+                                                  bpf_map_mmap_sz(map), PROT_READ | PROT_WRITE,
                                                   map->map_extra ? MAP_SHARED | MAP_FIXED : MAP_SHARED,
                                                   map->fd, 0);
                                if (map->mmaped == MAP_FAILED) {
index 6b7eb2d2aaf188234031bc638f58704788ab8e49..a451cbfbd781d99824dc5520dc51849c7ffc9cf5 100755 (executable)
@@ -228,8 +228,11 @@ class Type(SpecAttr):
         presence = ''
         for i in range(0, len(ref)):
             presence = f"{var}->{'.'.join(ref[:i] + [''])}_present.{ref[i]}"
-            if self.presence_type() == 'bit':
-                code.append(presence + ' = 1;')
+            # Every layer below last is a nest, so we know it uses bit presence
+            # last layer is "self" and may be a complex type
+            if i == len(ref) - 1 and self.presence_type() != 'bit':
+                continue
+            code.append(presence + ' = 1;')
         code += self._setter_lines(ri, member, presence)
 
         func_name = f"{op_prefix(ri, direction, deref=deref)}_set_{'_'.join(ref)}"
index 0b10ad00866867d9f4ba6787ca000f43bed230be..0a33d9195b7a9112df7824899d7564081e3d8782 100644 (file)
@@ -585,7 +585,7 @@ static int add_dead_ends(struct objtool_file *file)
        struct section *rsec;
        struct reloc *reloc;
        struct instruction *insn;
-       unsigned long offset;
+       uint64_t offset;
 
        /*
         * Check for manually annotated dead ends.
index aa5ec149f96c16e1e4736264b735201f93b5a9f5..b3b00269a52aac93d133b00b7000ce84db374209 100644 (file)
@@ -28,6 +28,8 @@ CONFIG_MCTP_FLOWS=y
 CONFIG_INET=y
 CONFIG_MPTCP=y
 
+CONFIG_NETDEVICES=y
+CONFIG_WLAN=y
 CONFIG_CFG80211=y
 CONFIG_MAC80211=y
 CONFIG_WLAN_VENDOR_INTEL=y
@@ -38,6 +40,7 @@ CONFIG_DAMON_VADDR=y
 CONFIG_DAMON_PADDR=y
 CONFIG_DEBUG_FS=y
 CONFIG_DAMON_DBGFS=y
+CONFIG_DAMON_DBGFS_DEPRECATED=y
 
 CONFIG_REGMAP_BUILD=y
 
index bcf195c64a45c186112c6aa381b62c91a9938050..567491f3e1b51b313439f7b3966da01c2faf1689 100644 (file)
@@ -32,7 +32,7 @@
  */
 #endif
 
-#if defined(__BPF_FEATURE_ARENA_CAST) && !defined(BPF_ARENA_FORCE_ASM)
+#if defined(__BPF_FEATURE_ADDR_SPACE_CAST) && !defined(BPF_ARENA_FORCE_ASM)
 #define __arena __attribute__((address_space(1)))
 #define cast_kern(ptr) /* nop for bpf prog. emitted by LLVM */
 #define cast_user(ptr) /* nop for bpf prog. emitted by LLVM */
index 0766702de84657460995af4b791374c941d5e285..d69fd2465f5367fc2471694f5938a7ab2cf03c47 100644 (file)
@@ -3,12 +3,14 @@
 #include <test_progs.h>
 #include <sys/mman.h>
 #include <network_helpers.h>
-
+#include <sys/user.h>
+#ifndef PAGE_SIZE /* on some archs it comes in sys/user.h */
+#include <unistd.h>
+#define PAGE_SIZE getpagesize()
+#endif
 #include "arena_htab_asm.skel.h"
 #include "arena_htab.skel.h"
 
-#define PAGE_SIZE 4096
-
 #include "bpf_arena_htab.h"
 
 static void test_arena_htab_common(struct htab *htab)
index e61886debab12727a594a0c3f54163bba35e3bea..d15867cddde06ab5c49bfdca8df1c1f69d0931d9 100644 (file)
@@ -3,8 +3,11 @@
 #include <test_progs.h>
 #include <sys/mman.h>
 #include <network_helpers.h>
-
-#define PAGE_SIZE 4096
+#include <sys/user.h>
+#ifndef PAGE_SIZE /* on some archs it comes in sys/user.h */
+#include <unistd.h>
+#define PAGE_SIZE getpagesize()
+#endif
 
 #include "bpf_arena_list.h"
 #include "arena_list.skel.h"
index 053f4d6da77a48f84d86263358c5c329bb6f0beb..cc184e4420f6e35ce9215187c5131f09a32484c7 100644 (file)
@@ -2,6 +2,7 @@
 /* Copyright (c) 2021 Facebook */
 
 #include <sys/syscall.h>
+#include <limits.h>
 #include <test_progs.h>
 #include "bloom_filter_map.skel.h"
 
@@ -21,6 +22,11 @@ static void test_fail_cases(void)
        if (!ASSERT_LT(fd, 0, "bpf_map_create bloom filter invalid value size 0"))
                close(fd);
 
+       /* Invalid value size: too big */
+       fd = bpf_map_create(BPF_MAP_TYPE_BLOOM_FILTER, NULL, 0, INT32_MAX, 100, NULL);
+       if (!ASSERT_LT(fd, 0, "bpf_map_create bloom filter invalid value too large"))
+               close(fd);
+
        /* Invalid max entries size */
        fd = bpf_map_create(BPF_MAP_TYPE_BLOOM_FILTER, NULL, 0, sizeof(value), 0, NULL);
        if (!ASSERT_LT(fd, 0, "bpf_map_create bloom filter invalid max entries size"))
index 985273832f891c291a308d03d35d1469204f9708..c4f9f306646ed3e7918ae484c78bde4aa56d342e 100644 (file)
@@ -5,6 +5,7 @@
 #include "cap_helpers.h"
 #include "verifier_and.skel.h"
 #include "verifier_arena.skel.h"
+#include "verifier_arena_large.skel.h"
 #include "verifier_array_access.skel.h"
 #include "verifier_basic_stack.skel.h"
 #include "verifier_bitfield_write.skel.h"
@@ -120,6 +121,7 @@ static void run_tests_aux(const char *skel_name,
 
 void test_verifier_and(void)                  { RUN(verifier_and); }
 void test_verifier_arena(void)                { RUN(verifier_arena); }
+void test_verifier_arena_large(void)          { RUN(verifier_arena_large); }
 void test_verifier_basic_stack(void)          { RUN(verifier_basic_stack); }
 void test_verifier_bitfield_write(void)       { RUN(verifier_bitfield_write); }
 void test_verifier_bounds(void)               { RUN(verifier_bounds); }
index b7bb712cacfdccb0747286634057a641b6b3f70a..1e6ac187a6a0ced2da5294ac6805a38f81047093 100644 (file)
@@ -22,7 +22,7 @@ int zero = 0;
 SEC("syscall")
 int arena_htab_llvm(void *ctx)
 {
-#if defined(__BPF_FEATURE_ARENA_CAST) || defined(BPF_ARENA_FORCE_ASM)
+#if defined(__BPF_FEATURE_ADDR_SPACE_CAST) || defined(BPF_ARENA_FORCE_ASM)
        struct htab __arena *htab;
        __u64 i;
 
index cd35b844843560db676c19618999a38a50979038..c0422c58cee2c56156bf886dbc50fcfd089c449e 100644 (file)
@@ -30,13 +30,13 @@ int list_sum;
 int cnt;
 bool skip = false;
 
-#ifdef __BPF_FEATURE_ARENA_CAST
+#ifdef __BPF_FEATURE_ADDR_SPACE_CAST
 long __arena arena_sum;
 int __arena test_val = 1;
 struct arena_list_head __arena global_head;
 #else
-long arena_sum SEC(".arena.1");
-int test_val SEC(".arena.1");
+long arena_sum SEC(".addr_space.1");
+int test_val SEC(".addr_space.1");
 #endif
 
 int zero;
@@ -44,7 +44,7 @@ int zero;
 SEC("syscall")
 int arena_list_add(void *ctx)
 {
-#ifdef __BPF_FEATURE_ARENA_CAST
+#ifdef __BPF_FEATURE_ADDR_SPACE_CAST
        __u64 i;
 
        list_head = &global_head;
@@ -66,7 +66,7 @@ int arena_list_add(void *ctx)
 SEC("syscall")
 int arena_list_del(void *ctx)
 {
-#ifdef __BPF_FEATURE_ARENA_CAST
+#ifdef __BPF_FEATURE_ADDR_SPACE_CAST
        struct elem __arena *n;
        int sum = 0;
 
index 5540b05ff9ee13589af00305f4427c8ebac1ced6..93144ae6df74124fb7e7bb27084dc1371483d774 100644 (file)
@@ -12,14 +12,18 @@ struct {
        __uint(type, BPF_MAP_TYPE_ARENA);
        __uint(map_flags, BPF_F_MMAPABLE);
        __uint(max_entries, 2); /* arena of two pages close to 32-bit boundary*/
-       __ulong(map_extra, (1ull << 44) | (~0u - __PAGE_SIZE * 2 + 1)); /* start of mmap() region */
+#ifdef __TARGET_ARCH_arm64
+        __ulong(map_extra, (1ull << 32) | (~0u - __PAGE_SIZE * 2 + 1)); /* start of mmap() region */
+#else
+        __ulong(map_extra, (1ull << 44) | (~0u - __PAGE_SIZE * 2 + 1)); /* start of mmap() region */
+#endif
 } arena SEC(".maps");
 
 SEC("syscall")
 __success __retval(0)
 int basic_alloc1(void *ctx)
 {
-#if defined(__BPF_FEATURE_ARENA_CAST)
+#if defined(__BPF_FEATURE_ADDR_SPACE_CAST)
        volatile int __arena *page1, *page2, *no_page, *page3;
 
        page1 = bpf_arena_alloc_pages(&arena, NULL, 1, NUMA_NO_NODE, 0);
@@ -58,7 +62,7 @@ SEC("syscall")
 __success __retval(0)
 int basic_alloc2(void *ctx)
 {
-#if defined(__BPF_FEATURE_ARENA_CAST)
+#if defined(__BPF_FEATURE_ADDR_SPACE_CAST)
        volatile char __arena *page1, *page2, *page3, *page4;
 
        page1 = bpf_arena_alloc_pages(&arena, NULL, 2, NUMA_NO_NODE, 0);
diff --git a/tools/testing/selftests/bpf/progs/verifier_arena_large.c b/tools/testing/selftests/bpf/progs/verifier_arena_large.c
new file mode 100644 (file)
index 0000000..ef66ea4
--- /dev/null
@@ -0,0 +1,68 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright (c) 2024 Meta Platforms, Inc. and affiliates. */
+
+#include <vmlinux.h>
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_tracing.h>
+#include "bpf_misc.h"
+#include "bpf_experimental.h"
+#include "bpf_arena_common.h"
+
+#define ARENA_SIZE (1ull << 32)
+
+struct {
+       __uint(type, BPF_MAP_TYPE_ARENA);
+       __uint(map_flags, BPF_F_MMAPABLE);
+       __uint(max_entries, ARENA_SIZE / PAGE_SIZE);
+} arena SEC(".maps");
+
+SEC("syscall")
+__success __retval(0)
+int big_alloc1(void *ctx)
+{
+#if defined(__BPF_FEATURE_ADDR_SPACE_CAST)
+       volatile char __arena *page1, *page2, *no_page, *page3;
+       void __arena *base;
+
+       page1 = base = bpf_arena_alloc_pages(&arena, NULL, 1, NUMA_NO_NODE, 0);
+       if (!page1)
+               return 1;
+       *page1 = 1;
+       page2 = bpf_arena_alloc_pages(&arena, base + ARENA_SIZE - PAGE_SIZE,
+                                     1, NUMA_NO_NODE, 0);
+       if (!page2)
+               return 2;
+       *page2 = 2;
+       no_page = bpf_arena_alloc_pages(&arena, base + ARENA_SIZE,
+                                       1, NUMA_NO_NODE, 0);
+       if (no_page)
+               return 3;
+       if (*page1 != 1)
+               return 4;
+       if (*page2 != 2)
+               return 5;
+       bpf_arena_free_pages(&arena, (void __arena *)page1, 1);
+       if (*page2 != 2)
+               return 6;
+       if (*page1 != 0) /* use-after-free should return 0 */
+               return 7;
+       page3 = bpf_arena_alloc_pages(&arena, NULL, 1, NUMA_NO_NODE, 0);
+       if (!page3)
+               return 8;
+       *page3 = 3;
+       if (page1 != page3)
+               return 9;
+       if (*page2 != 2)
+               return 10;
+       if (*(page1 + PAGE_SIZE) != 0)
+               return 11;
+       if (*(page1 - PAGE_SIZE) != 0)
+               return 12;
+       if (*(page2 + PAGE_SIZE) != 0)
+               return 13;
+       if (*(page2 - PAGE_SIZE) != 0)
+               return 14;
+#endif
+       return 0;
+}
+char _license[] SEC("license") = "GPL";
diff --git a/tools/testing/selftests/dmabuf-heaps/config b/tools/testing/selftests/dmabuf-heaps/config
new file mode 100644 (file)
index 0000000..be091f1
--- /dev/null
@@ -0,0 +1,3 @@
+CONFIG_DMABUF_HEAPS=y
+CONFIG_DMABUF_HEAPS_SYSTEM=y
+CONFIG_DRM_VGEM=y
diff --git a/tools/testing/selftests/drivers/net/netdevsim/settings b/tools/testing/selftests/drivers/net/netdevsim/settings
new file mode 100644 (file)
index 0000000..a62d2fa
--- /dev/null
@@ -0,0 +1 @@
+timeout=600
index a0b8688b0836941e0f8895f0477ea8da78a04f51..fb4472ddffd81bda3097619ad86d50d4cef6eb9e 100644 (file)
@@ -19,8 +19,8 @@ include ../lib.mk
 
 $(OUTPUT)/subdir:
        mkdir -p $@
-$(OUTPUT)/script:
-       echo '#!/bin/sh' > $@
+$(OUTPUT)/script: Makefile
+       echo '#!/bin/bash' > $@
        echo 'exit $$*' >> $@
        chmod +x $@
 $(OUTPUT)/execveat.symlink: $(OUTPUT)/execveat
index 05f94a741c7aa05841940b030aebb93f325f8214..2c575a2c0eab4124ba5d508bd7a132d7fc39d5e9 100755 (executable)
@@ -16,6 +16,8 @@ SIZE=256
 NAME_MAX=int(subprocess.check_output(["getconf", "NAME_MAX", "."]))
 
 test_num=0
+pass_num=0
+fail_num=0
 
 code='''#!/usr/bin/perl
 print "Executed interpreter! Args:\n";
@@ -42,7 +44,7 @@ foreach my $a (@ARGV) {
 # ...
 def test(name, size, good=True, leading="", root="./", target="/perl",
                      fill="A", arg="", newline="\n", hashbang="#!"):
-    global test_num, tests, NAME_MAX
+    global test_num, pass_num, fail_num, tests, NAME_MAX
     test_num += 1
     if test_num > tests:
         raise ValueError("more binfmt_script tests than expected! (want %d, expected %d)"
@@ -80,16 +82,20 @@ def test(name, size, good=True, leading="", root="./", target="/perl",
         if good:
             print("ok %d - binfmt_script %s (successful good exec)"
                   % (test_num, name))
+            pass_num += 1
         else:
             print("not ok %d - binfmt_script %s succeeded when it should have failed"
                   % (test_num, name))
+            fail_num = 1
     else:
         if good:
             print("not ok %d - binfmt_script %s failed when it should have succeeded (rc:%d)"
                   % (test_num, name, proc.returncode))
+            fail_num = 1
         else:
             print("ok %d - binfmt_script %s (correctly failed bad exec)"
                   % (test_num, name))
+            pass_num += 1
 
     # Clean up crazy binaries
     os.unlink(script)
@@ -166,6 +172,8 @@ test(name="two-under-trunc-arg", size=int(SIZE/2), arg=" ")
 test(name="two-under-leading",   size=int(SIZE/2), leading=" ")
 test(name="two-under-lead-trunc-arg", size=int(SIZE/2), leading=" ", arg=" ")
 
+print("# Totals: pass:%d fail:%d xfail:0 xpass:0 skip:0 error:0" % (pass_num, fail_num))
+
 if test_num != tests:
     raise ValueError("fewer binfmt_script tests than expected! (ran %d, expected %d"
                      % (test_num, tests))
index 0546ca24f2b20ceb7ee9deb26b80fc637c7a2ada..6418ded40bdddc7efa95c047d848359709f1ee70 100644 (file)
@@ -98,10 +98,9 @@ static int check_execveat_invoked_rc(int fd, const char *path, int flags,
        if (child == 0) {
                /* Child: do execveat(). */
                rc = execveat_(fd, path, argv, envp, flags);
-               ksft_print_msg("execveat() failed, rc=%d errno=%d (%s)\n",
+               ksft_print_msg("child execveat() failed, rc=%d errno=%d (%s)\n",
                               rc, errno, strerror(errno));
-               ksft_test_result_fail("%s\n", test_name);
-               exit(1);  /* should not reach here */
+               exit(errno);
        }
        /* Parent: wait for & check child's exit status. */
        rc = waitpid(child, &status, 0);
@@ -226,11 +225,14 @@ static int check_execveat_pathmax(int root_dfd, const char *src, int is_script)
         * "If the command name is found, but it is not an executable utility,
         * the exit status shall be 126."), so allow either.
         */
-       if (is_script)
+       if (is_script) {
+               ksft_print_msg("Invoke script via root_dfd and relative filename\n");
                fail += check_execveat_invoked_rc(root_dfd, longpath + 1, 0,
                                                  127, 126);
-       else
+       } else {
+               ksft_print_msg("Invoke exec via root_dfd and relative filename\n");
                fail += check_execveat(root_dfd, longpath + 1, 0);
+       }
 
        return fail;
 }
index d487c2f6a61509f6c4feb7930272c33f88d80239..17e3207d34ae7e74779964a44d62c8763d44a087 100644 (file)
@@ -5,6 +5,7 @@
 #include <link.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include "../kselftest.h"
 
 struct Statistics {
        unsigned long long load_address;
@@ -41,28 +42,23 @@ int main(int argc, char **argv)
        unsigned long long misalign;
        int ret;
 
+       ksft_print_header();
+       ksft_set_plan(1);
+
        ret = dl_iterate_phdr(ExtractStatistics, &extracted);
-       if (ret != 1) {
-               fprintf(stderr, "FAILED\n");
-               return 1;
-       }
+       if (ret != 1)
+               ksft_exit_fail_msg("FAILED: dl_iterate_phdr\n");
 
-       if (extracted.alignment == 0) {
-               fprintf(stderr, "No alignment found\n");
-               return 1;
-       } else if (extracted.alignment & (extracted.alignment - 1)) {
-               fprintf(stderr, "Alignment is not a power of 2\n");
-               return 1;
-       }
+       if (extracted.alignment == 0)
+               ksft_exit_fail_msg("FAILED: No alignment found\n");
+       else if (extracted.alignment & (extracted.alignment - 1))
+               ksft_exit_fail_msg("FAILED: Alignment is not a power of 2\n");
 
        misalign = extracted.load_address & (extracted.alignment - 1);
-       if (misalign) {
-               printf("alignment = %llu, load_address = %llu\n",
-                       extracted.alignment, extracted.load_address);
-               fprintf(stderr, "FAILED\n");
-               return 1;
-       }
+       if (misalign)
+               ksft_exit_fail_msg("FAILED: alignment = %llu, load_address = %llu\n",
+                                  extracted.alignment, extracted.load_address);
 
-       fprintf(stderr, "PASS\n");
-       return 0;
+       ksft_test_result_pass("Completed\n");
+       ksft_finished();
 }
index 2dbd5bc45b3ed0fb095214d395e0132ca3c76a62..b2f37d86a5f623b1a8e91af7b42bfc6db79af34b 100644 (file)
 #include <fcntl.h>
 #include <sys/mount.h>
 #include <unistd.h>
+#include "../kselftest.h"
 
 int main(void)
 {
+       int fd, rv;
+
+       ksft_print_header();
+       ksft_set_plan(1);
+
        if (unshare(CLONE_NEWNS) == -1) {
                if (errno == ENOSYS || errno == EPERM) {
-                       fprintf(stderr, "error: unshare, errno %d\n", errno);
-                       return 4;
+                       ksft_test_result_skip("error: unshare, errno %d\n", errno);
+                       ksft_finished();
                }
-               fprintf(stderr, "error: unshare, errno %d\n", errno);
-               return 1;
-       }
-       if (mount(NULL, "/", NULL, MS_PRIVATE|MS_REC, NULL) == -1) {
-               fprintf(stderr, "error: mount '/', errno %d\n", errno);
-               return 1;
+               ksft_exit_fail_msg("error: unshare, errno %d\n", errno);
        }
+
+       if (mount(NULL, "/", NULL, MS_PRIVATE | MS_REC, NULL) == -1)
+               ksft_exit_fail_msg("error: mount '/', errno %d\n", errno);
+
        /* Require "exec" filesystem. */
-       if (mount(NULL, "/tmp", "ramfs", 0, NULL) == -1) {
-               fprintf(stderr, "error: mount ramfs, errno %d\n", errno);
-               return 1;
-       }
+       if (mount(NULL, "/tmp", "ramfs", 0, NULL) == -1)
+               ksft_exit_fail_msg("error: mount ramfs, errno %d\n", errno);
 
 #define FILENAME "/tmp/1"
 
-       int fd = creat(FILENAME, 0700);
-       if (fd == -1) {
-               fprintf(stderr, "error: creat, errno %d\n", errno);
-               return 1;
-       }
+       fd = creat(FILENAME, 0700);
+       if (fd == -1)
+               ksft_exit_fail_msg("error: creat, errno %d\n", errno);
+
 #define S "#!" FILENAME "\n"
-       if (write(fd, S, strlen(S)) != strlen(S)) {
-               fprintf(stderr, "error: write, errno %d\n", errno);
-               return 1;
-       }
+       if (write(fd, S, strlen(S)) != strlen(S))
+               ksft_exit_fail_msg("error: write, errno %d\n", errno);
+
        close(fd);
 
-       int rv = execve(FILENAME, NULL, NULL);
-       if (rv == -1 && errno == ELOOP) {
-               return 0;
-       }
-       fprintf(stderr, "error: execve, rv %d, errno %d\n", rv, errno);
-       return 1;
+       rv = execve(FILENAME, NULL, NULL);
+       ksft_test_result(rv == -1 && errno == ELOOP,
+                        "execve failed as expected (ret %d, errno %d)\n", rv, errno);
+       ksft_finished();
 }
index 2de7c61d1ae308d06251bd9d072627e4120d37ce..3f74c09c56b62465189346e6a56f2525cb97bd6b 100644 (file)
@@ -24,7 +24,7 @@ echo 0 > events/enable
 echo "Get the most frequently calling function"
 sample_events
 
-target_func=`cut -d: -f3 trace | sed 's/call_site=\([^+]*\)+0x.*/\1/' | sort | uniq -c | sort | tail -n 1 | sed 's/^[ 0-9]*//'`
+target_func=`cat trace | grep -o 'call_site=\([^+]*\)' | sed 's/call_site=//' | sort | uniq -c | sort | tail -n 1 | sed 's/^[ 0-9]*//'`
 if [ -z "$target_func" ]; then
     exit_fail
 fi
index cbe99594d319b4156da2c48a09001d0f06e7a36f..18a49c70d4c6354baac96073bc99446ad70b0b85 100644 (file)
@@ -203,7 +203,7 @@ int main(int argc, char **argv)
        ksft_print_header();
        ksft_set_plan(nthreads);
 
-       filed = open(file, O_RDWR|O_CREAT);
+       filed = open(file, O_RDWR|O_CREAT, 0664);
        if (filed < 0)
                ksft_exit_fail_msg("Unable to open %s: %s\n", file, strerror(errno));
 
index f822ae31af22e20103900084f71e280e182a310a..374a308174d2ba7c17f496a4c94364e34815e355 100644 (file)
@@ -1745,9 +1745,12 @@ void pkey_setup_shadow(void)
        shadow_pkey_reg = __read_pkey_reg();
 }
 
+pid_t parent_pid;
+
 void restore_settings_atexit(void)
 {
-       cat_into_file(buf, "/proc/sys/vm/nr_hugepages");
+       if (parent_pid == getpid())
+               cat_into_file(buf, "/proc/sys/vm/nr_hugepages");
 }
 
 void save_settings(void)
@@ -1773,6 +1776,7 @@ void save_settings(void)
                exit(__LINE__);
        }
 
+       parent_pid = getpid();
        atexit(restore_settings_atexit);
        close(fd);
 }
index cc5f144430d4d246fa5dfd09445b6ecc78f46a81..7dbfa53d93a05f504ea4c1019bce92677cec136d 100644 (file)
@@ -137,7 +137,7 @@ static void test_mprotect(int pagemap_fd, int pagesize, bool anon)
                if (!map)
                        ksft_exit_fail_msg("anon mmap failed\n");
        } else {
-               test_fd = open(fname, O_RDWR | O_CREAT);
+               test_fd = open(fname, O_RDWR | O_CREAT, 0664);
                if (test_fd < 0) {
                        ksft_test_result_skip("Test %s open() file failed\n", __func__);
                        return;
index 856662d2f87a1b0db004c3e4297d3e5697424d62..6c988bd2f335677b9b87af1594407e63f907e542 100644 (file)
@@ -223,7 +223,7 @@ void split_file_backed_thp(void)
                ksft_exit_fail_msg("Fail to create file-backed THP split testing file\n");
        }
 
-       fd = open(testfile, O_CREAT|O_WRONLY);
+       fd = open(testfile, O_CREAT|O_WRONLY, 0664);
        if (fd == -1) {
                ksft_perror("Cannot open testing file");
                goto cleanup;
index b0ac0ec2356d6533c55662949a0cd40ebe0a9c8d..7ad6ba660c7d6f1f5762d0b231b92b05e971a3c5 100644 (file)
@@ -18,6 +18,7 @@ bool test_uffdio_wp = true;
 unsigned long long *count_verify;
 uffd_test_ops_t *uffd_test_ops;
 uffd_test_case_ops_t *uffd_test_case_ops;
+atomic_bool ready_for_fork;
 
 static int uffd_mem_fd_create(off_t mem_size, bool hugetlb)
 {
@@ -518,6 +519,8 @@ void *uffd_poll_thread(void *arg)
        pollfd[1].fd = pipefd[cpu*2];
        pollfd[1].events = POLLIN;
 
+       ready_for_fork = true;
+
        for (;;) {
                ret = poll(pollfd, 2, -1);
                if (ret <= 0) {
index cb055282c89c966e93804478a2d47513939375a8..cc5629c3d2aa1057b9718ea5cbe3ef469b222877 100644 (file)
@@ -32,6 +32,7 @@
 #include <inttypes.h>
 #include <stdint.h>
 #include <sys/random.h>
+#include <stdatomic.h>
 
 #include "../kselftest.h"
 #include "vm_util.h"
@@ -103,6 +104,7 @@ extern bool map_shared;
 extern bool test_uffdio_wp;
 extern unsigned long long *count_verify;
 extern volatile bool test_uffdio_copy_eexist;
+extern atomic_bool ready_for_fork;
 
 extern uffd_test_ops_t anon_uffd_test_ops;
 extern uffd_test_ops_t shmem_uffd_test_ops;
index 2b9f8cc52639d1942238b41a1ad55edc6bd406ed..21ec23206ab44a0ed036cec25e2c79a461c83020 100644 (file)
@@ -775,6 +775,8 @@ static void uffd_sigbus_test_common(bool wp)
        char c;
        struct uffd_args args = { 0 };
 
+       ready_for_fork = false;
+
        fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK);
 
        if (uffd_register(uffd, area_dst, nr_pages * page_size,
@@ -790,6 +792,9 @@ static void uffd_sigbus_test_common(bool wp)
        if (pthread_create(&uffd_mon, NULL, uffd_poll_thread, &args))
                err("uffd_poll_thread create");
 
+       while (!ready_for_fork)
+               ; /* Wait for the poll_thread to start executing before forking */
+
        pid = fork();
        if (pid < 0)
                err("fork");
@@ -829,6 +834,8 @@ static void uffd_events_test_common(bool wp)
        char c;
        struct uffd_args args = { 0 };
 
+       ready_for_fork = false;
+
        fcntl(uffd, F_SETFL, uffd_flags | O_NONBLOCK);
        if (uffd_register(uffd, area_dst, nr_pages * page_size,
                          true, wp, false))
@@ -838,6 +845,9 @@ static void uffd_events_test_common(bool wp)
        if (pthread_create(&uffd_mon, NULL, uffd_poll_thread, &args))
                err("uffd_poll_thread create");
 
+       while (!ready_for_fork)
+               ; /* Wait for the poll_thread to start executing before forking */
+
        pid = fork();
        if (pid < 0)
                err("fork");
@@ -1427,7 +1437,8 @@ uffd_test_case_t uffd_tests[] = {
                .uffd_fn = uffd_sigbus_wp_test,
                .mem_targets = MEM_ALL,
                .uffd_feature_required = UFFD_FEATURE_SIGBUS |
-               UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP,
+               UFFD_FEATURE_EVENT_FORK | UFFD_FEATURE_PAGEFAULT_FLAG_WP |
+               UFFD_FEATURE_WP_HUGETLBFS_SHMEM,
        },
        {
                .name = "events",
index 74ff9fb2a6f0e1c2e266a3a499501a6b05fa6905..58da5de99ac451370cd60d08a0319d5927fb8831 100755 (executable)
@@ -1177,6 +1177,7 @@ encap_params_common()
        local plen=$1; shift
        local enc_ethtype=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local src=$1; shift
        local mz=$1; shift
 
@@ -1195,11 +1196,11 @@ encap_params_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent dst $vtep2_ip src_vni 10020"
 
        run_cmd "tc -n $ns2 filter replace dev vx0 ingress pref 1 handle 101 proto all flower enc_dst_ip $vtep1_ip action pass"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Destination IP - match"
 
-       run_cmd "ip netns exec $ns1 $mz br0.20 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.20 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Destination IP - no match"
 
@@ -1212,20 +1213,20 @@ encap_params_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent dst $vtep1_ip dst_port 1111 src_vni 10020"
 
        run_cmd "tc -n $ns2 filter replace dev veth0 ingress pref 1 handle 101 proto $enc_ethtype flower ip_proto udp dst_port 4789 action pass"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev veth0 ingress" 101 1
        log_test $? 0 "Default destination port - match"
 
-       run_cmd "ip netns exec $ns1 $mz br0.20 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.20 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev veth0 ingress" 101 1
        log_test $? 0 "Default destination port - no match"
 
        run_cmd "tc -n $ns2 filter replace dev veth0 ingress pref 1 handle 101 proto $enc_ethtype flower ip_proto udp dst_port 1111 action pass"
-       run_cmd "ip netns exec $ns1 $mz br0.20 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.20 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev veth0 ingress" 101 1
        log_test $? 0 "Non-default destination port - match"
 
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev veth0 ingress" 101 1
        log_test $? 0 "Non-default destination port - no match"
 
@@ -1238,11 +1239,11 @@ encap_params_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent dst $vtep1_ip src_vni 10020"
 
        run_cmd "tc -n $ns2 filter replace dev vx0 ingress pref 1 handle 101 proto all flower enc_key_id 10010 action pass"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Default destination VNI - match"
 
-       run_cmd "ip netns exec $ns1 $mz br0.20 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.20 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Default destination VNI - no match"
 
@@ -1250,11 +1251,11 @@ encap_params_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent dst $vtep1_ip vni 10010 src_vni 10020"
 
        run_cmd "tc -n $ns2 filter replace dev vx0 ingress pref 1 handle 101 proto all flower enc_key_id 10020 action pass"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Non-default destination VNI - match"
 
-       run_cmd "ip netns exec $ns1 $mz br0.20 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.20 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Non-default destination VNI - no match"
 
@@ -1272,6 +1273,7 @@ encap_params_ipv4_ipv4()
        local plen=32
        local enc_ethtype="ip"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
@@ -1279,7 +1281,7 @@ encap_params_ipv4_ipv4()
        echo "------------------------------------------------------------------"
 
        encap_params_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $enc_ethtype \
-               $grp $src "mausezahn"
+               $grp $grp_dmac $src "mausezahn"
 }
 
 encap_params_ipv6_ipv4()
@@ -1291,6 +1293,7 @@ encap_params_ipv6_ipv4()
        local plen=32
        local enc_ethtype="ip"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
@@ -1298,7 +1301,7 @@ encap_params_ipv6_ipv4()
        echo "------------------------------------------------------------------"
 
        encap_params_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $enc_ethtype \
-               $grp $src "mausezahn -6"
+               $grp $grp_dmac $src "mausezahn -6"
 }
 
 encap_params_ipv4_ipv6()
@@ -1310,6 +1313,7 @@ encap_params_ipv4_ipv6()
        local plen=128
        local enc_ethtype="ipv6"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
@@ -1317,7 +1321,7 @@ encap_params_ipv4_ipv6()
        echo "------------------------------------------------------------------"
 
        encap_params_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $enc_ethtype \
-               $grp $src "mausezahn"
+               $grp $grp_dmac $src "mausezahn"
 }
 
 encap_params_ipv6_ipv6()
@@ -1329,6 +1333,7 @@ encap_params_ipv6_ipv6()
        local plen=128
        local enc_ethtype="ipv6"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
@@ -1336,7 +1341,7 @@ encap_params_ipv6_ipv6()
        echo "------------------------------------------------------------------"
 
        encap_params_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $enc_ethtype \
-               $grp $src "mausezahn -6"
+               $grp $grp_dmac $src "mausezahn -6"
 }
 
 starg_exclude_ir_common()
@@ -1347,6 +1352,7 @@ starg_exclude_ir_common()
        local vtep2_ip=$1; shift
        local plen=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local valid_src=$1; shift
        local invalid_src=$1; shift
        local mz=$1; shift
@@ -1368,14 +1374,14 @@ starg_exclude_ir_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent filter_mode exclude source_list $invalid_src dst $vtep2_ip src_vni 10010"
 
        # Check that invalid source is not forwarded to any VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 0
        log_test $? 0 "Block excluded source - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 0
        log_test $? 0 "Block excluded source - second VTEP"
 
        # Check that valid source is forwarded to both VTEPs.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Forward valid source - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -1385,14 +1391,14 @@ starg_exclude_ir_common()
        run_cmd "bridge -n $ns1 mdb del dev vx0 port vx0 grp $grp dst $vtep2_ip src_vni 10010"
 
        # Check that invalid source is not forwarded to any VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Block excluded source after removal - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
        log_test $? 0 "Block excluded source after removal - second VTEP"
 
        # Check that valid source is forwarded to the remaining VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 2
        log_test $? 0 "Forward valid source after removal - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -1407,6 +1413,7 @@ starg_exclude_ir_ipv4_ipv4()
        local vtep2_ip=198.51.100.200
        local plen=32
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1415,7 +1422,7 @@ starg_exclude_ir_ipv4_ipv4()
        echo "-------------------------------------------------------------"
 
        starg_exclude_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn"
+               $grp_dmac $valid_src $invalid_src "mausezahn"
 }
 
 starg_exclude_ir_ipv6_ipv4()
@@ -1426,6 +1433,7 @@ starg_exclude_ir_ipv6_ipv4()
        local vtep2_ip=198.51.100.200
        local plen=32
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1434,7 +1442,7 @@ starg_exclude_ir_ipv6_ipv4()
        echo "-------------------------------------------------------------"
 
        starg_exclude_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn -6"
+               $grp_dmac $valid_src $invalid_src "mausezahn -6"
 }
 
 starg_exclude_ir_ipv4_ipv6()
@@ -1445,6 +1453,7 @@ starg_exclude_ir_ipv4_ipv6()
        local vtep2_ip=2001:db8:2000::1
        local plen=128
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1453,7 +1462,7 @@ starg_exclude_ir_ipv4_ipv6()
        echo "-------------------------------------------------------------"
 
        starg_exclude_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn"
+               $grp_dmac $valid_src $invalid_src "mausezahn"
 }
 
 starg_exclude_ir_ipv6_ipv6()
@@ -1464,6 +1473,7 @@ starg_exclude_ir_ipv6_ipv6()
        local vtep2_ip=2001:db8:2000::1
        local plen=128
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1472,7 +1482,7 @@ starg_exclude_ir_ipv6_ipv6()
        echo "-------------------------------------------------------------"
 
        starg_exclude_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn -6"
+               $grp_dmac $valid_src $invalid_src "mausezahn -6"
 }
 
 starg_include_ir_common()
@@ -1483,6 +1493,7 @@ starg_include_ir_common()
        local vtep2_ip=$1; shift
        local plen=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local valid_src=$1; shift
        local invalid_src=$1; shift
        local mz=$1; shift
@@ -1504,14 +1515,14 @@ starg_include_ir_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent filter_mode include source_list $valid_src dst $vtep2_ip src_vni 10010"
 
        # Check that invalid source is not forwarded to any VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 0
        log_test $? 0 "Block excluded source - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 0
        log_test $? 0 "Block excluded source - second VTEP"
 
        # Check that valid source is forwarded to both VTEPs.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Forward valid source - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -1521,14 +1532,14 @@ starg_include_ir_common()
        run_cmd "bridge -n $ns1 mdb del dev vx0 port vx0 grp $grp dst $vtep2_ip src_vni 10010"
 
        # Check that invalid source is not forwarded to any VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Block excluded source after removal - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
        log_test $? 0 "Block excluded source after removal - second VTEP"
 
        # Check that valid source is forwarded to the remaining VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 2
        log_test $? 0 "Forward valid source after removal - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -1543,6 +1554,7 @@ starg_include_ir_ipv4_ipv4()
        local vtep2_ip=198.51.100.200
        local plen=32
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1551,7 +1563,7 @@ starg_include_ir_ipv4_ipv4()
        echo "-------------------------------------------------------------"
 
        starg_include_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn"
+               $grp_dmac $valid_src $invalid_src "mausezahn"
 }
 
 starg_include_ir_ipv6_ipv4()
@@ -1562,6 +1574,7 @@ starg_include_ir_ipv6_ipv4()
        local vtep2_ip=198.51.100.200
        local plen=32
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1570,7 +1583,7 @@ starg_include_ir_ipv6_ipv4()
        echo "-------------------------------------------------------------"
 
        starg_include_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn -6"
+               $grp_dmac $valid_src $invalid_src "mausezahn -6"
 }
 
 starg_include_ir_ipv4_ipv6()
@@ -1581,6 +1594,7 @@ starg_include_ir_ipv4_ipv6()
        local vtep2_ip=2001:db8:2000::1
        local plen=128
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1589,7 +1603,7 @@ starg_include_ir_ipv4_ipv6()
        echo "-------------------------------------------------------------"
 
        starg_include_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn"
+               $grp_dmac $valid_src $invalid_src "mausezahn"
 }
 
 starg_include_ir_ipv6_ipv6()
@@ -1600,6 +1614,7 @@ starg_include_ir_ipv6_ipv6()
        local vtep2_ip=2001:db8:2000::1
        local plen=128
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1608,7 +1623,7 @@ starg_include_ir_ipv6_ipv6()
        echo "-------------------------------------------------------------"
 
        starg_include_ir_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $grp \
-               $valid_src $invalid_src "mausezahn -6"
+               $grp_dmac $valid_src $invalid_src "mausezahn -6"
 }
 
 starg_exclude_p2mp_common()
@@ -1618,6 +1633,7 @@ starg_exclude_p2mp_common()
        local mcast_grp=$1; shift
        local plen=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local valid_src=$1; shift
        local invalid_src=$1; shift
        local mz=$1; shift
@@ -1635,12 +1651,12 @@ starg_exclude_p2mp_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent filter_mode exclude source_list $invalid_src dst $mcast_grp src_vni 10010 via veth0"
 
        # Check that invalid source is not forwarded.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 0
        log_test $? 0 "Block excluded source"
 
        # Check that valid source is forwarded.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Forward valid source"
 
@@ -1648,7 +1664,7 @@ starg_exclude_p2mp_common()
        run_cmd "ip -n $ns2 address del $mcast_grp/$plen dev veth0"
 
        # Check that valid source is not received anymore.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Receive of valid source after removal from group"
 }
@@ -1660,6 +1676,7 @@ starg_exclude_p2mp_ipv4_ipv4()
        local mcast_grp=238.1.1.1
        local plen=32
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1667,7 +1684,7 @@ starg_exclude_p2mp_ipv4_ipv4()
        echo "Data path: (*, G) EXCLUDE - P2MP - IPv4 overlay / IPv4 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn"
 }
 
@@ -1678,6 +1695,7 @@ starg_exclude_p2mp_ipv6_ipv4()
        local mcast_grp=238.1.1.1
        local plen=32
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1685,7 +1703,7 @@ starg_exclude_p2mp_ipv6_ipv4()
        echo "Data path: (*, G) EXCLUDE - P2MP - IPv6 overlay / IPv4 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn -6"
 }
 
@@ -1696,6 +1714,7 @@ starg_exclude_p2mp_ipv4_ipv6()
        local mcast_grp=ff0e::2
        local plen=128
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1703,7 +1722,7 @@ starg_exclude_p2mp_ipv4_ipv6()
        echo "Data path: (*, G) EXCLUDE - P2MP - IPv4 overlay / IPv6 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn"
 }
 
@@ -1714,6 +1733,7 @@ starg_exclude_p2mp_ipv6_ipv6()
        local mcast_grp=ff0e::2
        local plen=128
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1721,7 +1741,7 @@ starg_exclude_p2mp_ipv6_ipv6()
        echo "Data path: (*, G) EXCLUDE - P2MP - IPv6 overlay / IPv6 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_exclude_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn -6"
 }
 
@@ -1732,6 +1752,7 @@ starg_include_p2mp_common()
        local mcast_grp=$1; shift
        local plen=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local valid_src=$1; shift
        local invalid_src=$1; shift
        local mz=$1; shift
@@ -1749,12 +1770,12 @@ starg_include_p2mp_common()
        run_cmd "bridge -n $ns1 mdb replace dev vx0 port vx0 grp $grp permanent filter_mode include source_list $valid_src dst $mcast_grp src_vni 10010 via veth0"
 
        # Check that invalid source is not forwarded.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $invalid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 0
        log_test $? 0 "Block excluded source"
 
        # Check that valid source is forwarded.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Forward valid source"
 
@@ -1762,7 +1783,7 @@ starg_include_p2mp_common()
        run_cmd "ip -n $ns2 address del $mcast_grp/$plen dev veth0"
 
        # Check that valid source is not received anymore.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $valid_src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Receive of valid source after removal from group"
 }
@@ -1774,6 +1795,7 @@ starg_include_p2mp_ipv4_ipv4()
        local mcast_grp=238.1.1.1
        local plen=32
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1781,7 +1803,7 @@ starg_include_p2mp_ipv4_ipv4()
        echo "Data path: (*, G) INCLUDE - P2MP - IPv4 overlay / IPv4 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn"
 }
 
@@ -1792,6 +1814,7 @@ starg_include_p2mp_ipv6_ipv4()
        local mcast_grp=238.1.1.1
        local plen=32
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1799,7 +1822,7 @@ starg_include_p2mp_ipv6_ipv4()
        echo "Data path: (*, G) INCLUDE - P2MP - IPv6 overlay / IPv4 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn -6"
 }
 
@@ -1810,6 +1833,7 @@ starg_include_p2mp_ipv4_ipv6()
        local mcast_grp=ff0e::2
        local plen=128
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local valid_src=192.0.2.129
        local invalid_src=192.0.2.145
 
@@ -1817,7 +1841,7 @@ starg_include_p2mp_ipv4_ipv6()
        echo "Data path: (*, G) INCLUDE - P2MP - IPv4 overlay / IPv6 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn"
 }
 
@@ -1828,6 +1852,7 @@ starg_include_p2mp_ipv6_ipv6()
        local mcast_grp=ff0e::2
        local plen=128
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local valid_src=2001:db8:100::1
        local invalid_src=2001:db8:200::1
 
@@ -1835,7 +1860,7 @@ starg_include_p2mp_ipv6_ipv6()
        echo "Data path: (*, G) INCLUDE - P2MP - IPv6 overlay / IPv6 underlay"
        echo "---------------------------------------------------------------"
 
-       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp \
+       starg_include_p2mp_common $ns1 $ns2 $mcast_grp $plen $grp $grp_dmac \
                $valid_src $invalid_src "mausezahn -6"
 }
 
@@ -1847,6 +1872,7 @@ egress_vni_translation_common()
        local plen=$1; shift
        local proto=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local src=$1; shift
        local mz=$1; shift
 
@@ -1882,20 +1908,20 @@ egress_vni_translation_common()
        # Make sure that packets sent from the first VTEP over VLAN 10 are
        # received by the SVI corresponding to the L3VNI (14000 / VLAN 4000) on
        # the second VTEP, since it is configured as PVID.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev br0.4000 ingress" 101 1
        log_test $? 0 "Egress VNI translation - PVID configured"
 
        # Remove PVID flag from VLAN 4000 on the second VTEP and make sure
        # packets are no longer received by the SVI interface.
        run_cmd "bridge -n $ns2 vlan add vid 4000 dev vx0"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev br0.4000 ingress" 101 1
        log_test $? 0 "Egress VNI translation - no PVID configured"
 
        # Reconfigure the PVID and make sure packets are received again.
        run_cmd "bridge -n $ns2 vlan add vid 4000 dev vx0 pvid"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev br0.4000 ingress" 101 2
        log_test $? 0 "Egress VNI translation - PVID reconfigured"
 }
@@ -1908,6 +1934,7 @@ egress_vni_translation_ipv4_ipv4()
        local plen=32
        local proto="ipv4"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
@@ -1915,7 +1942,7 @@ egress_vni_translation_ipv4_ipv4()
        echo "----------------------------------------------------------------"
 
        egress_vni_translation_common $ns1 $ns2 $mcast_grp $plen $proto $grp \
-               $src "mausezahn"
+               $grp_dmac $src "mausezahn"
 }
 
 egress_vni_translation_ipv6_ipv4()
@@ -1926,6 +1953,7 @@ egress_vni_translation_ipv6_ipv4()
        local plen=32
        local proto="ipv6"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
@@ -1933,7 +1961,7 @@ egress_vni_translation_ipv6_ipv4()
        echo "----------------------------------------------------------------"
 
        egress_vni_translation_common $ns1 $ns2 $mcast_grp $plen $proto $grp \
-               $src "mausezahn -6"
+               $grp_dmac $src "mausezahn -6"
 }
 
 egress_vni_translation_ipv4_ipv6()
@@ -1944,6 +1972,7 @@ egress_vni_translation_ipv4_ipv6()
        local plen=128
        local proto="ipv4"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
@@ -1951,7 +1980,7 @@ egress_vni_translation_ipv4_ipv6()
        echo "----------------------------------------------------------------"
 
        egress_vni_translation_common $ns1 $ns2 $mcast_grp $plen $proto $grp \
-               $src "mausezahn"
+               $grp_dmac $src "mausezahn"
 }
 
 egress_vni_translation_ipv6_ipv6()
@@ -1962,6 +1991,7 @@ egress_vni_translation_ipv6_ipv6()
        local plen=128
        local proto="ipv6"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
@@ -1969,7 +1999,7 @@ egress_vni_translation_ipv6_ipv6()
        echo "----------------------------------------------------------------"
 
        egress_vni_translation_common $ns1 $ns2 $mcast_grp $plen $proto $grp \
-               $src "mausezahn -6"
+               $grp_dmac $src "mausezahn -6"
 }
 
 all_zeros_mdb_common()
@@ -1982,12 +2012,18 @@ all_zeros_mdb_common()
        local vtep4_ip=$1; shift
        local plen=$1; shift
        local ipv4_grp=239.1.1.1
+       local ipv4_grp_dmac=01:00:5e:01:01:01
        local ipv4_unreg_grp=239.2.2.2
+       local ipv4_unreg_grp_dmac=01:00:5e:02:02:02
        local ipv4_ll_grp=224.0.0.100
+       local ipv4_ll_grp_dmac=01:00:5e:00:00:64
        local ipv4_src=192.0.2.129
        local ipv6_grp=ff0e::1
+       local ipv6_grp_dmac=33:33:00:00:00:01
        local ipv6_unreg_grp=ff0e::2
+       local ipv6_unreg_grp_dmac=33:33:00:00:00:02
        local ipv6_ll_grp=ff02::1
+       local ipv6_ll_grp_dmac=33:33:00:00:00:01
        local ipv6_src=2001:db8:100::1
 
        # Install all-zeros (catchall) MDB entries for IPv4 and IPv6 traffic
@@ -2023,7 +2059,7 @@ all_zeros_mdb_common()
 
        # Send registered IPv4 multicast and make sure it only arrives to the
        # first VTEP.
-       run_cmd "ip netns exec $ns1 mausezahn br0.10 -A $ipv4_src -B $ipv4_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn br0.10 -a own -b $ipv4_grp_dmac -A $ipv4_src -B $ipv4_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "Registered IPv4 multicast - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 0
@@ -2031,7 +2067,7 @@ all_zeros_mdb_common()
 
        # Send unregistered IPv4 multicast that is not link-local and make sure
        # it arrives to the first and second VTEPs.
-       run_cmd "ip netns exec $ns1 mausezahn br0.10 -A $ipv4_src -B $ipv4_unreg_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn br0.10 -a own -b $ipv4_unreg_grp_dmac -A $ipv4_src -B $ipv4_unreg_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 2
        log_test $? 0 "Unregistered IPv4 multicast - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -2039,7 +2075,7 @@ all_zeros_mdb_common()
 
        # Send IPv4 link-local multicast traffic and make sure it does not
        # arrive to any VTEP.
-       run_cmd "ip netns exec $ns1 mausezahn br0.10 -A $ipv4_src -B $ipv4_ll_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn br0.10 -a own -b $ipv4_ll_grp_dmac -A $ipv4_src -B $ipv4_ll_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 2
        log_test $? 0 "Link-local IPv4 multicast - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 1
@@ -2074,7 +2110,7 @@ all_zeros_mdb_common()
 
        # Send registered IPv6 multicast and make sure it only arrives to the
        # third VTEP.
-       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -A $ipv6_src -B $ipv6_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -a own -b $ipv6_grp_dmac -A $ipv6_src -B $ipv6_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 103 1
        log_test $? 0 "Registered IPv6 multicast - third VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 104 0
@@ -2082,7 +2118,7 @@ all_zeros_mdb_common()
 
        # Send unregistered IPv6 multicast that is not link-local and make sure
        # it arrives to the third and fourth VTEPs.
-       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -A $ipv6_src -B $ipv6_unreg_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -a own -b $ipv6_unreg_grp_dmac -A $ipv6_src -B $ipv6_unreg_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 103 2
        log_test $? 0 "Unregistered IPv6 multicast - third VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 104 1
@@ -2090,7 +2126,7 @@ all_zeros_mdb_common()
 
        # Send IPv6 link-local multicast traffic and make sure it does not
        # arrive to any VTEP.
-       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -A $ipv6_src -B $ipv6_ll_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 mausezahn -6 br0.10 -a own -b $ipv6_ll_grp_dmac -A $ipv6_src -B $ipv6_ll_grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 103 2
        log_test $? 0 "Link-local IPv6 multicast - third VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 104 1
@@ -2165,6 +2201,7 @@ mdb_fdb_common()
        local plen=$1; shift
        local proto=$1; shift
        local grp=$1; shift
+       local grp_dmac=$1; shift
        local src=$1; shift
        local mz=$1; shift
 
@@ -2188,7 +2225,7 @@ mdb_fdb_common()
 
        # Send IP multicast traffic and make sure it is forwarded by the MDB
        # and only arrives to the first VTEP.
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "IP multicast - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 0
@@ -2205,7 +2242,7 @@ mdb_fdb_common()
        # Remove the MDB entry and make sure that IP multicast is now forwarded
        # by the FDB to the second VTEP.
        run_cmd "bridge -n $ns1 mdb del dev vx0 port vx0 grp $grp dst $vtep1_ip src_vni 10010"
-       run_cmd "ip netns exec $ns1 $mz br0.10 -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
+       run_cmd "ip netns exec $ns1 $mz br0.10 -a own -b $grp_dmac -A $src -B $grp -t udp sp=12345,dp=54321 -p 100 -c 1 -q"
        tc_check_packets "$ns2" "dev vx0 ingress" 101 1
        log_test $? 0 "IP multicast after removal - first VTEP"
        tc_check_packets "$ns2" "dev vx0 ingress" 102 2
@@ -2221,14 +2258,15 @@ mdb_fdb_ipv4_ipv4()
        local plen=32
        local proto="ipv4"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
        echo "Data path: MDB with FDB - IPv4 overlay / IPv4 underlay"
        echo "------------------------------------------------------"
 
-       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp $src \
-               "mausezahn"
+       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp \
+               $grp_dmac $src "mausezahn"
 }
 
 mdb_fdb_ipv6_ipv4()
@@ -2240,14 +2278,15 @@ mdb_fdb_ipv6_ipv4()
        local plen=32
        local proto="ipv6"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
        echo "Data path: MDB with FDB - IPv6 overlay / IPv4 underlay"
        echo "------------------------------------------------------"
 
-       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp $src \
-               "mausezahn -6"
+       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp \
+               $grp_dmac $src "mausezahn -6"
 }
 
 mdb_fdb_ipv4_ipv6()
@@ -2259,14 +2298,15 @@ mdb_fdb_ipv4_ipv6()
        local plen=128
        local proto="ipv4"
        local grp=239.1.1.1
+       local grp_dmac=01:00:5e:01:01:01
        local src=192.0.2.129
 
        echo
        echo "Data path: MDB with FDB - IPv4 overlay / IPv6 underlay"
        echo "------------------------------------------------------"
 
-       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp $src \
-               "mausezahn"
+       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp \
+               $grp_dmac $src "mausezahn"
 }
 
 mdb_fdb_ipv6_ipv6()
@@ -2278,14 +2318,15 @@ mdb_fdb_ipv6_ipv6()
        local plen=128
        local proto="ipv6"
        local grp=ff0e::1
+       local grp_dmac=33:33:00:00:00:01
        local src=2001:db8:100::1
 
        echo
        echo "Data path: MDB with FDB - IPv6 overlay / IPv6 underlay"
        echo "------------------------------------------------------"
 
-       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp $src \
-               "mausezahn -6"
+       mdb_fdb_common $ns1 $ns2 $vtep1_ip $vtep2_ip $plen $proto $grp \
+               $grp_dmac $src "mausezahn -6"
 }
 
 mdb_grp1_loop()
@@ -2320,7 +2361,9 @@ mdb_torture_common()
        local vtep1_ip=$1; shift
        local vtep2_ip=$1; shift
        local grp1=$1; shift
+       local grp1_dmac=$1; shift
        local grp2=$1; shift
+       local grp2_dmac=$1; shift
        local src=$1; shift
        local mz=$1; shift
        local pid1
@@ -2345,9 +2388,9 @@ mdb_torture_common()
        pid1=$!
        mdb_grp2_loop $ns1 $vtep1_ip $vtep2_ip $grp2 &
        pid2=$!
-       ip netns exec $ns1 $mz br0.10 -A $src -B $grp1 -t udp sp=12345,dp=54321 -p 100 -c 0 -q &
+       ip netns exec $ns1 $mz br0.10 -a own -b $grp1_dmac -A $src -B $grp1 -t udp sp=12345,dp=54321 -p 100 -c 0 -q &
        pid3=$!
-       ip netns exec $ns1 $mz br0.10 -A $src -B $grp2 -t udp sp=12345,dp=54321 -p 100 -c 0 -q &
+       ip netns exec $ns1 $mz br0.10 -a own -b $grp2_dmac -A $src -B $grp2 -t udp sp=12345,dp=54321 -p 100 -c 0 -q &
        pid4=$!
 
        sleep 30
@@ -2363,15 +2406,17 @@ mdb_torture_ipv4_ipv4()
        local vtep1_ip=198.51.100.100
        local vtep2_ip=198.51.100.200
        local grp1=239.1.1.1
+       local grp1_dmac=01:00:5e:01:01:01
        local grp2=239.2.2.2
+       local grp2_dmac=01:00:5e:02:02:02
        local src=192.0.2.129
 
        echo
        echo "Data path: MDB torture test - IPv4 overlay / IPv4 underlay"
        echo "----------------------------------------------------------"
 
-       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp2 $src \
-               "mausezahn"
+       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp1_dmac $grp2 \
+               $grp2_dmac $src "mausezahn"
 }
 
 mdb_torture_ipv6_ipv4()
@@ -2380,15 +2425,17 @@ mdb_torture_ipv6_ipv4()
        local vtep1_ip=198.51.100.100
        local vtep2_ip=198.51.100.200
        local grp1=ff0e::1
+       local grp1_dmac=33:33:00:00:00:01
        local grp2=ff0e::2
+       local grp2_dmac=33:33:00:00:00:02
        local src=2001:db8:100::1
 
        echo
        echo "Data path: MDB torture test - IPv6 overlay / IPv4 underlay"
        echo "----------------------------------------------------------"
 
-       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp2 $src \
-               "mausezahn -6"
+       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp1_dmac $grp2 \
+               $grp2_dmac $src "mausezahn -6"
 }
 
 mdb_torture_ipv4_ipv6()
@@ -2397,15 +2444,17 @@ mdb_torture_ipv4_ipv6()
        local vtep1_ip=2001:db8:1000::1
        local vtep2_ip=2001:db8:2000::1
        local grp1=239.1.1.1
+       local grp1_dmac=01:00:5e:01:01:01
        local grp2=239.2.2.2
+       local grp2_dmac=01:00:5e:02:02:02
        local src=192.0.2.129
 
        echo
        echo "Data path: MDB torture test - IPv4 overlay / IPv6 underlay"
        echo "----------------------------------------------------------"
 
-       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp2 $src \
-               "mausezahn"
+       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp1_dmac $grp2 \
+               $grp2_dmac $src "mausezahn"
 }
 
 mdb_torture_ipv6_ipv6()
@@ -2414,15 +2463,17 @@ mdb_torture_ipv6_ipv6()
        local vtep1_ip=2001:db8:1000::1
        local vtep2_ip=2001:db8:2000::1
        local grp1=ff0e::1
+       local grp1_dmac=33:33:00:00:00:01
        local grp2=ff0e::2
+       local grp2_dmac=33:33:00:00:00:02
        local src=2001:db8:100::1
 
        echo
        echo "Data path: MDB torture test - IPv6 overlay / IPv6 underlay"
        echo "----------------------------------------------------------"
 
-       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp2 $src \
-               "mausezahn -6"
+       mdb_torture_common $ns1 $vtep1_ip $vtep2_ip $grp1 $grp1_dmac $grp2 \
+               $grp2_dmac $src "mausezahn -6"
 }
 
 ################################################################################
index c6eda21cefb6b881f9180c730485f9fe28c0e59a..f27a12d2a2c9979adba840ab1065e8af9bc44aab 100644 (file)
@@ -1615,6 +1615,40 @@ TEST_F(tls, getsockopt)
        EXPECT_EQ(errno, EINVAL);
 }
 
+TEST_F(tls, recv_efault)
+{
+       char *rec1 = "1111111111";
+       char *rec2 = "2222222222";
+       struct msghdr hdr = {};
+       struct iovec iov[2];
+       char recv_mem[12];
+       int ret;
+
+       if (self->notls)
+               SKIP(return, "no TLS support");
+
+       EXPECT_EQ(send(self->fd, rec1, 10, 0), 10);
+       EXPECT_EQ(send(self->fd, rec2, 10, 0), 10);
+
+       iov[0].iov_base = recv_mem;
+       iov[0].iov_len = sizeof(recv_mem);
+       iov[1].iov_base = NULL; /* broken iov to make process_rx_list fail */
+       iov[1].iov_len = 1;
+
+       hdr.msg_iovlen = 2;
+       hdr.msg_iov = iov;
+
+       EXPECT_EQ(recv(self->cfd, recv_mem, 1, 0), 1);
+       EXPECT_EQ(recv_mem[0], rec1[0]);
+
+       ret = recvmsg(self->cfd, &hdr, 0);
+       EXPECT_LE(ret, sizeof(recv_mem));
+       EXPECT_GE(ret, 9);
+       EXPECT_EQ(memcmp(rec1, recv_mem, 9), 0);
+       if (ret > 9)
+               EXPECT_EQ(memcmp(rec2, recv_mem + 9, ret - 9), 0);
+}
+
 FIXTURE(tls_err)
 {
        int fd, cfd;
index 6091b45d226baf192c2d380ba893be15592f323d..a953c96aa16e1e814867b33d06e894ffb664bb1b 100644 (file)
@@ -1 +1 @@
-timeout=120
+timeout=180