r8169: remove unneeded check in r8168_pll_power_down
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 2 May 2018 19:39:35 +0000 (21:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 May 2018 20:23:49 +0000 (16:23 -0400)
RTL_GIGA_MAC_VER_23/24 are configured by rtl_hw_start_8168cp_2()
and rtl_hw_start_8168cp_3() respectively which both apply
CPCMD_QUIRK_MASK, thus clearing bit ASF.

Bit ASF isn't set at any other place in the driver, therefore this
check can be removed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index 66f10d119b12fbc09c3c6719acaee83316dcd1ae..ce7843aab81d38686977e1cb30f42f3ad5f8bba2 100644 (file)
@@ -4838,12 +4838,6 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
        if (r8168_check_dash(tp))
                return;
 
-       if ((tp->mac_version == RTL_GIGA_MAC_VER_23 ||
-            tp->mac_version == RTL_GIGA_MAC_VER_24) &&
-           (tp->cp_cmd & ASF)) {
-               return;
-       }
-
        if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||
            tp->mac_version == RTL_GIGA_MAC_VER_33)
                rtl_ephy_write(tp, 0x19, 0xff64);