drm/sti: move to devm_platform_ioremap_resource() usage

Replace platform_get_resource/_byname + devm_ioremap
with just devm_platform_ioremap_resource()

Used Coccinelle to do this change. SmPl patch:

@rule@
identifier res;
expression ioremap;
identifier pdev;
constant mem;
expression name;
@@
-struct resource *res;
...
-res = platform_get_resource_byname(pdev,mem,name);
<...
-if (!res) {
-...
-}
...>
-ioremap = devm_ioremap(...);
+ioremap = devm_platform_ioremap_resource_byname(pdev,name);

and
@rule_2@
identifier res;
expression ioremap;
identifier pdev;
@@
-struct resource *res;
...
-res = platform_get_resource(pdev,...);
<...
-if (!res) {
-...
-}
...>
-ioremap = devm_ioremap(...);
+ioremap = devm_platform_ioremap_resource(pdev,0);

v2: Fix compilation error.
v3: Handle returns properly since the new API return error pointers
and not NULL

Cc: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Alain Volmat <alain.volmat@foss.st.com>
Reviewed-by: Maxime Ripard <mripard@kernel.org>(v2)
Acked-by: Raphael Gallais-Pou <rgallaispou@gmail.com>(v2)
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
Link: https://patchwork.freedesktop.org/patch/640854/?series=144073&rev=5

diff --git a/drivers/gpu/drm/sti/sti_compositor.c b/drivers/gpu/drm/sti/sti_compositor.c
index 063f82d23d80c4ba83624a0066a18416a2b37351..8c529b0cca8b48fca532cd15e1f36fbe5bcbc71e 100644 (file)
--- a/drivers/gpu/drm/sti/sti_compositor.c
+++ b/drivers/gpu/drm/sti/sti_compositor.c
@@ -177,7 +177,6 @@ static int sti_compositor_probe(struct platform_device *pdev)
        struct device_node *np = dev->of_node;
        struct device_node *vtg_np;
        struct sti_compositor *compo;
-       struct resource *res;
        unsigned int i;
 
        compo = devm_kzalloc(dev, sizeof(*compo), GFP_KERNEL);
@@ -194,17 +193,10 @@ static int sti_compositor_probe(struct platform_device *pdev)
 
        memcpy(&compo->data, of_match_node(compositor_of_match, np)->data,
               sizeof(struct sti_compositor_data));
-
-       /* Get Memory ressources */
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (res == NULL) {
-               DRM_ERROR("Get memory resource failed\n");
-               return -ENXIO;
-       }
-       compo->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (compo->regs == NULL) {
+       compo->regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(compo->regs)) {
                DRM_ERROR("Register mapping failed\n");
-               return -ENXIO;
+               return PTR_ERR(compo->regs);
        }
 
        /* Get clock resources */

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 4dcddd02629b6a1052be8fb8333bd3aa17c083c5..74a1eef4674eeabc445b53b380e325f785242024 100644 (file)
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -511,7 +511,6 @@ static int sti_dvo_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct sti_dvo *dvo;
-       struct resource *res;
        struct device_node *np = dev->of_node;
 
        DRM_INFO("%s\n", __func__);
@@ -523,16 +522,9 @@ static int sti_dvo_probe(struct platform_device *pdev)
        }
 
        dvo->dev = pdev->dev;
-
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dvo-reg");
-       if (!res) {
-               DRM_ERROR("Invalid dvo resource\n");
-               return -ENOMEM;
-       }
-       dvo->regs = devm_ioremap(dev, res->start,
-                       resource_size(res));
-       if (!dvo->regs)
-               return -ENOMEM;
+       dvo->regs = devm_platform_ioremap_resource_byname(pdev, "dvo-reg");
+       if (IS_ERR(dvo->regs))
+               return PTR_ERR(dvo->regs);
 
        dvo->clk_pix = devm_clk_get(dev, "dvo_pix");
        if (IS_ERR(dvo->clk_pix)) {

diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 14fdc00d2ba03d4f96ba407ac8e576decb6f32c0..eedccdf70833145d8cc316588915db2c766bb31a 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -750,16 +750,9 @@ static int sti_hda_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        hda->dev = pdev->dev;
-
-       /* Get resources */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hda-reg");
-       if (!res) {
-               DRM_ERROR("Invalid hda resource\n");
-               return -ENOMEM;
-       }
-       hda->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (!hda->regs)
-               return -ENOMEM;
+       hda->regs = devm_platform_ioremap_resource_byname(pdev, "hda-reg");
+       if (IS_ERR(hda->regs))
+               return PTR_ERR(hda->regs);
 
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                        "video-dacs-ctrl");

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 164a34d793d86f114394048667ae3189e1c39242..37b8d619066ef14a2def26e2e4f90a9c2194238d 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1380,7 +1380,6 @@ static int sti_hdmi_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct sti_hdmi *hdmi;
        struct device_node *np = dev->of_node;
-       struct resource *res;
        struct device_node *ddc;
        int ret;
 
@@ -1399,17 +1398,9 @@ static int sti_hdmi_probe(struct platform_device *pdev)
        }
 
        hdmi->dev = pdev->dev;
-
-       /* Get resources */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hdmi-reg");
-       if (!res) {
-               DRM_ERROR("Invalid hdmi resource\n");
-               ret = -ENOMEM;
-               goto release_adapter;
-       }
-       hdmi->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (!hdmi->regs) {
-               ret = -ENOMEM;
+       hdmi->regs = devm_platform_ioremap_resource_byname(pdev, "hdmi-reg");
+       if (IS_ERR(hdmi->regs)) {
+               ret = PTR_ERR(hdmi->regs);
                goto release_adapter;
        }
 

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 0f658709c9d0d398c4eed65202443db9d0b41f8c..03684062309bbb9915d47fa6e6475cbb6c7beaaa 100644 (file)
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1356,7 +1356,6 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct device_node *vtg_np;
        struct sti_hqvdp *hqvdp;
-       struct resource *res;
 
        DRM_DEBUG_DRIVER("\n");
 
@@ -1367,17 +1366,10 @@ static int sti_hqvdp_probe(struct platform_device *pdev)
        }
 
        hqvdp->dev = dev;
-
-       /* Get Memory resources */
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               DRM_ERROR("Get memory resource failed\n");
-               return -ENXIO;
-       }
-       hqvdp->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (!hqvdp->regs) {
+       hqvdp->regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(hqvdp->regs)) {
                DRM_ERROR("Register mapping failed\n");
-               return -ENXIO;
+               return PTR_ERR(hqvdp->regs);
        }
 
        /* Get clock resources */

diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index af6c06f448c4819def8cc0d0836e30f991529690..6a464b035de800509fb6dc7c8780b5e1128643c1 100644 (file)
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -838,7 +838,6 @@ static int sti_tvout_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct device_node *node = dev->of_node;
        struct sti_tvout *tvout;
-       struct resource *res;
 
        DRM_INFO("%s\n", __func__);
 
@@ -850,16 +849,9 @@ static int sti_tvout_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        tvout->dev = dev;
-
-       /* get memory resources */
-       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "tvout-reg");
-       if (!res) {
-               DRM_ERROR("Invalid glue resource\n");
-               return -ENOMEM;
-       }
-       tvout->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (!tvout->regs)
-               return -ENOMEM;
+       tvout->regs = devm_platform_ioremap_resource_byname(pdev, "tvout-reg");
+       if (IS_ERR(tvout->regs))
+               return PTR_ERR(tvout->regs);
 
        /* get reset resources */
        tvout->reset = devm_reset_control_get(dev, "tvout");

diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index 5ba469b711b5318e9e9e6d8df127fb8933d1fac1..ee81691b32036d209020498511841f6da053e17d 100644 (file)
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -380,23 +380,15 @@ static int vtg_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct sti_vtg *vtg;
-       struct resource *res;
        int ret;
 
        vtg = devm_kzalloc(dev, sizeof(*vtg), GFP_KERNEL);
        if (!vtg)
                return -ENOMEM;
-
-       /* Get Memory ressources */
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res) {
-               DRM_ERROR("Get memory resource failed\n");
-               return -ENOMEM;
-       }
-       vtg->regs = devm_ioremap(dev, res->start, resource_size(res));
-       if (!vtg->regs) {
+       vtg->regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(vtg->regs)) {
                DRM_ERROR("failed to remap I/O memory\n");
-               return -ENOMEM;
+               return PTR_ERR(vtg->regs);
        }
 
        vtg->irq = platform_get_irq(pdev, 0);