net: support 64bit rates for getsockopt(SO_MAX_PACING_RATE)
authorEric Dumazet <edumazet@google.com>
Thu, 28 Feb 2019 23:17:28 +0000 (15:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 2 Mar 2019 07:08:30 +0000 (23:08 -0800)
For legacy applications using 32bit variable, SO_MAX_PACING_RATE
has to cap the returned value to 0xFFFFFFFF, meaning that
rates above 34.35 Gbit are capped.

This patch allows applications to read socket pacing rate
at full resolution, if they provide a 64bit variable to store it,
and the kernel is 64bit.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock.c

index 23aa02ffd6b811a294e232af0bd25f84d3c848cc..782343bb925b643348cc906a70b97caa0388178d 100644 (file)
@@ -1219,6 +1219,7 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
        union {
                int val;
                u64 val64;
+               unsigned long ulval;
                struct linger ling;
                struct old_timeval32 tm32;
                struct __kernel_old_timeval tm;
@@ -1464,8 +1465,13 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
 #endif
 
        case SO_MAX_PACING_RATE:
-               /* 32bit version */
-               v.val = min_t(unsigned long, sk->sk_max_pacing_rate, ~0U);
+               if (sizeof(v.ulval) != sizeof(v.val) && len >= sizeof(v.ulval)) {
+                       lv = sizeof(v.ulval);
+                       v.ulval = sk->sk_max_pacing_rate;
+               } else {
+                       /* 32bit version */
+                       v.val = min_t(unsigned long, sk->sk_max_pacing_rate, ~0U);
+               }
                break;
 
        case SO_INCOMING_CPU: