USB: idmouse: drop redundant open-count check from release
authorJohan Hovold <johan@kernel.org>
Tue, 5 Nov 2019 10:36:37 +0000 (11:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Nov 2019 10:16:49 +0000 (11:16 +0100)
The open count will always be exactly one when release is called, so
drop the redundant sanity check.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191105103638.4929-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/idmouse.c

index 0386bac224c48d166816b1ab26851b7976269ace..9b9d5df829d5c388380a6ea5f893d0ef833e90f6 100644 (file)
@@ -278,12 +278,6 @@ static int idmouse_release(struct inode *inode, struct file *file)
        /* lock our device */
        mutex_lock(&dev->lock);
 
-       /* are we really open? */
-       if (dev->open <= 0) {
-               mutex_unlock(&dev->lock);
-               return -ENODEV;
-       }
-
        --dev->open;
 
        if (!dev->present) {