livepatch: Add a missing newline character in klp_module_coming()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 30 Aug 2022 11:28:55 +0000 (19:28 +0800)
committerPetr Mladek <pmladek@suse.com>
Thu, 1 Sep 2022 14:27:59 +0000 (16:27 +0200)
The error message is not printed immediately because it does not end with
a newline character.

Before:
root@localhost:~# insmod vmlinux.ko
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters

After:
root@localhost:~# insmod vmlinux.ko
[   43.982558] livepatch: vmlinux.ko: invalid module name
insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters

Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20220830112855.749-1-thunder.leizhen@huawei.com
kernel/livepatch/core.c

index bc475e62279d2a39687e5209d6eced904a6c4691..42f7e716d56bf72812a95ec89ae1368f78bc7188 100644 (file)
@@ -1171,7 +1171,7 @@ int klp_module_coming(struct module *mod)
                return -EINVAL;
 
        if (!strcmp(mod->name, "vmlinux")) {
-               pr_err("vmlinux.ko: invalid module name");
+               pr_err("vmlinux.ko: invalid module name\n");
                return -EINVAL;
        }