btrfs: rename err to ret2 in resolve_indirect_refs()
authorDavid Sterba <dsterba@suse.com>
Fri, 30 May 2025 16:17:05 +0000 (18:17 +0200)
committerDavid Sterba <dsterba@suse.com>
Mon, 21 Jul 2025 21:53:27 +0000 (23:53 +0200)
Unify naming of return value to the preferred way, move the variable to
the closest scope.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/backref.c

index a4e0e2c3ea7d136fa0a0fd1863f155a8aeee5553..bebef4bd0c65929ff3c849ad9cea4d0842fe4466 100644 (file)
@@ -733,7 +733,6 @@ static int resolve_indirect_refs(struct btrfs_backref_walk_ctx *ctx,
                                 struct preftrees *preftrees,
                                 struct share_check *sc)
 {
-       int err;
        int ret = 0;
        struct ulist *parents;
        struct ulist_node *node;
@@ -752,6 +751,7 @@ static int resolve_indirect_refs(struct btrfs_backref_walk_ctx *ctx,
         */
        while ((rnode = rb_first_cached(&preftrees->indirect.root))) {
                struct prelim_ref *ref;
+               int ret2;
 
                ref = rb_entry(rnode, struct prelim_ref, rbnode);
                if (WARN(ref->parent,
@@ -773,18 +773,18 @@ static int resolve_indirect_refs(struct btrfs_backref_walk_ctx *ctx,
                        ret = BACKREF_FOUND_SHARED;
                        goto out;
                }
-               err = resolve_indirect_ref(ctx, path, preftrees, ref, parents);
+               ret2 = resolve_indirect_ref(ctx, path, preftrees, ref, parents);
                /*
                 * we can only tolerate ENOENT,otherwise,we should catch error
                 * and return directly.
                 */
-               if (err == -ENOENT) {
+               if (ret2 == -ENOENT) {
                        prelim_ref_insert(ctx->fs_info, &preftrees->direct, ref,
                                          NULL);
                        continue;
-               } else if (err) {
+               } else if (ret2) {
                        free_pref(ref);
-                       ret = err;
+                       ret = ret2;
                        goto out;
                }