net: dsa: remove check for dp->pl in EEE methods

When user ports are initialised, a phylink instance is always created,
and so dp->pl will always be non-NULL. The EEE methods are only used
for user ports, so checking for dp->pl to be NULL makes no sense. No
other phylink-calling method implements similar checks in DSA. Remove
this unnecessary check.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://patch.msgid.link/E1tL13z-006cZ7-BZ@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/dsa/user.c b/net/dsa/user.c
index c736c019e2af90747738f10b667e6ad936c9eb0b..e1a0b153c3535af7a4f26c08e66c9dd348436322 100644 (file)
--- a/net/dsa/user.c
+++ b/net/dsa/user.c
@@ -1230,7 +1230,7 @@ static int dsa_user_set_eee(struct net_device *dev, struct ethtool_keee *e)
        int ret;
 
        /* Port's PHY and MAC both need to be EEE capable */
-       if (!dev->phydev || !dp->pl)
+       if (!dev->phydev)
                return -ENODEV;
 
        if (!ds->ops->set_mac_eee)
@@ -1250,7 +1250,7 @@ static int dsa_user_get_eee(struct net_device *dev, struct ethtool_keee *e)
        int ret;
 
        /* Port's PHY and MAC both need to be EEE capable */
-       if (!dev->phydev || !dp->pl)
+       if (!dev->phydev)
                return -ENODEV;
 
        if (!ds->ops->get_mac_eee)