KVM: Move vcpu_load to arch-specific kvm_arch_vcpu_ioctl_set_guest_debug

Move vcpu_load() and vcpu_put() into the architecture specific
implementations of kvm_arch_vcpu_ioctl_set_guest_debug().

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c
index 5c7f657dd20740c1b21e75d13cf711f4b7bfbdf8..d7e3299a773460fcd3b39930864e078e72453475 100644 (file)
--- a/arch/arm64/kvm/guest.c
+++ b/arch/arm64/kvm/guest.c
@@ -361,10 +361,16 @@ int kvm_arch_vcpu_ioctl_translate(struct kvm_vcpu *vcpu,
 int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
                                        struct kvm_guest_debug *dbg)
 {
+       int ret = 0;
+
+       vcpu_load(vcpu);
+
        trace_kvm_set_guest_debug(vcpu, dbg->control);
 
-       if (dbg->control & ~KVM_GUESTDBG_VALID_MASK)
-               return -EINVAL;
+       if (dbg->control & ~KVM_GUESTDBG_VALID_MASK) {
+               ret = -EINVAL;
+               goto out;
+       }
 
        if (dbg->control & KVM_GUESTDBG_ENABLE) {
                vcpu->guest_debug = dbg->control;
@@ -378,7 +384,10 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
                /* If not enabled clear all flags */
                vcpu->guest_debug = 0;
        }
-       return 0;
+
+out:
+       vcpu_put(vcpu);
+       return ret;
 }
 
 int kvm_arm_vcpu_arch_set_attr(struct kvm_vcpu *vcpu,

diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
index 047651622cb86163080402d13c80953ada57c0bc..234531d1bee1e24052e23c100b3856d6c55fd590 100644 (file)
--- a/arch/powerpc/kvm/book3s.c
+++ b/arch/powerpc/kvm/book3s.c
@@ -755,7 +755,9 @@ int kvm_arch_vcpu_ioctl_translate(struct kvm_vcpu *vcpu,
 int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
                                        struct kvm_guest_debug *dbg)
 {
+       vcpu_load(vcpu);
        vcpu->guest_debug = dbg->control;
+       vcpu_put(vcpu);
        return 0;
 }
 

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index b5f46517c8396cfe4c542728a91e073cf998008c..6038e2e7aee03c2b29edb65624be370f01a6c928 100644 (file)
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -2016,12 +2016,15 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
 {
        struct debug_reg *dbg_reg;
        int n, b = 0, w = 0;
+       int ret = 0;
+
+       vcpu_load(vcpu);
 
        if (!(dbg->control & KVM_GUESTDBG_ENABLE)) {
                vcpu->arch.dbg_reg.dbcr0 = 0;
                vcpu->guest_debug = 0;
                kvm_guest_protect_msr(vcpu, MSR_DE, false);
-               return 0;
+               goto out;
        }
 
        kvm_guest_protect_msr(vcpu, MSR_DE, true);
@@ -2053,8 +2056,9 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
 #endif
 
        if (!(vcpu->guest_debug & KVM_GUESTDBG_USE_HW_BP))
-               return 0;
+               goto out;
 
+       ret = -EINVAL;
        for (n = 0; n < (KVMPPC_BOOKE_IAC_NUM + KVMPPC_BOOKE_DAC_NUM); n++) {
                uint64_t addr = dbg->arch.bp[n].addr;
                uint32_t type = dbg->arch.bp[n].type;
@@ -2065,21 +2069,24 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
                if (type & ~(KVMPPC_DEBUG_WATCH_READ |
                             KVMPPC_DEBUG_WATCH_WRITE |
                             KVMPPC_DEBUG_BREAKPOINT))
-                       return -EINVAL;
+                       goto out;
 
                if (type & KVMPPC_DEBUG_BREAKPOINT) {
                        /* Setting H/W breakpoint */
                        if (kvmppc_booke_add_breakpoint(dbg_reg, addr, b++))
-                               return -EINVAL;
+                               goto out;
                } else {
                        /* Setting H/W watchpoint */
                        if (kvmppc_booke_add_watchpoint(dbg_reg, addr,
                                                        type, w++))
-                               return -EINVAL;
+                               goto out;
                }
        }
 
-       return 0;
+       ret = 0;
+out:
+       vcpu_put(vcpu);
+       return ret;
 }
 
 void kvmppc_booke_vcpu_load(struct kvm_vcpu *vcpu, int cpu)

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 4e6304d45ca5544b310f8b2e158e63e5af536601..1c82dda07bc57ce489723b6bef6836dfce126ef7 100644 (file)
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -2801,13 +2801,19 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
 {
        int rc = 0;
 
+       vcpu_load(vcpu);
+
        vcpu->guest_debug = 0;
        kvm_s390_clear_bp_data(vcpu);
 
-       if (dbg->control & ~VALID_GUESTDBG_FLAGS)
-               return -EINVAL;
-       if (!sclp.has_gpere)
-               return -EINVAL;
+       if (dbg->control & ~VALID_GUESTDBG_FLAGS) {
+               rc = -EINVAL;
+               goto out;
+       }
+       if (!sclp.has_gpere) {
+               rc = -EINVAL;
+               goto out;
+       }
 
        if (dbg->control & KVM_GUESTDBG_ENABLE) {
                vcpu->guest_debug = dbg->control;
@@ -2827,6 +2833,8 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
                atomic_andnot(CPUSTAT_P, &vcpu->arch.sie_block->cpuflags);
        }
 
+out:
+       vcpu_put(vcpu);
        return rc;
 }
 

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 080e00dff426d99f852d989d1210aaa50cc7f749..9ef0b9299e93d0eb9472ca884af3e8d4b9f3c146 100644 (file)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7625,6 +7625,8 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
        unsigned long rflags;
        int i, r;
 
+       vcpu_load(vcpu);
+
        if (dbg->control & (KVM_GUESTDBG_INJECT_DB | KVM_GUESTDBG_INJECT_BP)) {
                r = -EBUSY;
                if (vcpu->arch.exception.pending)
@@ -7670,7 +7672,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu,
        r = 0;
 
 out:
-
+       vcpu_put(vcpu);
        return r;
 }
 

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 37217ec647b416b20aac353554b260df997736a0..b44762fcaf84ddd09e88bd1690a76d0fdc18e31e 100644 (file)
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2673,9 +2673,7 @@ out_free1:
                r = -EFAULT;
                if (copy_from_user(&dbg, argp, sizeof(dbg)))
                        goto out;
-               vcpu_load(vcpu);
                r = kvm_arch_vcpu_ioctl_set_guest_debug(vcpu, &dbg);
-               vcpu_put(vcpu);
                break;
        }
        case KVM_SET_SIGNAL_MASK: {