firmware: arm_scmi: Remove const from transport descriptors
authorCristian Marussi <cristian.marussi@arm.com>
Tue, 30 Jul 2024 14:47:02 +0000 (15:47 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Sun, 18 Aug 2024 19:22:16 +0000 (20:22 +0100)
The descriptor structure scmi_desc contains a variety of fields related to
the transport functionalities and it is defined by the transport drivers
themselves; such elements, though, serve varied purposes and have different
lifetime.

In particular, while there are some of those elements that provide a
description of transport features that are supposed to be immutable, on
the other side there are present also some other characteristics that are
instead supposed to be configurable on a per-platform base since they
represent configuration features tied to the specific hardware/firmware
system.

The immutable fields are already qualified as const on the their own; get
rid of the structure-level const qualifier which is not needed, so as to
enable possible runtime customization of the mutable configuration
features.

No functional change.

Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Tested-by: Peng Fan <peng.fan@nxp.com> #i.MX95 19x19 EVK
Message-Id: <20240730144707.1647025-2-cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/common.h
drivers/firmware/arm_scmi/transports/mailbox.c
drivers/firmware/arm_scmi/transports/optee.c
drivers/firmware/arm_scmi/transports/smc.c
drivers/firmware/arm_scmi/transports/virtio.c

index e44f7d1b44174d444aade9962f4e3c9b49de9544..6d9227db473ff67d3ab63301eefdbdeb063a8546 100644 (file)
@@ -405,7 +405,7 @@ struct scmi_transport_core_operations {
  */
 struct scmi_transport {
        struct device *supplier;
-       const struct scmi_desc *desc;
+       struct scmi_desc *desc;
        struct scmi_transport_core_operations **core_ops;
 };
 
index 917f9b8918d68e46bc657dde52d0f5414e8b045d..a481a286606233aadd88dab6250b728d4a210a71 100644 (file)
@@ -355,7 +355,7 @@ static const struct scmi_transport_ops scmi_mailbox_ops = {
        .poll_done = mailbox_poll_done,
 };
 
-static const struct scmi_desc scmi_mailbox_desc = {
+static struct scmi_desc scmi_mailbox_desc = {
        .ops = &scmi_mailbox_ops,
        .max_rx_timeout_ms = 30, /* We may increase this if required */
        .max_msg = 20, /* Limited by MBOX_TX_QUEUE_LEN */
index 978750aaf6b7992eb687258df0b8739c265394cc..56fc63edf51e23df27a695be2474a055ea4fcf42 100644 (file)
@@ -510,7 +510,7 @@ static int scmi_optee_ctx_match(struct tee_ioctl_version_data *ver, const void *
        return ver->impl_id == TEE_IMPL_ID_OPTEE;
 }
 
-static const struct scmi_desc scmi_optee_desc = {
+static struct scmi_desc scmi_optee_desc = {
        .ops = &scmi_optee_ops,
        .max_rx_timeout_ms = 30,
        .max_msg = 20,
index 6fc3e1973c58b850096228c7705bed3027828cb8..b7243939f1618df052bc13c9963b423ddd1d70ee 100644 (file)
@@ -273,7 +273,7 @@ static const struct scmi_transport_ops scmi_smc_ops = {
        .fetch_response = smc_fetch_response,
 };
 
-static const struct scmi_desc scmi_smc_desc = {
+static struct scmi_desc scmi_smc_desc = {
        .ops = &scmi_smc_ops,
        .max_rx_timeout_ms = 30,
        .max_msg = 20,
index c107579e7fe7bacce068d86cf9d8b2ecad5587c7..d349766bc0b267ee5ca44d31952353d89ad7a83a 100644 (file)
@@ -790,7 +790,7 @@ static const struct scmi_transport_ops scmi_virtio_ops = {
        .poll_done = virtio_poll_done,
 };
 
-static const struct scmi_desc scmi_virtio_desc = {
+static struct scmi_desc scmi_virtio_desc = {
        .ops = &scmi_virtio_ops,
        /* for non-realtime virtio devices */
        .max_rx_timeout_ms = VIRTIO_MAX_RX_TIMEOUT_MS,