crypto: tegra-aes - Fix NULL pointer dereference
authorSachin Kamat <sachin.kamat@linaro.org>
Mon, 16 Sep 2013 03:31:10 +0000 (09:01 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 23 Sep 2013 20:02:22 +0000 (06:02 +1000)
'dd' is tested for NULL. However, it is derefenced in the error
message print. Change the print to pr_err to avoid this.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/tegra-aes.c

index 403282f01af977c9775d0af8cad7f42a2f677934..33f9530914026fdbab7ba531d4ac086dfcd8e7de 100644 (file)
@@ -27,6 +27,8 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/errno.h>
@@ -716,7 +718,7 @@ static int tegra_aes_rng_reset(struct crypto_rng *tfm, u8 *seed,
        u8 *dt;
 
        if (!ctx || !dd) {
-               dev_err(dd->dev, "ctx=0x%x, dd=0x%x\n",
+               pr_err("ctx=0x%x, dd=0x%x\n",
                        (unsigned int)ctx, (unsigned int)dd);
                return -EINVAL;
        }