media: stm32-dcmi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/platform/st/stm32/stm32-dcmi.c b/drivers/media/platform/st/stm32/stm32-dcmi.c
index 2ac508da5ba363a2a3e6bffc23b60bb0730d16d1..dad6e22e4ce42c3030787b05745c8938cacfd018 100644 (file)
--- a/drivers/media/platform/st/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/st/stm32/stm32-dcmi.c
@@ -2135,7 +2135,7 @@ err_media_device_cleanup:
        return ret;
 }
 
-static int dcmi_remove(struct platform_device *pdev)
+static void dcmi_remove(struct platform_device *pdev)
 {
        struct stm32_dcmi *dcmi = platform_get_drvdata(pdev);
 
@@ -2148,8 +2148,6 @@ static int dcmi_remove(struct platform_device *pdev)
        media_device_cleanup(&dcmi->mdev);
 
        dma_release_channel(dcmi->dma_chan);
-
-       return 0;
 }
 
 static __maybe_unused int dcmi_runtime_suspend(struct device *dev)
@@ -2203,7 +2201,7 @@ static const struct dev_pm_ops dcmi_pm_ops = {
 
 static struct platform_driver stm32_dcmi_driver = {
        .probe          = dcmi_probe,
-       .remove         = dcmi_remove,
+       .remove_new     = dcmi_remove,
        .driver         = {
                .name = DRV_NAME,
                .of_match_table = of_match_ptr(stm32_dcmi_of_match),