iio: adc: cc10001: Fix regulator_get_voltage() return value check
authorNaidu Tellapati <naidu.tellapati@imgtec.com>
Thu, 7 May 2015 21:22:19 +0000 (18:22 -0300)
committerJonathan Cameron <jic23@kernel.org>
Tue, 12 May 2015 19:01:12 +0000 (20:01 +0100)
regulator_get_voltage() returns a non-negative value in case of success,
and a negative error in case of error. Let's fix this.

Fixes: 1664f6a5b0c8 ("iio: adc: Cosmic Circuits 10001 ADC driver")
Signed-off-by: Naidu Tellapati <naidu.tellapati@imgtec.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/cc10001_adc.c

index e7810ac8e2951f754b606f344e2dbfe85b01967f..fb7c5d2cc61a7a8067de2714cd2c3ac625cdcf5d 100644 (file)
@@ -230,7 +230,7 @@ static int cc10001_adc_read_raw(struct iio_dev *indio_dev,
 
        case IIO_CHAN_INFO_SCALE:
                ret = regulator_get_voltage(adc_dev->reg);
-               if (ret)
+               if (ret < 0)
                        return ret;
 
                *val = ret / 1000;