net: dsa: Improve subordinate PHY error message
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 30 Jun 2020 04:43:13 +0000 (21:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Jun 2020 19:44:20 +0000 (12:44 -0700)
It is not very informative to know the DSA master device when a
subordinate network device fails to get its PHY setup. Provide the
device name and capitalize PHY while we are it.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dsa/slave.c

index 4c7f086a047b1d623d3545e2b7732abc4d221706..e147e10b411c69d64ff89f7461c88149226eda09 100644 (file)
@@ -1795,7 +1795,8 @@ int dsa_slave_create(struct dsa_port *port)
 
        ret = dsa_slave_phy_setup(slave_dev);
        if (ret) {
-               netdev_err(master, "error %d setting up slave phy\n", ret);
+               netdev_err(master, "error %d setting up slave PHY for %s\n",
+                          ret, slave_dev->name);
                goto out_gcells;
        }