bcachefs: Drop racy warning
authorKent Overstreet <kent.overstreet@linux.dev>
Sun, 15 Dec 2024 06:52:54 +0000 (01:52 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Fri, 10 Jan 2025 04:38:41 +0000 (23:38 -0500)
Checking for writing past i_size after unlocking the folio and clearing
the dirty bit is racy, and we already check it at the start.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/fs-io-buffered.c

index ff8b8df50bf38b074cbfd43e83b4a04a6de6c285..ab1d5db2fa56a065ad72bf92b3dc8f357af100ac 100644 (file)
@@ -625,15 +625,6 @@ do_io:
                BUG_ON(!bio_add_folio(&w->io->op.wbio.bio, folio,
                                     sectors << 9, offset << 9));
 
-               /* Check for writing past i_size: */
-               WARN_ONCE((bio_end_sector(&w->io->op.wbio.bio) << 9) >
-                         round_up(i_size, block_bytes(c)) &&
-                         !test_bit(BCH_FS_emergency_ro, &c->flags),
-                         "writing past i_size: %llu > %llu (unrounded %llu)\n",
-                         bio_end_sector(&w->io->op.wbio.bio) << 9,
-                         round_up(i_size, block_bytes(c)),
-                         i_size);
-
                w->io->op.res.sectors += reserved_sectors;
                w->io->op.i_sectors_delta -= dirty_sectors;
                w->io->op.new_i_size = i_size;