net: stmmac: remove write-only priv->speed
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 7 Mar 2025 00:11:29 +0000 (00:11 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 03:31:58 +0000 (19:31 -0800)
priv->speed is only ever written to in two locations, but never
read. Therefore, it serves no useful purpose. Remove this unnecessary
struct member.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1tqLJJ-005aQm-Mv@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

index 3a00a988cb36f788a11bec6e49c2313997734397..d87275c1cf23b5c7a50e3b6df61813aa1b9ba237 100644 (file)
@@ -282,7 +282,6 @@ struct stmmac_priv {
        /* Generic channel for NAPI */
        struct stmmac_channel channel[STMMAC_CH_MAX];
 
-       int speed;
        unsigned int pause_time;
        struct mii_bus *mii;
 
index a3accab213b035f4b72cd5a8ffd8586fcd9bc35b..fa1d7d3a2f438f4a6b5a1e4d6254fe1b22dbc680 100644 (file)
@@ -1027,8 +1027,6 @@ static void stmmac_mac_link_up(struct phylink_config *config,
                }
        }
 
-       priv->speed = speed;
-
        if (priv->plat->fix_mac_speed)
                priv->plat->fix_mac_speed(priv->plat->bsp_priv, speed, mode);
 
@@ -7852,7 +7850,6 @@ int stmmac_suspend(struct device *dev)
        if (stmmac_fpe_supported(priv))
                timer_shutdown_sync(&priv->fpe_cfg.verify_timer);
 
-       priv->speed = SPEED_UNKNOWN;
        return 0;
 }
 EXPORT_SYMBOL_GPL(stmmac_suspend);