drm/i915/gvt: replace idr_init() by idr_init_base()
authorDeepak R Varma <mh12gx2825@gmail.com>
Wed, 4 Nov 2020 12:15:32 +0000 (17:45 +0530)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Wed, 11 Nov 2020 02:30:07 +0000 (10:30 +0800)
idr_init() uses base 0 which is an invalid identifier. The new function
idr_init_base allows IDR to set the ID lookup from base 1. This avoids
all lookups that otherwise starts from 0 since 0 is always unused.

References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")

Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20201104121532.GA48202@localhost
drivers/gpu/drm/i915/gvt/gvt.c
drivers/gpu/drm/i915/gvt/vgpu.c

index 495b6afd65713004036ceba24085ea057263ed7c..0262a6fa3a6c68af58d8678932f51b7da6b8a05c 100644 (file)
@@ -312,7 +312,7 @@ int intel_gvt_init_device(struct drm_i915_private *i915)
 
        gvt_dbg_core("init gvt device\n");
 
-       idr_init(&gvt->vgpu_idr);
+       idr_init_base(&gvt->vgpu_idr, 1);
        spin_lock_init(&gvt->scheduler.mmio_context_lock);
        mutex_init(&gvt->lock);
        mutex_init(&gvt->sched_lock);
index 8fa9b31a248401ffc28a0b862827e3da6c4f2fa0..85bfcc15385fd3a77d2e13217bd6d97fa0b80879 100644 (file)
@@ -392,7 +392,7 @@ static struct intel_vgpu *__intel_gvt_create_vgpu(struct intel_gvt *gvt,
        mutex_init(&vgpu->dmabuf_lock);
        INIT_LIST_HEAD(&vgpu->dmabuf_obj_list_head);
        INIT_RADIX_TREE(&vgpu->page_track_tree, GFP_KERNEL);
-       idr_init(&vgpu->object_idr);
+       idr_init_base(&vgpu->object_idr, 1);
        intel_vgpu_init_cfg_space(vgpu, param->primary);
        vgpu->d3_entered = false;