media: atmel-isi: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 5 Aug 2024 21:51:15 +0000 (23:51 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 9 Aug 2024 05:56:39 +0000 (07:56 +0200)
There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of wait_for_completion_timeout() causing
patterns like:

        timeout = wait_for_completion_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/atmel/atmel-isi.c

index c1108df72dd516fad2e0de5567afc08e0aabc64d..5c823d3f9cc0c9927036c6cb82252bcf1104db06 100644 (file)
@@ -242,7 +242,7 @@ static irqreturn_t isi_interrupt(int irq, void *dev_id)
 #define        WAIT_ISI_DISABLE        0
 static int atmel_isi_wait_status(struct atmel_isi *isi, int wait_reset)
 {
-       unsigned long timeout;
+       unsigned long time_left;
        /*
         * The reset or disable will only succeed if we have a
         * pixel clock from the camera.
@@ -257,9 +257,9 @@ static int atmel_isi_wait_status(struct atmel_isi *isi, int wait_reset)
                isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS);
        }
 
-       timeout = wait_for_completion_timeout(&isi->complete,
-                       msecs_to_jiffies(500));
-       if (timeout == 0)
+       time_left = wait_for_completion_timeout(&isi->complete,
+                                               msecs_to_jiffies(500));
+       if (time_left == 0)
                return -ETIMEDOUT;
 
        return 0;