tty: tty_buffer: better types in __tty_buffer_request_room()
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Wed, 16 Aug 2023 10:55:28 +0000 (12:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Aug 2023 12:58:15 +0000 (14:58 +0200)
* use bool for 'change' as it holds a result of a boolean.
* use size_t for 'left', so it is the same as 'size' which it is
  compared to. Both are supposed to contain an unsigned value.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230816105530.3335-9-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_buffer.c

index e162318d6c31e43913882fedbfe2190ba1c8da8c..414bb7f9155f0dfdfa8efbc929c344150d455a6c 100644 (file)
@@ -263,7 +263,8 @@ static int __tty_buffer_request_room(struct tty_port *port, size_t size,
 {
        struct tty_bufhead *buf = &port->buf;
        struct tty_buffer *b, *n;
-       int left, change;
+       size_t left;
+       bool change;
 
        b = buf->tail;
        if (!b->flags)